- Wine-Devel - list.winehq.org

Fwd: wineserver: fix get_update_region for desktop window
by Michael Jung Jan. 5, 2005

Jan. 5, 2005

Alexandre, could you please give a short comment on this one? Thanks, Michael ---------- Forwarded Message ---------- Subject: wineserver: fix get_update_region for desktop window Date: Wednesday 05 January 2005 00:36 From: Michael Jung <mjung(a)iss.tu-darmstadt.de> To: wine-devel(a)winehq.org Cc: wine-patches(a)winehq.org Calling SetSysColor in the current cvs version of wine causes an infinite loop in update_now in dlls/user/painting.c. As I understand it, the problem is the following: get_update_flags will promote it's child window argument to the next child window (via a wineserver call to get_update_region), if the current child doesn't need any repaint. Calling get_update_flags on the desktop window will always return a repaint flag, so it never gets ahead. The attached patch automatically promotes the child window argument to the first child, if called on the desktop window. I don't know if this really is the desired behaviour. Another fix would be to not return any repaint flags for the desktop window. Ciao, Michael -------------------------------------------------------

2 1

Re: Fix for "Cluster size not supported" - resend
by Alexandre Julliard Jan. 5, 2005

Jan. 5, 2005

Rein Klazes <wijn(a)wanadoo.nl> writes: > Totals size of the file system should be f_blocks * f_frsize, but that > gives a value 16 times too small. In this case f_blocks (as f_bfree, > f_bavail) are the number of f_bsize blocks, wrong. This is a quite > up-to-date system, Debian unstable with 2.6.10 kernel. > > Attached is the simplest solution, fall back to fstatfs() on Linux > systems. It is btw also what 'df' does. Wouldn't it be easier to simply use f_bsize instead of f_frsize? Why would switching to fstatfs be preferable? -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: [QUARTZ] Media Type Parsing
by Christian Costa Jan. 5, 2005

Jan. 5, 2005

Paul Vriens wrote: >Hi, > >the Media Types use "Source Filter" instead of "File Source" in the registry. > >Changelog: >Media Types should use "Source Filter" instead of "File Source" > >Cheers, > >Paul Vriens. > >------------------------------------------------------------------------ > >--- regsvr.org.c 2005-01-05 11:37:05.894187368 +0100 >+++ regsvr.c 2005-01-05 12:39:03.985260298 +0100 >@@ -130,6 +130,8 @@ > 'S', 'u', 'b', 't', 'y', 'p', 'e', 0 }; > static WCHAR const filesource_valuename[12] = { > 'F', 'i', 'l', 'e', ' ', 'S', 'o', 'u', 'r', 'c', 'e', 0 }; >+static WCHAR const sourcefilter_valuename[14] = { >+ 'S', 'o', 'u', 'r', 'c', 'e', ' ', 'F', 'i', 'l', 't', 'e', 'r', 0 }; > static WCHAR const extensions_keyname[11] = { > 'E', 'x', 't', 'e', 'n', 's', 'i', 'o', 'n', 's', 0 }; > >@@ -391,7 +393,7 @@ > if (res != ERROR_SUCCESS) goto error_close_keys; > > StringFromGUID2(&CLSID_AsyncReader, buf, 39); >- res = RegSetValueExW(subtype_key, filesource_valuename, 0, REG_SZ, (CONST BYTE*)buf, >+ res = RegSetValueExW(subtype_key, sourcefilter_valuename, 0, REG_SZ, (CONST BYTE*)buf, > (lstrlenW(buf) + 1) * sizeof(WCHAR)); > if (res != ERROR_SUCCESS) goto error_close_keys; > > Good catch! It would be good to do the same for register_mediatypes_extension and then remove the filesource string. Bye, Christian

1 0

Re: video4linux - wine
by Jasper van Veghel Jan. 5, 2005

Jan. 5, 2005

Rob Shearman wrote: > Mike McCormack wrote: > > > > >There's currently no support, but you could add it via the Still Image > >(STI) API. It's meant for scanners and webcams. There's probably a > >way to add VFW (Video For Windows drivers) too. > > > >I have written an IDL file for IStillImage, which I haven't gotten > >round to submitting as yet. I've attached it incase you're > >interested... I think it still needs some fixing up. > > > >Mike > > > > > >MediaHost (TM) wrote: > > > >>Question: Is there support for video4linux devices with wine? Is > >>there some support for webcams? What are the settings (config)? I > >>couldn't find anything useful on google concerning this issue.... > > > > You're probably much better off implementing a DirectShow -> V4L filter, > especially if you want to capture movies or sound. > > Rob > I've recently been looking into VFW with Wine, and though I certainly am no expert at the Windows API concerning this (first time I really looked into DX), nor Wine for that matter, I was able to get a bit further from where I started, so allow me to share my experiences with you. As an application to test this stuff with I went for MSN 6.2, though certainly not the best application for this, it seemed neat to finally have Webcam support on MSN - I eventually got some of it working with a load of native DLLs, some hacking on the SSL stuff (I ended up simply setting useSSL = false, the applica- tion was sending plain-text over an SSL socket, which wasn't working; this fixed things, or at least for this application ;-)) and adding some undocumented flag to InternetSetOption (optionId = 87) - anyway, it seems that MSN is using some- thing along the lines of the following webcam class I found using Google - indeed, using a DirectShow filter: http://www.jolash.com/projects/other_projects/webcam/WebCam.h For things to start working under Wine I used the following native DLLs, which I also registered with regsvr32 (for CLSIDs etc.) COMCTL32.DLL urlmon.dll CRYPT32.DLL MSOSS.DLL oleaut32.dll ole32.dll rpcrt4.dll MSVCRT.DLL shlwapi.dll shdocvw.dll MLANG.DLL qcap.dll amstream.dll Though I'm not sure if amstream is needed. Don't know what qcap does as I only managed to get to a point where something in qcap was called which was then being forwarded to Quartz (IAMStreamConfig, for which I added a bunch of stubs and semi-stubs (filled in some bogus information for VIDEO_STREAM_CONFIG_CAPS, VIDEOINFOHEADER and AM_MEDIA_TYPE) It turned out that, at least MSN, and this webcam class too, uses devenum to find the video input devices (CLSID_VideoInputDeviceCategory), for which I've added the proper code to CreateSpecialCategories and hence CreateClassEnumerator (it also seems that the windows DLL of devenum always recreates the dynamic registery entries whereas Wine only seems to add them once and then never again, that is, once they're in the registry they stay there (hence if a new audio card gets added to the system ..)) The Windows DLL seemed to be using avicap32 to collect information on the available video input devices, so I've simply had capGetDriverDescription return some string with a fictional video driver (this also makes it possible to use a native devenum.dll) Next up is Quartz, which seemed to want IAMStreamConfig (collecting information on the video stream (res, depth, sps, ..) for starters, but I never got around to implementing enough of that for the program to accept it and move on, so that's where I got stuck. It may also have had something to do with MSN wanting an IKsPin which isn't imple- mented (which is why native quartz may have failed, when trying to approach the kernel in some way) Here's a small scenario of what I observed working with both native and hacked up DLLs ;-) DEVENUM - Read all VideoInputDeviceRenderer's (from CLSID) DEVENUM - BindToObject() --> VfwCapture QCAP - BindToClass --> Quartz(VideoRenderer) QUARTZ - VideoRenderer_create QUARTZ - [FAIL] InputPin_QueryInterface (IKsPin) QUARTS - VideoRenderer_QueryInterface (IAMStreamConfig) Anyway, the 'patches' I wrote are probably not worth much as the whole under- taking was more of a little endeavor trying to see how far I go (MSN actually managed to sign in, by the way, but kept crashing a few seconds after that (the webcam stuff can be accessed without signing in though, there's a preview option in one of the menus), but perhaps this brief explanation of my steps will prove useful for someone wanting to implement this aspect of VFW :-) Perhaps someone could build a control from the class I mentioned earlier which can then be used for testing (through the webpage that refers to it says it's missing some code; but at least it's a starting point) Jasper

1 0

[QUARTZ] Fixes to regsvr.c (RESEND)
by Paul Vriens Jan. 5, 2005

Jan. 5, 2005

Hi, the Media Types (and Media Type Extensions) use "Source Filter" instead of "File Source" in the registry. There were also some small typos. I will continue with changes to regsvr.c. My first goal is to have the native quartz running with the builtin registration ! Changelog: - Media Types (and Extensions) should use "Source Filter" instead of "File Source" - Removed filesource_valuename - Fixed typo for some class-names - Fixed typo in MPEG1System Media Type Cheers, Paul Vriens.

1 0

Trying to get rid of gdi.h
by Rémi Assailly Jan. 5, 2005

Jan. 5, 2005

Hi all I started a work to get rid of GDI_GetObjPtr and GDI_ReleaseObj in x11drv but I am absolutely not sure if I have chosen a good way. What I send you is incomplete : some GDI_* are still staying and we cannot get rid of those functions using my way. After getting rid of GDI_* we'll be able to get rid of BITMAPOBJ* and PALETTEOBJ* using opaque pointers as Alexandre told me. Rémi

1 0

oleaut32 marshalling
by Bill Medland Jan. 5, 2005

Jan. 5, 2005

Anyone any idea what is wrong here? In particular any idea why the xCall occurs almost immediately before the TMProxyImpl_Connect that would give it a channel to use? (The software works fine with a native oleaut32.dll) -- Bill Medland mailto:billmedland(a)mercuryspeed.com http://webhome.idirect.com/~kbmed

2 2

question about the status of the wine printing system
by Udo Rader Jan. 5, 2005

Jan. 5, 2005

Hi, I'm having some kind of hard time with wine's printing capabilities and have already started digging the wine sources for potential fixes to my problems (printing to some high volume postscript printers from some Adobe applications). But before I proceed any further, I would be grateful for some basic information on wine's printing system (unfortunately the documentation on this issue is somewhat "limited" :-) * Postscript level Googling the net some resources indicate that wine only supports postscript level 1 printing. Is this still true as of now? Does this also affect CUPS environments? * Postscript level vs. PPDs If wine only supports language level 1, why then does generic.ppd have its LanguageLevel set to 3? * starting point Most of the printing tasks are obviously handled by the stuff in dlls/wineps/*. Any other important nodes? happy hacking Udo Rader -- b e s t s o l u t i o n . a t EDV Systemhaus GmbH ------------------------------------------------------------------------ udo rader technischer leiter/CEM mobile ++43 660 5263642 ------------------------------------------------------------------------ eduard-bodem-gasse 8/3 A-6020 innsbruck fax ++43 512 935833 http://www.bestsolution.at phone ++43 512 935834

4 4

video4linux - wine
by MediaHost (TM) Jan. 5, 2005

Jan. 5, 2005

Question: Is there support for video4linux devices with wine? Is there some support for webcams? What are the settings (config)? I couldn't find anything useful on google concerning this issue.... -- Regards Signer: Eddy Nigg Company: StartCom Linux at www.startcom.org <http://www.startcom.org/> MediaHost^(TM) at www.mediahost.org <http://www.mediahost.org/> Skype: startcom <callto://startcom/> Phone: +1.213.341.0390

3 2

Re: [AppDB] Implement maintainer ratings.
by Paul van Schayck Jan. 5, 2005

Jan. 5, 2005

Hey Tony, Few comments. > + maintainer_rating text, > + maintainer_release text, Why text, why not a varchar of 100 characters. It doesn't matter that much but it just optimizes our code a bit. > - $versionName = addslashes($_REQUEST['versionName']); > - $description = addslashes($_REQUEST['description']); > - $webPage = addslashes($_REQUEST['webPage']); > + $versionName = addslashes($_REQUEST['versionName']); > + $keywords = $_REQUEST['keywords']; > + $description = addslashes($_REQUEST['description']); > + $webPage = addslashes($_REQUEST['webPage']); > + $maintainer_rating = $_REQUEST['maintainer_rating']; > + $maintainer_release = $_REQUEST['maintainer_release']; > //did anything change? > if ($VersionChanged) > { > $query = "UPDATE appVersion SET versionName = '".$versionName."', ". > "keywords = '".$_REQUEST['keywords']."', ". > "description = '".$description."', ". > - "webPage = '".$webPage."'". > + "webPage = '".$webPage."',". > + "maintainer_rating = '".$maintainer_rating."',". > + "maintainer_release = '".$maintainer_release."'". > " WHERE appId = ".$_REQUEST['appId']." and versionId = ".$_REQUEST['versionId']; > if (mysql_query($query)) > { This is far from sql injection safe. Anyone can enter anything into $_REQUEST['mantainer_release'] or $_REQUEST['mantainer_rating'] and change any field from the appVersion table. It isn't a real problem in this case because they can already change most fields as maintainer. But they can for example change the versionId to make an app-version belong to any application. To prevent this we should make our queries with the compile_*_string functions from include/db.php. That function is doing addslashes. And generates an as safe as possible query string. Usage can be seen in admin/editAppFamily.php. Also query_appdb should be used instead of mysql_query(). And appId and versionId should always be check with is_numeric(). Right now without giving out details it's possible to change any application as long as you are maintainer of one application. Will you fix it or shall I? Paul

1 0