- Wine-Devel - list.winehq.org

Re: [OLE #16] Comment out an assert, as we don't yet implement IRemUnknown
by Andreas Mohr Dec. 28, 2004

Dec. 28, 2004

Hi, On Tue, Dec 28, 2004 at 03:37:17PM +0000, Mike Hearn wrote: > Mike Hearn <mh(a)codeweavers.com> > Comment out an assert, as we don't yet implement IRemUnknown > > --- dlls/ole32/stubmanager.c (revision 9) > +++ dlls/ole32/stubmanager.c (local) > @@ -171,8 +175,10 @@ int stub_manager_unref(struct stub_manag > EnterCriticalSection(&m->lock); > if (!list_empty(&m->ifstubs)) > { > - ERR("PANIC: Stub manager is being destroyed with outstanding interface stubs\n"); > - assert( FALSE ); > + ERR("PANIC: Stub manager %s is being destroyed with outstanding interface stubs\n", wine_dbgstr_longlong(m->oid)); > + > + /* assert( FALSE ); */ > + /* fixme: this will happen sometimes until we do proper lifecycle management via IRemUnknown */ > } > > /* fixme: the lifecycle of table-weak marshals is not $ find|xargs grep FIXME|wc -l 11011 $ find|xargs grep fixme|wc -l 83 Might be good to keep it that way... Andreas Mohr

3 3

[AppDB] Get rid of value fillers in appSubmit.php for a new version
by Paul van Schayck Dec. 28, 2004

Dec. 28, 2004

Those value fillers are not used. We never send users back to the page when errors are found (maybe we should). Changelog: Remove registered globals from the new-version submit. They are not used.

3 4

wine: could not load kernel32.dll, status c000007b
by Serge S. Spiridonoff Dec. 28, 2004

Dec. 28, 2004

Hi, I've compiled a Win32 GUI app under Linux using WineLib but it fails to start. Any ideas what's wrong with the program? [test]WINEDEBUG=+loaddll ./dlg1 trace:loaddll:load_dll Loaded module L"c:\\windows\\system\\msvcrt.dll" : builtin trace:loaddll:load_dll Loaded module L"c:\\windows\\system\\advapi32.dll" : builtin trace:loaddll:load_dll Loaded module L"c:\\windows\\system\\gdi32.dll" : builtin trace:loaddll:load_dll Loaded module L"c:\\windows\\system\\user32.dll" : builtin trace:loaddll:load_dll Loaded module L"c:\\windows\\system\\winspool.drv" : builtin trace:loaddll:load_dll Loaded module L"c:\\windows\\system\\comctl32.dll" : builtin trace:loaddll:load_dll Loaded module L"c:\\windows\\system\\iphlpapi.dll" : builtin trace:loaddll:load_dll Loaded module L"c:\\windows\\system\\rpcrt4.dll" : builtin trace:loaddll:load_dll Loaded module L"c:\\windows\\system\\ole32.dll" : builtin trace:loaddll:load_dll Loaded module L"c:\\windows\\system\\shlwapi.dll" : builtin trace:loaddll:load_dll Loaded module L"c:\\windows\\system\\shell32.dll" : builtin trace:loaddll:load_dll Loaded module L"c:\\windows\\system\\comdlg32.dll" : builtin trace:loaddll:MODULE_LoadModule16 Loaded module "krnl386.exe" : builtin trace:loaddll:MODULE_LoadModule16 Loaded module "system.drv" : builtin trace:loaddll:MODULE_LoadModule16 Loaded module "GDI.EXE" : builtin trace:loaddll:MODULE_LoadModule16 Loaded module "USER.EXE" : builtin trace:loaddll:load_dll Loaded module L"c:\\windows\\system\\x11drv.dll" : builtin trace:loaddll:load_dll Loaded module L"c:\\windows\\system\\imm32.dll" : builtin wine: could not load kernel32.dll, status c000007b Thanks in advance, Serge

1 0

Re: MSI: free allocated buffers
by Joris Huizer Dec. 28, 2004

Dec. 28, 2004

Mike McCormack wrote: > > ChangeLog: > <aric(a)codeweavers.com> > * free allocated buffers > > The other daty I saw a lot of patches changing things like if (buffer) HeapFree(GetProcessHeap(),0,buffer); To HeapFree(GetProcessHeap(),0,buffer); Why are you adding new code with the if() statement in place again? Just curious regards, Joris

3 2

Re: Unicodify System Metrics
by Mike Hearn Dec. 28, 2004

Dec. 28, 2004

On Tue, 28 Dec 2004 00:26:36 -0500, jchevrier wrote: > --- sysparams.c.orig 2004-12-27 20:09:20.000000000 -0500 > +++ sysparams.c 2004-12-27 21:45:02.674627072 -0500 Hi, The patch looks OK at a first glance but in future please diff from the source root, preferably against CVS. thanks -mike

1 0

[AppDB] naming convention
by Jonathan Ernst Dec. 28, 2004

Dec. 28, 2004

As discussed with Chris and others on IRC we'd like to use a new variable naming convention in AppDB code. The proposed scheme is the following ("hungarian notation"): handles: $hSomeHandle integer: $iSomeInteger objects: $oSomeObject arrays: $aSomeArray strings: $sSomeString and so on. constants will still be uppercase without prefix. Do someone object this ? Jonathan

2 2

Re: free allocated buffers
by Dmitry Timoshkov Dec. 28, 2004

Dec. 28, 2004

"Mike McCormack" <mike(a)codeweavers.com> wrote: > Index: dlls/msi/action.c > =================================================================== > RCS file: /home/wine/wine/dlls/msi/action.c,v > retrieving revision 1.55 > diff -u -r1.55 action.c > --- dlls/msi/action.c 27 Dec 2004 19:12:35 -0000 1.55 > +++ dlls/msi/action.c 28 Dec 2004 06:47:04 -0000 > @@ -423,6 +423,59 @@ > } > } > > +/* Called when the package is being closed */ > +extern void ACTION_free_package_structures( MSIPACKAGE* package) > +{ > + INT i; The "extern" above should be removed. -- Dmitry.

1 0

Re: clean-up
by Chris Morgan Dec. 28, 2004

Dec. 28, 2004

Can you post a new version with the fixes that people replied with? I think the rest of the patch looks good. Chris On Thursday 23 December 2004 4:38 am, Eric Blade wrote: > The attached patch includes a lot of cleaning up, > mostly to HTML, a bit to some PHP. > > > > > > __________________________________ > Do you Yahoo!? > Send a seasonal email greeting and help others. Do good. > http://celebrity.mail.yahoo.com

1 0

Re: clean-up
by Paul van Schayck Dec. 27, 2004

Dec. 27, 2004

Hey Eric, On Thu, 23 Dec 2004 01:38:02 -0800 (PST), Eric Blade <ekdikeo4(a)yahoo.com> wrote: > The attached patch includes a lot of cleaning up, > mostly to HTML, a bit to some PHP. What's this supposed to do: if(!$tempResult) { - echo "$query \n"; + echo "$query < >\n"; echo "An error occurred: ".mysql_error().""; exit; } @@ -68,7 +68,7 @@ if(debugging()) { echo $query; - echo " "; + echo "< >< >"; } And: -if(!loggedin()) +if(!loggedin() || (!havepriv("admin")) Shouldn't this be if(!loggedin() AND (!havepriv("admin")) Rest looks good. Kind regards, Paul

3 2

public domain code from lkcl
by Brian Vincent Dec. 27, 2004

Dec. 27, 2004

I'm not sure if this is useful to anyone, but I thought I remembered licensing being an issue with this once before: http://www.advogato.org/article/814.html "I really really AM relinquishing all copyright of all Samba-related source code that i have ever written, and am placing all that code into the Public Domain." "Specifically, but not limited to, that includes the code in samba which made its way into nmbd (dating right back to 1.9.15.p6 and before, and also including the nmbd_multiworkgroup version), all modifications of smbd that made their way into versions of 1.9.15 and up, all versions known as samba_ntdom _and_ Samba TNG, the code that i cut/paste over to FreeDCE to integrate a NamedPipe Interface plugin and also the FreeDCE NTLMSSP authentication plugin i worked on." -Brian

1 0