- Wine-Devel - list.winehq.org

Patch to support VT_BYREF | VT_I4 in typelib.c _copy_arg
by Erich Hoover Dec. 10, 2004

Dec. 10, 2004

dlls/oleaut32/typelib.c does not currently support VT_BYREF | VT_I4 in _copy_arg, this causes InstallShield to crash when attempting to install the demo for "Prince of Persia: Warrior Within" (and probably other InstallShield programs as well). Installation can complete with this fix under Win9x w/ Desktop (2K and XP options still fail due to "unimplemented function imagehlp.dll.StackWalk64" and non-Desktop fails for unknown reason).

3 2

current CVS broken.
by Ivan Leo Puoti Dec. 10, 2004

Dec. 10, 2004

I believe this patch http://www.winehq.com/hypermail/wine-cvs/2004/12/0081.html is causing this compile error on my system. make[2]: Entering directory `/path/to/wine/source/dlls/winmm/winejack' gcc -c -I. -I. -I../../../include -I../../../include -D__WINESRC__ -D_REENTRANT -fPIC -Wall -pipe -mpreferred-stack-boundary=2 -fno-strict-aliasing -gstabs+ -Wpointer-arith -g -O2 -o audio.o audio.c audio.c: In function `JACK_WaveInit': audio.c:902: warning: implicit declaration of function `wine_dlsym' audio.c:902: warning: assignment makes pointer from integer without a cast audio.c:903: warning: assignment makes pointer from integer without a cast audio.c:904: warning: assignment makes pointer from integer without a cast audio.c:905: warning: assignment makes pointer from integer without a cast audio.c:906: warning: assignment makes pointer from integer without a cast audio.c:907: warning: assignment makes pointer from integer without a cast audio.c:908: warning: assignment makes pointer from integer without a cast audio.c:909: warning: assignment makes pointer from integer without a cast audio.c:910: warning: assignment makes pointer from integer without a cast audio.c:911: warning: assignment makes pointer from integer without a cast audio.c:912: warning: assignment makes pointer from integer without a cast audio.c:913: warning: assignment makes pointer from integer without a cast audio.c:914: warning: assignment makes pointer from integer without a cast audio.c:915: warning: assignment makes pointer from integer without a cast audio.c:916: warning: assignment makes pointer from integer without a cast audio.c:934: warning: implicit declaration of function `strcpyW' audio.c:998: warning: implicit declaration of function `wine_dlclose' audio.c: In function `wodDevInterfaceSize': audio.c:1682: warning: implicit declaration of function `MultiByteToWideChar' audio.c:1682: error: `CP_ACP' undeclared (first use in this function) audio.c:1682: error: (Each undeclared identifier is reported only once audio.c:1682: error: for each function it appears in.) audio.c: In function `wodDevInterface': audio.c:1692: error: `CP_ACP' undeclared (first use in this function) audio.c: In function `widDevInterfaceSize': audio.c:2428: error: `CP_ACP' undeclared (first use in this function) audio.c: In function `widDevInterface': audio.c:2438: error: `CP_ACP' undeclared (first use in this function) make[2]: *** [audio.o] Error 1 make[2]: Leaving directory `/path/to/wine/source/wine/dlls/winmm/winejack' make[1]: *** [winmm/winejack] Error 2 make[1]: Leaving directory `/path/to/wine/source/wine/dlls' make: *** [dlls] Error 2 ____________________________________________________________ Libero ADSL: 3 mesi gratis e navighi a 1.2 Mega, senza costi di attivazione. Abbonati subito su http://www.libero.it

3 6

Office2K and current Wine
by Igor Shmukler Dec. 9, 2004

Dec. 9, 2004

Hello, We have problems running most programs including Office with latest wine (20041201) we built from sources on RH9. Following error message appears when running installer: $ fixme:msi:MsiEnableLogA 00000516 "c:\\windows\\temp\\Office 2000 SR-1 Premium Setup(0006)_MsiExec.txt" 00000000 fixme:msi:MsiInstallProductW L"Z:\\home\\ser\\.wine\\office\\data1.msi" L"" fixme:msi:HANDLE_CustomType1 DATABASE NOT THREADSAFE... not starting fixme:msi:HANDLE_CustomType1 DATABASE NOT THREADSAFE... not starting fixme:msi:HANDLE_CustomType1 DATABASE NOT THREADSAFE... not starting fixme:msi:HANDLE_CustomType1 DATABASE NOT THREADSAFE... not starting fixme:msi:ACTION_PerformAction UNHANDLED MSI ACTION L"AppSearch" fixme:msi:HANDLE_CustomType1 DATABASE NOT THREADSAFE... not starting fixme:msi:HANDLE_CustomType1 DATABASE NOT THREADSAFE... not starting fixme:msi:HANDLE_CustomType1 DATABASE NOT THREADSAFE... not starting fixme:msi:HANDLE_CustomType1 DATABASE NOT THREADSAFE... not starting fixme:msi:HANDLE_CustomType1 DATABASE NOT THREADSAFE... not starting fixme:msi:HANDLE_CustomType1 DATABASE NOT THREADSAFE... not starting fixme:msi:HANDLE_CustomType1 DATABASE NOT THREADSAFE... not starting fixme:msi:HANDLE_CustomType1 DATABASE NOT THREADSAFE... not starting fixme:msi:ACTION_PerformAction UNHANDLED MSI ACTION L"ResolveSource" fixme:msi:HANDLE_CustomType1 DATABASE NOT THREADSAFE... not starting fixme:msi:HANDLE_CustomType1 DATABASE NOT THREADSAFE... not starting fixme:msi:HANDLE_CustomType1 DATABASE NOT THREADSAFE... not starting wine: Unhandled exception (thread 000b), starting debugger... Is this a known issue? Any pointers would be most welcome. Thank you in advance, Igor.

1 0

tools/wineinstall
by Christian Britz Dec. 9, 2004

Dec. 9, 2004

Dear all, the script tools/wineinstall suggest to uninstall wine first if you update an existing installation. This makes senses but it is uncomfortable that the script doesn't offer the option to do that for the user. You always have to su before installing a new version Thx Christian

2 2

Re: include file cleanup : another step
by Vincent Béron Dec. 9, 2004

Dec. 9, 2004

Le jeu 09/12/2004 à 15:47, Rémi Assailly a écrit : > I moved some defines, ttydrv will not use gdi.h any longer. > I notice that some headers are declared twice, I removed useless > declarations. > > Changelog: > * moved some defines from gdi.h > ---- > > --- dlls/gdi/palette.c~ 2004-10-18 23:18:58.000000000 +0200 > +++ dlls/gdi/palette.c 2004-12-09 14:14:52.000000000 +0100 > @@ -37,6 +37,11 @@ > #include "wine/debug.h" > #include "winerror.h" > > +/* palette object */ > +#define NB_RESERVED_COLORS 20 /* number of fixed colors in system palette */ > + > +#define PC_SYS_USED 0x80 /* palentry is used (both system and logical) */ > + > WINE_DEFAULT_DEBUG_CHANNEL(palette); > > static INT PALETTE_GetObject( HGDIOBJ handle, void *obj, INT count, LPVOID buffer ); > > --- include/gdi.h~ 2004-03-04 21:41:13.000000000 +0100 > +++ include/gdi.h 2004-12-09 19:01:20.154559672 +0100 > @@ -83,14 +83,6 @@ > SEGPTR segptr_bits; /* segptr to DIB bits */ > } BITMAPOBJ; > > -/* palette object */ > - > -#define NB_RESERVED_COLORS 20 /* number of fixed colors in system palette */ > - > -#define PC_SYS_USED 0x80 /* palentry is used (both system and logical) */ > -#define PC_SYS_RESERVED 0x40 /* system palentry is not to be mapped to */ > -#define PC_SYS_MAPPED 0x10 /* logical palentry is a direct alias for system palentry */ > - > typedef struct tagPALETTEOBJ > { > GDIOBJHDR header; > > --- dlls/ttydrv/palette.c~ 2004-12-09 18:57:42.835597176 +0100 > +++ dlls/ttydrv/palette.c 2004-12-09 14:27:48.000000000 +0100 > @@ -22,10 +22,14 @@ > > #include <stdlib.h> > > -#include "gdi.h" > -#include "winbase.h" > #include "ttydrv.h" > #include "wine/debug.h" > +#include "wine/wingdi16.h" > + > +/* palette object */ > +#define NB_RESERVED_COLORS 20 /* number of fixed colors in system palette */ > + > +#define PC_SYS_USED 0x80 /* palentry is used (both system and logical) */ > > WINE_DEFAULT_DEBUG_CHANNEL(ttydrv); > > --- dlls/x11drv/palette.c~ 2004-12-01 12:32:11.000000000 +0100 > +++ dlls/x11drv/palette.c 2004-12-09 19:03:03.933782832 +0100 > @@ -24,11 +24,16 @@ > #include <string.h> > > #include "gdi.h" > -#include "windef.h" > #include "winreg.h" > #include "x11drv.h" > #include "wine/debug.h" > > +/* palette object */ > +#define NB_RESERVED_COLORS 20 /* number of fixed colors in system palette */ > + > +#define PC_SYS_USED 0x80 /* palentry is used (both system and logical) */ > +#define PC_SYS_RESERVED 0x40 /* system palentry is not to be mapped to */ > + > WINE_DEFAULT_DEBUG_CHANNEL(palette); > > /* Palette indexed mode: Defining the same thing in multiple files is a clear indication an #include is needed. Vincent

1 0

Re: Visual studio 6 build fix.
by Juan Lang Dec. 9, 2004

Dec. 9, 2004

> MS Visual C++ v6, when invoking the compiler and other build tools does > the following: > > create anonymous pipe; > duplicate the pipes write handle; > open's the file NUL > The attached patch makes this work properly. Ahh, cool, that might help with MinGW's windres.exe, too. It uses _popen, which I've implemented to do basically the same as above. _popen works for a silly little test program I wrote, but windres.exe isn't getting its output. I'll check it out. Thanks, --Juan __________________________________ Do you Yahoo!? Yahoo! Mail - now with 250MB free storage. Learn more. http://info.mail.yahoo.com/mail_250

1 0

Re: visual studio 6 not happy?
by Dan Kegel Dec. 9, 2004

Dec. 9, 2004

Jerry Geis wrote: > I am trying to use wine 12-01-04 release with Visual Studio. > I am getting the vcspawn error. Have you ever found a solution to that? > [http://www.winehq.com/hypermail/wine-devel/2003/02/0335.html] Nope. I didn't look very hard, though. > If not I am trying to use the command line nmake. I can export the make file > but how do I build it after that. I know 'wine nmake /f project.mak > CFG="project - Win32 Release"' but that > doesnt exactly do it. From what directory do you execute that? I did it > in the release directory. Have you read http://codingstyle.com/articles/using-ms-vcpp-with-gnu-wine.html ? It might explain that. I haven't really used nmake much, so I've forgotten how I ran it. I usually ignore the .mak file and just build things by hand, as described in http://kegel.com/wine/cl-howto.html, because I do such small things (Wine unit tests, mostly). - Dan -- Trying to get a job as a c++ developer? See http://kegel.com/academy/getting-hired.html

2 1

winelib problems
by Joris Huizer Dec. 9, 2004

Dec. 9, 2004

Hello, I tried winemaker (just the notepad example explained at the page) but it doesn't work: - I had to comment out 'use strict' - otherwise winemaker would complain; - still no notepad2 executable is generated... Is it under active development, or is winemaker having bigger problems? regards, Joris

1 0

EnumCalendarInfo
by Vitaly Lipatov Dec. 9, 2004

Dec. 9, 2004

Some months ago Ken Belleau done some implementation of EnumCalendarInfo. http://www.winehq.org/hypermail/wine-patches/2004/04/0170.html I can't find any discussion of this patch. It is possible to review it and apply now? I would like to write some tests for this functions later. P.S. Sorry for patches I send this list. Have I to resend it in wine-patches or not? -- Vitaly Lipatov, ALT Linux Team Russia, Saint-Petersburg, www.etersoft.ru

2 1

Re: Another systray patch
by Alexandre Julliard Dec. 9, 2004

Dec. 9, 2004

Mike Hearn <mike(a)navi.cx> writes: > There was a crash in the previous patch, here is a fixed version. > > - Add a new wineshell process, and put system tray handling in there > - Rewrite the shell32 systray handling to be out of process > - Support the freedesktop.org XEMBED protocol It would be nice to do the XEMBED stuff as a separate patch. Also I was hoping you would get rid of WS_EX_TRAYWINDOW instead of adding even more uses of it... > + /* we can't intern this with the rest as it depends on the screen we are connecting to */ > + systray_buffer = HeapAlloc(GetProcessHeap(), 0, sizeof(char)*20); > + sprintf(systray_buffer, "_NET_SYSTEM_TRAY_S%d", DefaultScreen(display)); The screen will be 0 in 99.9% of the cases, you should preallocate that one. > +void *xmalloc(unsigned int size) > +{ > + void *p = HeapAlloc(GetProcessHeap(), 0, size); > + > + if (!p) > + { > + fprintf(stderr, "wineshell: virtual memory exhausted\n"); > + exit(1); > + } > + > + ZeroMemory(p, size); exit(1) is not acceptable here, you should handle allocation failures properly. Also malloc doesn't clear the buffer so xmalloc shouldn't either, otherwise it's very confusing. > +struct request { > + NOTIFYICONDATAA ansi; > + NOTIFYICONDATAW wide; > + BOOL unicode; > + BYTE *copydata; Inter-process data should always be sent in Unicode. -- Alexandre Julliard julliard(a)winehq.org

2 2