- Wine-Devel - list.winehq.org

Re: wine/dlls/user button.c
by Dimitrie O. Paun Oct. 26, 2004

Oct. 26, 2004

> The thing is that the old code wasn't entirely correct too. > Here is a test case + fix. Thanks a lot Dmitry, I got carried away with some other stuff. -- Dimi.

1 0

Problems downloading the RedHat packages
by Bill Medland Oct. 26, 2004

Oct. 26, 2004

I am unable to download the RedHat 20041019 packages; any idea why? (Did they get built?) I can download a SuSE one (well, it at least asks me if I want to save it) but for all the Red Hat ones I've tried the mirror page keeps repeatedly coming up and it never actually tries to download. -- Bill Medland mailto:billmedland(a)mercuryspeed.com http://webhome.idirect.com/~kbmed

3 2

Re: unaligned access bug in winspool on sparc
by Juan Lang Oct. 26, 2004

Oct. 26, 2004

> I just ran across an evil little bug in the > WINSPOOL_GetPrinter_2 function. It looks like this > type of bug could be hiding in other API functions > too. It causes a segmentation fault because of an > unaligned access on Solaris (sparc). Yikes. That's a bad one. The trouble is MS loves this sort of return value. Even if the dll itself doesn't dereference an unaligned pointer, the caller might depending on how things are layed out. The trouble is i386 allows unaligned memory access, so we don't see this sort of thing. If you happen to know how MS handles alignment on platforms that require it, we might be able to fix it. Otherwise it'll have to be case-by-case I'm afraid. --Juan _______________________________ Do you Yahoo!? Declare Yourself - Register online to vote today! http://vote.yahoo.com

4 4

Re: wine/dlls/user button.c
by Mike McCormack Oct. 25, 2004

Oct. 25, 2004

Hi Dimi, The following hunk of the patch below breaks the IE install. You should be able to press Alt-A to accept the license in the first dialog, but with this hunk applied it no longer works. Mike Index: wine/dlls/user/button.c diff -u wine/dlls/user/button.c:1.2 wine/dlls/user/button.c:1.3 --- wine/dlls/user/button.c:1.2 Thu Oct 21 11:18:35 2004 +++ wine/dlls/user/button.c Thu Oct 21 11:18:35 2004 @@ -179,10 +224,13 @@ case WM_GETDLGCODE: switch(btn_type) { - case BS_PUSHBUTTON: return DLGC_BUTTON | DLGC_UNDEFPUSHBUTTON; - case BS_DEFPUSHBUTTON: return DLGC_BUTTON | DLGC_DEFPUSHBUTTON; - case BS_RADIOBUTTON: - case BS_AUTORADIOBUTTON: return DLGC_BUTTON | DLGC_RADIOBUTTON; + case BS_AUTOCHECKBOX: return DLGC_BUTTON | DLGC_WANTCHARS; + case BS_AUTORADIOBUTTON: return DLGC_RADIOBUTTON; + case BS_CHECKBOX: return DLGC_BUTTON | DLGC_WANTCHARS; + case BS_DEFPUSHBUTTON: return DLGC_DEFPUSHBUTTON; + case BS_GROUPBOX: return DLGC_STATIC; + case BS_PUSHBUTTON: return DLGC_UNDEFPUSHBUTTON; + case BS_RADIOBUTTON: return DLGC_RADIOBUTTON; default: return DLGC_BUTTON; } Alexandre Julliard wrote: > ChangeSet ID: 14031 > CVSROOT: /opt/cvs-commit > Module name: wine > Changes by: julliard(a)wine.codeweavers.com 2004/10/04 23:11:13 > > Modified files: > dlls/user : button.c > > Log message: > Dimitrie O. Paun <dpaun(a)rogers.com> > Audit and document button code. > Change [GS]etWindowLong{,Ptr}A to [GS]etWindowLong{,Ptr}W. > Change WM_GETDLGCODE as per the MSDN documentation. > > Patch: http://cvs.winehq.org/patch.py?id=14031 > > Old revision New revision Changes Path > 1.2 1.3 +74 -26 wine/dlls/user/button.c > >

2 1

rsaenh [beware: 27kB attachment]
by Michael Jung Oct. 25, 2004

Oct. 25, 2004

Hello, I've worked on an OpenSSL based implementation of rsaenh.dll in my spare time over the last three months. Although it is by no means complete, I feel that the coarse structure should be stable by now. The patch is appended to this mail as a gzipped tape archive. I'm aware that small patches are preferable, but I hope someone helps me to get this beast in: Please give me feedback on what remains to be done. If you want to try the patch note the following: - After you have applied the patch you have to run autoheader and autoconf. Then cd dlls ; make_dlls ; cd .. ; configure. - After you have compiled and installed wine, you have to unregister rsabase and register rsaenh (regsvr32 /U rsabase ; regsvr32 rsaenh). rsaenh.dll is meant to replace rsabase.dll sometime (Windows XP also has rsaenh.dll only). - This patch was tested with the attached regression tests and with some MSDN example code. No real application was tested until now. - This code is not secure! The user's persistent private RSA signature and key exchange key pairs are stored in the registry in _plaintext_. Do not use this with your homebanking application ;) - The code depends on CUR_BLOB_VERSION being defined in wincrypt.h. This is implemented in a distinct trivial patch, which I've submitted this morning and which will probably go into CVS tonight (that is if you live in germany ;) - You ain't see a whole lot, if you don't have the openssl headers installed (libssl-dev on debian). The code will compile without, but you'll get a lot of FIXME's and some of the regression tests will fail. Please excuse me for posting a 30kB message. Greetings, Michael

1 0

Problems With MSI
by Joaquín Fernández Oct. 25, 2004

Oct. 25, 2004

Hello... i am having problems installing program with MSI Installer. When i launch setup.exe, the installer begin the process and when finish of copy files (progress bar is 100%), stay in endless loop. I ran serveral programs using MSI installer but nothing, all hangs at end of copy files. I tested it with WINEDLLOVERRIDES="msi,msiexec.exe=n" too but is equal. Some dll override or other thing? Regards Joaquín P.D.: Wine 20040914 & Mandrake Linux 10.1 Community -- -----BEGIN PGP PUBLIC KEY BLOCK----- Version: GnuPG v1.2.4 (GNU/Linux) mQFCBEFI/gARAwDd2+ojasT3rCyRktSw+Ix3m+yoxSD0NkpMLlunmJxwvn6wKZVl mDw76/Zu9mqDWWeSGdSl+60T7fDLrJZSEB45O9T5jdujj01GFeer7xuiuHBTFw8o CXqD/hzhqYc46ecAoIQQjZ2qZtOWLPRBbegK/nyOIguNAv9QGiKPLBS8o0ksxEUp EfLAExVmu6Zp693uKGf6XrBWNcLriuwRPr1mjy3N/bhMlqc3vcTeUBwxiUuX5h2P NQgB3d2AbJS6oEvhmZL0Bn/8Ij/MSvVrartmCXuw9eSx0aMC/R7Kw9TtUfxFVUGx fQKwoA9BXNElPLcNohbBS/fH87IMMxCJyn+rmTeNCEcUEQ7UgvVCdlzZ8+L4PdlH qGR81nhZVEwPRnSSesLpSHRC1QQVoceBeb7PICr/b2eZiKMX+bQ+Sm9hcXXDrW4g TWFudWVsIEZlcm7DoW5kZXogUXVpbGVzIDxqb2FxdWluQGNhc2FkZWFsYWJhbnph Lm9yZz6IXgQTEQIAHgUCQUj+AAIbAwYLCQgHAwIDFQIDAxYCAQIeAQIXgAAKCRBH 677/q7xL4e15AJwNfSpeaXXMH2EjuKblfeBe51MrUgCcCP5jEnpXrDXLWULIW5yD t6VdHlU= =a8BM -----END PGP PUBLIC KEY BLOCK-----

1 0

Re: WSCEnumProtocols, was _SHExpandEnvironmentStrings() should return input string if no % found to expand?
by Rolf Kalbermatter Oct. 25, 2004

Oct. 25, 2004

James Hawkins wrote: >> No, it will work. The cast probably there because the original author >> didn't want to write two functions. Instead he added a bool to the >> internal function that specifies whether the buffer is unicode or >> not. The cast is then needed to keep the compiler happy. > >The fact that the structures have a string in them is one issue that >you're ignoring. You can't make a cast from a unicode to an ansi >string just by casting. You have to call RtlMultiByteToWideChar to >convert it. This isn't a problem here since the helper function which is called has as last parameter a boolean telling it if the structure should be interpreted as the ANSI or Unicode version. While this may look asthetically wrong it is technically correct as long as the strings are embedded as pointers instead of inlined. There is a string inlined in the structure but it is at the end of the structure only so even there it is not necessarily a problem although the internal helper function needs to take extra care to get it right and in that it might be a better idea to just implement the Unicode version and convert for the ANSI one. >The major problem that you're ignoring is that you're >casting from one kind of struct to another, and they aren't the same. >The cast wont work. You would have to individually pull out the >relevant fields into a new PROTOCOL_INFO struct like I said in the >last post. If by original author I'm assuming you're talking about >the author of the spec file. In which case, there was only one >function in the spec file to begin with, because all functions only >have one in the spec file originally until someone stubs out that >function and finds out that it needs and A and a W...which is why I >didn't want my patch committed. This would be indeed the real problem if it was the case, but (from my SDK headers): int WSPAPI WSCEnumProtocols(IN LPINT lpiProtocols, OUT LPWSAPROTOCOL_INFOW lpProtocolBuffer, IN OUT LPDWORD lpdwBufferLength, OUT LPINT lpErrno); int WSAAPI WSAEnumProtocolsA(IN LPINT lpiProtocols, OUT LPWSAPROTOCOL_INFOA lpProtocolBuffer, IN OUT LPDWORD lpdwBufferLength); There is no ANSI version defined for the WSC function. This means either of two things: It is on all versions of Windows Unicode or it is very much like many Shell functions really ANSI on non NT systems while NT systems implement it as Unicode. Seeing that MSDN claims this to be supported on even Win95 I tend to believe the second one but only tests will show. The fact that modern SDK headers don't contain any indication of ANSI support means nothing as Microsoft has removed support for developing Win9x application from many SDK headers and MSDN. The problem seems to me rather that even the WSAEnumProtocols function casts the WSAPROTOCOL_INFOA/W structure pointer into PROTOCOL_INFOA and since they have indeed a completely different layout we are basically causing big trouble. I doubt that WSAEnumProtocols ever did work properly unless MS has at some point changed the second parameter of the function. Once this has been fixed, the implementation as suggested by Hans should actually work fine. Rolf Kalbermatter

1 0

Re: Fully Revised Wine User Guide Introduction
by Francois Gouget Oct. 25, 2004

Oct. 25, 2004

On Mon, 25 Oct 2004, Francois Gouget wrote: > On Fri, 22 Oct 2004, Scott Ritchie wrote: > [...] >> Unlike my previous patch, this one should be properly formatted, > > It still had very long lines. So here's a line-wrapped version of the patch: > > Changelog: > > * documentation/introduction.sgml > > Scott Ritchie <scott(a)open-vote.org> > Revised Wine User Guide Introduction Sorry for this. I was without Internet access for a while and our emails crossed. Hmmm, I wonder... does this double the chances of the patch getting accepted?<g> -- Francois Gouget fgouget(a)free.fr http://fgouget.free.fr/ Any sufficiently advanced bug is indistinguishable from a feature. -- from some indian guy

1 0

d3drs_multisampleantialias: check for it?
by Devils Cry Oct. 24, 2004

Oct. 24, 2004

Hi again... :/ ^^ So im now moving for the multisampleantialias call... ive found the gl_multisample_arb function to be matching, so far, so good. Now while googling for it i only found code examples which check whether multisampling is supported before it is activated. My question: do i need this? I found no other call in the d3d8lib which asks for its extension the way i found it (http://nehe.gamedev.net/data/lessons/lesson.asp?lesson=46) Theres also another problem: the multisampling has to be turned off after its done, turned on again if something is drawn and after this turned off again (at least i understood it that way...). Is it enough to simply turn it on? And if not, how should i do this??? Thx in advance Nikolas

2 1

Re: _SHExpandEnvironmentStrings() should return input string if no % found to expand?
by Hans Leidekker Oct. 24, 2004

Oct. 24, 2004

On Sunday 24 October 2004 01:35, James Hawkins wrote: > The reason why I said to ignore this patch is because there has to be > both an A and a W version of it. I'm pretty sure that this cast: No, I believe this is an exception. I assume that the spec file is correct in that there are no A and W versions of this function in shell32, it's just WSCEnumProtocols(). > (PROTOCOL_INFOA *)buffer > from a LPWSAPROTOCOL_INFOW structure isn't going to work. No, it will work. The cast probably there because the original author didn't want to write two functions. Instead he added a bool to the internal function that specifies whether the buffer is unicode or not. The cast is then needed to keep the compiler happy. > WSAPROTOCOL_INFO and PROTOCOL_INFO don't even have the same fields: No, but WSCEnumProtocols() wants WSAPROTOCOL_INFOW structures, just like WSAEnumProtocolsW(). Quote from MSDN: int WSCEnumProtocols( LPINT lpiProtocols, LPWSAPROTOCOL_INFOW lpProtocolBuffer, LPDWORD lpdwBufferLength, LPINT lpErrno ); -Hans

2 1