- Wine-Devel - list.winehq.org

RE: fixed bug in shell32
by Rolf Kalbermatter Oct. 5, 2004

Oct. 5, 2004

>@@ -163,10 +163,10 @@ > else > ret = (SHNotifyDeleteFileA(szTemp) == ERROR_SUCCESS); > } while (ret && FindNextFileA(hFind, &wfd)); >+ FindClose(hFind); >+ if (ret) >+ ret = (SHNotifyRemoveDirectoryA(pszDir) == ERROR_SUCCESS); > } >- FindClose(hFind); >- if (ret) >- ret = (SHNotifyRemoveDirectoryA(pszDir) == ERROR_SUCCESS); > return ret; > } This create a FindFile handle leak if the user chooses to abort the delete operation. Rolf Kalbermatter

1 0

Re: Contributing to WINE
by Shachar Shemesh Oct. 5, 2004

Oct. 5, 2004

Hi Ronald, I cannot stress this point enough. Wine is a community project. Everyone involved in the Wine project would appreciate a chance to answer your questions, as well as hear what you have to say. Sometimes there is a need to establish private communication with certain people. As a rule, however, all technical guidance and discussions should be done on the mailing list. This way, everyone gets a chance to respond to your inquiries. Also, it appears that many participants of this list, as well as the web mail archive, are having problems with the format in which you send your emails. Please try to send mail to this list in plain text format. The format in which you sent me seems to be ok, but I cannot say for sure. Ronald Robin wrote: >Hi Shachar, thank you for your response to my post. I am sorry for several >things: First, that we have not tried posting to this mailing list before. >We thought before that it would be better to establish communications first >with the person who leads the project (i.e. Mr. Julliard). I guess that was >my mistake. Second, that it took me a long time to respond back to you. >You've been a great help. Thank you for the suggestions that you gave. I'm >sure it would be most helpful in case we would need to hire some more help >in the future. > >Anyway, I'd like to introduce myself again. I'm Ronald Robin of SpecOpS >Labs. I am the Project Manager for the David Project. I'm in charge of >managing the research and development efforts within our lab as well as >those done by our partner universities an institutions including the the >National Computer Center, De Lasalle University, and Ateneo de Manila >Univesity here in the Philippines. > >As mandated by our President & CEO, Frederick Lewis and our CTO, Peter >Valdez, we are glad to announce to you that one of my team's newer >objectives is to regularly contribute to the WINE Community. To get things >started with, I can assign some of our developers to focus working on >something we can proudly contribute to the WINE community. We may not be >able to dedicate a significant number of them, but it’s a start. > > Any development you can put towards the wine project would be appreciated and welcomed. >I was wondering, is it ok for me to ask you some more questions? > > Better yet, ask everyone the questions. This way, you will get answers even if I happen to be busy, or not know the answer. >I believe you're one of the best persons right now to help us get some ideas >as to what particular problem areas we can focus our contribution efforts >on. It would be really nice if my team can contribute something significant >to the community. > > While I thank you for the complement, this is not how things usually work in a free software project. As you may know, Wine has several areas that could use a developer's attention. We don't know much about your company, so it would be hard to know what areas would be best for you to contribute in. First off, we would all appreciate if you sent any code you happen to change in Wine while working on David anyways. This basic form of contribution is usually the easiest for you to do. As for general areas of improvements in Wine, there are a few. Development there had better be coordinated with the people already working on these things. Probably the area most needing tender love and care is DCOM. While people are currently working on it, we still depend on Microsoft's DLLs in that area, which is not a good thing. Another place that could use enhancement is MSI. Personally, I also want to see better BiDi support, but that's something not many of the list's members care about as much as I. I'm sure other list members will be happy to fill in other areas where your help would be most appreciated. >Thanks again. > > Any time. >Cheers! > >Ronald Robin > > Shachar -- Shachar Shemesh Lingnu Open Source Consulting ltd. http://www.lingnu.com/

1 0

wctype
by Ge van Geldorp Oct. 5, 2004

Oct. 5, 2004

I compared the results of CT_CTYPE1 GetStringTypeW() between Windows 2000 and Wine and found a lot of differences (about 12000 of them). Nothing really spectacular, e.g. codepoint 0x00b5 (MICRO SIGN) is classified C1_PUNCT in Win2k and (C1_ALPHA | C1_LOWER) in Wine. I noticed that the Wine table is generated from information on ftp.unicode.org, so I'm wondering if the table generation is correct or if Microsoft made some strange choices? Gé van Geldorp.

2 2

Thread not detaching?
by Duane Clark Oct. 4, 2004

Oct. 4, 2004

I have an application that is hanging, apparently because a thread is not detaching: 000a:Call kernel32.ExitThread(00000000) ret=4077907f 000a:Call ntdll.LdrShutdownThread() ret=40376278 000a:Call PE DLL (proc=0x40ea2024,module=0x40ea0000 L"midimap.drv",reason=THREAD_DETACH,res=(nil)) 000a:Ret PE DLL (proc=0x40ea2024,module=0x40ea0000 L"midimap.drv",reason=THREAD_DETACH,res=(nil)) retval=1 000a:Call PE DLL (proc=0x40d4a02c,module=0x40d40000 L"msacm.drv",reason=THREAD_DETACH,res=(nil)) 000a:Ret PE DLL (proc=0x40d4a02c,module=0x40d40000 L"msacm.drv",reason=THREAD_DETACH,res=(nil)) retval=1 000a:Call PE DLL (proc=0x40d1405c,module=0x40d10000 L"wineoss.drv",reason=THREAD_DETACH,res=(nil)) 000a:Ret PE DLL (proc=0x40d1405c,module=0x40d10000 L"wineoss.drv",reason=THREAD_DETACH,res=(nil)) retval=1 000a:Call PE DLL (proc=0x407dc1d8,module=0x407d0000 L"user32.dll",reason=THREAD_DETACH,res=(nil)) 000a:Call ntdll.RtlAllocateHeap(401e0000,00000000,00000080) ret=4080a08c 000a:Ret ntdll.RtlAllocateHeap() retval=4026cfd8 ret=4080a08c err:ntdll:RtlpWaitForCriticalSection section 0x403f2580 "syslevel.c: Win16Mutex" wait timed out in thread 000b, blocked by 000a, retrying (60 sec) err:ntdll:RtlpWaitForCriticalSection section 0x408849c0 "../../windows/user.c: USER_SysLevel" wait timed out in thread 000a, blocked by 000b, retrying (60 sec) The place it is happening is in WIN_GetPtr(), in the call to USER_Lock(). It is getting to RtlpWaitForCriticalSection() and hanging forever: 000a:Call PE DLL (proc=0x407dc1d8,module=0x407d0000 L"user32.dll",reason=THREAD_DETACH,res=(nil)) trace:ntdll:RtlEnterCriticalSection Here trace:ntdll:RtlEnterCriticalSection finished SpinCount trace:ntdll:RtlEnterCriticalSection done trace:ntdll:RtlEnterCriticalSection Here trace:ntdll:RtlEnterCriticalSection finished SpinCount trace:ntdll:RtlEnterCriticalSection done trace:win:WIN_DestroyThreadWindows Destroying windows 000a:Call ntdll.RtlAllocateHeap(401e0000,00000000,00000080) ret=4080a08c trace:ntdll:RtlEnterCriticalSection Here trace:ntdll:RtlEnterCriticalSection finished SpinCount trace:ntdll:RtlEnterCriticalSection done 000a:Ret ntdll.RtlAllocateHeap() retval=4026cff8 ret=4080a08c trace:win:WIN_DestroyThreadWindows Start trace:win:WIN_DestroyThreadWindows 0 : 0x10022 trace:win:WIN_IsCurrentThread here trace:win:WIN_GetPtr here trace:win:WIN_GetPtr 1 trace:syslevel:_EnterSysLevel (0x40885ae0, level 2): thread a count before 0 trace:ntdll:RtlEnterCriticalSection Here trace:ntdll:RtlEnterCriticalSection finished SpinCount trace:ntdll:RtlpWaitForCriticalSection Here err:ntdll:RtlpWaitForCriticalSection section 0x403f2580 "syslevel.c: Win16Mutex" wait timed out in thread 000b, blocked by 000a, retrying (60 sec) Any clues on what should be happening here?

2 5

Setting DllOverrides by script
by Bill Medland Oct. 4, 2004

Oct. 4, 2004

I stopped concentrating for quite a few months and now the whole config system has changed.!! Any chance of some help? When we released the previous version of our product on Linux we included a couple of perl scripts etc. for setting up the Wine suitably, including adding a couple of drives, setting the path, modifying dll overrides. Now I am trying to figure out how to do it all with the new config system. Doing the drives is easy; a couple of symlinks. Doing the path is easy; regedit /s /E and regedit /s <filename> The problem I am having is with the DLL overrides. I see that they are now based on HKLM\Software\Wine\Wine\DllOverrides. How do I get them in? It seems to me that the only way that works is to edit the config itself and then restart the wineserver. Is that correct? (If so the no big deal) (I can't seem to import into the config using regedit nor can I actually edit the subtree under the GUI) -- Bill Medland mailto:billmedland(a)mercuryspeed.com http://webhome.idirect.com/~kbmed

3 4

Re: Tab control update
by Robert Shearman Oct. 4, 2004

Oct. 4, 2004

Jon Griffiths wrote: >Hi, > >A fairly large update to the tab control. This makes it work as per >native in my app. > >Regards, >Jon > > +dlls/comctl32/tab.c dlls/comctl32/tests/tab.c > Items can be variable sized; use an accessor to retrieve them > Send WM_NOTIFYFORMAT/WM_QUERYUISTATE to match native messages > There is no point in sending WM_QUERYUISTATE. I believe it is only really used for the toolbar control, but the native comctl32 has a common framework that means it is sent for all controls. > Only create a scroll control when/if we need one (like native) > Dump tab extra data when tracing > Combine all Unicode/Ascii calls together > Pass infoPtr around instead of fetching it multiple times, store > hwnd and focus state in it too. > Calculate correct tab widths when TCS_FIXEDWIDTH is not given > Code simplifications/const correctness/formatting fixes > Add some new combinations to tests for correct tab sizes > > I haven't looked at the rest of the changes yet and I won't have a chance until Sunday, but the changelog looks sane enough. Is it possible to split the patch up to make it more easily reviewable? Rob

3 5

Re: small fix
by Mike Hearn Oct. 4, 2004

Oct. 4, 2004

Hi, >Hi! >Here is a small patch for wine-20040914. >Summary: tool window with a caption are not managed. > This doesn't seem quite right - WS_EX_TOOLWINDOW & WS_CAPTION should be managed as we set the EWMH hints for this style later on in the code. What WM are you using Sergey? thanks -mike

1 0

Re: ez-cdda sleep
by Dan Kegel Oct. 3, 2004

Oct. 3, 2004

Eric Pouech (pouech-eric(a)wanadoo.fr) wrote: > ... > But, the address we get in GetThreadContext is the one from where the > thread waits on the server (hence the 0xffffe410 address), not the > address it was suspended from (as it's supposed to be) > > I don't think it will be easy to fix. > > Possible ideas: > ... > - storing context in server while entering USR1 signal handler (to be > done without races, which will require some more work, as the server > doesn't synchronize with the USR1 handler) This one seems most natural. Maybe the server should wait for the context to be stored before returning from SuspendThread. I bet on Windows, the target thread is really suspended before SuspendThread returns, and this would ensure that behavior. Maybe if we do this right, we can get rid of the racy looking loop at the top of test_SuspendThread() in dlls/kernel/tests/thread.c ... or is that loop needed on Windows, too? - Dan -- My technical stuff: http://kegel.com My politics: see http://www.misleader.org for examples of why I'm for regime change

2 1

Re: systemparamatersw question
by Ivan Leo Puoti Oct. 3, 2004

Oct. 3, 2004

>Write a program looping through the SPI values, then use regmon >to find the keys it accesses. Thanks, I'll give this a go. Ivan. ____________________________________________________________ Libero ADSL: navighi gratis a 1.2 Mega, senza canone e costi di attivazione. Abbonati subito su http://www.libero.it

1 0

Regression to Get IE Help to Work after September Snapshot
by Dan McGhee Oct. 3, 2004

Oct. 3, 2004

I could not get IE Help, or any application based on it, to work after the September snapshot. I did a regression and identified the commit of 20040824 16:00:16 CDT as causing the problem. This commit edits this patch: http://cvs.winehq.org/patch.py?id=13475 Among other things this patch changes wine/dlls/Makefile.in wine/configure.ac wine/configure I discovered during the regression that if I use ./tools/wineinstall and let wine set up my fake windows and .wine/config file I couldn't get IE Help to work. However, I used the September snapshot to test this, if I do "./configure, make depend && make" followed by install" and used a .wine generated by wine before the commit I identified, IE Help works. I also noticed when I found the patch that it was edited today to change the files that I noted above, but I can't tell if the changes address the subject of this post. I'm a real rookie when it comes to reading this patches and can suppy only information to this list. If it will help, I will be more than happy to create "diff" files from the "before and after" wine versions to help close in on the situation. Dan

2 5