- Wine-Devel - list.winehq.org

Re: MakeSureDirectoryPathExists improvement
by Alexandre Julliard Sept. 28, 2004

Sept. 28, 2004

Wolfgang Schwotzer <wolfgang.schwotzer(a)gmx.net> writes: > @@ -91,13 +91,28 @@ > */ > BOOL WINAPI MakeSureDirectoryPathExists(LPCSTR DirPath) > { > - if (CreateDirectoryA(DirPath, NULL)) return TRUE; > - if (GetLastError() == ERROR_ALREADY_EXISTS) > + char path[MAX_PATH]; > + const char *p = DirPath; > + int n; > + > + if (strchr(p, ':') != NULL) > + p = strchr(p, ':'); > + while ((p = strchr(p, '\\')) != NULL) > { > - SetLastError(ERROR_SUCCESS); > - return TRUE; > + n = p - DirPath + 1; > + strncpy(path, DirPath, n); > + path[n] = '\0'; > + if( !CreateDirectoryA(path, NULL) && > + (GetLastError() != ERROR_ACCESS_DENIED) && > + (GetLastError() != ERROR_ALREADY_EXISTS)) > + return FALSE; > + p++; > } > - return FALSE; > + if (GetLastError() == ERROR_ACCESS_DENIED || > + (GetLastError() == ERROR_ALREADY_EXISTS)) > + SetLastError(ERROR_SUCCESS); > + > + return TRUE; I don't think you want to simply ignore ERROR_ACCESS_DENIED. You should fix your algorithm to not try to create the drive root and then ignore only ERROR_ALREADY_EXISTS. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: winecfg: Add Makefile rules to rebuild resource file when translations change
by Alexandre Julliard Sept. 28, 2004

Sept. 28, 2004

Mike Hearn <mike(a)navi.cx> writes: > Add Makefile rules to rebuild resource file when translations change 'make depend' is a convenient way to do that, maybe you should give it a try ;-) -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: stub implementation SystemFunction036
by Filip Navara Sept. 28, 2004

Sept. 28, 2004

James Hawkins wrote: >+ >+VOID WINAPI SystemFunction036(PCHAR Buffer, INT BufferSize) >+{ >+ FIXME("(%s, %i): stub\n", Buffer, BufferSize); >+} >+ > > If you really want to stub this function then please don't print the buffer contents. It's an output buffer and contains garbage (maybe the garbage means something, but still it's garbage). - Filip

2 1

Re: SystemFunction036 debugging problem
by James Hawkins Sept. 27, 2004

Sept. 27, 2004

> Is the target (the thing calling SystemFunction036) available to download > anywhere? Yea. here's the link: http://www.download.com/redir?pid=10287361&merid=107235&mfgid=107235&lop=li… On Tue, 28 Sep 2004 07:29:14 +0800, Jonathan Wilson <jonwil(a)tpgi.com.au> wrote: > Is the target (the thing calling SystemFunction036) available to download > anywhere? > > -- James Hawkins

1 0

Problems installing office 2k.
by James Pellow Sept. 27, 2004

Sept. 27, 2004

Hi List, I just installed wine from cvs as of this morning and am still having problems installing office. I get the following error when starting the installer with the msi debugging channel on: fixme:msi:MsiEnableLogA 00000516 "c:\\windows\\temp\\Office 2000 Professional Setup (0014)_MsiExec.txt" 00000000 trace:msi:MsiEnableLogW 00000516 L"c:\\windows\\temp\\Office 2000 Professional Setup (0014)_MsiExec.txt" 00000000 trace:msi:MsiInstallProductA "/I" "" fixme:msi:MsiInstallProductW L"/I" L"" trace:msi:MsiVerifyPackageW L"/I" trace:msi:MsiOpenDatabaseW L"/I" (null) 0x4055fd78 trace:msi:MSI_OpenDatabaseW L"/I" (null) fixme:msi:MSI_OpenDatabaseW open failed r = 80004005! trace:msi:MsiCloseHandle 405aa5aa Installation of /I () failed. Mike had suggested I not use the builtin msi.dll. Since no native msi system was installed, the office 2k installer to tried to install one resulting in the following error: fixme:thread:NtSetInformationThread Set ThreadImpersonationToken handle to (nil) fixme:thread:NtSetInformationThread Set ThreadImpersonationToken handle to 0x50 err:ntdll:NtQueryInformationToken Unhandled Token Information class 8! fixme:thread:NtSetInformationThread Set ThreadImpersonationToken handle to 0x44 fixme:powermgnt:SetThreadExecutionState (0x80000001): stub, harmless. fixme:powermgnt:SetThreadExecutionState (0x80000000): stub, harmless. fixme:thread:NtSetInformationThread Set ThreadImpersonationToken handle to (nil) Installation of /i (REBOOT=REALLYSUPRESS) failed. It is suprising to me that nobody else has reported this office 2k msi problem. I guess everyone is using OpenOffice these days :) I really don't use wine much, but I have been following its progress over the years and compile and test it once in a while. I am happy to do a little more debugging if someone wanted to give me some pointers. Thanks. Cheers, James -- ***************************** James A. Pellow, President Alent Design Solutions www.alentdesignsolutions.com (509) 526-0682 *****************************

1 0

edonkey2000 dll err
by J. Grant Sept. 27, 2004

Sept. 27, 2004

Hello, As this is an "err, I thought I should post the the devl list. I am using CVS build from 2004-09-20. I am using DLL's copied from working win2k install. It seems quite fatal, any ideas? Kind regards JG c:\opt\ed2k>edonkey2000.exe c:\opt\ed2k>err:module:import_dll No implementation for MSVCRT.dll.??_U(a)YAPAXI@Z imported from L"C:\\opt\\ed2k\\MSVCIRT.dll", setting to 0xdeadbeef err:module:import_dll No implementation for MSVCRT.dll.??_V(a)YAXPAX@Z imported from L"C:\\opt\\ed2k\\MSVCIRT.dll", setting to 0xdeadbeef -- Homepage: http://jguk.org/ Blog: http://jguk.org/index.html#blog Radio: http://jguk.org/index.html#radio

3 3

Re: Getting winebuild to work on HP-UX
by Warren_Baird/CSI＠cimmetry.com Sept. 27, 2004

Sept. 27, 2004

"Eric Frias" <efrias(a)syncad.com> wrote on 09/27/2004 09:52:12 AM: > I don't know if this made it through on Thursday; if not, here's a repeat: I saw it on the archive - sorry I didn't get a chance to respond on Friday. Thanks for the repeat, though - it saves me cutting and pasting from the browser. :-) > I'm afraid I won't be a lot of help right now, but I might be able to offer > some moral support. Well - at this point even moral support would be a good thing... > I've spent several weeks last year trying to get > winelib working on HPUX, but I don't really have anything to show for it. > Before I could get anything working, I had to abandon HPUX and work on > fixing up Linux and Solaris stuff because it was in higher demand. I'll > eventually need to get HPUX working also, but I won't be able to devote too > much time to it for at least a month. My timeline is probably tighter than that - I'm hoping to have winelib working within the next month... So you might be lucky. :-) > I was in the same situation as you are... very rusty at x86 assembly, able > to comprehend a little sparc assembly, but I didn't know a thing about > pa-risc. I was simply typing make, letting it run until it had some error > because HPUX wasn't supported, coming up with some fix for it, and > repeating. Some days I felt like I almost grasped what was going on and how > to fix it, and some days it felt like it was miles away. I never got all of > wine compiling, so I have no idea if any of the fixes I made were correct or > not. I'd be happy to share them with you, but seeing them might do you more > harm than good. Yeah, if you wouldn't mind, send me the patches --- It may give me some useful ideas, at least. > Anyway, good luck, and if you weren't looking for an excuse to learn pa-risc > assembly, well, you have my sympathies. I'm told it builds character :-) :-) then I guess my character is in for a bit of a work-out. <sigh> Thanks, Warren -- Warren Baird, Technical Group Leader warren_baird(a)cimmetry.com Cimmetry System Inc. 514 735 3219 x148

1 0

Wine User Guide changes (RFC)
by Brian Vincent Sept. 27, 2004

Sept. 27, 2004

With Mike's recent Winecfg patches and the renewed hope we'll cut over to using Winecfg some day, I went through and began updating the Wine User Guide. The focus of the changes thus far was to remove references to the config file and discuss Winecfg instead. Without actually being able to use Winecfg these changes are useless, but it's probably worth looking this over to see whether these docs are headed in the right direction. For now, the biggest changes can be found in configuring.sgml (which translates into the "Configuring Wine" part of the guide.) A diff is available here: http://www.theshell.com/~vinn/wine-user-guide.diff However, this stuff is best looked at as a side-by-side comparison with the existing docs. You can find that here: http://www.theshell.com/~vinn/wine-user-guide.html (Not having looked at Mike's recent patches, I'm sure this will soon be out of date. Things like drive detection are missing. There's also parts that I left undone: such as the printing config, an appendix listing reg keys would be nice once we know what they all are. Other parts probably need a better explanation, such as font configuration. Anything you notice missing is probably worth telling me about, though it won't be hard to find lots of mistakes.) One of the big goals of all this is to reduce the amount of documentation and outdated stuff. Therefore, registry.sgml, printing.sgml, and fonts.sgml have been somewhat merged into configuring.sgml. fonts.sgml contained a lot of outdated info in it that probably caused more confusion than helped. Going forward, we have a lot of documentation in the User Guide about downloading Wine, compiling Wine, CVS, etc; mostly stuff that's already duplicated in some form or another on the web site. I'd like to see as much stuff like that removed from the User Guide as possible, we can simply refer people to WineHQ for more info. (I think the reason for the duplication is that the website docs simply didn't exist when the User Guide was written, now the website has superceded the User Guide.) When it's all said and done we should be left with the following sections: - Introduction - Configuration - Running - Troubleshooting At least, that's the direction I think it should go and at some point I could begin making those changes. Anyone disagree? Any thoughts, comments, concerns, criticisms? -Brian

2 1

tree/list-view slowness
by James Hawkins Sept. 27, 2004

Sept. 27, 2004

I am currently working on making Kazaa Lite 2.4.3 more usable. The most major problem remaining is that when the user chooses to search for a file on the network, the program slows almost to a halt and becomes mostly unmanageable. The results are displayed in a tree/list-view in the right pane [1]. I've looked into both of the controls, and it seems like the slowness could be coming from their implementation, but even when I set comctl32 to native, the problem remains. Also, I've done a trace+treeview and a trace+listview and only treeview api's seem to be called and not listview. Would it be a possibility that they implemented their own listview? Can anyone describe a method I can use to track down the inefficiency? Thankyou for your help. [1] http://www.andrew.cmu.edu/user/jhawkins/klite.jpeg -- James Hawkins

2 1

Re: Listbox fixes
by Alexandre Julliard Sept. 27, 2004

Sept. 27, 2004

Jon Griffiths <jon_p_griffiths(a)yahoo.com> writes: > +dlls/user/listbox.c > Draw background of the empty selected item in empty lists > Dont draw a focus rect if we do not have the focus > Dont select items on key up/down in multi-select lists This is causing a test failure: listbox.c:134: Test failed: style 0x8, step step, field selected: expected 2, got 1 listbox.c:134: Test succeeded inside todo block: style 0x8, step step, field selcount: expected 1, got 1 (the second one is a good thing of course...) -- Alexandre Julliard julliard(a)winehq.org

5 6