- Wine-Devel - list.winehq.org

Wine Status - User Interface
by Tom Aug. 19, 2004

Aug. 19, 2004

Hello, I have been working on a update for the Status UI page over the last couple day's and i'm attaching a copy of what I have. I've re-named the template to .html so you can view it in your e-mail program or browser of choice. I haven't done the changelog so just view this againt http://www.winehq.org/site/status_ui for changes or diff. commits, suggestions, and flames are welcomed Regards, Tom

2 1

gethostbyname on local host returns 127.0.0.1 for address
by Robert Reif Aug. 19, 2004

Aug. 19, 2004

On windows gethostbyname for the local host returns the addresses of the available network interfaces. On wine and unix, it only returns the localhost 127.0.0.1. Any ideas on how to get the windows behavior? #include <stdio.h> #ifdef _WIN32 #include <winsock2.h> #include <ws2tcpip.h> #else #include <netdb.h> #endif int main(int argc, char* argv[]) { char host_name[1024]; char ** alias; struct hostent * host; unsigned int i = 0; #ifdef _WIN32 WSADATA wsaData; WORD wVersionRequested = MAKEWORD(2, 2); int error = WSAStartup(wVersionRequested, &wsaData); if (error != 0) { fprintf(stderr, "WSAStartup failed\n"); return 1; } // Confirm that the Windows Sockets DLL supports 2.2. // Note that if the DLL supports versions greater // than 2.2 in addition to 2.2, it will still return // 2.2 in wVersion since that is the version we // requested. if (LOBYTE(wsaData.wVersion) != 2 || HIBYTE(wsaData.wVersion) != 2) { fprintf(stderr, "couldn't find dll\n"); return 1; } #endif if (gethostname(host_name, sizeof(host_name)) != 0) { fprintf(stderr, "gethostname failed\n"); return 1; } printf("host: %s\n", host_name); host = gethostbyname(host_name); if (host == 0) { fprintf(stderr, "gethostbyname failed\n"); return 1; } printf("name of host: %s\n", host->h_name); for (alias = host->h_aliases; *alias != NULL; alias++) printf("alias: %s\n", *alias); printf("length of address: %d\n", host->h_length); while (host->h_addr_list[i] != 0) { struct in_addr n_addr; memcpy(&n_addr, host->h_addr_list[i], sizeof(struct in_addr)); printf("%d: %s\n", i, inet_ntoa(n_addr)); i++; } return 0; }

1 0

Re: Fixed some ref handling
by Alexandre Julliard Aug. 18, 2004

Aug. 18, 2004

Jacek Caban<jack(a)itma.pwr.wroc.pl> writes: > I attached two test. The first is simple and shows a problem > that the patch fixes but the second one is a more complex test. Could you please merge the test into the existing test framework? -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: Removed slovenian translation
by Alexandre Julliard Aug. 18, 2004

Aug. 18, 2004

Jacek Caban<jack(a)itma.pwr.wroc.pl> writes: > Changelog: > Removed slovenian translation If the translation is not complete it should be fixed, or at worse commented out. Removing it doesn't make sense, we'll need to add it back someday anyway. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: KERNEL: pull WINDIR and WINSYSDIR from config before using hardcoded defaults (possible fix for WWN #234, #235 c:\\windows is not accessible Error)
by Alexandre Julliard Aug. 18, 2004

Aug. 18, 2004

Alex Villacís Lasso <a_villacis(a)palosanto.com> writes: > Changelog: > * if windir or winsysdir environment vars are undefined, pull values > from config file before falling to hardcoded values This of course defeats the whole purpose of the use of environment variables, which is to get rid of the config file. If the environment variables are not set it's because the user's config is wrong, they should be set in HKLM\System\CurrentControlSet\Control\SessionManager or (preferably) in HKCU\Environment. The code is supposed to migrate them automatically, but this may not always work if the registry already contains other values, in which case it needs to be fixed by hand. Going back to the config file is definitely not the right way. -- Alexandre Julliard julliard(a)winehq.org

1 0

bug
by Ivan Leo Puoti Aug. 18, 2004

Aug. 18, 2004

Since futimes is used instead of utime the installer of word viewer 97 has had a few installation issues. For a start, when the setup looks for installed components, it goes into a non infinite loop that lasts a few minutes. This only took a few seconds previously. I don't know what is causing this slow performance. The changelog of the patch that caused this regression says "so that it can be done on the client side.", maybe doing the call on client side makes it slow because the call has to go trough wineserver? I don't know. Also the graphics aren't redrawn until the loop ends. A relay log of the loop follows. I'm not very confident that I'll be able to fix this myself, but any help/hints are welcome. Interestingly the loop doesn't occur during a call to kernel.dll.SetFileTime() that's the function modified by the patch. The patch that causes the problem is http://cvs.winehq.org/patch.py?id=11722 Subsequent patches have obviously modified the function, but this hasn't solved the problem. MAybe the subsequent patches avoid an infinite loop (I don't remember the loop finishing with wine from a few months ago). Ivan.

1 0

New Fun Project - Winelib port of Allegiance
by Steven Edwards Aug. 18, 2004

Aug. 18, 2004

Hi all, Microsoft Research has released a Shared Source version of the game Allegiance. This is a hefty 512 meg download and of course the license that it is under would prevent anyone from sharing the changes but this would really allow us to improve Winelib by porting such a massive game. http://research.microsoft.com/research/allegiance/ Grab your copy quick before they pull it down. Thanks Steven __________________________________ Do you Yahoo!? Yahoo! Mail - 50x more storage than other providers! http://promotions.yahoo.com/new_mail

1 0

Re: OLEAUT32: implementation for IPersistPropertyBag_Load for OLEFont
by Robert Shearman Aug. 18, 2004

Aug. 18, 2004

Alex Villacís Lasso wrote: > This implementation is enough to satisfy VB6 when loading font objects > from property bags in projects. > > Changelog: > * Added implementation for IPersistPropertyBag_Load on OLEFont Looks good, but a few comments below: ... >+ V_VT(&valueAttr) = VT_EMPTY; > > It is probably better practice to use VariantInit here. >+ iRes = IPropertyBag_Read(pPropBag, sAttrName, &valueAttr, pErrorLog); >+ switch (iRes) { > > >+ case S_OK: >+ if (V_VT(&valueAttr) == VT_BSTR) { >+ /* Type is BSTR, use for name directly */ >+ OLEFontImpl_put_Name(this, V_BSTR(&valueAttr)); >+ >+ /* FIXME: Leaking memory here? */ >+ } else { >+ /* Don't know how to handle this type */ >+ FIXME("Name has type %d, not implemented\n", V_VT(&valueAttr)); >+ iRes = E_NOTIMPL; >+ } > Perhaps use VariantChangeType here? >+ break; >+ case E_POINTER: >+ FIXME("\tiResult = [E_POINTER]\n"); >+ break; >+ case E_INVALIDARG: >+ FIXME("\tiResult = [undef]\n"); >+ iRes = S_OK; >+ break; >+ case E_FAIL: >+ FIXME("\tiResult = [E_FAIL]\n"); >+ break; >+ } > Catch the errors you need to (why is E_INVALIDARG ok?) and either move these common debug statements to the end of the function (they should also be ERR's, not FIXME's). Also, you other unexpected errors, which is bad. >+ } >+ >+ if (iRes == S_OK) { >+ CY iSize; >+ iSize.s.Hi = 0; >+ iSize.s.Lo = 0; >+ >+ V_VT(&valueAttr) = VT_EMPTY; >+ iRes = IPropertyBag_Read(pPropBag, sAttrSize, &valueAttr, pErrorLog); >+ switch (iRes) { >+ case S_OK: >+ switch (V_VT(&valueAttr)) { >+ case VT_I2: >+ iSize.s.Lo = V_I2(&valueAttr) * 10000UL; >+ break; >+ case VT_UI2: >+ iSize.s.Lo = V_UI2(&valueAttr) * 10000UL; >+ break; >+ case VT_I4: >+ iSize.s.Lo = V_I4(&valueAttr) * 10000UL; >+ break; >+ case VT_UI4: >+ iSize.s.Lo = V_UI4(&valueAttr) * 10000UL; >+ break; >+ case VT_R4: >+ iSize.s.Lo = (ULONG)(V_R4(&valueAttr) * 10000UL); >+ break; >+ case VT_R8: >+ iSize.s.Lo = (ULONG)(V_R8(&valueAttr) * 10000UL); >+ break; > > Again, perhaps use VariantChangeType here? >+ default: >+ /* Don't know how to handle this type */ >+ FIXME("Size type %d, not implemented\n", V_VT(&valueAttr)); >+ iRes = E_NOTIMPL; >+ break; >+ } >+ if (iRes != E_NOTIMPL) IFont_put_Size(this, iSize); >+ break; >+ case E_POINTER: >+ FIXME("\tiResult = [E_POINTER]\n"); >+ break; >+ case E_INVALIDARG: >+ FIXME("\tiResult = [undef]\n"); >+ iRes = S_OK; >+ break; >+ case E_FAIL: >+ FIXME("\tiResult = [E_FAIL]\n"); >+ break; >+ } > Same comment as before about errors. >+ } >+ if (iRes == S_OK) { >+ signed short iCharset = 0; >+ >+ V_VT(&valueAttr) = VT_EMPTY; >+ iRes = IPropertyBag_Read(pPropBag, sAttrCharset, &valueAttr, pErrorLog); >+ switch (iRes) { >+ case S_OK: >+ switch (V_VT(&valueAttr)) { >+ case VT_I2: >+ if (V_I2(&valueAttr) < 0) { >+ FIXME("Unexpected value for Font Charset (%hd), using 0\n", V_I2(&valueAttr)); >+ } else { >+ iCharset = V_I2(&valueAttr); >+ } >+ break; >+ case VT_UI2: >+ if (V_UI4(&valueAttr) > 32767L) { >+ FIXME("Unexpected value for Font Charset (%ld), using 0\n", V_UI4(&valueAttr)); >+ } else { >+ iCharset = V_UI2(&valueAttr); >+ } >+ break; >+ case VT_I4: >+ if (V_I4(&valueAttr) < 0 || V_I4(&valueAttr) > 32767L) { >+ FIXME("Unexpected value for Font Charset (%ld), using 0\n", V_I4(&valueAttr)); >+ } else { >+ iCharset = V_I4(&valueAttr); >+ } >+ break; >+ case VT_UI4: >+ if (V_UI4(&valueAttr) > 32767L) { >+ FIXME("Unexpected value for Font Charset (%ld), using 0\n", V_UI4(&valueAttr)); >+ } else { >+ iCharset = V_UI4(&valueAttr); >+ } >+ break; >+ default: >+ /* Don't know how to handle this type */ >+ FIXME("Charset type %d, not implemented\n", V_VT(&valueAttr)); >+ iRes = E_NOTIMPL; > > Use VariantChangeType here and you will get all the bounds checking for free. >+ } >+ if (iRes != E_NOTIMPL) IFont_put_Charset(this, iCharset); >+ break; >+ case E_POINTER: >+ FIXME("\tiResult = [E_POINTER]\n"); >+ break; >+ case E_INVALIDARG: >+ FIXME("\tiResult = [undef]\n"); >+ iRes = S_OK; >+ break; >+ case E_FAIL: >+ FIXME("\tiResult = [E_FAIL]\n"); >+ break; >+ } >+ } >+ >+ if (iRes == S_OK) { >+ signed short iWeight = FW_NORMAL; >+ >+ V_VT(&valueAttr) = VT_EMPTY; >+ iRes = IPropertyBag_Read(pPropBag, sAttrWeight, &valueAttr, pErrorLog); >+ switch (iRes) { >+ case S_OK: >+ switch (V_VT(&valueAttr)) { >+ case VT_I2: >+ if (V_I2(&valueAttr) < 0) { >+ FIXME("Unexpected value for Font Weight (%hd), using FW_NORMAL\n", V_I2(&valueAttr)); >+ } else { >+ iWeight = V_I2(&valueAttr); >+ } >+ break; >+ case VT_UI2: >+ if (V_UI4(&valueAttr) > 32767L) { >+ FIXME("Unexpected value for Font Weight (%ld), using FW_NORMAL\n", V_UI4(&valueAttr)); >+ } else { >+ iWeight = V_UI2(&valueAttr); >+ } >+ break; >+ case VT_I4: >+ if (V_I4(&valueAttr) < 0 || V_I4(&valueAttr) > 32767L) { >+ FIXME("Unexpected value for Font Weight (%ld), using FW_NORMAL\n", V_I4(&valueAttr)); >+ } else { >+ iWeight = V_I4(&valueAttr); >+ } >+ break; >+ case VT_UI4: >+ if (V_UI4(&valueAttr) > 32767L) { >+ FIXME("Unexpected value for Font Weight (%ld), using FW_NORMAL\n", V_UI4(&valueAttr)); >+ } else { >+ iWeight = V_UI4(&valueAttr); >+ } >+ break; >+ default: >+ /* Don't know how to handle this type */ >+ FIXME("Weight type %d, not implemented\n", V_VT(&valueAttr)); >+ iRes = E_NOTIMPL; >+ } > Again, use VariantChangeType. >+ if (iRes != E_NOTIMPL) IFont_put_Weight(this, iWeight); >+ break; >+ case E_POINTER: >+ FIXME("\tiResult = [E_POINTER]\n"); >+ break; >+ case E_INVALIDARG: >+ FIXME("\tiResult = [undef]\n"); >+ iRes = S_OK; >+ break; >+ case E_FAIL: >+ FIXME("\tiResult = [E_FAIL]\n"); >+ break; >+ } >+ } >+ >+ if (iRes == S_OK) { >+ BOOL bUnderline = FALSE; >+ >+ V_VT(&valueAttr) = VT_EMPTY; >+ iRes = IPropertyBag_Read(pPropBag, sAttrUnderline, &valueAttr, pErrorLog); >+ switch (iRes) { >+ case S_OK: >+ switch (V_VT(&valueAttr)) { >+ case VT_I2: >+ bUnderline = V_I2(&valueAttr) ? TRUE : FALSE; >+ break; >+ case VT_I4: >+ bUnderline = V_I4(&valueAttr) ? TRUE : FALSE; >+ break; >+ case VT_UI2: >+ bUnderline = V_UI2(&valueAttr) ? TRUE : FALSE; >+ break; >+ case VT_UI4: >+ bUnderline = V_UI4(&valueAttr) ? TRUE : FALSE; >+ break; >+ case VT_BOOL: >+ bUnderline = V_BOOL(&valueAttr); >+ break; >+ default: >+ /* Don't know how to handle this type */ >+ FIXME("Underline type %d, not implemented\n", V_VT(&valueAttr)); >+ iRes = E_NOTIMPL; >+ break; >+ } > Again, VariantChangeType. >+ if (iRes != E_NOTIMPL) IFont_put_Underline(this, bUnderline); >+ break; >+ case E_POINTER: >+ FIXME("\tiResult = [E_POINTER]\n"); >+ break; >+ case E_INVALIDARG: >+ FIXME("\tiResult = [undef]\n"); >+ iRes = S_OK; >+ break; >+ case E_FAIL: >+ FIXME("\tiResult = [E_FAIL]\n"); >+ break; >+ } >+ } >+ >+ if (iRes == S_OK) { >+ BOOL bItalic = FALSE; >+ >+ V_VT(&valueAttr) = VT_EMPTY; >+ iRes = IPropertyBag_Read(pPropBag, sAttrItalic, &valueAttr, pErrorLog); >+ switch (iRes) { >+ case S_OK: >+ switch (V_VT(&valueAttr)) { >+ case VT_I2: >+ bItalic = V_I2(&valueAttr) ? TRUE : FALSE; >+ break; >+ case VT_I4: >+ bItalic = V_I4(&valueAttr) ? TRUE : FALSE; >+ break; >+ case VT_UI2: >+ bItalic = V_UI2(&valueAttr) ? TRUE : FALSE; >+ break; >+ case VT_UI4: >+ bItalic = V_UI4(&valueAttr) ? TRUE : FALSE; >+ break; >+ case VT_BOOL: >+ bItalic = V_BOOL(&valueAttr); >+ break; >+ default: >+ /* Don't know how to handle this type */ >+ FIXME("Italic type %d, not implemented\n", V_VT(&valueAttr)); >+ iRes = E_NOTIMPL; >+ break; >+ } > Again, use VariantChangeType. >+ if (iRes != E_NOTIMPL) IFont_put_Italic(this, bItalic); >+ break; >+ case E_POINTER: >+ FIXME("\tiResult = [E_POINTER]\n"); >+ break; >+ case E_INVALIDARG: >+ FIXME("\tiResult = [undef]\n"); >+ iRes = S_OK; >+ break; >+ case E_FAIL: >+ FIXME("\tiResult = [E_FAIL]\n"); >+ break; >+ } >+ } >+ >+ if (iRes == S_OK) { >+ BOOL bStrikethrough = FALSE; >+ >+ V_VT(&valueAttr) = VT_EMPTY; >+ iRes = IPropertyBag_Read(pPropBag, sAttrStrikethrough, &valueAttr, pErrorLog); >+ switch (iRes) { >+ case S_OK: >+ switch (V_VT(&valueAttr)) { >+ case VT_I2: >+ bStrikethrough = V_I2(&valueAttr) ? TRUE : FALSE; >+ break; >+ case VT_I4: >+ bStrikethrough = V_I4(&valueAttr) ? TRUE : FALSE; >+ break; >+ case VT_UI2: >+ bStrikethrough = V_UI2(&valueAttr) ? TRUE : FALSE; >+ break; >+ case VT_UI4: >+ bStrikethrough = V_UI4(&valueAttr) ? TRUE : FALSE; >+ break; >+ case VT_BOOL: >+ bStrikethrough = V_BOOL(&valueAttr); >+ break; >+ default: >+ /* Don't know how to handle this type */ >+ FIXME("Strikethrough type %d, not implemented\n", V_VT(&valueAttr)); >+ iRes = E_NOTIMPL; >+ break; >+ } > > Again, use VariantChangeType. >+ if (iRes != E_NOTIMPL) IFont_put_Strikethrough(this, bStrikethrough); >+ break; >+ case E_POINTER: >+ FIXME("\tiResult = [E_POINTER]\n"); >+ break; >+ case E_INVALIDARG: >+ FIXME("\tiResult = [undef]\n"); >+ iRes = S_OK; >+ break; >+ case E_FAIL: >+ FIXME("\tiResult = [E_FAIL]\n"); >+ break; >+ } >+ } >+ return iRes; > } > > static HRESULT WINAPI OLEFontImpl_IPersistPropertyBag_Save( > > Thanks, Rob

1 0

Re: Some more hardcoded c:\windows paths
by Juan Lang Aug. 18, 2004

Aug. 18, 2004

Vincent wrote: > Any idea why CSIDL_PROGRAMS was HKEY_DISALLOWED? That, apparently, was my mistake. I introduced it here: http://www.winehq.org/hypermail/wine-patches/2004/04/0106.html Thanks for fixing it. --Juan __________________________________ Do you Yahoo!? New and Improved Yahoo! Mail - Send 10MB messages! http://promotions.yahoo.com/new_mail

1 0

Re: WineSetupTk...
by Ivan Leo Puoti Aug. 18, 2004

Aug. 18, 2004

> I doubt there's a one maintainer Nobody maintains it because it's obsolete and isn't used with current versions of wine. Ivan.

1 0