- Wine-Devel - list.winehq.org

winrash: some todos
by Sylvain Petreolle Aug. 1, 2004

Aug. 1, 2004

Some suggestions for winrash: * Running Windows NT version >= 4.XY, we should check for the use of an administrator account... installing as normal user gave these results : no error message said the HKLM keys couldnt be created => UserID & mail not set => service install/run fails silently * http links : the 3 http links fail to open at the end of installation, this has already been reported on wine-users list. (the mouse arrow changes though) ===== Sylvain Petreolle (spetreolle_at_users_dot_sourceforge_dot_net) Say NO to software patents Dites NON aux brevets logiciels "You believe it's the year 1984, when in fact, its closer to 2184"1984 / Matrix Vous manquez despace pour stocker vos mails ? Yahoo! Mail vous offre GRATUITEMENT 100 Mo ! Créez votre Yahoo! Mail sur http://fr.benefits.yahoo.com/ Le nouveau Yahoo! Messenger est arrivé ! Découvrez toutes les nouveautés pour dialoguer instantanément avec vos amis. A télécharger gratuitement sur http://fr.messenger.yahoo.com

1 0

Re: cleanup a->w cross calls in advapi32/crypt.c
by Dmitry Timoshkov Aug. 1, 2004

Aug. 1, 2004

"James Hawkins" <truiken(a)gmail.com> wrote: > Fixed even more bugs spotted by Dmitry. > > Changelog > * cleanup cross-call functions The quality of the patch still is not good enough. -- Dmitry.

2 2

Re: cleanup a->w cross calls in commdlg/fontdlg.c
by Dmitry Timoshkov Aug. 1, 2004

Aug. 1, 2004

"James Hawkins" <truiken(a)gmail.com> wrote: > Changelog > * fix cross-call functions > - return DialogBoxIndirectParamA(COMDLG32_hInstance, template, > + return DialogBoxIndirectParamW(COMDLG32_hInstance, template, > lpChFont->hwndOwner, FormatCharDlgProcA, (LPARAM)lpChFont ); You can't pass a not unicode dlgproc to DialogBoxIndirectParamW and hope that it will work. -- Dmitry.

1 0

Re: Question about mmap issues on FreeBSD/NetBSD
by Yorick Hardy Aug. 1, 2004

Aug. 1, 2004

Try the patch below, I am not yet sure why this would be necessary. Perhaps it helps. >I've got some cross platform issues i cannot resolve. There are some >obvious issues like the assumption that round() is in the math library >and not linking in the math library itself. i've worked passed those. >Currently, I'm working with a patched version of the latest cvs source >on Solaris 9x86. After applying Robert Lunnon's patch kit to the latest >cvs course and substituting rint for the round function in >wine/dlls/dsound/mixer.c and add the math library to EXTRALIBS, I got a >clean compile. however running the wine binary results in the following: > >try_mmap_fixed: vfork: Resource temporarily unavailable > >I'm not intimately familiar with how wine manages it's memory so I >hesitate to guess what is going on. I've attached the output of the >truss if anyone has any ideas on what it going on or how to fix it >please let me know. Kind regards, -- Yorick Hardy --- libs/wine/mmap.c.orig Thu Jul 29 20:03:03 2004 +++ libs/wine/mmap.c Sun Aug 1 13:07:07 2004 @@ -135,6 +135,8 @@ has exited. Furthermore, Wine sets SIGCHLD to SIG_IGN, so we don't need to wait for the child. */ + waitpid(pid, &pagesize, 0); + return result == addr; } #endif /* (__svr4__ || __NetBSD__) && !MAP_TRYFIXED */

1 0

Re: [RESENT] Make wine work with freedesktop.org MIME system
by Mike Hearn Aug. 1, 2004

Aug. 1, 2004

This was checked into CVS a few days ago, no need to resend. thanks -mike On Sun, 2004-08-01 at 11:35 +0200, Christian Neumair wrote: > Mike felt good enough to explain me on IRC where I should hook into the > wine build system. I've put up a tiny patch that works like a charm with > GNOME/shared-mime-info HEAD. It associates wine with the MIME type used > for DOS/Win32 binaries. > > regs, > Chris

1 0

Wine leaking GDI handles?
by Jon Griffiths Aug. 1, 2004

Aug. 1, 2004

Hi, I am trying to track down some GDI leaks in a large application I am porting. To make things easier I added logging to GDI_AllocObject and GDI_FreeObject in order to find mismatches at program termination, and hacked a script to find allocations that weren't deallocated. The patch to dlls/gdi/gdiobj.c and the script used are both attached below. My first question is; Is this a valid approach to tracking leaks, or are some GDI objects deallocated in another way? i.e. Should there be a GDI_FreeObject call for every GDI_AllocObject call or not? I run this analysis by setting WINEDEBUG="+all" and executing my app redirecting the results to a file. I then run the matching script to generate a list of addresses from GDI_AllocObject that have no corresponding GDI_FreeObject, along with the line number in the trace that the allocation occurred. This produced a rather overwhelming list which has thus far enabled me to find several application bugs causing leaks. However investigating several of the calls makes me suspect that Wine itself may have some leaks. If you follow the directions above against Wines clock.exe it lists here 121 unmatched deallocations (winver has 126). Some of these are for things like stock objects which arguably aren't very important, since they are only created once. But it appears that window creation/destruction may have leaks which is of definite concern here since my app creates many windows while generating screens on the fly (I see in my app that when GetDC is called for the first time on a window, causing a CreateDCW call, a region is leaked, or at least thats what it looks like to me). I seems a good idea to attempt to diagnose the leaks on a simple program like clock/winver before trying a more complicated app. Could someone with more experience in GDI verify that these leaks are genuine? I am a little lost amongst the GDI/user code... Thanks, Jon p.s. The script below does not handle GDI realloc, but I have yet to see it in any of my traces yet. ===== "Don't wait for the seas to part, or messiahs to come; Don't you sit around and waste this chance..." - Live jon_p_griffiths(a)yahoo.com __________________________________ Do you Yahoo!? Yahoo! Mail is new and improved - Check it out! http://promotions.yahoo.com/new_mail

1 0

Re: cleanup a->w cross calls in advapi32/crypt.c
by Dmitry Timoshkov Aug. 1, 2004

Aug. 1, 2004

"James Hawkins" <truiken(a)gmail.com> wrote: > Fixed more bugs spotted by Dmitry. > > Changelog > * cleanup cross-call functions If you could use 'static const' as everywhere else and not 'const static' that would be nice. > + size = sizeof(DWORD); > + r = RegQueryValueExW(key, nameW, NULL, &keytype, NULL, &size); Why did you add size initialization here? If that wasn't done before there was a reason for that. > + provNameLen = *pcbProvName * sizeof(WCHAR); > + if ( pszProvName && (str = CRYPT_Alloc(provNameLen * sizeof(WCHAR))) ) > + CRYPT_ReturnLastError(ERROR_NOT_ENOUGH_MEMORY); > + ret = CryptEnumProvidersW(dwIndex, pdwReserved, dwFlags, pdwProvType, str, &provNameLen); Remove double sizeof(WCHAR) multiplcation here and everywhere else. > - DWORD size = sizeof(DWORD); > + DWORD size = sizeof(pdwProvType); > HKEY subkey; > - if (RegEnumKeyA(hKey, dwIndex, pszProvName, *pcbProvName)) > + if (RegEnumKeyW(hKey, dwIndex, pszProvName, *pcbProvName)) RegEnumKeyW takes number of characters, not bytes. Why did you change that since your previous patch? Please read documentation first, otherwise you are wasting your and our time. -- Dmitry.

1 0

Re: cleanup a->w cross calls in advapi32/crypt.c
by Dmitry Timoshkov Aug. 1, 2004

Aug. 1, 2004

"James Hawkins" <truiken(a)gmail.com> wrote: > Fixed bugs spotted by Dmitry > > Changelog > * cleanup cross-call functions Still there are bugs in the patch. 1. RegQueryValueExW/RegSetValueExW take bytes in the last parameter 2. Do not use 'strlen' as a name of the variable, that at least very confusing. -- Dmitry.

1 0

for whoever maintinas winrash
by Ivan Leo Puoti Aug. 1, 2004

Aug. 1, 2004

We've had the following complaints on wine-users. > I installed this on a windows 98se box. I can't say I like having the DOS > window open all the time (it's ugly). Can this not be written as a windows > programme, and sit in the system tray? > > Also, during the installation process, after I entered my email address, the > installer removed what it called 'invalid characters' - i.e., underscores. >All my main email addresses contain underscores, so I was forced to enter an > old one that is not very reliable. Ivan.

4 5

Re: [Wine]starcraft fails right at the end of the install
by Michael Chang July 31, 2004

July 31, 2004

On Sat, Jul 31, 2004 at 11:21:30AM +0000, cedric wrote: > Hi all i'm running wine 20040716, installed manualy, no wineinstall, blank > windows drive, only the right dirs are present there, as i couldn't get > regedit to make the default reg keys for me > > I tried to install starcraft, but right after it copied all the files it comes > up with this error screen: > Error: > Unable to create a link to E:\Help\Star.htm as C:\Windos\start > menu\programs\starcraft\help.lnk Installation aborted error 0: success at > LinkUndo.cpp line 165. I noticed this "error" with other programs. Apparently, wine (or at least this build) doesn't support creating links in the start menu, or something along those lines -- it makes sence when you consider that wine users shouldn't exactly see a point in "accessing" these windows shortcuts. However, your program's setup is finicky about being unable to create shortcuts for the program, so you can't continue. (Some installs complain, but allow you to continue...) Maybe wine-devel could consider creating a stub, or just falsely return true to these calls? Also, you might want to look at CVS code, to see if this has already been implemented. If all else fails, try looking at the M$ Windows binaries/patches for win95 - i.e. DCOM, and MSI stuff, etc. They *might* help, but correct me if I'm wrong. > After i click cancel all the starcraft files are deleted. After i tried again > i killed wine without pressing cancel. All the starcraft files remain, but > when i run the installer again it askes me to install the game instead of run, > so i guess not all the regestry keys have been created. Also, when i try to > run the game from the program files directory, sc complains about the cd not > being present. Setup Program probably creates shortcuts, then reg entries. But since it can't create shortcuts, it never creates the reg entries. That's my theory. (See above.) Most games are stupid in that they rely on their registry entries to tell them that the program is installed, as opposed to actually checking the filesystem. > > here are the errors wine gave me: > bash-2.05b$ cd /mnt/cdrom/ > bash-2.05b$ wine INSTALL.EXE Oh! One more thing. Your CD-Rom should be mounted to a dosdevice, and you should/can execute it from there, I think. So your first line should/might say "cd /home/<user>/.wine/dosdevices/<cd>:". (/home/cedric/.wine/dosdevices/e:) Also, note that windows never had case-sensitive names -- maybe bad program is causing errors by Linux/wine being case sensitive? > err:font:ReadFontDir Can't open directory > "/home/cedric/.wine/dosdevices/c:/windows/Fonts" > Fontconfig error: line 24: not well-formed (invalid token) > Fontconfig error: Cannot load default config file > fixme:bitblt:X11DRV_BitBlt potential optimization - client-side DIB copy > fixme:bitblt:X11DRV_BitBlt potential optimization - client-side DIB copy > fixme:shell:Stream_WriteLocationInfo writing empty location info > err:font:ReadFontDir Can't open directory > "/home/cedric/.wine/dosdevices/c:/windows/Fonts" > Fontconfig error: line 24: not well-formed (invalid token) > Fontconfig error: Cannot load default config file > err:menubuilder:InvokeShellLinker failed to extract icon. > fixme:shell:Stream_WriteLocationInfo writing empty location info > err:font:ReadFontDir Can't open directory > "/home/cedric/.wine/dosdevices/c:/windows/Fonts" > Fontconfig error: line 24: not well-formed (invalid token) > Fontconfig error: Cannot load default config file > err:menubuilder:InvokeShellLinker failed to extract icon. > > And some random info: > bash-2.05b$ ls -l ~/.wine/dosdevices/ > total 0 > lrwxr-xr-x 1 cedric users 8 Jul 11 10:22 a:: -> /dev/fd0 > lrwxr-xr-x 1 cedric users 22 May 16 22:16 c: > -> /storage/windows-drive > lrwxr-xr-x 1 cedric users 10 May 16 22:16 com1 -> /dev/ttyS0 > lrwxr-xr-x 1 cedric users 10 May 16 22:16 com2 -> /dev/ttyS1 > lrwxr-xr-x 1 cedric users 10 May 16 22:16 com3 -> /dev/ttyS2 > lrwxr-xr-x 1 cedric users 10 May 16 22:16 com4 -> /dev/modem > lrwxr-xr-x 1 cedric users 2 Jul 11 10:53 d: -> /d > lrwxr-xr-x 1 cedric users 11 Jul 11 18:25 e: -> /mnt/cdrom/ > lrwxr-xr-x 1 cedric users 12 May 16 22:16 f: -> /home/cedric > lrwxr-xr-x 1 cedric users 8 May 16 22:16 lpt1 -> /dev/lp0 > > bash-2.05b$ uname -a > Linux lfs 2.6.7 #1 Sat Jun 26 14:30:34 Local time zone must be set--see zic > manu i686 GenuineIntel unknown GNU/Linux > > bash-2.05b$ gcc -v > Reading specs from /usr/lib/gcc-lib/i686-pc-linux-gnu/3.3.2/specs > Configured with: ../gcc-3.3.2/configure --prefix=/usr --enable-shared > --enable-threads=posix --enable-__cxa_atexit --enable-clocale=gnu > --enable-languages=c,c++ : (reconfigured) ../gcc-3.3.2/configure --prefix=/usr > --enable-shared --enable-threads=posix --enable-__cxa_atexit > --enable-clocale=gnu --enable-languages=c,c+ > > Please CC me as i'm not a member of this list I hope you don't mind me putting you in the To: line instead. > > Regards, > cedric > -- > The only dumb question is the one omitted > > De enige domme vraag is degene die niet gesteld wordt > _______________________________________________ > wine-users mailing list > wine-users(a)winehq.org > http://www.winehq.org/mailman/listinfo/wine-users Just my two cents. Hope I helped in any way possible. Consider joining the wine-users/wine-devel lists, and taking part. It's a good idea, and using e-mail filtering software like POPFile is easy; even the most inexperienced users can just mention noticed behaviour in Wine. (Or, use internal filtering software in your e-mail client - 99% of wine e-mails already have [Wine] in their subject lines anyways.) Error messages are self-explainatory if you know how to read them. :) -Michael

1 0