- Wine-Devel - list.winehq.org

Re: winetests/winrash
by Rolf Kalbermatter July 29, 2004

July 29, 2004

Chris Morgan <cmorgan(a)alum.wpi.edu> wrote: >I wouldn't mind adding a systray icon. I wasn't really sure how that was >supposed to be done. I tried having the service add a systray icon without >much success, I don't believe services can interact with the desktop. That >may mean that a separate winrash monitor may have to be written that >communicates with the service. Services can interact with the desktop but not by default. It is a special option you specify when installing the service. The magic for this is in the dwServiceType parameter of the CreateService() to register a service object in the system. >From MSDN: SERVICE_FILE_SYSTEM_DRIVER File system driver service. SERVICE_KERNEL_DRIVER Driver service. SERVICE_WIN32_OWN_PROCESS Service that runs in its own process. SERVICE_WIN32_SHARE_PROCESS Service that shares a process with one or more other services. For more information, see Service Programs. If you specify either SERVICE_WIN32_OWN_PROCESS or SERVICE_WIN32_SHARE_PROCESS, and the service is running in the context of the LocalSystem account, you can also specify the following type. Type Meaning SERVICE_INTERACTIVE_PROCESS The service can interact with the desktop. Not sure how winrash is currently installed but if it is not through a small Win32 setup app but an InstallShield app, I'm sure it has according parameters to let it install as interactive service Rolf Kalbermatter

2 1

Fwd: Re: rsabase.dll
by Michael Jung July 29, 2004

July 29, 2004

I'm sorry, if this mail appears three times on the wine-devel list. I've sent it twice already, but it doesn't seem to get forwarded to the wine-devel list. Is there a problem with the mailing list? Rob, could you give me a short notificaton, if you have received those mails? Thank, Michael ---------- Forwarded Message ---------- Subject: Re: rsabase.dll Date: Tuesday 27 July 2004 10:08 From: Michael Jung <mjung(a)iss.tu-darmstadt.de> To: wine-devel(a)winehq.org Cc: rob(a)codeweavers.com Rob, > I think there are many reasons to favour "real handles": If a long running > process is using rsabase (e.g. a webserver serving https: requests) with > many temporary connections and many keys, resource leakage is an issue. > Furthermore, since rsabase is a cryptographic service provider, it might be > important that a key, which is not referenced anymore is in fact destroyed > (and the > corresponding memory be nulled). I would think that otherwise you will > over time accumulate a lot of keys in your address space, which is probably > a security problem. Now, I'm aware that wine is not in a state today to be > used for security critical applications and first rsabase implementations > will probably have security issues more severe than this. However, sometime > I think rsabase will have to use real handles. Why not right from the > start? I've thought about this statement again and realized that I'm wrong and that I probably misunderstood you. I realized that one doesn't need "real handles" in user mode code at all to implement correct resource management. And I think I understand that one does need them in the kernel (aka wineserver) for objects, which are accessed from multiple threads. However, there are some instances of "real handle" implementations outside wineserver in wine (e.g. dlls/msi/handle.c). Do you (or anybody else on the mailing list) now what for? Some things, which I could imagine would still be easier to implement correctly with "real handles", are the INVALID_HANDLE_VALUE value, checking that a thread does not access a resource via an already released handle and in general checking in a precise manner if a handle value is valid (which, as I understand it, is often done in wine with a magic value at the beginning of the object.) Greetings, Michael -- Michael Jung, MSc Be liberal in what you accept, Integrated Circuits and Systems Lab and conservative in what you send. University of Technology, Darmstadt -- Jonathan Postel, Internet Pioneer phone: +49(6151)16-6692 / email: mjung(a)iss.tu-darmstadt.de

1 0

Is bugzilla worth keeping?
by Mike Hearn July 29, 2004

July 29, 2004

One thing I notice about most other open source projects is that they have many more flamewars than we do. So, I thought I'd start one: It strikes me, looking at the wine-bugs list, that there is a huge disparity between the number of people maintaining it and the number of people filing bugs in it. It seems to be quite rare for communication on bugfixes to take place there, wine-devel is the more usual forum. So are we misleading users by having a bugzilla into thinking that if they file a bug there, it'll be fixed when it probably won't? If so, does it matter? If we were to simply drop bugzilla, how would it impact the project? Thoughts, anybody? thanks -mike

10 10

winetests/winrash
by James Hawkins July 29, 2004

July 29, 2004

What is it exactly that winrash does? Is it running winetests using the native libraries of the Windows operating system that the user is running the tests on, or are the wine libraries being tested through some means? Is there a site where this information is readily available? I have one suggestion: users typically like to see results when they volunteer their computer time to a project such as this, which is understandable, so a future version might benefit from a system tray icon that can be opened up to see the test running and/or display results of the tests that have been run. -- James Hawkins

2 1

How do we handle unicode (utf-8) codepages?
by Shachar Shemesh July 29, 2004

July 29, 2004

What do we do if the user requests a Unicode codepage? I've just had a conversation with a user on IRC where I believe things didn't work for him because LANG was set to es_ES.UTF-8. On one hand, I don't think we can force ANSI applications to work in Unicode. On the other hand, we cannot change the locale - it will mean noone (whether ANSI or not) will not be able to access non-ASCII file names and files. Comments? Shachar -- Shachar Shemesh Lingnu Open Source Consulting ltd. http://www.lingnu.com/

2 1

Re: Re: WineHQ:service.cgi: fix winrash option
by chmorgan＠charter.net July 28, 2004

July 28, 2004

Which errors are you referring to? The most frequent ones lately are the ones where the winetest package isn't available on the sourceforge osdn mirror. We are still asking people to download the tests from this location for particular test releases. I'd imagine the fix is simply to point the downloads at valid mirror for the file. Chris > > From: Ferenc Wagner <wferi(a)afavant.elte.hu> > Date: 2004/07/26 Mon AM 07:57:51 EDT > To: wine-devel(a)winehq.org > CC: <wine-patches(a)winehq.com>, <cmorgan(a)alum.WPI.EDU> > Subject: Re: WineHQ:service.cgi: fix winrash option > > <chmorgan(a)charter.net> writes: > > > What is the service doing with winrash options btw? The > > installer stops, installs and starts the winrash service. > > > > The installer uses /S for silent installs, otherwise it > > will try to popup windows. Are you sure the service isn't > > calling the installer with /S? > > You are right, I was wrong. This patch is rubbish. I can't > really understand the errors on wine-test-results. Have you > got an idea what may have gone wrong? Aren't any functional > winrash instances running? Is something broken in the > service script? The documentation is somewhat scarce so I'm > doing a slow start... > -- > Feri. > >

2 1

Re: DCOM: Fix Ref Counting in StdMarshalImpl_MarshalInterface
by Robert Shearman July 28, 2004

July 28, 2004

Robert Shearman wrote: > Changelog: > > Mike Hearn <mh(a)codeweavers.com> > Fix ref counting in StdMarshalImpl_MarshalInterface for case where the > stub already exists. > >Index: wine/dlls/ole32/compobj_private.h >=================================================================== >RCS file: /home/wine/wine/dlls/ole32/compobj_private.h,v >retrieving revision 1.14 > Oops. Wrong patch. Rob

1 0

Re: COM RPC: Fix Infinite Loop
by Robert Shearman July 28, 2004

July 28, 2004

Robert Shearman wrote: > Changelog: > Fix for infinite loop that could occur if _invoke_onereq failed. Please don't apply this patch. I'll submit a better and more complete one in a minute. Rob

1 0

Non-working patch for 3GB of memory allocation
by Shachar Shemesh July 28, 2004

July 28, 2004

Ok, this patch would probably not be appropriate even if it did work. The surprising thing, however, is that it doesn't. The idea was simple. We use mmap as usual until mmap starts to fail with no memory. When that happens, we switch to allocating memory with malloc, which allegably knows how to use "brk" in order to allocate memory from the lower 1GB area. The patch is against 20040716. The attached program tries to repeatedly allocate ~100MB, until it fails. It is compiled for advanced server (i.e. - it has 3GB of address space, but that's besides the point). When actually run (through strace), one can see the mmaps being carried out and successful, and then the mmap that fails (no memory). Then malloc is attempted, which tries mmap, then brk, and then mmap again. All fail. This is the point where I stop understanding. Does anyone have any explanation as to why malloc fails? Does wine prevent large scale use of the lower area due to some reason? Any ideas would be appreciated. Shachar ? runconfig ? dlls/ntdll/.virtual.c.swp Index: dlls/ntdll/virtual.c =================================================================== RCS file: /home/wine/wine/dlls/ntdll/virtual.c,v retrieving revision 1.37 diff -u -r1.37 virtual.c --- dlls/ntdll/virtual.c 22 Jun 2004 03:02:35 -0000 1.37 +++ dlls/ntdll/virtual.c 26 Jul 2004 13:53:41 -0000 @@ -78,6 +78,7 @@ /* Per-view flags */ #define VFLAG_SYSTEM 0x01 /* system view (underlying mmap not under our control) */ #define VFLAG_VALLOC 0x02 /* allocated by VirtualAlloc */ +#define VFLAG_MALLOC 0x04 /* allocated using malloc */ /* Conversion from VPROT_* to Win32 flags */ static const BYTE VIRTUAL_Win32Flags[16] = @@ -168,9 +169,13 @@ DPRINTF( "View: %p - %p", addr, addr + view->size - 1 ); if (view->flags & VFLAG_SYSTEM) DPRINTF( " (system)\n" ); - else if (view->flags & VFLAG_VALLOC) - DPRINTF( " (valloc)\n" ); - else if (view->mapping) + else if (view->flags & VFLAG_VALLOC) { + DPRINTF( " (valloc" ); + if (view->flags & VFLAG_MALLOC) + DPRINTF( " using malloc)\n" ); + else + DPRINTF( ")\n" ); + } else if (view->mapping) DPRINTF( " %p\n", view->mapping ); else DPRINTF( " (anonymous)\n"); @@ -348,7 +353,12 @@ */ static void delete_view( struct file_view *view ) /* [in] View */ { - if (!(view->flags & VFLAG_SYSTEM)) unmap_area( view->base, view->size ); + if (!(view->flags & VFLAG_SYSTEM)) { + if( !(view->flags & VFLAG_MALLOC) ) + unmap_area( view->base, view->size ); + else + free( view->base ); + } list_remove( &view->entry ); if (view->mapping) NtClose( view->mapping ); free( view ); @@ -559,6 +569,7 @@ { void *ptr; NTSTATUS status; + int used_malloc=0; if (base) { @@ -602,7 +613,19 @@ { if ((ptr = wine_anon_mmap( NULL, view_size, VIRTUAL_GetUnixProt(vprot), 0 )) == (void *)-1) { - if (errno == ENOMEM) return STATUS_NO_MEMORY; + if (errno == ENOMEM) + { + /* mmap allocation failed. Let's see if we can try malloc, and whether it is going to be more lucky */ + FIXME("About to try malloc\n"); + if( /* Unix protection is not malloc compatible, or */ (ptr = malloc( size ))!=NULL ) + { + used_malloc=1; + goto memory_allocated; + } else { + FIXME("malloc failed\n"); + return STATUS_NO_MEMORY; + } + } return STATUS_INVALID_PARAMETER; } /* if we got something beyond the user limit, unmap it and retry */ @@ -623,8 +646,17 @@ munmap( (char *)ptr + size, view_size - size ); } +memory_allocated: status = create_view( view_ret, ptr, size, vprot ); - if (status != STATUS_SUCCESS) unmap_area( ptr, size ); + if( used_malloc && status==STATUS_SUCCESS ) + (*view_ret)->flags|=VFLAG_MALLOC; + else if (status != STATUS_SUCCESS) + { + if( !used_malloc ) + unmap_area( ptr, size ); + else + free( ptr ); + } return status; }

2 6

delayed unloading of .so in WINE
by Santosh Siddheshwar July 28, 2004

July 28, 2004

Hi, Is there any way to specify in config file or any other place, a way to prevent/delay a shared object from being unloaded till the application using it terminates? In dlopen there is a flag RTLD_NODELETE which keeps the loaded shared object in memory even after dlclose is called. The shared object is unloaded only when the app exits. Do we have some way to do this in WINE? Or does any feature in Windows necessitate implementing this kind of behaviour in WINE? I can think of VC++ linker flags /DELAYLOAD and /DELAY:unload which might need the use of such mechanism. Regards Santosh Siddheshwar ********************************************************************* Disclaimer: The information in this e-mail and any attachments is confidential / privileged. It is intended solely for the addressee or addressees. If you are not the addressee indicated in this message, you may not copy or deliver this message to anyone. In such case, you should destroy this message and kindly notify the sender by reply email. Please advise immediately if you or your employer does not consent to Internet email for messages of this kind. *********************************************************************

2 1