- Wine-Devel - list.winehq.org

Re: Yahoo!
by Johane June 15, 2004

June 15, 2004

1 0

Do we still need wineinstall?
by Mike Hearn June 15, 2004

June 15, 2004

Hi, I've been running without a config file for a while now, and have fixed various misc bugs related to that as I go - I'm sure there are some more in there, but as the config file is destined for eventual doom anyway I am wondering if we still need wineinstall at all? Currently, it's possible to use Wine quite succesfully just by doing a standard ./configure, make, make install. When you run wine for the first time wineprefixcreate will be used to setup ~/.wine, merge the registry, create the fake windows drive and so on. The only piece you don't get is the default config file, but that doesn't seem to make much difference any more. At least, the defaults should be in the code not the config file as people never upgrade that bit anyway :) So - do we still need it?

2 1

Re: winetest: move to resources (take n) (resend)
by Alexandre Julliard June 14, 2004

June 14, 2004

Ferenc Wagner <wferi(a)afavant.elte.hu> writes: > This is a resend to elicit some feedback on your objections > against this patch. What did I miss again? It's much better this time. The only thing I would suggest changing is that the build info text formatting should be done in the code, not in the makefile. Also I think it would be cleaner to use a different rc file for the dist case instead of using #ifdefs. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: Create DIALOGINFO On Demand When Calling DIALOG_get_info
by Alexandre Julliard June 14, 2004

June 14, 2004

Robert Shearman <R.J.Shearman(a)warwick.ac.uk> writes: > This patch fixes bug 2210: > http://bugs.winehq.org/show_bug.cgi?id=2210 > This patch differs slightly from the one posted to wine-devel, as it > includes some checks for NULL return from DIALOG_get_info. I don't think you want to create the dialog info in all cases, this should only be done where we are sure we have a dialog window. For instance you don't want MapDialogRect to add dialog info to arbitrary windows just because it got passed a wrong handle. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: wine/include ddeml.h
by andrejoh＠c2i.net June 14, 2004

June 14, 2004

* Alexandre Julliard (Mon, 14 Jun 2004 11:58:02 -0500) wrote: | Dmitry Timoshkov <dmitry(a)codeweavers.com> | Fix CBR_BLOCK definition. | | Patch: http://cvs.winehq.org/patch.py?id=12591 | | Old revision New revision Changes Path | 1.29 1.30 +1 -1 wine/include/ddeml.h This one causes a compile failure: dde/server.c: In function `WDML_ServerHandleRequest': dde/server.c:580: error: pointers are not permitted as case values switch ((ULONG_PTR)hDdeData) [...] case CBR_BLOCK: The patch below fixes it by casting to an ULONG_PTR, which is what the switch variable is casted to. Index: dlls/user/dde/server.c =================================================================== RCS file: /home/wine/wine/dlls/user/dde/server.c,v retrieving revision 1.16 diff -u -w -p -r1.16 server.c --- dlls/user/dde/server.c 26 Apr 2004 23:29:44 -0000 1.16 +++ dlls/user/dde/server.c 14 Jun 2004 19:18:52 -0000 @@ -577,7 +577,7 @@ static WDML_QUEUE_STATE WDML_ServerHandl WDML_PostAck(pConv, WDML_SERVER_SIDE, 0, FALSE, FALSE, pXAct->atom, pXAct->lParam, WM_DDE_REQUEST); break; - case CBR_BLOCK: + case (ULONG_PTR)CBR_BLOCK: ret = WDML_QS_BLOCK; break; default: -- Try Anarchy Online http://www.anarchy-online.com/content/downloads/tryout/ Netiquette guidelines ftp://ftp.rfc-editor.org/in-notes/rfc1855.txt How to quote properly http://www.i-hate-computers.demon.co.uk/ Hvordan sitere riktig http://home.online.no/~vidaandr/news/OBSquoting.html

1 0

Re: wine/dlls/user/dde client.c
by Ivan June 14, 2004

June 14, 2004

This patch http://www.winehq.com/hypermail/wine-cvs/2004/06/0085.html breaks the build on Mandrake 10.0 using gcc 3.3.2 and make 3.8, with the following error: dde/server.c: In function `WDML_ServerHandleRequest': dde/server.c:580: error: pointers are not permitted as case values make[2]: *** [dde/server.o] Error 1 make[2]: Leaving directory `/home/ivan/Development/Wine/CVS/wine/wine/dlls/user' make[1]: *** [user] Error 2 make[1]: Leaving directory `/home/ivan/Development/Wine/CVS/wine/wine/dlls' make: *** [dlls] Error 2 Ivan.

1 0

Re: revised winmm GetDevCaps better pointer check patch
by Alexandre Julliard June 14, 2004

June 14, 2004

Robert Reif <reif(a)earthlink.net> writes: > +/* Use the first version for strict compatibility with Microsoft */ > +/* #define WINMM_IsBadWritePtr(x,y) IsBadWritePtr((x), (y)) */ > +#define WINMM_IsBadWritePtr(x,y) ((x)==NULL) This is very confusing, if we don't check the pointer we shouldn't have a macro that looks like we do. The proper way is to add exception handlers in functions where an app explicitly relies on the pointer check, and not add checks otherwise; using the IsBad*Ptr functions is always wrong since they are not thread-safe. -- Alexandre Julliard julliard(a)winehq.org

1 0

General serial communications issues
by David Purucker June 14, 2004

June 14, 2004

Hello, I have tried several terminal programs (Hyperterm and TeraTerm) under several builds of Wine including Wine-20040505 and they seem to have the same generic problem. They all exhibit the same situation, DATA seems to go OUT, but never seems to come IN. Several other people have experienced the same thing, as seen in this bug report: http://bugs.winehq.org/show_bug.cgi?id=2115 By the way, TeraTerm does work fine in TCP/IP mode, so it's definitely a serial problem. It's freeware available here: http://hp.vector.co.jp/authors/VA002416/teraterm.html It appears to be a fundamental problem in the serial/file code, which I understand is now under the ntdll tree. Obviously, I don't know much about it, but there is definitely something wrong. I was wondering if any developers were aware of this problem, as the decreased general usage of serial communications may have caused this to slip under the carpet, so to speak. I look forward to hearing any ideas, work-arounds, or patches. Thanks _________________________________________________________________ Stop worrying about overloading your inbox - get MSN Hotmail Extra Storage! http://join.msn.click-url.com/go/onm00200362ave/direct/01/

7 20

Re: Fix 3 bugs in locale handling
by Alexandre Julliard June 14, 2004

June 14, 2004

Dmitry Timoshkov <dmitry(a)baikal.ru> writes: > 1. If the locale has changed current code never refreshes win.ini > and registry values due to the following test done in GetLocaleInfoW: > > /* first check for overrides in the registry */ > > if (!(lcflags & LOCALE_NOUSEROVERRIDE) && lcid == GetUserDefaultLCID()) > { > > lcid is always pointing to current user locale returned by GetUserDefaultLCID() > and therefore cached (old) values get returned. > > I modified code to get data directly from kernel resources in that case. It seems to me that this is what we are doing already since we pass LOCALE_NOUSEROVERRIDE in that case, I don't see how your patch would make any difference (and win.ini definitely gets refreshed with the current code). Could you please give more details on the problem you are seeing? -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: SHELL32:RunFileDlg
by Alexandre Julliard June 14, 2004

June 14, 2004

Filip Navara <xnavara(a)volny.cz> writes: > + if (!(hRes = FindResourceW(shell32_hInstance, L"SHELL_RUN_DLG", (LPWSTR)RT_DIALOG))) You cannot use wide char string constants in Wine. -- Alexandre Julliard julliard(a)winehq.org

1 0