- Wine-Devel - list.winehq.org

Re: [OLE] Better handling of References
by Mike Hearn May 26, 2004

May 26, 2004

Oops, sending to wine-devel too (this is what I get for using a newsreader...) On Wed, 26 May 2004 03:55:25 +0200, Raphael wrote: > I'm trying to install Splinter Cell Demo (installshield). > And i have seen: > - one typelib was released while typeinfos (childs of typelib) are in use > - the install "crash" (catched and returns an E_UNEXPECTED error) when it > wants to call ITypeInfo_fnGetContainingTypeLib (who want to AddRef the > freshly released TypeLib) Hi Raphael, This has been a known problem for a long time now, with several attempts to fix it, all of them have been incorrect. It seems your approach is a new one and interesting, but I'm not sure this is how Windows does it. Does anybody know exactly what Windows does in this situation? It might be worth writing a test case to find out. Objects in a semi-freed state seem like a slightly odd way to do things. > Now i have another crash later, but it seems a problem with an invoke method > who failed :( > If any ole/rpc expert can look at this problem i'll be very happy :) Well, if you could provide more detail (backtrace etc) on the crash it would be good. A few comments on the patch: - --(This->ref); + /** escape decrement for soft_references */ + if (This->ref > 0) { + --(This->ref); + } else { + ERR("trying to Release again an ITypeLib2 in freing state waiting for ITypeInfo (%p) childs Releases\n", This); + } I don't remember whether this object is supposed to be thread safe or not, but should this not be an InterlockedDecrement? I think the error could be better phrased as: ERR("Reference count on an ITypeLib2 object (%p) already zero: waiting for ITypeInfo children to be released as well"); or words to that effect. + if (This->soft_ref > 0) { + ERR("trying to Release an ITypeLib2 while some ITypeInfo (%p) childs are actually with Refs > 1. So Dont free it now \n", This); + /** maybe scaning ITypeInfo list to dump ITypeInfos with Refs > 1 */ + return 1; + } Is it actually an error to do that? If you free a typelib while refs are held on child typeinfos, is this a bug in the app or a legitimate thing to do? If it's not a bug in the app we probably shouldn't use ERR here. ++(This->ref); + if (This->ref > 1) { + if (NULL != This->pTypeLib) ++(This->pTypeLib->soft_ref); + } + Ditto on thread safety. Please forgive me if this object is not free threaded. --- variant.c 30 Apr 2004 18:32:58 -0000 1.97 +++ variant.c 26 May 2004 01:46:44 -0000 @@ -605,6 +605,8 @@ hres = VARIANT_ValidateType(V_VT(pVarg)); + if (V_VT(pVarg) == VT_EMPTY) return hres; + if (SUCCEEDED(hres)) { if (!V_ISBYREF(pVarg)) This change looks OK though I'm not sure why it's necessary. Does the Splinter Cell installer actually need this? thanks -mike

1 0

CoRegisterMessageFilter
by Simon Harvey May 26, 2004

May 26, 2004

hello I was wondering if anybody was doing work on or was in the process of implementing CoRegisterMessageFilter in dlls/ole32/ole2.c ? I would like to take a stab at it but i wont if somebody else is going to do it. thanks simon Find local movie times and trailers on Yahoo! Movies. http://au.movies.yahoo.com

2 1

Bad wine today.
by Rein Klazes May 26, 2004

May 26, 2004

Hi, I wonder if I am the only one that sees this with any windows prog that I try: |$ wine sol |x11drv: Can't open display: |Please ensure that your X server is running and that $DISPLAY is set correctly. |$ (other X programs run fine). I did the usual things when in trouble: a make clean, fresh cvs update. That did not help. Debugmessages "+all", does not give any messages. Version win98 or win2k makes no difference. Reverting to the yesterdays cvs, makes wine work again. Any idea? Rein. -- Rein Klazes rklazes(a)xs4all.nl

2 2

Crash and corrupted registry
by Christian Costa May 25, 2004

May 25, 2004

Hi, This is the second time I had to reboot when by box is stuck while running a windows apps. In both case the registry had been corrupted. This is very annoying. Could we have the wineserver do a backup of registry files at startup so we can retreive the previous version if a corruption occurs? That would be very usefull. Thanks, Christian

2 2

Re: Bad wine today.
by Ivan May 25, 2004

May 25, 2004

Current CVS works for me. Ivan.

1 0

Re: additional download for winehq download page
by Ivan May 25, 2004

May 25, 2004

< And if a prog doesn't provide the dll it should have at least a readme to tell people where to get it. I can tell you out of experience that this isn't always true. What about the attached patches? Ivan.

1 0

Re: Strip comments from end of line in INI parser
by Alexandre Julliard May 25, 2004

May 25, 2004

Mike Hearn <mike(a)navi.cx> writes: > Mike Hearn <mike(a)navi.cx> > Strip comments and whitespace from end of line in PROFILE_CopyString That will make it impossible to have an ini entry containing a ';'. I really doubt that Windows does it this way; could you please provide a test case? -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: winegcc: Use $(CC) for building generated .spec.c
by Dimitrie O. Paun May 25, 2004

May 25, 2004

On Tue, May 25, 2004 at 12:56:27AM -0700, Jon Griffiths wrote: > Building and linking a C++ dll to a Winelib app currently fails using > winegcc as it will use $(CXX) to compile the .spec.c file. This means > it won't link correctly to libwine.so due to the name mangling. I > tried 2 solutions: changing winebuild to generate extern "C" {} > declarations where needed, and changing winegcc to use $(CC) instead. > Of the two, I think the latter is neater. The following patch > implements it. I thought that gcc will figure the langauge based on the extension. So g++ file.c would actually compile as a C file... But this may not work for other compilers. We could do it ourselves in compile(), choose $CC or $CXX based on the extension. However, I'm not sure it's better than your solution. In fact, it's a lot more risky. -- Dimi.

2 1

Proprietary Hardware and related stuff - Get them work with Linux
by Gianfranco Luceri May 25, 2004

May 25, 2004

Hello, I own a Matrox Mistyque with Rainbow Runner Studio and Rainbow Runner TV (not G-Series) add-on cards and there's no way of getting them all work with Linux due to the lack of documentation about a proprietary chip (MGA-something-I-cant-remember-any-more). The only supported OSes are Win95 (fully operational, not taking into account the Os flaws) and WinNT 4.0 (some "minor" features aren't available). Maybe WINE is the only way to get it (and similar hardware) work with Linux. Infact the driver and related software could be installed and executed with WINE, assuming that WINE could succesfully access the I/O port used by the hardware (and maybe linux is not even aware of that hardware!) Maybe I'll try that by myself and post the (maybe bad) results I'll get (at least a divorce from my wife). Any comments, hint, post wuold be appreciated. There's a lot o people owning a Rainbow Runner (not G-Series) or hardware with the same problem out there. So please help. Thank you. DonalDuck

1 0

mingw crossbuild broke
by Kevin Koltzau May 25, 2004

May 25, 2004

the mingw crossbuild broke last night with mmap.c: In function `wine_mmap_add_reserved_area': mmap.c:291: error: `PROT_NONE' undeclared (first use in this function) mmap.c:291: error: (Each undeclared identifier is reported only once mmap.c:291: error: for each function it appears in.) mmap.c:291: error: `MAP_FIXED' undeclared (first use in this function) should those defines be included in one of our headers?

1 0