- Wine-Devel - list.winehq.org

Re: compiling wine on Darwin/MacOS X 8/10
by Alexandre Julliard April 17, 2004

April 17, 2004

emmanuel maillard <e.rsz(a)libertysurf.fr> writes: > Changelog > Fix a lstat problem on darwin I don't think you want to remove the check. What error does lstat return in that case? -- Alexandre Julliard julliard(a)winehq.org

2 2

COMCTL32 Subclassing
by Filip Navara April 16, 2004

April 16, 2004

Hi, I have found a bug in Wine's comctl32.dll that causes crashes with subclassed windows. There can happen a situation when DefSubclassProc ends with all subclassings removed, in this case it cleans up the subclassing stack stored in a window property and frees it's memory. If DefSubclassProc was called from SubclassWndProc, there will happen crash because the subclassing stack is no longer valid. Anyone has a solution for this? - Filip --- lib/comctl32/commctrl.c 15 Apr 2004 08:29:56 -0000 1.9 +++ lib/comctl32/commctrl.c 16 Apr 2004 23:32:26 -0000 @@ -1284,9 +1284,7 @@ } stackpos = stack->stackpos; stack->stackpos = stack->stacknum; - ret = DefSubclassProc(hWnd,uMsg,wParam,lParam); - stack->stackpos = stackpos; - return ret; + return DefSubclassProc(hWnd,uMsg,wParam,lParam); }

1 0

Problem with winealsa
by Francois Gouget April 16, 2004

April 16, 2004

I decided to run the winmm test in interactive mode with wineoss and winealsa to see if everything is ok. So first, to do that just do: cd dlls/winmm/tests WINETEST_INTERACTIVE=1 ../../../tools/runtest -P wine -M winmm.dll -T ../../.. -p winmm_test.exe.so wave.c That will most likely run it with wineoss as the sound driver, then edit ~/.wine/config so it looks like this: [WinMM] ; Uncomment the "Drivers" line matching your sound setting. ;"Drivers" = "wineoss.drv" ; default for most common configurations ;"Drivers" = "winearts.drv" ; for KDE "Drivers" = "winealsa.drv" ; for ALSA users ;"Drivers" = "winejack.drv" ; for Jack sound server ;"Drivers" = "winenas.drv" ; for NAS sound system ;"Drivers" = "wineaudioio.drv" ; for Solaris machines ;"Drivers" = "" ; to disable sound And you should get exactly the same result but with the winealsa driver. Actually, it may play a couple extra or a couple less tones depending on what Alsa's OSS emulation and Alsa-native report as their supported sound formats. Anyway, each tone should play for 1 second. This is the case when using wineoss but when using winealsa they play for only 0.5 second! Does anyone have any insight into this? While I was at it I also tested winearts and it played the tones at a rate of 1 per second as expected. -- Francois Gouget fgouget(a)free.fr http://fgouget.free.fr/ In theory, theory and practice are the same, but in practice they're different.

1 0

winapi_check broken
by Stefan Leichter April 16, 2004

April 16, 2004

Hello, winapi_check --cross-call-unicode-ascii does not longer work for me. Looks like it loops when searching for the spec-files. Does anyone else noticed this problem? Normaly a run took less than 10 minutes for me. Today i stopped it after two hours. There was only one output line: .: searching for /\.spec$/ My system is SuSE 9.0 Bye Stefan

1 0

Re: controls/menu.c
by Dimitrie O. Paun April 16, 2004

April 16, 2004

On Fri, 16 Apr 2004, Ge van Geldorp wrote: > This fixes the black text on white background in AbiWord menus > > Changelog: > Ge van Geldorp <gvg(a)reactos.com> > Setup menu drawing colors before calling owner draw routine Good catch Ge, this was really annoying, and maybe the most upsetting visual glitch. We still have a refresh/invalidate off-by-one bug somewhere, the dialogs leave a black margin (to the right and at the bottom). Did you see that? -- Dimi.

2 1

Re: dlls/richedit/reader.c
by Phil Krylov April 16, 2004

April 16, 2004

Hello Ge, Friday, April 16, 2004, 3:56:41 PM, you wrote: GvG> Changelog: GvG> Ge van Geldorp <gvg(a)reactos.com> GvG> Work around problem in NSIS installers which can't handle 1 char GvG> at a time reading of RTF text. To make it fully compatible with MS richedit, the buffer size should be not 10 chars, but 4096. Although it's not documented, all versions of MS Richedit always use this value. -- Best regards, Phil mailto:phil(a)newstar.rinet.ru

2 1

RE: Handling dialog messages for non-template based dialogs
by Santosh Siddheshwar April 16, 2004

April 16, 2004

Could you take a look at this fix? I would think I have resolved the other issue with SetDefButton as well. Tests with msg ran fine. Regards Santosh Siddheshwar <<patch.diff>> > -----Original Message----- > From: Dmitry Timoshkov [SMTP:dmitry(a)baikal.ru] > Sent: Friday, April 16, 2004 1:35 PM > To: Santosh Siddheshwar; Alexandre Julliard > Cc: Robert Shearman; wine-devel(a)winehq.org > Subject: Re: Handling dialog messages for non-template based dialogs > > "Santosh Siddheshwar" <santosh.s(a)sonata-software.com> wrote: > > > This test fails with WINE even after I create the DIALOGINFO structure > the > > first time it enters DefDlgProc. Not sure why this test should work on > > Windows. > > Since I wrote it under Windows it apparently works there. > > > Basically at the stage where you are setting DM_SETDEFID there are > > no child windows on the dialog. > > Yes, I was also confused when I saw this for the first time. > > > Then what does DM_SETDEFID and DM_GETDEFID do when there are no child > > controls on the dialog? > > Looks like it should store id in the dialog structure, and only then try > to change the look of a control. > > > My guess is implementation of DEFDLG_SetDefButton > > may need to change. > > Yes, but that's another bug, not related to your patch. Although it would > be > great if you could fix that as well, don't bother if you have no time, > I'll > fix it later, this should be a very simple patch. > > -- > Dmitry. ********************************************************************* Disclaimer: The information in this e-mail and any attachments is confidential / privileged. It is intended solely for the addressee or addressees. If you are not the addressee indicated in this message, you may not copy or deliver this message to anyone. In such case, you should destroy this message and kindly notify the sender by reply email. Please advise immediately if you or your employer does not consent to Internet email for messages of this kind. *********************************************************************

2 1

[Peter Riocreux] Re: dlls/kernel/console.c::SetConsoleCtrlHandler() cleanup/fixup
by Peter Riocreux April 16, 2004

April 16, 2004

Sorry, mistyped the wine-patches address before ...

1 0

RE: Handling dialog messages for non-template based dialogs
by Santosh Siddheshwar April 16, 2004

April 16, 2004

This test fails with WINE even after I create the DIALOGINFO structure the first time it enters DefDlgProc. Not sure why this test should work on Windows. Basically at the stage where you are setting DM_SETDEFID there are no child windows on the dialog. Then what does DM_SETDEFID and DM_GETDEFID do when there are no child controls on the dialog? My guess is implementation of DEFDLG_SetDefButton may need to change. Regards Santosh Siddheshwar > -----Original Message----- > From: Dmitry Timoshkov [SMTP:dmitry(a)baikal.ru] > Sent: Thursday, April 15, 2004 5:48 PM > To: Santosh Siddheshwar; Alexandre Julliard > Cc: Robert Shearman; wine-patches(a)winehq.com > Subject: Re: Handling dialog messages for non-template based dialogs > > "Santosh Siddheshwar" <santosh.s(a)sonata-software.com> wrote: > > > OK.One place where this could be done is WM_NCCREATE which comes before > > WM_CREATE. Other place (possibly better) where it might be possible to > do > > this is in CBTProc hook procedure. Not sure about the second option > though. > > Any thoughts? > > Attached test case shows that dialog info is initialized on the very first > DefDlgProc invocation. > > So, DefDlgProc16/A/W as the very first thing should call DIALOG_get_info > and > if it returns NULL initialize dialog structures. > > Alexandre, please apply the test as soon as the dialog initialization is > fixed. > > Changelog: > Dmitry Timoshkov <dmitry(a)codeweavers.com> > Add a message test for custom dialog initialization. > > -- > Dmitry. << File: msg.c.diff >> ********************************************************************* Disclaimer: The information in this e-mail and any attachments is confidential / privileged. It is intended solely for the addressee or addressees. If you are not the addressee indicated in this message, you may not copy or deliver this message to anyone. In such case, you should destroy this message and kindly notify the sender by reply email. Please advise immediately if you or your employer does not consent to Internet email for messages of this kind. *********************************************************************

2 1

Re: [Darwine] compiling wine on Darwin/MacOS X 5/10
by Pierre d'Herbemont April 16, 2004

April 16, 2004

Emmanuel, Index: libs/wine/loader.c =================================================================== RCS file: /home/wine/wine/libs/wine/loader.c,v retrieving revision 1.16 diff -u -r1.16 loader.c --- libs/wine/loader.c 2 Jan 2004 21:08:05 -0000 1.16 +++ libs/wine/loader.c 15 Apr 2004 18:17:07 -0000 @@ -182,6 +182,9 @@ +#ifdef __APPLE__ + if ((test_only == 0x2) && (ret = wine_dlopen(path, RTLD_NOW | RTLD_GLOBAL, error, errorsize ))) break; +#endif +#ifdef __APPLE__ + if (!(ntdll = dlopen_dll( "ntdll.dll", error, error_size, 0x2, &file_exists ))) return; +#else if (!(ntdll = dlopen_dll( "ntdll.dll", error, error_size, 0, &file_exists ))) return; +#endif These tests are no longer useful on Mac OS X. It was when ntdll was built as a dylib. However the check for environ is useful. Pierre On 15 avr. 04, at 23:36, emmanuel maillard wrote: > Hi, > here come some patches to build wine on Darwin/OS X > > Changelog > Build dylib on Darwin > > emmanuel > > <libs.diff>

1 0