- Wine-Devel - list.winehq.org

[PATCH] Small (visual) issue in generating html documentation
by pvriens＠xs4all.nl March 25, 2004

March 25, 2004

Hi, Just a small contribution. Hey, have to start somewhere. When doing a 'make htmlpages' the resulting index.html has no ',' between Q and R for the Index pages. Attached path should fix that. Cheers, Paul

1 0

NetBios
by flyker March 25, 2004

March 25, 2004

Does wine NetBios can work with remote windows application that use NetBios ?

1 0

Re: shell32 patch 24
by Alexandre Julliard March 25, 2004

March 25, 2004

"Martin Fuchs" <martin-fuchs(a)gmx.net> writes: > + if (This->bDirty) > + return S_OK; > + > return NOERROR; S_OK and NOERROR mean the same thing, so this doesn't look quite right. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: shell32 patch 23e
by Alexandre Julliard March 24, 2004

March 24, 2004

"Martin Fuchs" <martin-fuchs(a)gmx.net> writes: > + /* Add double quotation marks unless we already have them (e.g.: "%1" %* for exefile) */ > + if (res != out && *(res - 1) == '"') > + { > + strcpyW(res, cmd); > + res += strlenW(cmd); > + } > + else > + { > + strcpyW(res, cmd); > + res += strlenW(cmd); > + } Shouldn't you be doing something different in the else branch? Otherwise that test doesn't seem very useful ;-) -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: To Do A.11 - Integrate API status into WineHQ
by hatky March 24, 2004

March 24, 2004

>I'd rather there wasn't a DB. I know it saved time >and effort coding >wise to do it this way. Future changes will require >updates to the db, >and that can't be automated the way the current >scripts are. option2 crontab this: mysql -u user -D winapi -H >winapi_stats.html < test.sql now test.sql is a file that can be changed and the user is the only thing hardcoded in the crontab.... -- Jeremy Newman <jnewman(a)codeweavers.com> CodeWeavers, Inc. __________________________________ Do you Yahoo!? Yahoo! Finance Tax Center - File online. File on time. http://taxes.yahoo.com/filing.html

2 1

lostwages: add my irc nick
by Kevin Koltzau March 24, 2004

March 24, 2004

Changelog Add my irc nick

1 0

Re: To Do A.11 - Integrate API status into WineHQ
by hatky March 24, 2004

March 24, 2004

On Wednesday 24 March 2004 22:19, you wrote: > On Wed, 24 Mar 2004, hatky wrote: > > It looks complicated but it's all 3 mysql commands to > > get a complete table > > with whatever data you want from the winapi stats data > > in a nice table... > > [...] > > > comments? > > Yeah, there's no need for a database. Right now Francois' > soluions works perfectly fine without a DB, please don't > use one. I say this is not acceptable, but is up to > laxdragon, he's the website maintainer. It uses DB only for creating the file as a parser becouse it's 3 lines of code instade of 30 line parsing and very very flexable, I talked to laxdragon, he has not problem with it, he is still reviewing it... -- Hatky, Worshiper of wine (http://www.winehq.org/ or http://hatky.myz.info/wine/) Impossible is only an opinion. __________________________________ Do you Yahoo!? Yahoo! Finance Tax Center - File online. File on time. http://taxes.yahoo.com/filing.html

1 0

Missing WWN issues
by Francois Gouget March 24, 2004

March 24, 2004

Looking through the WINeHQ CVS I noticed that we are missing 4 WWN issues. Fortunately they seem to be available at the Wine Kernel Cousin web site... sort of. Would some kind soul volunteer for retrieving what can be retrieved? * WWN 88 and WWN 89 http://www.kerneltraffic.org/wine/wn20010314_88.html http://www.kerneltraffic.org/wine/wn20010315_89.html Unfortunately these two appear to be empty so there's not much to save. * WWN 90 http://www.kerneltraffic.org/wine/wn20010409_90.html Eric Pouech's call for a replacement. * WWN 91 http://www.kerneltraffic.org/wine/wn20010415_91.html Brian Vincent's first WWN. -- Francois Gouget fgouget(a)free.fr http://fgouget.free.fr/ Hiroshima '45 - Czernobyl '86 - Windows '95

2 1

Re: winetest: add support for revision info
by Ferenc Wagner March 24, 2004

March 24, 2004

This patch goes somewhat against Dimi's. Instead of invoking cvs, it extracts the working revision info from the CVS/Entries files resulting in speedy operation. Thus I incorporated all the stuff into maketest, executing unconditionally. Hope it is still portable. ChangeLog: - Extract revision info from CVS/Entries. - #include "winetest.rc" into gui.rc. MinGW can't link in more than one resource files. - Enlarge chunk size of network transfer. Index: Makefile.in =================================================================== RCS file: /home/wine/wine/programs/winetest/Makefile.in,v retrieving revision 1.23 diff -u -r1.23 Makefile.in --- Makefile.in 20 Mar 2004 19:21:39 -0000 1.23 +++ Makefile.in 22 Mar 2004 23:03:43 -0000 @@ -1,4 +1,5 @@ TOPSRCDIR = @top_srcdir@ +export TOPSRCDIR TOPOBJDIR = ../.. SRCDIR = @srcdir@ VPATH = @srcdir@ @@ -13,8 +14,7 @@ util.c RC_SRCS = \ - gui.rc \ - winetest.rc + gui.rc RC_BINSRC = gui.rc RC_BINARIES = wine.ico @@ -46,9 +46,6 @@ winetest.rc: maketest Makefile.in $(SRCDIR)/maketest $(TESTBINS) > $@ || ( $(RM) $@ && exit 1 ) - -revision.info: - (cd $(TOPSRCDIR); for file in dlls/*/tests/*.c; do rev=`cvs stat "$$file" | grep "Working" | awk '{print $$3}'`; echo "$$file:$$rev"; done) > $@ || ( $(RM) $@ && exit 1 ) winetest.res: $(TESTBINS) Index: gui.rc =================================================================== RCS file: /home/wine/wine/programs/winetest/gui.rc,v retrieving revision 1.2 diff -u -r1.2 gui.rc --- gui.rc 2 Mar 2004 20:56:35 -0000 1.2 +++ gui.rc 22 Mar 2004 23:03:43 -0000 @@ -21,6 +21,7 @@ #include <windows.h> #include <winres.h> #include "guires.h" +#include "winetest.rc" /* for the MinGW cross-compiler */ IDD_STATUS DIALOG 0, 0, 160, 140 STYLE WS_OVERLAPPEDWINDOW Index: main.c =================================================================== RCS file: /home/wine/wine/programs/winetest/main.c,v retrieving revision 1.7 diff -u -r1.7 main.c --- main.c 20 Mar 2004 19:21:39 -0000 1.7 +++ main.c 22 Mar 2004 23:03:43 -0000 @@ -140,7 +140,6 @@ } snprintf(buffer, sizeof(buffer), "dlls/%s/tests/%s.c", test, subtest); - fprintf(stderr, "file=%s\n", buffer); return buffer; } @@ -149,36 +148,35 @@ const struct rev_info* rev; for(rev = rev_infos; rev->file; rev++) { - fprintf(stderr, " ?{%s:%s)\n", rev->file, rev->rev); if (strcmp(rev->file, file) == 0) return rev->rev; } - return ""; + return "-"; } void extract_rev_infos () { char revinfo[256], *p; - int size = 0, i = 0, len; + int size = 0, i, len; HMODULE module = GetModuleHandle (NULL); for (i = 0; TRUE; i++) { if (i >= size) { size += 100; - rev_infos = xrealloc(rev_infos, size); + rev_infos = xrealloc (rev_infos, size * sizeof (*rev_infos)); } memset(rev_infos + i, 0, sizeof(rev_infos[i])); len = LoadStringA (module, i + 30000, revinfo, sizeof(revinfo)); if (len == 0) break; /* end of revision info */ - if (len >= sizeof(revinfo)) + if (len >= sizeof(revinfo) - 1) report (R_FATAL, "Revision info too long."); if(!(p = strrchr(revinfo, ':'))) report (R_FATAL, "Revision info malformed (i=%d)", i); *p = 0; rev_infos[i].file = strdup(revinfo); rev_infos[i].rev = strdup(p + 1); - } while(1); + } } void* extract_rcdata (int id, DWORD* size) @@ -196,7 +194,7 @@ return addr; } -/* Fills out the name, is_elf and exename fields */ +/* Fills in the name, is_elf and exename fields */ void extract_test (struct wine_test *test, const char *dir, int id) { @@ -459,48 +457,45 @@ cmdLine = mystrtok (cmdLine); while (cmdLine) { - if (*cmdLine == '-') - if (cmdLine[2]) { - report (R_ERROR, "Not a single letter option: %s", - cmdLine); - usage (); - exit (2); - } - cmdLine++; - switch (*cmdLine) { - case 'c': - report (R_TEXTMODE); - break; - case 'h': - usage (); - exit (0); - case 'q': - report (R_QUIET); - break; - case 's': - submit = mystrtok (NULL); - if (tag) - report (R_WARNING, "ignoring tag for submit"); - send_file (submit); - break; - case 'o': - logname = mystrtok (NULL); - run_tests (logname, tag); - break; - case 't': - tag = mystrtok (NULL); - cp = badtagchar (tag); - if (cp) { - report (R_ERROR, "invalid char in tag: %c", *cp); - usage (); - exit (2); - } - break; - default: - report (R_ERROR, "invalid option: -%c", *cmdLine); + if (cmdLine[0] != '-' || cmdLine[2]) { + report (R_ERROR, "Not a single letter option: %s", cmdLine); + usage (); + exit (2); + } + switch (cmdLine[1]) { + case 'c': + report (R_TEXTMODE); + break; + case 'h': + usage (); + exit (0); + case 'q': + report (R_QUIET); + break; + case 's': + submit = mystrtok (NULL); + if (tag) + report (R_WARNING, "ignoring tag for submit"); + send_file (submit); + break; + case 'o': + logname = mystrtok (NULL); + run_tests (logname, tag); + break; + case 't': + tag = mystrtok (NULL); + cp = badtagchar (tag); + if (cp) { + report (R_ERROR, "invalid char in tag: %c", *cp); usage (); exit (2); } + break; + default: + report (R_ERROR, "invalid option: -%c", cmdLine[1]); + usage (); + exit (2); + } cmdLine = mystrtok (NULL); } if (!logname && !submit) { Index: maketest =================================================================== RCS file: /home/wine/wine/programs/winetest/maketest,v retrieving revision 1.4 diff -u -r1.4 maketest --- maketest 20 Mar 2004 19:21:39 -0000 1.4 +++ maketest 22 Mar 2004 23:03:43 -0000 @@ -16,13 +16,15 @@ echo "$i \"$test\"" done -if [ -f revision.info ]; then - i=0 - for line in `cat revision.info`; do - i=`expr $i + 1` - echo "$i+30000 \"$line\"" - done -fi +i=30000 +cd $TOPSRCDIR +for dir in dlls/*/tests; do + sed -ne "s|^/$[^.]*.c$/$[^/]*$.*|$dir/\1:\2|p" $dir/CVS/Entries 2>/dev/null +done |\ +while read; do + echo "$i \"$REPLY\"" + i=`expr $i + 1` +done echo "}" Index: send.c =================================================================== RCS file: /home/wine/wine/programs/winetest/send.c,v retrieving revision 1.7 diff -u -r1.7 send.c --- send.c 19 Mar 2004 19:15:23 -0000 1.7 +++ send.c 22 Mar 2004 23:03:43 -0000 @@ -158,7 +158,7 @@ report (R_STATUS, "Sending %u bytes of data", filesize); report (R_PROGRESS, 2, filesize); - while ((bytes_read = fread (buffer, 1, BUFLEN / 8, f))) { + while ((bytes_read = fread (buffer, 1, BUFLEN / 2, f))) { if (send_buf (s, buffer, bytes_read)) { report (R_WARNING, "Error sending body: %d, %d", errno, WSAGetLastError ());

2 4

appdb bug
by Ivan Leo Murray-Smith March 24, 2004

March 24, 2004

On this page http://appdb.winehq.org/appview.php?appId=935&versionId=1229 there should be 6 comments, but only 2 are displayed, can someone hacking one the appdb code, or J.N. look into this? Ivan.

3 2