- Wine-Devel - list.winehq.org

Re: vsnprintf: glibc and win32 not compatible
by Jesse Allen March 9, 2004

March 9, 2004

On Tue, Mar 09, 2004 at 01:45:59PM +0800, Jonathan Wilson wrote: > >Discovered an issue with null pointer passed for %s (Warcraft III likes to > >do that it seems). I handle it by printing "(null)". Other than that, it > >will > Have you made it do something usefull if the user passes a null for a wide > char string? (i.e. passes %S and a null string?) > (A reply to the list this time) OK, I have added %S and %C. They pretty much copy %s and %c. I have started to read through dlls/user/wsprintf.c to show me how it's really done. Though, it is not finished. So in the case if something asks for %S and gives a null pointer, it will do the same as %s and print "(null)". glibc does the same thing for %s and %ls. If anyone would like try the updated version they can download snprintf.c and snprintf.h, renamed since it implements snprintf now, from ftp://narf.dnip.net/ and copy it into dlls/msvcrt. Update Makefile.in and msvcrt.spec and it should work after that. But it it still very experimental and there is more to do. Jesse

1 0

Re: Contribution offer: Localization work
by Ivan Leo Murray-Smith March 9, 2004

March 9, 2004

> Important: I did not want to change the sense of the original file. > Personally I think even bugs should be persistant between different > translations. ;-) Otherwise they would drift away from each other too > much (my opinion). On the other hand, I had to change some sections > slightly, as they would not make too much sense in german, could be > miss-interpreted or simply would sound ugly if translated very close to > the original. I don't know how the other translators handle this issue. As any latin student knows, you simply can't translate word by word, also you mustn't make a translation that sounds ugly. The important thing is that the file look as if it was written in the language you're translating to, not adapted from another one. Also, in computers it's important to use the same words that are already being used. For example, the italian translation of "Save file as" is "Salva file con nome" that literally means "Save the file with a name", so you can't translate literally, you have to use what is usually used for that functionality in other programs. Just go on as you have up to now. If you think something is wrong, send a patch that updates both the original and the translation. > If there is a translated Readme shouldn't there also be a translated licence > file? I'm sure there is already one translated available from GNU.org. Then > this should say LIZENZ instead of LICENSE. The GPL is licensed only for distribution without modification, you can't touch the GPL or the license information in any way shape or from. What you can do is add the translations released by the FSF, as long as you specify that the legally valid version is the english one.

1 0

unsubscribe banana67
by Andrew de Quincey March 9, 2004

March 9, 2004

2 1

Re: Implement Drag List Control
by Dimitrie O. Paun March 9, 2004

March 9, 2004

On March 9, 2004 2:20 pm, Robert Shearman wrote: > This patch adds full support for drag list common controls. There are no > known bugs, so as far as I am concerned this is 100% complete compared > to ComCtl32 v5.81 and probably v6.0 too. Nice! Now, to keep track of these things, I've added the following note to each of the controls that I have audited/fixed: * NOTE * * This code was audited for completeness against the documented features * of Comctl32.dll version 6.0 on Sep. 9, 2002, by Dimitrie O. Paun. * * Unless otherwise noted, we believe this code to be complete, as per * the specification mentioned above. * If you discover missing features, or bugs, please note them below. It would be nice to add something like this to the drag control as well (also, now that you have it fresh in your mind, maybe you can audit it against v6.0, as this is the version that I used for other controls). Take a look at dlls/comctl32/updown.c, dlls/comctl32/comboex.c, etc. for examples. -- Dimi.

1 0

Re: Wine as shared library patch
by Peter Dennis Bartok March 9, 2004

March 9, 2004

Alexandre, et. al, Our WinMain doesn't get called because our patch prevents it. If it were to get called, we'd be on a different (Wine-created) stack, with all kinds of things that are hard to undo, like the exception handling, etc. The goal of my patch was to have minimal impact on Wine, and allow the *same* wine code/binaries to be used for regular use as well as shared library, so any future Wine version you create will automatically also support shared library use. I modeled the global __wine_shared_lib variable after the __wine_main_argX globals you introduced last year, assuming that following that style would create the least resistance of getting my patch accepted. Having Wine set up the TEB and stack environment and actually call our WinMain and us then trying to 'undo' that in WinMain creates potential for future breakage of our library, in case you change something related to the TEB & stack. Having a variable in kernel that prevents creation of these, on the other hand, is easy to maintain, and really has no impact on performance or coding. I will be happy to implement any suggestions you may have on how to solve it another way in a single codebase that doesn't intruce the potential of breaking it in the future. I may very well have overlooked something. Regards, Peter -----Original Message----- From: "Alexandre Julliard" <julliard(a)winehq.org> To: "Miguel de Icaza" <miguel(a)ximian.com> Cc: "Peter Dennis Bartok" <peter(a)novonyx.com>; "Robert Shearman" <R.J.Shearman(a)warwick.ac.uk>; <wine-devel(a)winehq.org> Date: 07 March, 2004 17:37 Subject: Re: Wine as shared library patch >Miguel de Icaza <miguel(a)ximian.com> writes: > >> Well, the issue is that our WinMain is never called, and we would >> rather not depend on this in our patch, but instead get the small >> global that says `Hey Wine, just return'. > >The global variable thing is ugly; we could export a different entry >point instead, but I'm not sure it's really necessary. Why doesn't >your WinMain get called? > >-- >Alexandre Julliard >julliard(a)winehq.org > > >

6 12

statvfs breakage
by Gerald Pfeifer March 9, 2004

March 9, 2004

I'm afraid the following change date: 2004/03/05 21:03:46; author: julliard; state: Exp; Use statvfs instead of statfs, and provide a default implementation in libwine_port if necessary. is not portable, as seen on FreeBSD 4.8: acrux[71]:/sw/test/wine/libs/port% make /sw/gcc-3.3.2/bin/gcc -c -I. -I. -I../../include -I../../include -D__WINESRC__ -D_REENTRANT -fPIC -Wall -pipe -mpreferred-stack-boundary=2 -fno-strict-aliasing -gstabs+ -Wpointer-arith -g -O2 -o statvfs.o statvfs.c statvfs.c: In function `statvfs': statvfs.c:60: error: structure has no member named `f_namelen' Would you mind adding an autoconf test for that? (I saw that there are already a couple of those for statvfs.) Gerald -- Gerald Pfeifer (Jerry) gerald(a)pfeifer.com http://www.pfeifer.com/gerald/

1 1

Re: Warn If GetProcAddress Fails
by Kevin Koltzau March 9, 2004

March 9, 2004

Many apps dynamically bind to entry points to determine if features in Windows are available as well, This may cause quite a few apps to report huge numbers of warnings when there is actually nothing wrong On Monday 08 March 2004 08:44 pm, Robert Shearman wrote: > Many applications dynamically bind to entry points and can fail in > strange ways if they are not found. This patch enables users to see any > failing GetProcAddress calls that could be responsible for bad > behaviour.

2 1

vsnprintf: glibc and win32 not compatible
by Jesse Allen March 9, 2004

March 9, 2004

Hi, Here I have filed a bug on vsnprintf: http://bugs.winehq.org/show_bug.cgi?id=2075 Basically it says, without repeating, that vsnprintf called from glibc is not quite a suitable replacement for an actual msvcrt vsnprintf. An example is given to highlight a specific issue. I have a question on how should one approach fixing this? I have thought of two different ways: 1) Create our own vsnprintf version from scratch (fairly difficult) or 2) Create a wrapper for glibc's vsnprintf that translates win32ish format statements into a glibc friendly one. (not too bad and smaller patch) We could later move in a better or complete version to improve performance. The issue intrigues me, and I find that it should be resolved at some point. I'd like to get on the right path, so I'd at least start on something that will later be accepted. Thanks, Jesse

7 9

Cygwin under Wine
by Erik de Castro Lopo March 8, 2004

March 8, 2004

Hi all, I'm interested in running Cygwin under Wine. When trying to run the cygwin bash.exe I get the following: fixme:console:SetConsoleCtrlHandler (0x61025d10,0) - no error checking or testing yet fixme:console:SetConsoleCtrlHandler (0x61025d10,1) - no error checking or testing yet fixme:ntdll:NtQueryInformationToken (0x60,5,0x6167010c,44,0x4078ef5c): stub fixme:ntdll:NtQueryInformationToken (0x60,1,0x616700a4,44,0x4078ef5c): stub fixme:advapi:SetTokenInformation (0x60, TokenOwner, 0x616700a4, 44): stub fixme:ntdll:NtQueryInformationToken (0x60,6,0x4078ef68,3076,0x4078ef5c): stub fixme:ntdll:NtQueryObject Unsupported information class 1 fixme:ntdll:NtQueryObject Unsupported information class 1 fixme:psapi:GetProcessMemoryInfo (hProcess=0x30, 0x4078ecb0, 40): stub I've tried hacking the Wine version of GetProcessMemoryInfo and I've had a look at the Cygwin sources to see what they are actually doing with this function. Unfortunately, I am still at a loss as to whay Cygwin expects. Anybody got any ideas on how to fix this? Cheers, Erik -- +-----------------------------------------------------------+ Erik de Castro Lopo nospam(a)mega-nerd.com (Yes it's valid) +-----------------------------------------------------------+ Linux: Because rebooting is for adding new hardware

1 0

Re: Contribution offer: Localization work
by Ivan Leo Murray-Smith March 8, 2004

March 8, 2004

Look at the programs directory, most programs can be translated. You're usually looking for a De.rc file, if it's missing, make a second copy of the En.rc file, and call it De.rc. Now translate the strings in the file. You then have to edit the header file, this may be another rc file. In can case you can find the file by running grep En.rc * in the programs directory. Open the file, and add #include "De.rc" in alphabetical order in the list of language rc files. Once you've done this, make a patch, so your work can be easily applied to the wine source tree, a howto is at http://www.winehq.com/site/sending_patches. Also note that quite a few dlls need translating too. The file may not always be En.rc, for example in dlls/commdlg it's called cdlg_En.rc Finally, one important thing is keeping the translations up to date, so you should update the translation every time there is a change in the english resource file. Don't forget to check that the existing translations are up to date and correct. Once you've done a patch, send it, in the email body or as an attachment, to wine-patches(a)winehq.com This should give you plenty of work for now :-) Ivan.

3 2