- Wine-Devel - list.winehq.org

Happy 2004
by Ivan Leo Murray-Smith Dec. 31, 2003

Dec. 31, 2003

Happy New Year from the Central European Time Zone! Ivan.

1 0

Re: Simple arguments check
by Alexandre Julliard Dec. 31, 2003

Dec. 31, 2003

Mike Hearn <mike(a)theoretic.com> writes: > Index: dlls/shell32/pidl.c > =================================================================== > RCS file: /home/wine/wine/dlls/shell32/pidl.c,v > retrieving revision 1.94 > diff -u -r1.94 pidl.c > --- dlls/shell32/pidl.c 4 Nov 2003 04:21:01 -0000 1.94 > +++ dlls/shell32/pidl.c 25 Dec 2003 19:32:48 -0000 > @@ -1234,10 +1234,19 @@ > LPSHELLFOLDER shellfolder; > > TRACE_(shell)("(pidl=%p,%p)\n",pidl,pszPath); > - pdump(pidl); > > - if (!pidl) return FALSE; > + if (!pidl) { > + ERR_(shell)("argument check failed: pidl == null\n"); > + return FALSE; > + } > + > + if (!pszPath) { > + ERR_(shell)("argument check failed: pszPath == null\n"); > + return FALSE; > + } The ERRs are useless. If Windows does a NULL check, then we should do one too, without any error message; if Windows doesn't, then we shouldn't check at all. -- Alexandre Julliard julliard(a)winehq.com

3 4

Re: MCI #4: Add support for many MCIWNDM_ messages and some MCI_ commands
by Dimitrie O. Paun Dec. 31, 2003

Dec. 31, 2003

On December 30, 2003 11:48 am, Dmitry Timoshkov wrote: > + * Add support for all remaining MCI_ commands and MCIWNDM_ messages. > + * Add support for all MCIWNDF_ flags. An explicit list of MCI_ commands/MCIWNDM_ messages/MCIWNDF_ flags would be much appreciated (if it's under 30ish items). This would give a much better indication of the amount of work left to do. -- Dimi.

3 4

Re: PATCH: dlls/winmm/wineoss/audio.c
by Alexandre Julliard Dec. 31, 2003

Dec. 31, 2003

Gerald Pfeifer <gerald(a)pfeifer.com> writes: > Tests by a FreeBSD user and discussions with one of the FreeBSD sound > maintainers confirmed that this is the right fix for that platform. > > I'm not sure whether you want to make this change in general, for all > platforms, so for now I have embedded it in an #if(n)def. I think we should do that on all platforms, yes. And you probably want to fix OSS_WaveInInit too. -- Alexandre Julliard julliard(a)winehq.com

2 1

Silly question, sloghtly off topic
by Joshua Walker Dec. 31, 2003

Dec. 31, 2003

If you replace a win9x advapi32.dll with a winNT advapi32.dll, do you gain the extra security features? I'm guessing no... -Joshua

2 1

PATCH - winebrowser
by Chris Morgan Dec. 30, 2003

Dec. 30, 2003

Has Rein's fix for mozilla and Ivan's additional browsers. Tried to clean the script up a little bit, could probably still use some work but I'm no script guru. Chris * tools/winebrowser, tools/wineinstall, tools/Makefile.in, winedefault.reg Chris Morgan <cmorgan(a)alum.wpi.edu> Add HKEY_LOCAL_MACHINE\software\classes\http\shell\open\command key and value. Winebrowser script. Makefile changes to install/remove script. Wineinstall should create a simlink from windows/winebrowser.exe to the location of winebrowser on the machine.

1 0

Re: Add support for some other MCI_ commands and implement mciSendCommandW
by Alexandre Julliard Dec. 30, 2003

Dec. 30, 2003

Dmitry Timoshkov <dmitry(a)baikal.ru> writes: > @@ -84,7 +84,16 @@ BOOL VFWAPIV MCIWndRegisterClass(HINSTAN > { > WNDCLASSW wc; > > - wc.style = CS_VREDRAW | CS_HREDRAW | CS_DBLCLKS | CS_OWNDC; > + /* Since we are going to register a class belonging to MSVFW32 > + * and later we will create windows with a different hInstance > + * CS_GLOBALCLASS is needed. And because the second attempt > + * to register a global class will fail we need to test whether > + * the class was already registered. > + */ > + if (GetClassInfoW(MSVFW32_hModule, mciWndClassW, &wc)) > + return TRUE; > + This is not thread-safe; if you need to know why the class creation failed you should check the last error returned from RegisterClassW. -- Alexandre Julliard julliard(a)winehq.com

1 0

Re: Allow regsvr32 to register multiple DLLs at once
by Alexandre Julliard Dec. 30, 2003

Dec. 30, 2003

Mike Hearn <mike(a)theoretic.com> writes: > When you just get the urge to reregister your entire windows/system > directory... > > Mike Hearn <mike(a)theoretic.com> > Allow regsvr32 to register multiple DLLs even if some fail regsvr32 is a standard Windows program, we shouldn't invent new options that don't exist on Windows. -- Alexandre Julliard julliard(a)winehq.com

1 0

Re: Re: Key exist query in registry
by Dimitrie O. Paun Dec. 30, 2003

Dec. 30, 2003

> I call RefreshListView() but the key doesn't appear in > the list. Should we do some insert to the listview? Or > this could be a bug? Hold on, are you inserting a key or a value? Values appear in the listview, keys in the treeview. But I don't think there is a treeview refresh just yet, so it's a bit trickier. Maybe we should first handle values, it's easier, we can worry about keys after that... -- Dimi.

2 1

Re: option to ignore primary selection
by Mike Hearn Dec. 30, 2003

Dec. 30, 2003

On Thu, 2003-12-18 at 05:00, Ulrich Czekalla wrote: > This patch adds an option (turned off by default) to restrict Wine to only > use the clipboard selection since it will never implement proper behaviour > for the primary selection (You'll never be able to select text with the > mouse). The kind of people who get confused by this will probably not alter the defaults in this way, or even understand what the option does. Perhaps it should be on by default, with power users who are willing to accept its half completeness willing to switch on support for PRIMARY themselves? thanks -mike

3 2