- Wine-Devel - list.winehq.org

Re: ntdll / kernel32: #38
by Dmitry Timoshkov Dec. 12, 2003

Dec. 12, 2003

"Eric Pouech" <pouech-eric(a)wanadoo.fr> wrote: > +HANDLE WINAPI OpenConsoleW(LPCWSTR name, DWORD access, LPSECURITY_ATTRIBUTES sa, > + DWORD creation) > +{ > + static const WCHAR coninW[] = {'C','O','N','I','N','$',0}; > + static const WCHAR conoutW[] = {'C','O','N','O','U','T','$',0}; > + BOOL output; > + HANDLE ret; > + > + if (strcmpW(coninW, name) == 0) > + output = FALSE; > + else if (strcmpW(conoutW, name) == 0) > + output = TRUE; While you are moving the code around then you are probably reviewing it as well? So, the question is: shouldn't the above comparisons be case insensitive? -- Dmitry.

2 1

Re: menu: Fix for menu tracking problem version 2
by Alexandre Julliard Dec. 12, 2003

Dec. 12, 2003

Andrew de Quincey <adq_dvb(a)lidskialf.net> writes: > I wrote a program in windows which had owner drawn menu items. Whenever I > received the WM_DRAWITEM message: > > 1) I called GetCapture(), and compared it with the hwnd of main window > containing the menu. It pops up a message box if they are different. > 2) I then called SetCapture() with the HWND of the menu item itself. > > This approximately simulates what IDA is doing. > > The message box never popped up. This shows that even though the capture was > changed in one WM_DRAWITEM, windows had reset the capture to the window > containing the menu by the time of the next one. I also checked the messages > _were_ being sent using Spy++ (in case of a programming error). That's a good start, but it's not enough to know what Windows is really doing. You should also check the capture window right after you call SetCapture; and you should use GetGUIThreadInfo and print out all the details, especially the GUI_INMENUMODE flag. My suspicion is that the capture is not allowed to change at all in menu mode. -- Alexandre Julliard julliard(a)winehq.com

2 5

Problems with transparent windows
by Juan Antonio Boscá Lloret Dec. 12, 2003

Dec. 12, 2003

Hello, I've found a probable bug in Wine when running win32 applications. Wine does not repaint windows areas that are hidden by another window over them (I think this is a behaviour by design). This behaviour is not correct when the upper window is transparent (WS_EX_TRANSPARENT style). Is it a bug? Thank you. --------------------------------------------------------------- Juan Antonio Boscá Lloret Departamento Programación CAE, S.A. jabosca(a)edicurs.com ---------------------------------------------------------------

2 1

Re: wine/dlls/kernel pthread.c
by Rein Klazes Dec. 12, 2003

Dec. 12, 2003

On Fri, 12 Dec 2003 00:19:25 -0600, you wrote: > Log message: > Return an error in wine_pthread_mutex_unlock if we don't own the > critical section, this should avoid trouble caused by a locking bug > inside Xlib. Good, the locking problem that I reported seems to be fixed by this. Rein. -- Rein Klazes rklazes(a)xs4all.nl

1 0

Re: unicode & wine internals
by Mike Hearn Dec. 12, 2003

Dec. 12, 2003

No patch? On Thu, 2003-12-11 at 20:14, Eric Pouech wrote: > wine_get_unix_file_name is now a unicode function > A+

1 0

Re: shlexec: Fixes for buffer overrun problems
by Alexandre Julliard Dec. 12, 2003

Dec. 12, 2003

Andrew de Quincey <adq_dvb(a)lidskialf.net> writes: > Hi, this is a cleanup of shell32/shlexec.c to remove potential buffer > overruns. I've also tried to make parts of the code a little easier to > follow, without affecting the functionality. It's a very inefficient mechanism, you are reallocating the same string over and over to append sometimes only a single char. The right way to avoid overflows is to compute the length of the full string first and then allocate all the needed space at once. -- Alexandre Julliard julliard(a)winehq.com

2 1

Re: Janitorial: Get rid of W->A calls for shlexec (2/2)
by Alexandre Julliard Dec. 12, 2003

Dec. 12, 2003

Marcelo Duarte <wine-devel(a)bol.com.br> writes: > Hi, > > Changelog: > Marcelo Duarte <wine-devel(a)bol.com.br> > -Janitorial: Get rid of W->A calls for shlexec > -Implementation of FindExecutableW > > Coments: > After you aplying my patch 1/2 and made corrections using sizeof, I see the > problems in the patch 2/2 and I do the corrections, and now, I think that all > is correct. No, there are still many places where the sizes are wrong. Every time you change a buffer from char[] to WCHAR[] you have to fix uses of sizeof on that buffer to count characters properly. Also there are still HeapAlloc calls that are done in bytes instead of WCHARs. -- Alexandre Julliard julliard(a)winehq.com

1 0

Re: comctl32/toolbar: Potential fix for button redraw in TBSTYLE_FLAT toolbars
by Dimitrie O. Paun Dec. 12, 2003

Dec. 12, 2003

On December 11, 2003 04:32 pm, Andrew de Quincey wrote: > I have concluded that the WM_ERASEBKGND is sent from within WM_PAINT when > the toolbar detects that the mouse has moved off a button and wants to > de-highlight it. Well, it probably does a InvalidateRect() call. You can try an ugly InvaldateRect(hwnd, 0, TRUE); but this will probably result in flicker. For added bonus, figure out the button's rect, and pass it in: /* figure out stuff in rect */ InvalidateRect(hwnd, &rect, TRUE); BTW, what are the parameters of WM_ERASEBKGND? -- Dimi.

2 4

bugs in d3d8.dll and msvcrt.dll
by Ivan Leo Murray-Smith Dec. 11, 2003

Dec. 11, 2003

There are 2 bugs that prevent mafia (Trial version) from working correctly, they are in d3d8.dll and msvcrt.dll, updated backtraces generated with wine-20031212 are at http://bugs.winehq.com/show_bug.cgi?id=1670 the demo is at http://www.mafia-game.com in the downloads section.

1 0

Deadlock?
by Shachar Shemesh Dec. 11, 2003

Dec. 11, 2003

When trying to run Microsoft Digital Image Pro, I occasionally get problems when loading it. The splash screen comes up, and then it hangs. This problem only happens occasionally. I have not, to date, managed to reproduce it with relay turned on. This is what I do get on screen: err:module:import_dll No implementation for USER32.dll.GetScrollBarInfo imported from L"C:\\Program Files\\Microsoft Picture It! 9\\piutil.dll", setting to 0xdeadbeef err:font:ReadFontDir Can't open directory "/win/windows/fonts" err:imagelist:ImageList_LoadImageW Error loading image! err:toolbar:ToolbarWindowProc unknown msg 204e wp=000000ca lp=4080deec err:toolbar:ToolbarWindowProc unknown msg 204e wp=000000ca lp=4080ea54 err:toolbar:ToolbarWindowProc unknown msg 2210 wp=00ca0001 lp=00010051 err:toolbar:ToolbarWindowProc unknown msg 204e wp=40c757d8 lp=4080eaa4 err:toolbar:ToolbarWindowProc unknown msg 2210 wp=57d80001 lp=00010053 fixme:toolbar:TOOLBAR_SetPadding stub - nothing done with values, cx=7, cy=9 fixme:imm:ImmAssociateContext (0x10056, (nil)): semi-stub fixme:imm:ImmAssociateContext (0x10058, (nil)): semi-stub fixme:imm:ImmAssociateContext (0x1005a, (nil)): semi-stub fixme:hook:NotifyWinEvent (32784,0x10056,-4,0)-stub! fixme:hook:NotifyWinEvent (32784,0x1005a,-4,0)-stub! fixme:hook:NotifyWinEvent (32782,0x10058,-4,0)-stub! err:toolbar:ToolbarWindowProc unknown msg 204e wp=000000ca lp=4080e61c fixme:imm:ImmAssociateContext (0x1009d, (nil)): semi-stub err:ntdll:RtlpWaitForCriticalSection section 0x4020fc60 "loader.c: loader_section" wait timed out in thread 0009, blocked by 000c, retrying (60 sec) err:ntdll:RtlpWaitForCriticalSection section 0x7c38b208 "?" wait timed out in thread 000c, blocked by 0009, retrying (60 sec) -- Shachar Shemesh Open Source integration & consulting Home page & resume - http://www.shemesh.biz/

2 4