- Wine-Devel - list.winehq.org

Re: wine/dlls/kernel kernel_main.c Makefile.in
by Dimitrie O. Paun Oct. 10, 2003

Oct. 10, 2003

On October 9, 2003 08:50 pm, Alexandre Julliard wrote: > We can now use the standard DllMain as entry point. Cool, what about the one in user32: [dimi(a)dimi wine.src]$ grep DLLMAIN `find -name "Makefile.in"` ./dlls/user/Makefile.in:DLLMAIN = UserClientDllInitialize(a)12 It's the last one, we could get rid of the DLLMAIN stuff... -- Dimi.

1 0

Re: patch for error handling after driver callback calls.
by Alexandre Julliard Oct. 9, 2003

Oct. 9, 2003

Dave_Belanger(a)cimmetry.com writes: > (See attached file: patch_callbacks_return.txt) The idea is that the DC interface functions should behave just like the corresponding APIs, so if the API returns the old value the DC function should do that too. This way it guarantees that we can implement the full behavior of the API in the driver. -- Alexandre Julliard julliard(a)winehq.com

1 0

Re: patch for EMFDRV_UpdateBBox
by Alexandre Julliard Oct. 9, 2003

Oct. 9, 2003

Dave_Belanger(a)cimmetry.com writes: > (See attached file: patch_emf_updatebbox.txt) Is there a reason you are not using LPtoDP() here? -- Alexandre Julliard julliard(a)winehq.com

1 0

Re: Detect alternatives to w3m
by Dimitrie O. Paun Oct. 9, 2003

Oct. 9, 2003

On Wed, 8 Oct 2003, Francois Gouget wrote: > > I did not know about w3m before I saw this patch. More well-known and > widely spread alternatives are lynx and links which are command-line > compatible with w3m. So I propose to also look for them. Yeah, I didn't know about w3m either. Wouldn't a configure check be better here? -- Dimi.

4 6

RE: question about copyright and code, is this legal?
by Patrik Stridvall Oct. 9, 2003

Oct. 9, 2003

> On Fri, 3 Oct 2003 23:07, Patrik Stridvall wrote: > > [correct summary of the law deleted] > > > As far as Wine is concerned though I can't think of > > any Windows API that: > > 1. Returns pure facts (not having any unique expression) > > 2. Would fulfill the requirement of needed a significant > > effort to collect to collect the fact. > > > > So no I wouldn't worry about it as far as Wine is concerned. > > Unfortunately it appears there may be one: LCMapString. If > all the things we > have discovered about the tables are correct (and I am by no > means assuming > that they are), then the Microsoft sort key table meets the > industrious > collection requirements and returns facts in a way that could not be > duplicated without duplicating the table (it returns the > table entry in > literal form, so it couldn't even be represented as a > different table). The significant effort requirement is for EACH fact seen by ITSELF. For example if a make a database with the home and work addresses and telephone numbers for every Wine contributor EACH fact seen by ITSELF will take significant effort (at least on average) since they are in most cases are not readily available. In your example above anybody knowledgable in some language, say Japanese, can easily determine the return values for inputs involving their language for LCString AFAICS. Futhermore the example I made above is what the law was designed to protect so it is doubtful any court would even attempt to extend it to your example. The intent of the lawmakers is VERY important here in Sweden. > This is what is (generally) returned by LCMapString. The > actual table is > included in an external file under NT (sortkey.nls), so one > option (likely > the best option) would be to implement LCMapString using a > standard table > from unicode.org, then provide a facility so that people in > the US and Canada > can (at their own risk of course) use the Microsoft versions > relying on > Feist. In addition I doubt any court in Sweden would even try the case since the facts in questions was intentionally published by Microsoft in the US where the collection of facts was not protected because of Feist and thus legally importable from there...

2 1

european cvs mirror problems
by Ivan Leo Murray-Smith Oct. 9, 2003

Oct. 9, 2003

I'm getting this message cvs update -PAd cvs [update aborted]: connect to rhlx01.fht-esslingen.de(129.143.116.10):2401 failed: Connection refused will this be fixed?

1 0

Re: Byteswapping
by Warren_Baird＠cimmetry.com Oct. 9, 2003

Oct. 9, 2003

> The best is to use the Rtl*ByteSwap functions from winternl.h. That is certainly the best solution --- I hadn't noticed that those had been added... I'll try redoing our swapping code with them and make sure it all works... Warren

1 0

Re: [janatorial] HeapReAlloc
by Dimitrie O. Paun Oct. 9, 2003

Oct. 9, 2003

On Wed, 8 Oct 2003, Oleg Prokhorov wrote: > Change-log: > fix wine code depended on That's cool, but we need to somehow manage this. There are almost 300 occurences of memory reallocation, and we need to somehow keep track of what was reviwed/fixed etc., otherwise we risk missing quite a few... We should start with a comprehensive list of things that need fixing... -- Dimi.

4 3

imagehlp - MS_VC/Mingw porting
by Steven Edwards Oct. 9, 2003

Oct. 9, 2003

The part about the imagehlp version in the header doesnt have to be in there I just figured we might as well add it while we are trying to be the same. Changelog: Bring imagehlp (mostly) inline with the PSDK and Mingw Index: wine/dlls/imagehlp/debug.c =================================================================== RCS file: /home/wine/wine/dlls/imagehlp/debug.c,v retrieving revision 1.11 diff -u -r1.11 debug.c --- wine/dlls/imagehlp/debug.c 5 Sep 2003 23:08:37 -0000 1.11 +++ wine/dlls/imagehlp/debug.c 9 Oct 2003 01:01:39 -0000 @@ -75,7 +75,7 @@ */ BOOL WINAPI StackWalk( DWORD MachineType, HANDLE hProcess, HANDLE hThread, - PSTACKFRAME StackFrame, PVOID ContextRecord, + LPSTACKFRAME StackFrame, LPVOID ContextRecord, PREAD_PROCESS_MEMORY_ROUTINE ReadMemoryRoutine, PFUNCTION_TABLE_ACCESS_ROUTINE FunctionTableAccessRoutine, PGET_MODULE_BASE_ROUTINE GetModuleBaseRoutine, Index: wine/dlls/imagehlp/imagehlp_main.c =================================================================== RCS file: /home/wine/wine/dlls/imagehlp/imagehlp_main.c,v retrieving revision 1.15 diff -u -r1.15 imagehlp_main.c --- wine/dlls/imagehlp/imagehlp_main.c 5 Sep 2003 23:08:37 -0000 1.15 +++ wine/dlls/imagehlp/imagehlp_main.c 9 Oct 2003 01:01:39 -0000 @@ -58,7 +58,7 @@ /*********************************************************************** * ImagehlpApiVersion (IMAGEHLP.@) */ -PAPI_VERSION WINAPI ImagehlpApiVersion() +LPAPI_VERSION WINAPI ImagehlpApiVersion(VOID) { return &IMAGEHLP_ApiVersion; } @@ -66,7 +66,7 @@ /*********************************************************************** * ImagehlpApiVersionEx (IMAGEHLP.@) */ -PAPI_VERSION WINAPI ImagehlpApiVersionEx(PAPI_VERSION AppVersion) +LPAPI_VERSION WINAPI ImagehlpApiVersionEx(LPAPI_VERSION AppVersion) { if(!AppVersion) return NULL; Index: wine/include/imagehlp.h =================================================================== RCS file: /home/wine/wine/include/imagehlp.h,v retrieving revision 1.19 diff -u -r1.19 imagehlp.h --- wine/include/imagehlp.h 5 Sep 2003 23:15:44 -0000 1.19 +++ wine/include/imagehlp.h 9 Oct 2003 01:01:51 -0000 @@ -25,6 +25,8 @@ extern "C" { #endif /* defined(__cplusplus) */ +#define API_VERSION_NUMBER 7 /* 7 is the default */ + /*********************************************************************** * Types */ @@ -168,7 +170,7 @@ USHORT MinorVersion; USHORT Revision; USHORT Reserved; -} API_VERSION, *PAPI_VERSION; +} API_VERSION, *LPAPI_VERSION; typedef struct _IMAGE_DEBUG_INFORMATION { LIST_ENTRY List; @@ -414,11 +416,11 @@ BOOL WINAPI ImageUnload( PLOADED_IMAGE LoadedImage ); -PAPI_VERSION WINAPI ImagehlpApiVersion( +LPAPI_VERSION WINAPI ImagehlpApiVersion( void ); -PAPI_VERSION WINAPI ImagehlpApiVersionEx( - PAPI_VERSION AppVersion +LPAPI_VERSION WINAPI ImagehlpApiVersionEx( + LPAPI_VERSION AppVersion ); BOOL WINAPI MakeSureDirectoryPathExists( LPCSTR DirPath __________________________________ Do you Yahoo!? The New Yahoo! Shopping - with improved product search http://shopping.yahoo.com

1 0

Re: patch for implementation of EMF driver SetPixel metarecord.
by Dimitrie O. Paun Oct. 8, 2003

Oct. 8, 2003

On Wed, 8 Oct 2003 Dave_Belanger(a)cimmetry.com wrote: This patches are so hard to review. Not only are they not inlined, but they are attached as Application/OCTET-STREAM. This means I have to type about 8 keystrokes to open them in pine. Please, pretty please, try to inline them. If this doesn't wokr (have you tried?), at least attach them as text/plain. Thanks. -- Dimi. P.S. Inlining them is _far_ supperior to attachment. First, we can review them without any additional action. Second, we can simply press "Reply" and quote the code we want to comment on. This is very important.

1 0