- Wine-Devel - list.winehq.org

Re: New EXE
by Ivan Leo Murray-Smith Sept. 1, 2003

Sept. 1, 2003

>Yes, it would be nice to have more frequent releases, but we would have >trouble labeling them...unless we stick to the build date. But in that >case, we have to have a well understood convention on what YYYYMMDD >means in terms of time, and we have to stick to it (well, the person >building this should). Any takers? What about an automatic build?

2 1

Bugzilla bug #556
by Dave Miller Aug. 31, 2003

Aug. 31, 2003

Bug 556 is "reconcile the windows and wine spec files." The point I think is make sure all windows APIs are listed, and listed correctly. I have a question... If a particular API has four different ordinals in four different windows versions, what goes in the spec file? You can see an example of what I mean here: http://24.229.94.2/cgi-bin/query.cgi?version=&status=&type=&ordinal=&api=SH… If the answer is simple enough I'll start working on the bug. On a slightly related note, I relied on the wine spec files to build the apidb. I'm getting the idea now this wasn't quite the right approach, and it says some APIs are exported by wine when in fact they are not. Should I have used the .spec.def file instead? ------------------------------------- So many Right-wing Christians. So few lions.

3 2

Re: [winecfg 1.1] Implement saveConfigValue(), style changes, code cleanup, UI alignment
by Dimitrie O. Paun Aug. 31, 2003

Aug. 31, 2003

On August 28, 2003 06:50 am, Mike Hearn wrote: > 2) Introduce some kind of global flag, maybe a config.h switch, maybe an > exported variable (which is best?) that controls whether the > configuration is read from the registry or config file. As patches are > submitted to make Wine read the registry as well as the config file, the > controls in winecfg would be re-enabled so people can test it. Once all > the settings have been dual-purposed in this way, we can write a bit of > migration code so people upgrading have their configurations copied into > the registry, then throw the switch. I really don't understand why we need the dual-purpose stuff. All we need to do is: -- make sure we have a GUI element for all settings in ~/.wine/config (how far are we from having this?) -- have loadConfig() initialize all these elements properly -- have saveConfig() do the saving, being a mirror image of loadConfig() (can't we unify them somehow so we have only one place to modify to add new values? [1]) -- when all this is done, just remove the code from server/registry.c:1475:init_registry() Am I missing something? [1] Maybe it's better to have a more descriptive structure detailing stuff for each value, and having generic loadConfig/saveConfig() methods that know how to walk said structure and do the right thing. This way we can easily do add all sorts of attributes to the configuration values and do all sort of nice things, like save only stuff that has been modified, automatically tie in the variable to the control, etc. -- Dimi.

7 18

Re: gethostbyname() feature.
by Jakob Eriksson Aug. 31, 2003

Aug. 31, 2003

Maybe you could write a regression test for this function? Rein Klazes wrote: >hi, > >In the newsgroup someone reported a crash in gethostbyname() when the >application called it with a null parameter. > >msdn says about this: > >| If null is provided in the name parameter, the returned string is >| the same as the string returned by a successful gethostname >| function call. > >gethostbyname does not return a string, but I think this it what they >meant to say. >I have tested gethostbyname under Win2K to do this. > >Changelog: > dlls/winsock : socket.c async.c > _ws_gethostbyname() and WSAAsyncGetHostByName() when called with > a null name, should use the name returned by gethostname(). > >Rein. > > >------------------------------------------------------------------------ > >--- wine/dlls/winsock/socket.c 2003-08-31 10:00:10.000000000 +0200 >+++ mywine/dlls/winsock/socket.c 2003-08-31 09:59:16.000000000 +0200 >@@ -2903,6 +2903,16 @@ > int ebufsize=1024; > struct hostent hostentry; > int locerr = ENOBUFS; >+#endif >+ char buf[100]; >+ if( !name) { >+ name = buf; >+ if( gethostname( buf, 100) == -1) { >+ SetLastError( WSAENOBUFS); /* appropriate ? */ >+ return retval; >+ } >+ } >+#ifdef HAVE_LINUX_GETHOSTBYNAME_R_6 > host = NULL; > extrabuf=HeapAlloc(GetProcessHeap(),0,ebufsize) ; > while(extrabuf) { >--- wine/dlls/winsock/async.c 2003-08-31 10:00:10.000000000 +0200 >+++ mywine/dlls/winsock/async.c 2003-08-31 09:47:31.000000000 +0200 >@@ -402,6 +402,16 @@ > int ebufsize=1024; > struct hostent hostentry; > int locerr = ENOBUFS; >+#endif >+ char buf[100]; >+ if( !(aq->host_name)) { >+ aq->host_name = buf; >+ if( gethostname( buf, 100) == -1) { >+ fail = WSAENOBUFS; /* appropriate ? */ >+ break; >+ } >+ } >+#ifdef HAVE_LINUX_GETHOSTBYNAME_R_6 > he = NULL; > extrabuf=HeapAlloc(GetProcessHeap(),0,ebufsize) ; > while(extrabuf) { > >

1 0

Re: wsock32: implement arp query
by Tom Aug. 31, 2003

Aug. 31, 2003

Juan Lang wrote: >ChangeLog: implement arp table querying through >WsControl, and fix problem I introduced getting IP >addresses for multiple interfaces > > > Ummm..... The patch :) Tom

1 0

Re: [ANN] Conformance testing campaign
by Ivan Leo Murray-Smith Aug. 30, 2003

Aug. 30, 2003

Hereby I ask people who have access to real Windows machines So vmware won't do? (I think the answer is no because of directx (Not a problem for me to do a real install, just asking)).

2 1

Re: winedos / Fix DOS exit paths
by Dimitrie O. Paun Aug. 30, 2003

Aug. 30, 2003

On August 30, 2003 12:52 pm, Jukka Heinonen wrote: > The reason why I'm posting lots of small patches is that I'm currently > working on a big RMCB fix which seems to still have some minor problems What is this RMCB? Google wasn't all that helpful... -- Dimi.

2 1

LoadModule16 regression?
by Jukka Heinonen Aug. 30, 2003

Aug. 30, 2003

After LoadModule16 was moved to dlls/kernel, it started to strip path from module name. This makes it impossible to execute DOS applications (and probably Win16 applications, too) unless you are in the same directory as the application. MSDN documentation on Win32 version of LoadModule states that path should not be stripped but I'm not sure how Win16 version is supposed to work. It probably uses different search order if path is not present, anyway. -- Jukka Heinonen <http://www.iki.fi/jhei/>

2 1

Bug in regrtest
by Jakob Eriksson Aug. 30, 2003

Aug. 30, 2003

The tester runs on Win9X, but there is a bug that prevents it from running tests properly. I am working on it. Tested working on Windows NT so far. I will keep you posted. regards, Jakob

1 0

Re: shlobj.o
by Vincent Béron Aug. 30, 2003

Aug. 30, 2003

Le sam 30/08/2003 à 08:29, Martin Fuchs a écrit : > + STDMETHOD_(ULONG, AddRef) (THIS) PURE; > + STDMETHOD_(ULONG, Release) (THIS) PURE; > + STDMETHOD (DragEnter)(THIS_ HWND hwndTarget, IDataObject* pDataObject, > POINT* ppt, DWORD dwEffect) PURE; > + STDMETHOD (DragLeave)(THIS) PURE; > + STDMETHOD (DragOver)(THIS_ POINT* ppt, DWORD dwEffect) PURE; > + STDMETHOD (Drop)(THIS_ IDataObject* pDataObject, POINT* ppt, DWORD > dwEffect) PURE; Your patch is unfortunately wrapped. shlguid.h suffers from the same problem. Vincent

2 1