- Wine-Devel - list.winehq.org

Dmusic interfaces
by Sylvain Petreolle June 16, 2003

June 16, 2003

Is anyone of you working on Dmusic interfaces ? Now doing test with Dxdiag doesnt work, it says "No such interface" when trying to create a IDirectPerformance object. I did a look through the source and noticed that Dll(Un)RegisterServer are stubs. fixme:ole:CoCreateInstance no instance created for interface {07d43d03-6523-11d2-871d-00600893b1bd} of class {d2ac2881-b39b-11d1-8704-00600893b1bd}, hres is 0x80004002 ===== Sylvain Petreolle (spetreolle at users dot sourceforge dot net) ICQ #170597259 "What if tomorrow the War could be over ?" Morpheus, in "Reloaded". For the Law of Oil and Fire, Im an European that lives in France. For all my Brothers and friends, Im a human living on Earth. ___________________________________________________________ Do You Yahoo!? -- Une adresse @yahoo.fr gratuite et en français ! Yahoo! Mail : http://fr.mail.yahoo.com

1 0

Re: Winefile : French translation
by Alexandre Julliard June 16, 2003

June 16, 2003

Sylvain Petreolle <spetreolle(a)yahoo.fr> writes: > Changelog: > Add French Translation, finish English translation. > > (no unwanted easter egg in this one ;)) No but it looks like the accents didn't make it through... or was this deliberate? -- Alexandre Julliard julliard(a)winehq.com

2 3

Re: wine/dlls/ntdll critsection.c
by Mike Hearn June 16, 2003

June 16, 2003

On Mon, 16 Jun 2003 14:36:22 -0500, Sir Alexandre Julliard scribed thus: > Log message: > Mike Hearn <mike(a)theoretic.com> > Add the ID of the blocking thread to the error message. Hi Alexandre, I'm wondering what the best way to try and make Wines output less scary is, as the MESSAGE() parts of this patch were not merged. Was the message not phrased right, or do you think that the console output is an inappropriate place to put such things? Alternatively, as Lionel pointed out, it may be that people think they are not necessary, as the only people who can do anything about it will understand the message anyway. thanks -mike

2 2

Re: Bidi B4
by Shachar Shemesh June 16, 2003

June 16, 2003

Hi Alexander, Please let me know if my patch series was rejected, and if so, why. If your'e just not over the backlog yet, I appologize for the noise. Shachar Shachar Shemesh wrote: > Apply against previous patches, using -p1 > > Changelog: > Shachar Shemesh <winecode(a)shemesh.biz> > > * Fix compilation errors when ICU library is not available. > -- Shachar Shemesh Open Source integration consultant Home page & resume - http://www.shemesh.biz/

1 0

Re: [DINPUT] Some more dinput stuff
by Lionel Ulmer June 16, 2003

June 16, 2003

> As your patch is a little malformed and conflicts with mine (a big one) > i send my patch merged with yours, can you look if all is correct. Why did you not send a patch against a tree patched with Christian's ? And moreover, it seems you have another patch lying around (the one adding the IDirectInputDevice2A interface to the QueryInterface call). The problem is not the Changelog one, it's just that it's now really hard to do any code review with these kinds of stuff as change are accumulating :-/ Lionel -- Lionel Ulmer - http://www.bbrox.org/

3 5

dlls/dmusic/dmusic_misc.c revision 1.3
by Gerald Pfeifer June 16, 2003

June 16, 2003

I'm afraid the following change to dlls/dmusic/dmusic_misc.c revision 1.3 date: 2003/06/13 18:59:51; author: julliard; state: Exp; lines: +113 -9 Raphael Junqueira <fenix(a)club-internet.fr> - always use IDirectMusicPerformance8Impl instead of IDirectMusicPerformanceImpl (as the first inherits from the second) - implement many Loader, AudioPath and Performance8 stubs - fix the class factory - more debug traces - for now IDirectMusicLoader8::LoadObjectFromFile always returns not supported format - fix the IDirectMusicPerformance8::Init (many crashes) - implementation of IDirectMusicPerformance8InitAudio is causing the following warning: dmusic_misc.c:260: warning: passing arg 2 of `IDirectMusicPerformanceImpl_SetGraph' from incompatible pointer type Could someone more familiar with this have a look at what's wrong? Thanks, Gerald -- Gerald "Jerry" pfeifer(a)dbai.tuwien.ac.at http://www.pfeifer.com/gerald/

2 1

Re: [GDI] GetObject fails on buffer=NULL
by Alexandre Julliard June 16, 2003

June 16, 2003

Kelly Leahy <kellyleahy(a)swbell.net> writes: > @@ -60,6 +64,9 @@ > INT (*pGetObjectW)( HGDIOBJ handle, void *obj, INT count, LPVOID > buffer ); > BOOL (*pUnrealizeObject)( HGDIOBJ handle, void *obj ); > BOOL (*pDeleteObject)( HGDIOBJ handle, void *obj ); > + INT (*pGetObjectSizeA)( HGDIOBJ handle, void *obj ); > + INT (*pGetObjectSizeW)( HGDIOBJ handle, void *obj ); > + INT (*pGetObjectSize16)( HGDIOBJ handle, void *obj ); You should put the fix directly in the pGetObject[AW] functions, instead of adding new functions that don't correspond to anything in the Windows API. Even though this is an internal interface it should be kept as similar as possible to the exported interface. -- Alexandre Julliard julliard(a)winehq.com

2 1

Debugging ... ?
by Auge Mike June 16, 2003

June 16, 2003

Hi all, How can i debug wine itself? I don't want to debug the win32 application, i want to debug the whole wine while it is running? Thanx in advance, Yours, _________________________________________________________________ MSN 8 with e-mail virus protection service: 2 months FREE* http://join.msn.com/?page=features/virus

2 1

Re: [D3D] Some execute buffers rewrites + misc fixes
by Christian Costa June 15, 2003

June 15, 2003

Hi, Sorry, for a unknown reason my wine-devel delivery had been disabled. I enabled it but I've just seen your posts in the archives... > Some comments on 'small' parts... I will have to commit the patch on > my tree > to try to understand the resulting code to understand it better [:-)] >> + if ( IsEqualGUID( &IID_IDirectDrawSurface, riid ) || >> + IsEqualGUID( &IID_IDirectDrawSurface2, riid ) || >> + IsEqualGUID( &IID_IDirectDrawSurface3, riid ) ) { >> + IDirectDrawSurface7_AddRef(ICOM_INTERFACE(This->surface, >> IDirectDrawSurface7)); >> + *obp = ICOM_INTERFACE(This->surface, IDirectDrawSurface3); >> + TRACE(" Return IDirectDrawSurface3 interface %p\n", *obp); >> + return S_OK; >> + } >> + if ( IsEqualGUID( &IID_IDirectDrawSurface3, riid ) || >> + IsEqualGUID( &IID_IDirectDrawSurface7, riid ) ) { + >> IDirectDrawSurface7_AddRef(ICOM_INTERFACE(This->surface, >> IDirectDrawSurface7)); >> + *obp = ICOM_INTERFACE(This->surface, IDirectDrawSurface7); >> + TRACE(" Return IDirectDrawSurface7 interface %p\n", *obp); >> + return S_OK; >> + } > > Well, it's a bit strange to have 'IID_IDirectDrawSurface3' twice, no > [:-)] ? This seems like the Copy/Paste syndrom [:-)] >> /* We only support the BLT with DEPTH_FILL for now */ >> - if (This->ddraw_owner->d3d != NULL) { >> + if ((dwFlags & DDBLT_DEPTHFILL) && This->ddraw_owner->d3d != >> NULL) { >> if (This->ddraw_owner->d3d->current_device != NULL) { >> >> This->ddraw_owner->d3d->current_device->clear(This->ddraw_owner->d3d->current_device, >> >> 0, NULL, /* Clear the whole screen */ > > Did you add this check here because some game were actually doing a > 'normal' > blit on the ZBuffer ? Yes! From a ZBuffer surface to another... Don't remember the game though... (because it crashed in another part of wine) > What happens in this case ? When doing the standard blit, the app set the DDBLT struct pointer to NULL so without the check this simply crashes when accessing the depthfill member of the structure. > Moreover, you could also add here (which I forgot to do in my patch), > support for the 'dst locking rectangle' in case an application tries to > clear only part of the buffer (see example in the Blt overide function in > d3ddevice/mesa.c for the 'Colorfill' case). Yes this can be done as well. [:-)] > Well, I have a comment... But it's in a part of the code that will be so > rarely used that it could be completely thrown away anyway [:-)] Sure, It's barely used. [:-)] > Basically, you are doing the full projection (without doing the clipping > though) in software... And this does not go well at all with lighting. Yes, there is no lighting yet. > This is why I choose in the previous code to only do the world > transformation to > NOT impact at all lighting (and it worked for Twist AFAIK). So I am > wondering why you choose to go all the way and did not do exactly as I > did > (basically, only do the WORLD transform and set only the PROJ / VIEW one > using the D3D7 API and set the WORLD to Identity as we already did the > transform). Because the world transformation introduced the W coordinate which cannot be passed to drawing functions. But well, this coordinate should be always be 1 after the world transformation so we can ommit it. >Even better would have been to have reused fully our VertexBuffer code and > our (hacky [:-)] ) TransformVertices code. Oh! Well I forgot this hack... [;-)] Bye Christian

2 2

CVS - builtin,native load order failing
by Guy Harrison June 15, 2003

June 15, 2003

Hi Folks, FreeBSD-4.7, (yes, --prefix=/all) ... [snip] 0009:trace:module:MODULE_GetLoadOrder got standard wildcard "b,n" for "mfc42.dll" 0009:trace:heap:RtlFreeHeap (0x5c2c0000,00000002,5c2c1768): returning TRUE 0009:trace:module:load_dll Trying built-in 'C:\windows\system\mfc42.dll' 0009:err:module:BUILTIN32_dlopen failed to load .so lib for builtin mfc42.dll: Cannot open "/all/lib/wine/mfc42.dll.so" 0009:warn:module:load_dll Loading of builtin DLL C:\windows\system\mfc42.dll failed (status -1073741702). 0009:warn:module:load_dll Failed to load module 'C:\windows\system\mfc42.dll'; status=-1073741702 0009:trace:heap:RtlFreeHeap (0x5c2c0000,00000002,5c2c0c40): returning TRUE 0009:err:module:import_dll Loading module (file) MFC42.DLL (which is needed by C:\app\Paint Shop Pro\PSP.EXE) failed (error -1073741702). [snip] I'll leave it to you guys to decide if this is correct... --- wine/dlls/ntdll/loader.c.ORIGINAL Sun Jun 15 04:05:58 2003 +++ wine/dlls/ntdll/loader.c Sun Jun 15 16:30:36 2003 @@ -1084,7 +1084,7 @@ return nts; } - if (nts != STATUS_NO_SUCH_FILE) + if (nts != STATUS_PROCEDURE_NOT_FOUND) { WARN("Loading of %s DLL %s failed (status %ld).\n", filetype, filename, nts); ...or if 'nts' was wrong in the first place. -- Guy Harrison swamp-dog(a)ntlworld.com

1 0