- Wine-Devel - list.winehq.org

Re: OLE storage SetFilePointer fix
by Alexandre Julliard April 12, 2003

April 12, 2003

Andreas Mohr <andi(a)rhlx01.fht-esslingen.de> writes: > P.S.: Alexandre, I'd REALLY like you to finally put a patch status > tracking system in place. The number of people submitting patches > for the second, third, bazillionth time is astonishing (I speak > from my very own experience, too!). I really don't know how many very > valuable Wine patches got lost due to not getting applied without any > status reply whatsoever... You know, nobody prevents you from implementing a better patch tracking system, and if it makes my life easier I'll be more than happy to use it. Or if you don't want to write code, you could volunteer to manually keep track of all submitted patches and resubmit the lost ones. But of course that's a lot more work than simply complaining about it... -- Alexandre Julliard julliard(a)winehq.com

1 0

Re: PATCH: video mode changes
by Lionel Ulmer April 12, 2003

April 12, 2003

Hi, I have some comments on this patch : > + if (devmode->dmFields & DM_BITSPERPEL) > + { > + if (devmode->dmBitsPerPel != GetSystemMetrics(SM_WINE_BPP)) > + continue; > + } This may cause problems... It's not per-se a problem in your patch, but from what I know Windows applications expect to have '32' on a 24/32 display and Wine stores here '24'. So you may 'refuse' some modes that should be valid. (again, if ever you have a graphic card still supporting 24/24 mode, please tell me so that I can torture your XFree libraries to find a valid way of checking the difference between 24/24 and 24/32) > + SYSMETRICS_Set( SM_CXSCREEN, devmode->dmPelsWidth ); > + SYSMETRICS_Set( SM_CYSCREEN, devmode->dmPelsHeight ); This are actually 'User' internal functions ? In that case, why not just do the resolution change in the X11 driver and let User itself handle the sysmetric change ? I.e. call these in the 'ChangeDisplaySettingsExW' function and not in the low-level graphic driver. Now my most important grief : did you think about all the people who 1) use Desktop mode and 2) disable XVidMode in their config file ? For those, applications may now abort saying 'Vidmode not supported' (whereas it was working just fine before because we accepted all modes that are smaller than the actual screen size). So I would say that if no VidMode is present or if the User driver function does not exist in the driver, the old 'stub' API should remain as it is. Lionel -- Lionel Ulmer - http://www.bbrox.org/

2 3

Re: winedos / Improve tracing
by BiGgUn April 12, 2003

April 12, 2003

Why didn't you use TRACE instead of DPRINTF ? Stephan

1 0

Toolbar debug message
by BiGgUn April 12, 2003

April 12, 2003

Hi How can i see debug messages from toolbar.c ? Neither '--debug-msg trace+toolbar' nor '--debug-msg +toolbar' works. The '+loaddll' option claims that i use the _builtin_ version of comctl32. I do not have no more ideas :( Stephan

2 1

Wine 0.9 TODO v0.8
by Dimitrie O. Paun April 12, 2003

April 12, 2003

Hi folks, The next version of the 0.9 TODO is way past due (again!), and today is as good as any other day for a brand new release: http://www.dssd.ca/wine/Wine-0.9-TODO-0.8.html ChangeLog * Jer finished the WineHQ redesign (A1) * Brian completed the screenshot galery (A4) * Adam is our new Slackware maintainer (A6) * Andreas updated the User & Development Guide (B1,B3) * I took on the Packaging Guide and Winelib docu (B2,B4,B8) * New task: more modular doc building (B12) * I've updated and integrated Jaco's winecfg into the tree (C2) * John did more work on the DLL registration (C5) * Shachar got a working version of wineboot into the tree (C7) * I finished messing with wrc (D5) * I got winegcc to a working state (D6) * Marcus made the printing system detection dynamic (E3) * Eric improved WinHelp some more (E6) Please note that this version has been in the making for almost 4 month! Lot's of stuff changed, feedback is much appreciated. -- Dimi.

3 2

Re: PATCH: video mode changes
by Dimitrie O. Paun April 12, 2003

April 12, 2003

On April 12, 2003 12:16 am, Alex Pasadyn wrote: > + if (TRACE_ON(x11drv)) > + { > + MESSAGE("\tDM_fields=");_dump_DM_fields(devmode->dmFields);MESSAGE("\n"); > + MESSAGE(" bpp=%ld\n",devmode->dmBitsPerPel); > + MESSAGE(" width=%ld\n",devmode->dmPelsWidth); > + MESSAGE(" height=%ld\n",devmode->dmPelsHeight); > + MESSAGE(" freq=%ld\n",devmode->dmDisplayFrequency); > + } Please don't use MESSAGE. Use TRACE instead, it will do the right thing. This piece can be rewritten as: TRACE("\tDM_fields=");_dump_DM_fields(devmode->dmFields);TRACE("\n"); TRACE(" bpp=%ld\n",devmode->dmBitsPerPel); TRACE(" width=%ld\n",devmode->dmPelsWidth); TRACE(" height=%ld\n",devmode->dmPelsHeight); TRACE(" freq=%ld\n",devmode->dmDisplayFrequency); Also, it will be a lot nicer if you rewrite _dump_DM_dields to return a string, so you can write: TRACE("\tDM_fields=%s\n", debug_DM_fields(devmode->dmFields)); TRACE(" bpp=%ld\n",devmode->dmBitsPerPel); TRACE(" width=%ld\n",devmode->dmPelsWidth); TRACE(" height=%ld\n",devmode->dmPelsHeight); TRACE(" freq=%ld\n",devmode->dmDisplayFrequency); The debug_DM_fields() function would than look like so: static const char* debug_DM_fields(DWORD fields) { BOOL first = TRUE; char buf[128] = "", *p = buf; #define DEBUG_FIELD(x) if ((fields) & DM_##x) { p += sprintf(p, "%s%s", first ? "" : " ,", #x); first = FALSE; } DEBUG_FIELD(BITSPERPEL); DEBUG_FIELD(PELSWIDTH); DEBUG_FIELD(PELSHEIGHT); DEBUG_FIELD(DISPLAYFLAGS); DEBUG_FIELD(DISPLAYFREQUENCY); DEBUG_FIELD(POSITION); #undef DEBUG_FIELD return wine_dbg_sprintf("%s", buf); } -- Dimi.

2 1

Re: Wine Packaging Guide update
by Mike Hearn April 12, 2003

April 12, 2003

> NOTE: I am (was?) a strong believer in markup. I started this > work because I thought the document doesn't belong in the > Docu section, and needed updating, without being aware of > the potential problems with SGML. By the time I was done, > I was completely horrified by this SGML business. It has > it's advantages, but they come at a hefty price, so we > have to be very careful when we employ it. It works OK > for documents that don't require a lot of markup, like the > FAQ. In fact, in that case it _saves_ on formating markup. > It works nicely for documents that are essentially books > (such as the User Guide, etc.) where you can expect someone > to print out the nicely formatted .pdf/.ps. However, for > technical documents that need to be maintained often, and > are useful as a online resource that people are likely to > open in an editor, it blows chunks. Now I start to understand > Alexandre's preference for troff for man pages... Hehe, I'm glad I'm not the only one who thinks DocBook is overrated - I've been wrestling with it for the past few weeks as part of writing a shared packaging metadata spec, and an automatic documentation framework for bash libraries, and I have NEVER got it to work correctly. I've found that clean HTML with some small CSS can make a document that looks more professional (imo) and is far easier to read in a text editor, not least because emacs (and i assume vim) can apply the formatting in the tags to the text itself. I've never looked at troff, but free software seems to need a better documentation/markup system - DocBook SGML just seems far, far too complex for doing something that is essentially quite simple.

1 0

Re: PATCH: Winemaker's --wrap option
by Jeremy Newman April 12, 2003

April 12, 2003

Please stop resending this message to the list. I have gotten more than 20 copies of this message now. On Tue, 2003-04-08 at 14:59, Javier López wrote: > ----- Original Message ----- > From: "Juraj Hercek" <juraj(a)syncad.com> > To: <wine-patches(a)winehq.com> > Sent: Tuesday, April 08, 2003 4:35 AM > Subject: PATCH: Winemaker's --wrap option > > > > Changelog: > > > > Juraj Hercek <juraj(a)syncad.com> > > * tools/winemaker : > > Fixed generation of makefiles and wrapper files when "--wrap" option > > is used. > > > > <snip> -- Jeremy Newman <jnewman(a)codeweavers.com> CodeWeavers, Inc.

4 3

Re: wine/dlls make_dlls Makefile.in Makedll.rules.in
by Vincent Béron April 12, 2003

April 12, 2003

Alexandre Julliard a écrit: > ChangeSet ID: 7854 > CVSROOT: /opt/cvs-commit > Module name: wine > Changes by: julliard(a)wine.codeweavers.com 2003/04/11 19:05:28 > > Modified files: > dlls : make_dlls Makefile.in Makedll.rules.in > > Log message: > Fixed rules for auto documentation (reported by Vincent Béron). > > Patch: http://cvs.winehq.com/patch.py?id=7854 > > Old revision New revision Changes Path > 1.23 1.24 +19 -0 wine/dlls/make_dlls > 1.172 1.173 +19 -0 wine/dlls/Makefile.in > 1.52 1.53 +4 -13 wine/dlls/Makedll.rules.in Not good. Won't work correctly for dlls containing subdirs with a Makefile (msacm, etc.). In those cases, only the first level directory will be processed, not the subdirs. Vincent

2 1

Provide USB support in wine ?
by Sylvain Petreolle April 11, 2003

April 11, 2003

"Accidentally", when updating my RH system, I discovered that libusb is a library that provides user access to the USB devices, regardless of the OS. It appears we could use it in wine, since : - its license compatible (LGPL) - it supports some OSes on which wine is built. Like : Linux FreeBSD NetBSD, OpenBSD (dont know if this works now, referring to http://www.winehq.com/?page=faq#Under_what_hardware_platforms_and_Wine) Darwin (never heard of it for Wine ??) MacOS X (recent Qemu work makes this possible) Could such a support be possible/doable ? ===== Sylvain Petreolle (spetreolle at users dot sourceforge dot net) ICQ #170597259 No more War ! "What if tomorrow the War could be over ?" Morpheus, in "Reloaded". For the Law of Oil and Fire, Im an European that lives in France. For all my Brothers and friends, Im a human living on Earth. ___________________________________________________________ Do You Yahoo!? -- Une adresse @yahoo.fr gratuite et en français ! Yahoo! Mail : http://fr.mail.yahoo.com

5 4