- Wine-Devel - list.winehq.org

suspended threads acquiring synchronization objects
by Peter Hunnisett Feb. 17, 2003

Feb. 17, 2003

Howdy, we've discovered that windows seems to not allow suspended threads to acquire synchronization objects, which make really really good sense, while wine does. I've attached a simple test case, the code for the test case and a ReWind licensed patch for the problem. Would people have a look at the patch and let me know if it's the best way to fix it, or if I've missed anything? (other than the attachements on the first go at this)? Thanks, Peter peter(a)transgaming.com Index: server/thread.c =================================================================== RCS file: /home/wine/wine/server/thread.c,v retrieving revision 1.87 diff -u -r1.87 thread.c --- server/thread.c 1 Feb 2003 01:38:40 -0000 1.87 +++ server/thread.c 13 Feb 2003 21:59:25 -0000 @@ -401,6 +401,9 @@ struct thread_wait *wait = thread->wait; struct wait_queue_entry *entry = wait->queues; + /* Suspended threads may not acquire locks */ + if( thread->suspend > 0 ) return -1; + assert( wait ); if (wait->flags & SELECT_ALL) { @@ -938,7 +941,10 @@ if ((thread = get_thread_from_handle( req->handle, THREAD_SUSPEND_RESUME ))) { if (thread->state == TERMINATED) set_error( STATUS_ACCESS_DENIED ); - else reply->count = resume_thread( thread ); + else { + reply->count = resume_thread( thread ); + if( reply->count == 1 ) wake_thread( thread ); + } release_object( thread ); } }

2 1

Problem with recent builds under RH8.0
by David D. Hagood Feb. 17, 2003

Feb. 17, 2003

Ever since upgrading to RH8.0, I've been getting the following errors when building Wine - even with a fresh CVS pull: device.o: In function `DrawPrimitiveI': /usr/src/wine/dlls/d3d8/device.c:392: undefined reference to `glMultiTexCoord2f'/usr/src/wine/dlls/d3d8/device.c:416: undefined reference to `glMultiTexCoord3f'/usr/src/wine/dlls/d3d8/device.c:516: undefined reference to `glMultiTexCoord2f'/usr/src/wine/dlls/d3d8/device.c:535: undefined reference to `glMultiTexCoord3f'/usr/src/wine/dlls/d3d8/device.c:730: undefined reference to `glClientActiveTexture' /usr/src/wine/dlls/d3d8/device.c:764: undefined reference to `glMultiTexCoord4f'device.o: In function `setupTextureStates': /usr/src/wine/dlls/d3d8/device.c:981: undefined reference to `glActiveTexture' device.o: In function `IDirect3DDevice8Impl_SetRenderState': /usr/src/wine/dlls/d3d8/device.c:2548: undefined reference to `glActiveTexture' device.o: In function `IDirect3DDevice8Impl_SetTexture': /usr/src/wine/dlls/d3d8/device.c:2977: undefined reference to `glActiveTexture' device.o: In function `IDirect3DDevice8Impl_SetTextureStageState': /usr/src/wine/dlls/d3d8/device.c:3156: undefined reference to `glActiveTexture' collect2: ld returned 1 exit status make[2]: *** [d3d8.dll.so] Error 1 make[2]: Leaving directory `/usr/src/wine/dlls/d3d8' If I disable the build of the D3D system, Wine builds and runs.

7 9

Re: PATCH: to implement toc and position shadowing in cdrom
by Eric Pouech Feb. 17, 2003

Feb. 17, 2003

Waldeck Schutzer wrote: > Hi Eric, > > I followed your suggestions which greatly simplified the code. Thank > you. Now, since we are using the fixed-size windows TOC, memory > allocation is no longer an issue. Some of the sanity checks over dev > were removed. I also made an attemt at making the code more portable and > also fixed the BSD code. However, I couldn't find a seek function in the > BSD cd driver, so I used the play function instead. Is there a BSD > expert out there who could check this out? On the mcicda side, I > factored out that piece of code you suggested but because my box is > presently busy on a week-long calculation I couldn't run any tests on > Windows. the code in cdrom.diff is still wrong. you cannot use the dev variable in most of the inner functions as an index in the cdrom_cache array. the index you need is in fact the low word of client-id in CDROM_DeviceIoControl I'd suggest that you change CDROM_Open to return a pointer to the relevant cdrom_cache structure instead of dev mcicda.diff looks better now A+ -- Eric Pouech

1 0

Fun with MSDE
by Dan Kegel Feb. 17, 2003

Feb. 17, 2003

The "free" ASP.NET IDE from http://www.asp.net, Web Matrix, uses MSDE (the embedded SQL server that fed the Slammer worm). MSDE can be "freely" downloaded from http://www.asp.net/msde/ Out of curiosity, I tried installing MSDE on cvs wine today. A few notes: The installer is an Installshield Package-for-the-web wrapper around an MSI installer. A couple fixmes show up while displaying the initial EULA window: fixme:win:SetWindowTextA cannot set text "" of other process window (nil) fixme:propsheet:PROPSHEET_CollectPageInfo Could not load resource #0000? The EULA dialog box (which uses richedit) doesn't wrap lines on wine like it does on windows. (Its title is wrong, too; not suprising given the fixme.) On WinXP, Win98 and Wine, the package-for-the-web installer doesn't stat the real installer after it unpacks. This is normal. (Oddly, it does a ShellExecute of the nonsensical executable [Param_Launch], but that's just a bug in their InstallShield script, I think.) To continue on, one then runs c:/sql2ksp3/MSDE/setup.exe by hand. On Win98, it put up a dialog box or two, but aborted, saying "A strong SA password is required for security reasons... Setup will now exit." On Wine, it terminated silently, as I didn't have MSI.DLL and friends installed. Copying in those files (roughly, MSI*.* from c:/windows/system) got me further Running with winver = winxp, it failed with a dialog box saying Fatal SQLUNIRL.DLL Initialization Error File: ..\src\procaddr.c, line: 422 NDDEAPI.DLL Could not be loaded, NT Error 2 Running with winver = win98, it failed with a dialog box saying Microsoft SQL Server Desktop Engine Setup requires Internet Explorer version 5.0.2314.0 or above. OK, that's enough fun for me for today. I was just curious to see how far the install would go, I'm not interested in actually using MSDE. - Dan -- Dan Kegel http://www.kegel.com http://counter.li.org/cgi-bin/runscript/display-person.cgi?user=78045

1 0

Re: wine/ win32/device.c server/trace.c server/tim ...
by Rein Klazes Feb. 17, 2003

Feb. 17, 2003

On Fri, 14 Feb 2003 14:27:11 -0600, you wrote: > Log message: > Changed fd operations to take a struct fd instead of a struct object. > Removed get_file_info function from object operations. > Added get_device_id request to avoid abusing get_file_info. > > Patch: http://cvs.winehq.com/patch.py?id=7246 This breaks newsbin. From the trace: | 00000009:Call kernel32.CreateFileA(40732b08 "H:\\binw\\nbpro\\LibFilter.dll",80000000,00000001,00000000,00000003,00000080,00000000) ret=100598b5 | 00000009:Ret kernel32.CreateFileA() retval=00000048 ret=100598b5 | 00000009:Call kernel32.CreateFileMappingA(00000048,00000000,00000002,00000000,00000000,00000000) ret=100598d8 | 00000009:Ret kernel32.CreateFileMappingA() retval=00000000 ret=100598d8 | 00000009:Call kernel32.LoadLibraryA(407328d8 "user32") ret=1005a038 | 00000009:Ret kernel32.LoadLibraryA() retval=40810000 ret=1005a038 | 00000009:Call kernel32.GetProcAddress(40810000,407328d8 "MessageBoxA") ret=1005a054 | 00000009:Ret kernel32.GetProcAddress() retval=408b385c ret=1005a054 | 00000009:Call user32.MessageBoxA(00000000,407329f4 "Unable to read this file.",40732b08 "H:\\binw\\nbpro\\LibFilter.dll",00002010) ret=1005a063 Any suggestions? Rein. -- Rein Klazes rklazes(a)xs4all.nl

6 12

Re: Add no html to patch style notes
by Dimitrie O. Paun Feb. 17, 2003

Feb. 17, 2003

On Mon, 17 Feb 2003, Tony Lambregts wrote: > + No html please. The reason for this is that any mail program > + can handle text. I would reformulate this: No HTML mail please. It is considered bad netiquet as it uglifies the message, and is not viewable by many of the subscribers. -- Dimi.

1 0

Re: Fix small bug in RtlFindMostSignificantBit (Attachment as Mime Base64) [Virus checked]
by Dan Kegel Feb. 17, 2003

Feb. 17, 2003

thomas.mertes(a)t-mobile.at wrote: > This time I configured Lotus Notes to create the attachment > as Mime Base64 conversion. (The attachment in the other Mail > was in Mime Quoted-Printable format). Please tell me > which attachment format is most useable. They were both base64, from what I could tell. Suggestion: turn off HTML email when posting to the wine mailing lists. Plain text is much easier for many people to read. Minor nit: most people, when they attach patches, use a filename that ends in .patch. - Dan -- Dan Kegel http://www.kegel.com http://counter.li.org/cgi-bin/runscript/display-person.cgi?user=78045

3 2

Re: Status of defered debugmessages
by Eric Pouech Feb. 17, 2003

Feb. 17, 2003

Uwe Bonnes wrote: > Hallo, > > in c.e.w.e, the subject of starting the debugmessages defereed appeared > again. A google search brings up a not applied patch from 2001. > > What's the status? > With multi 100MByte logs, it would be usefull. > > Bye Alexandre doesn't like the way of using key combinations (which could be useful to a given program) if you want to do it, winedbg just does the job A+ -- Eric Pouech

2 3

Re: Looking for information on implemented API's in wine
by Rolf Kalbermatter Feb. 17, 2003

Feb. 17, 2003

David Miller <compsol(a)ptd.net> wrote: >I am ready to begin work on the actual database aspect of cross referencing >the windows dlls. As part of the database I would like to include the >status of a given API in wine so it will be possible to do things like >query for all unimplemented APIs in a given dll. The first questions I >have are whether or not I can depend on the spec files to give a complete >list, and can someone either point me to documentation on the spec files or >explain everything I need to know in order to determine the status of APIs >defined there? I'm sure this will not really be enough, although it is at least a start. There are a lot of functions which are implemented according to the spec file but only consists of an empty function body with a FIXME, or is only partly implemented with again a FIXME somewhere in the function. Rolf Kalbermatter

7 10

Re: Allow native dlls and debugmsg in runtest
by Eric Pouech Feb. 16, 2003

Feb. 16, 2003

Uwe Bonnes wrote: > Changelog > tools/runtest > Allow the use of native dlls and debugmessages > (Includes " Allow native dlls in runtest") do we really need this in the scripts ? couldn't we just use the WINEOPTIONS from the command line ? WINEOPTIONS="-debugmsg +foo" runtest instead of what you propose runtest -d "-debugmsg +foo" just my 2 cents A+ -- Eric Pouech

3 4