- Wine-Devel - list.winehq.org

Wine, Mozilla & IE ?
by Juan Rey Saura Jan. 14, 2003

Jan. 14, 2003

Hi ! I've read in the list there is a project about compiling Mozilla under Wine, I think it would be great. Several parts of wine need an IWebBrowser implemtation; CHM support, some applications... One implementation based on the khtml is in the works, but Mozilla does implement it yet ( see http://www.iol.ie/~locka/mozilla/mozilla.htm ). Could Mozilla, under Wine or maybe native version, be used as a replacement for the IE IWebBrowser implementation?

10 18

WineMine wrc error
by John Westerman Jan. 14, 2003

Jan. 14, 2003

Hi, I seem to have a bit of trouble building the winemine sample. When it gets to the wrc stage it just says: make: *** [rsrc.res] Error 1 Any ideas?

1 0

Re: distcc and wine
by Martin Pool Jan. 14, 2003

Jan. 14, 2003

On 8 Jan 2003, Paul Millar <paulm(a)astro.gla.ac.uk> wrote: > Hi Martin, > > On a similar note, I've been investigating OpenMOSIX on and off (mostly > off) for doing distributed compiling. In general, I've found it not > particularly stable (although its improving) and the performance not > particularly great -- although I've not had time to investigate the causes > of these problems. Besides, compiling code is quite a tricky task for it > to schedule/migrate. I haven't tried it myself but I would have expected the short, intense jobs generated by compilation to be a problem. > A reduction in compilation time by a factor of 2.6 (for three machines) > isn't bad at all! > > If you have the time, could you repeat this with different values for the > -j option? Timing how long it takes with -j2 (and perhaps -j3 and -j4) > would be interesting. Yes, I've been meaning to add that to the benchmark tool. I'll let you know. > Also, repeat the compilation several times for each value of -j and taking > the mean and standard deviation would be interesting too. In informal measurements it seems to be quite reproducible. The sd is typically only a few percent of the overall time. But that might be an interesting option to add too. -- Martin

2 2

Re: prevent dereferencing null
by Dimitrie O. Paun Jan. 14, 2003

Jan. 14, 2003

On January 9, 2003 07:08 pm, Bill Medland wrote: > + if (!tpinfo->chanbuf) { > + ERR("tpinfo has no Rpc Channel Buffer\n"); > + return 0; > + } Is this expected behaviour? If so, there's no need for the ERR msg. If not, there's no need for the test, we need to fix the root cause... -- Dimi.

3 4

patch for "GetFileTitleW: illegal call to GetFileTitleA" 2ed
by liu spider Jan. 14, 2003

Jan. 14, 2003

Thanks to Dmitry Timoshkov. This patch is the second edition, adopted his suggestions. ChangeLog: -dlls/commdlg/filetitle.c implemented GetFileTitleW GetFileTitleA now is a call to GetFileTitleW (The patch seems to be ignored without any comments. Could anyone give some clues on how to improve this patch? thanks.) liuspider __________________________________________________ Do you Yahoo!? Yahoo! Mail Plus - Powerful. Affordable. Sign up now. http://mailplus.yahoo.com Index: dlls/commdlg/filetitle.c =================================================================== RCS file: /home/wine/wine/dlls/commdlg/filetitle.c,v retrieving revision 1.12 diff -u -r1.12 filetitle.c --- dlls/commdlg/filetitle.c 31 May 2002 23:25:45 -0000 1.12 +++ dlls/commdlg/filetitle.c 12 Jan 2003 07:09:56 -0000 @@ -3,6 +3,7 @@ * * Copyright 1994 Martin Ayotte * Copyright 1996 Albrecht Kleine + * Copyright 2003 liuspider * * This library is free software; you can redistribute it and/or * modify it under the terms of the GNU Lesser General Public @@ -24,10 +25,10 @@ #include "winbase.h" #include "winnls.h" #include "commdlg.h" +#include "wine/unicode.h" +#include "winternl.h" #include "wine/debug.h" -#include "heap.h" /* Has to go */ - WINE_DEFAULT_DEBUG_CHANNEL(commdlg); #include "cdlg.h" @@ -38,19 +39,39 @@ */ short WINAPI GetFileTitleA(LPCSTR lpFile, LPSTR lpTitle, UINT cbBuf) { - int i, len; + int ret; + UNICODE_STRING strWFile, strWTitle; + RtlCreateUnicodeStringFromAsciiz(&strWFile, lpFile); + RtlCreateUnicodeStringFromAsciiz(&strWTitle,lpTitle); + ret = GetFileTitleW(strWFile.Buffer, strWTitle.Buffer, cbBuf * sizeof(WCHAR)); + if (!ret){ + WideCharToMultiByte( CP_ACP, 0, strWTitle.Buffer, -1, lpTitle, cbBuf, NULL, NULL ); + } + RtlFreeUnicodeString( &strWFile ); + RtlFreeUnicodeString( &strWTitle ); + return ret; +} + +/*********************************************************************** + * GetFileTitleW (COMDLG32.@) + * + */ +short WINAPI GetFileTitleW(LPCWSTR lpFile, LPWSTR lpTitle, UINT cbBuf) +{ + int i, len; + WCHAR brkpoint[] = {'*','[',']'}; TRACE("(%p %p %d); \n", lpFile, lpTitle, cbBuf); if(lpFile == NULL || lpTitle == NULL) return -1; - len = strlen(lpFile); + len = strlenW(lpFile); if (len == 0) return -1; - if(strpbrk(lpFile, "*[]")) + if(strpbrkW(lpFile, brkpoint)) return -1; len--; @@ -70,34 +91,14 @@ if(i == -1) i++; - TRACE("---> '%s' \n", &lpFile[i]); + TRACE("---> '%s' \n", debugstr_w(&lpFile[i])); - len = strlen(lpFile+i)+1; + len = strlenW(lpFile+i)+1; if(cbBuf < len) return len; - strncpy(lpTitle, &lpFile[i], len); + strncpyW(lpTitle, &lpFile[i], len); return 0; -} - - -/*********************************************************************** - * GetFileTitleW (COMDLG32.@) - * - */ -short WINAPI GetFileTitleW(LPCWSTR lpFile, LPWSTR lpTitle, UINT cbBuf) -{ - LPSTR file = HEAP_strdupWtoA(GetProcessHeap(), 0, lpFile); /* Has to go */ - LPSTR title = HeapAlloc(GetProcessHeap(), 0, cbBuf); - short ret; - - ret = GetFileTitleA(file, title, cbBuf); - - if (cbBuf > 0 && !MultiByteToWideChar( CP_ACP, 0, title, -1, lpTitle, cbBuf )) - lpTitle[cbBuf-1] = 0; - HeapFree(GetProcessHeap(), 0, file); - HeapFree(GetProcessHeap(), 0, title); - return ret; }

1 0

Re: tests for GetPrinterDriverDirectoryA
by Francois Gouget Jan. 14, 2003

Jan. 14, 2003

On Mon, 13 Jan 2003, Stefan Leichter wrote: > Am Montag 13 Januar 2003 18:42 schrieben Sie: > > On Sun, 12 Jan 2003, Stefan Leichter wrote: > > > Am Sonntag 12 Januar 2003 02:43 schrieben Sie: [...] > > > > However it fails on Wine: > > > > info.c:25: Test failed: pcbNeeded set to 18 instead of 19 > > > > info.c:30: Test failed: pcbNeeded set to 18 instead of 19 > > > > info.c:34: Test failed: expected result == 0, got 18 > > > > info.c:35: Test failed: pcbNeeded set to 18 instead of 19 > > > > info.c:48: Test failed: expected result != 0, got 0 > > > > info.c:71: Test failed: expected result != 0, got 0 > > after this patch wine will fix the errors listed above Yep, that works. -- Francois Gouget fgouget(a)free.fr http://fgouget.free.fr/ Cahn's Axiom: When all else fails, read the instructions.

1 0

Re: Help with /?? stuff
by Alberto Massari Jan. 13, 2003

Jan. 13, 2003

At 20.24 10/01/2003 +0200, Shachar Shemesh wrote: >Alberto Massari wrote: > >[...] >> >>BTW, do you need any help on this task? > >"Need" is a strong term. I can complete the task on my own, but your help >will be most welcome (in other words, if there is another aread of Wine >that needs your attention and noone seems to be working on, that would be >a better use of everyone's time). If you want to help with wineboot, I >think the best place to start is with the "win.ini" processing, and then >to port Andy's function to run whole "run" keys to the new prog. > >If you do decide to help with wineboot, please email me in private when >starting to work on each activity, to prevent "competition" on writing >stuff in. Unfortunately I'm currently fully booked on trying to fix the bugs that prevent ole32 and shell32 from working with IE6; but installing IE6 needs a working wineboot, so, whenever I succeed in the first task, I will start working on wineboot. Alberto

3 11

what does __leave do?
by Greg Turner Jan. 13, 2003

Jan. 13, 2003

Could someone run the following code under a microsoft compiler for me, and let me know the result? main() { int x = 0; __try { x = 1; __leave; } __finally { x = 2; } printf("x was %d\n", x); } thanks, -- gmt "If everyone is thinking alike then somebody isn't thinking." --George S. Patton

2 2

Sysparams registry tests
by Francois Gouget Jan. 13, 2003

Jan. 13, 2003

Here are the failing user32/sysparams registry tests on Win95, Win98 and NT4. sysparams.c:676:testing SPI_{GET,SET}MENUDROPALIGNMENT sysparams.c:161: Test failed: Wrong value in registry: subKey=Software\Microsoft\Windows NT\CurrentVersion\Windows, valName=MenuDropAlignment, testValue=1, value= sysparams.c:161: Test failed: Wrong value in registry: subKey=Software\Microsoft\Windows NT\CurrentVersion\Windows, valName=MenuDropAlignment, testValue=0, value= -> on Win9x this is in Control Panel\desktop sysparams.c:711:testing SPI_{GET,SET}DOUBLECLKWIDTH sysparams.c:161: Test failed: Wrong value in registry: subKey=Control Panel\Mouse, valName=DoubleClickWidth, testValue=0, value= sysparams.c:161: Test failed: Wrong value in registry: subKey=Control Panel\Mouse, valName=DoubleClickWidth, testValue=10000, value= -> on Win9x this is in Control Panel\desktop sysparams.c:741:testing SPI_{GET,SET}DOUBLECLKHEIGHT sysparams.c:161: Test failed: Wrong value in registry: subKey=Control Panel\Mouse, valName=DoubleClickHeight, testValue=0, value= sysparams.c:161: Test failed: Wrong value in registry: subKey=Control Panel\Mouse, valName=DoubleClickHeight, testValue=10000, value= -> on Win9x this is in Control Panel\desktop sysparams.c:644:testing SPI_{GET,SET}ICONTITLEWRAP sysparams.c:161: Test failed: Wrong value in registry: subKey=Control Panel\Desktop\WindowMetrics, valName=IconTitleWrap, testValue=1, value= sysparams.c:161: Test failed: Wrong value in registry: subKey=Control Panel\Desktop\WindowMetrics, valName=IconTitleWrap, testValue=0, value= -> on NT4 this is in Control Panel\Desktop Notice how this is not even a clean separation between NT OSes and Win9x ones: Win9x aligns with XP for SPI_SETICONTITLEWRAP but not NT4, while for the other settings it's the opposite. Anyway, is it worth keeping these tests? That is making sure that SPI_xxx stores the setting in the registry key we expect? Do we know of applications that depend on these specific settings? If not then I will just submit a patch to remove these checks. Or maybe Wine should store these settings in all known locations? Note that I already removed these tests for SPI_ICONHORIZONTALSPACING and SPI_ICONVERTICALSPACING because for these Windows does not even always store the same value: sometimes it's the value we provide but most of the time that value seems to be multiplied by -15 (resulting in the negative number!). And the -15 changes to anothe value if you change the icon size. -- Francois Gouget fgouget(a)free.fr http://fgouget.free.fr/ tcA thgirypoC muinelliM latigiD eht detaloiv tsuj evah uoY

1 0

Re: user32.SendMessageCallback
by Alexandre Julliard Jan. 13, 2003

Jan. 13, 2003

"Robert Shearman" <R.J.Shearman(a)warwick.ac.uk> writes: > ChangeLog: > - Fix SendMessageCallback so that it works in all cases now You can't do it that way, the callback has to be called in the context of the thread that sent the message. -- Alexandre Julliard julliard(a)winehq.com

2 1