- Wine-Devel - list.winehq.org

Re: Window menu
by Dmitry Timoshkov Jan. 8, 2003

Jan. 8, 2003

"Duane Clark" <dclark(a)akamail.com> wrote: > Changelog: > A window with a WS_EX_APPWINDOW extended style can also > get a menu. [skipped] > /* Set the window menu */ > > - if ((wndPtr->dwStyle & (WS_CAPTION | WS_CHILD)) == WS_CAPTION ) > + if ((wndPtr->dwStyle & WS_CAPTION || wndPtr->dwExStyle & WS_EX_APPWINDOW) > + && !( wndPtr->dwStyle & WS_CHILD) ) Sorry for the late response, but this doesn't look right to me. First of all check for WS_CAPTION should be if ((dwStyle & WS_CAPTION) == WS_CAPTION) because WS_CAPTION is a two bit style. Next, apparently menu can be assigned only for a window that has a caption and not is a child. If for some reason in your case a window has no WS_CAPTION style set (even after all style corrections) then it's a bug in Wine and it should be found and fixed. I would suggest to write a conformance test for this, which will create windows with various styles, check whether they have a caption (by comparing client and window rectangles), then try to set a menu for a window. -- Dmitry.

2 2

Possible Proformence Costs on Non-debug Builds
by Nathan Boyle Jan. 8, 2003

Jan. 8, 2003

Why are there 20364 debug messages that get compiled into the code even w/ debug messages turned off? They don't actually do anything when you configure w/ --disable-debug, but shouldn't all those "if"s slow down execution incredibly? Why arn't the "if"s implemented in preprocessor directives? Please CC any replys to boylenate316(a)aol.com, i am using my junk-mail account to send this b/c i cant send e-mails from the AOL website on Linux[IE specific tags probably], and waol.exe insists that i need it to install the dun/ras files and reboot whenever i try to run it under wine. NOTE: i just updated my Wine code from CVS and compiled about an hour ago.. just another WindBlows X-tra P-ricey hater who misses WfW 3.11.... -- _______________________________________________ Get your free email from http://mymail.swirvemail.com

2 1

Re: Re: DirectSound and i810 soundcards
by chrismorgan＠rcn.com Jan. 8, 2003

Jan. 8, 2003

> Ove Kaaven wrote: > > On Mon, 6 Jan 2003, Francois Gouget wrote: > [...] > > Note that test results from Windows XP won't be very useful for this; > > under XP, dsound primary buffers doesn't map directly to the sound > > hardware any more, according to MSDN. If you create and use a dsound > > primary buffer under XP, it will just become another stream sent to XP's > > kernel-mode sound mixer, before it gets to the hardware. > > Ah that probably explains some results I've seen then. Thanks. > > > >>I don't know why the mmap fails. I would tend to think this is a > >>limitation or bug of the Alsa driver since it works with the OSS driver. > > > > ALSA has resampling features. If you open the sound device at e.g. 11kHz, > > then ALSA's OSS emulation will, instead of telling you that the chip is > > 48kHz, install a resampling filter to convert from 11kHz to the hardware's > > required 48kHz. Unfortunately, that filter gets in the way of direct > > access, making an mmap fail. (In WineX we test mmap on a range of common > > frequencies to work around this.) > > Ok. That makes sense. That's sort of the opposite direction of the > DirectSound patch I sent to wine-patches (and which just got applied). > The annoying thing is that the mmap, the device format bubbling up and > the CreateThread are all in different places :-( > Oh well, I'll try to come up with something. It seems hacking things to > make mmap succeeds is the simplest approach. But what's the best approach? > Why not just stop trying to mmap the device? XP can apparently get away without it... > 1. if we tweak things so that the mmap call succeeds then Wine will be > making the resampling. And Wine is not really good at that and tends to > introduce audible distortion. It probably doesn't matter if you start > from an 8kHz signal but if you're playing a 44kHz sound... > > 2. if we tweak things so that the CreateThread is done, then the > resampling will be done by Alsa (or whichever back-end) which will > presumably do it much better than us. howeve rin that case we have to > make the almost never used case work and I'm not sure how well it would > work anyway (I'm concerned about skips/cracks/pops). > > To make 1. cleaner maybe we should have a Wine-specific message that > asks the backend to return the formats supported by the device, i.e. for > OSS returning an exact translation of the value returned by > SNDCTL_DSP_GETFMTS. > Then if our msacm gets improved to the Jack sound format conversion > library we're golden... (what's the status of this btw?) > I think we should stick with what we currently have where we try to open the device with the app requested audio output format and then fallback to having the msacm do the conversion to a supported format if necessary. Why not use the existing waveOutGetDevCaps() message to get the device capabilities? Afaik the library is mostly done. I haven't taken any look at how to integrate it into wine yet though, been quite busy with other jack audio related work lately. I was planning on working on this though. Chris

2 1

Sound driver autodetection
by chrismorgan＠rcn.com Jan. 7, 2003

Jan. 7, 2003

I've been thinking about implementing sound driver autodetection in wine. On startup wine would try to open a device with each of the drivers until one was opened successfully. This seems pretty simple to implement, I was wondering if there was a dynamic way of detecting the list of drivers to try or whether this list would have to be hardcoded in a c file. Eric, any hints? Chris

2 1

Re: Graphic cards for Wine [/Linux;)]
by Sylvain Petreolle Jan. 7, 2003

Jan. 7, 2003

--- brett holcomb <brettholcomb(a)charter.net> a écrit : > What version of Nvidia card and drivers are you running? > I've found my GF3 to be solid and stable. Tried with a Geforce 2, Geforce 2 MX and Geforce 4 MX from Sparkle. Drivers : always with the latest binariesthat be found on NVidia site. Yes I know they are XFree86 opensource drivers but they are slow for 3D. ===== Sylvain Petreolle spetreolle(a)users.sourceforge.net Fight against Spam ! http://www.euro.cauce.org/en/index.html ICQ #170597259 "Don't think you are. Know you are." Morpheus in Matrix, chapter 15. ___________________________________________________________ Do You Yahoo!? -- Une adresse @yahoo.fr gratuite et en français ! Yahoo! Mail : http://fr.mail.yahoo.com

1 0

Agent File Access
by Oliver Sampson Jan. 7, 2003

Jan. 7, 2003

Howdy, I'd like to (finally) get around to fixing something that Agent does that's really annoying. When launching programs, it sends a string with backslashes for directory markers instead of forward slashes. Anyhow, if I'm going to start looking at the problem, could someone point me at the right file to begin looking at? I think I asked this some time ago, but I can't seem to find the email. (I remember looking at the code, and since it was a *real* simple fix, it sorta just fell by the way side.) Thanks, ==================================================== Oliver Sampson olsam(a)quickaudio.com http://www.oliversampson.com

2 6

Graphic cards for Wine [/Linux;)]
by Sylvain Petreolle Jan. 7, 2003

Jan. 7, 2003

Due to the problems encountered with NVidia drivers running Wine, I want to change my video card to another without NVidia chipset. Could someone who is using fast 3D (who said 'gamer' ? :)) give me some tips to buy another one that have free drivers ? PS : As shown in $SUBJ, wine isnt the only thing that pushes me to change my card. I get crashes in another software like MPlayer video player and X itself. My PC was online one week online without X and guess what ? no crashes :) ===== Sylvain Petreolle spetreolle(a)users.sourceforge.net Fight against Spam ! http://www.euro.cauce.org/en/index.html ICQ #170597259 "Don't think you are. Know you are." Morpheus in Matrix, chapter 15. ___________________________________________________________ Do You Yahoo!? -- Une adresse @yahoo.fr gratuite et en français ! Yahoo! Mail : http://fr.mail.yahoo.com

1 0

Conformance tests status update
by Francois Gouget Jan. 7, 2003

Jan. 7, 2003

Yesterday I compiled and uploaded new Windows binaries for the conformance tests. The new binaries contain a ton of fixes, in particular for the following tests but there are more: kernel/alloc kernel/format_msg kernel/path kernel/process msvcrt/scanf netapi32/access netapi32/apibuf netapi32/wksta You can find them at the following URL: http://fgouget.free.fr/wine/tests-en.shtml That page will also tell you when the Windows binaries were last updated. However now I need *help* to fix the following test failures. I.e these tests fail and I don't know how to fix them so a patch, or hints as to what needs to be done would be greatly appreciated: (well, the alternative is that I could also just remove them) * kernel32/alloc On Win9x fails with: alloc.c:208: Test failed: GlobalReAlloc failed to convert FIXED to MOVEABLE: error=87 alloc.c:213: Test failed: Converting from FIXED to MOVEABLE didn't REALLY work alloc.c:238: Test failed: Discarded memory we shouldn't have alloc.c:239: Test failed: GlobalUnlock Failed. * kernel32/file On Win9x fails with: file.c:609: Test failed: WriteFile error 183 file.c:610: Test failed: expected number of bytes written 0 file.c:611:Current offset = 0100 file.c:612: Test failed: expected file offset 21 file.c:617: Test failed: WriteFile error 87 file.c:618: Test failed: expected number of bytes written 0 file.c:620: Test failed: expected file offset 517 file.c:634: Test failed: ReadFile error 0 file.c:635: Test failed: expected number of bytes read 0 file.c:636:Current offset = 0000 file.c:637: Test failed: expected file offset 21 file.c:639: Test failed: pattern match failed * kernel32/locale Fails on Win98 with: locale.c:499: Test failed: GetDateFormat check DATE_YEARMONTH with null format expected ERROR_INVALID_FLAGS got return of '10' and error of '0' * netapi32/access Fails on NT4: access.c:77: Test failed: NetUserGetInfo: rc=2221 then crashes And on Win 2000/XP with: access.c:95: Test failed: Bad Network Path * user32/sysparams Messes up the user's environment on Win9x and has lots of failures. * user32/win Crashes on Win9x when calling SetParent(desktop, hwndMain) There are more tests that fail and I would certainly appreciate help with these too (would free me lots of time to do other things on Wine). Otherwise I will have a crack at them and see what I can do. -- Francois Gouget fgouget(a)free.fr http://fgouget.free.fr/ Good judgment comes from experience, and experience comes from bad judgment -- Barry LePatner

4 4

Wine Fun v0.3
by Dimitrie O. Paun Jan. 7, 2003

Jan. 7, 2003

Hi folks, I haven't released a version of the Fun page in a loooong time, and a _lot_ of things changed. In fact, I would say at least 90% of it has changed since last time. Here it is for your viewing pleasure: http://www.dssd.ca/wine/Wine-Fun-0.3.html Check it out, maybe you'll find something that tickles your fancy! ;) -- Dimi.

3 5

Re: wineboot wininit patch 1
by Andreas Mohr Jan. 7, 2003

Jan. 7, 2003

On Tue, Jan 07, 2003 at 08:19:19PM +0200, Shachar Shemesh wrote: > Changelog > Shachar Shemesh <winecode(a)sun.consumer.org.il> > > programs/wineboot/wineboot.c > > * Added a print to indicate to user that installation is done. Hmm, I'm not sure whether that's an entirely good idea. It's probably more flexible to have the script invoking wineboot print such a message instead. (some people might want to have "hidden" execution of wineboot configured) But OTOH you could also solve that issue by configuring wineboot to be silent in such a case, so maybe having such a message is a good thing after all. Andreas Mohr

2 1