- Wine-Devel - list.winehq.org

regression with CFLAGS=-g
by Shachar Shemesh Jan. 2, 2003

Jan. 2, 2003

Hi, There is a regression when compiling wine with CFLAGS=-g. The latest CVS throws an unhandled exception when exiting notepad. When notepad is compiled with CFLAGS=-g -O2 (the defaults), there is no crash even if the rest of the libraries are compiled with -g. This also happens on Wine 20021216. Any idea? Shachar

1 0

Re: Fixing include quotes (was: Re: conformance test for ShellExecute)
by Dan Kegel Jan. 2, 2003

Jan. 2, 2003

Dimitrie O. Paun wrote: > Bottom line, since the change is free (the work is done by a script), > and there is little chance of conflicts with other patches (it touches > only the include statements), I think it's worth doing now. There is one downside: it may make old patches harder to apply, and it may make it harder to sync with other trees (e.g. rewind). On the other hand, encouraging people to use the tool to tidy up any files they're working on makes patches harder to read, as it mixes formatting changes with real changes. Six of one, half dozen of another... - Dan -- Dan Kegel Linux User #78045 http://www.kegel.com

3 3

Re: Make RECT === RECTL, fix compile warnings, use uniform format
by Dimitrie O. Paun Jan. 2, 2003

Jan. 2, 2003

On December 28, 2002 04:10 pm, Dan Kegel wrote: > Decided to leave debugrect for later, too much of a pain for now. > This patch just uses a uniform format for RECTs where possible. > It reorders three or so TRACEs that had the coordinates in > nonstandard order, too. Patch against current CVS attached. > Should compile fine, but I haven't tested it (so do look it over :-) Cool stuff. Can you please turn this thing: Index: dlls/comctl32/datetime.c =================================================================== RCS file: /home/wine/wine/dlls/comctl32/datetime.c,v retrieving revision 1.34 diff -d -u -r1.34 datetime.c --- dlls/comctl32/datetime.c 2 Dec 2002 18:11:00 -0000 1.34 +++ dlls/comctl32/datetime.c 28 Dec 2002 20:43:22 -0000 @@ -1098,7 +1098,7 @@ infoPtr->rcClient.bottom = HIWORD(lParam); infoPtr->rcClient.right = LOWORD(lParam); - TRACE("Height=%d, Width=%d\n", infoPtr->rcClient.bottom, infoPtr->rcClient.right); + TRACE("Height=%ld, Width=%ld\n", infoPtr->rcClient.bottom, infoPtr->rcClient.right); /* use DrawEdge to adjust the size of rcEdge to get rcDraw */ memcpy((&infoPtr->rcDraw), (&infoPtr->rcClient), sizeof(infoPtr->rcDraw)); Into a standard [(%ld,%ld)-(%ld,%ld)]? As for debugrect(), it seems like half of the printed rectangles are in commctrl, so what we can do is use debugrect() in there without having to introduce any infrastructure changes. We can do that after Alexandre commits this change, so we don't cram too much stuff into one patch. -- Dimi.

3 7

RE: Fixing include quotes (was: Re: conformance test for ShellExecute)
by Patrik Stridvall Jan. 2, 2003

Jan. 2, 2003

> On December 30, 2002 03:41 pm, Patrik Stridvall wrote: > > I'm already on it by improving winapi_cleanup. > > Very well, I've put you up for it instead. But make sure > you don't over do it :) Well, for the future I have planned grouping and automatic addition of #ifdef HAVE_ and that sort of things. That is overdoing a little perhaps but it will look nicer. :-) > It seems to me the algo is simple > (if the include can not be accessed relative to the dir in > which the .c file is, change it to <>), This is that it already does I think. Please try it out yourself. > and the operation > is really one time. It depends what you mean by one time. People make mistakes. winapi_cleanup does C++ comment to C comment conversion and this is "one time" as well... > So if you have something that works, > let's just get the patch (and here I'm referring to the one > that does the actual "" to <> change) in, and check this off. I think it is better than Alexandre runs winapi_cleanup --include-quotes himself if he thinks it does the correct things. If not please inform me what the problem is. In my tree, the patch is over 800k.

4 4

sharpdevelop and .NET
by tom potts Jan. 2, 2003

Jan. 2, 2003

Has anyone tried to run sharpdevelop http://www.icsharpcode.net under Wine and if so does Wine need the .NET redistributable to run it/can it run it? Tom _____________________________________________________________ Get 25MB, POP3, Spam Filtering with LYCOS MAIL PLUS for $19.95/year. http://login.mail.lycos.com/brandPage.shtml?pageId=plus&ref=lmtplus

2 1

Visual-MinGW: Winelib patch
by Dimitrie O. Paun Jan. 2, 2003

Jan. 2, 2003

Hi Manu, I got around getting Visual-MinGW to compile under Winelib. This patch touches only your makefile, and I hope the changes are not controversial: -- Use forward slash instead of backslash -- Explicitly list the DLLs you link against (shell32, comdlg32, advapi32) -- It make sense to specify -mno-cygwin For some reason, the code seems to require it. Please check that it works under Windows as well. If it does, if makes sense to have it as Visual-MinGW should not have a dependency on Cygwin, as far as I can tell. -- Do not use -pedantic, the code does not compile with gcc 3.2 on Linux with that flag. -- Do not use -fvtable-thunks, it is deprecated in gcc 3.2 Please apply this patch with 'patch -p1 < winelib.diff'. Note that I still need to get some changes integrated into the official Wine tree before you can actually compile Visual-MinGW under Winelib. The changes are not controversial, and I hope to get them in real soon. I will let you know when that happens. Regardless, I think the changes I'm proposing are logical in and of themselves, so I figured they can be integrated regardless. Enjoy! --- Visual-MinGW.orig/Projects/vmingw/src/makefile 2002-06-08 06:07:10.000000000 -0400 +++ Visual-MinGW/Projects/vmingw/src/makefile 2002-12-31 01:43:29.000000000 -0500 @@ -1,25 +1,25 @@ # Generated automatically by Visual-MinGW. # http://visual-mingw.sourceforge.net/ -CC = g++ +CXX = g++ WRES = windres DLLWRAP = dllwrap CPPFLAGS = -D_WIN32_IE=0x0400 -LDBASEFLAGS = -mwindows -lcomctl32 -lole32 +LDBASEFLAGS = -mwindows -mno-cygwin -lcomctl32 -lole32 -lshell32 -lcomdlg32 -ladvapi32 INCDIRS = -I ../include OPTIMIZ = -O2 STRIP = -s ifeq ($(MAKECMDGOALS),debug) -CXXFLAGS = -W -Wall -pedantic $(INCDIRS) -g -fvtable-thunks -fno-rtti +CXXFLAGS = -W -Wall $(INCDIRS) -g -mno-cygwin -fno-rtti LDFLAGS = $(LDBASEFLAGS) else -CXXFLAGS = -W -Wall -pedantic $(INCDIRS) $(OPTIMIZ) -fvtable-thunks -fno-rtti +CXXFLAGS = -W -Wall $(INCDIRS) $(OPTIMIZ) -mno-cygwin -fno-rtti LDFLAGS = $(STRIP) $(LDBASEFLAGS) endif -SRCDIR = .\src -BINDIR = ..\bin +SRCDIR = ./src +BINDIR = ../bin LIBDIRS = %.o : %.rc @@ -51,7 +51,7 @@ # Dependency rules $(TARGET): $(OBJS) - $(CXX) -o $(BINDIR)\visual-mingw.exe $(OBJS) $(INCDIRS) $(LIBDIRS) $(LDFLAGS) + $(CXX) -o $(BINDIR)/visual-mingw.exe $(OBJS) $(INCDIRS) $(LIBDIRS) $(LDFLAGS) rsrc.o: rsrc.rc -- Dimi.

2 6

Re: winemaker problem
by Jeff Smith Jan. 2, 2003

Jan. 2, 2003

Yes there should be. Currently execname.so is being created rather than execname.exe.so. The patch I submitted a few hours ago (don't know if it has made it through yet) includes a fix for this. Copying the file is actually what I did for several weeks, rather than dig in to winemaker to fix the problem. But I get fed up and started putting together a patch for this several days ago. So now it is ready to roll. Good timing, yes? -- Jeff S >From: Shachar Shemesh <wine-devel(a)sun.consumer.org.il> > >Shouldn't there be a winemine-hcs.exe.so file there? >If you rename winemine-hcs.so to winemine-hcs.exe.so, what happens? > > Shachar > >Hans Christian Studt wrote: > >>It still cannot find 'winemine-hcs.exe'. >>What seems to comes nearest is >>-rwxr-xr-x 969 jan 1 21:00 winemine-hcs >>-rwxrwxr-x 793446 jan 1 21:00 winemine-hcs.so >>-rw-rw-r-- 44160 jan 1 21:00 winemine-hcs.spec.c >>-rw-rw-r-- 92648 jan 1 21:00 winemine-hcs.spec.o >>-rw-rw-r-- 173 jan 1 20:59 winemine.exe.dbg.c >>-rw-rw-r-- 2040 jan 1 21:00 winemine.exe.dbg.o >>-rw-rw-r-- 43665 jan 1 15:39 winemine.exe.spec.c >> >>I sure hope someone can help out - because I plan to try to see if I can >>make some of those 7.000 win32 applications over at sourceforge.net >>compile under winelib. _________________________________________________________________ MSN 8 with e-mail virus protection service: 2 months FREE* http://join.msn.com/?page=features/virus

2 1

winemaker problem
by Hans Christian Studt Jan. 2, 2003

Jan. 2, 2003

Hi, Problem 1 ========= I am trying to follow this discription on how to compile win32 source code with the winelib http://www.winehq.org/Docs/winelib-user/ winelib-getting-started.shtml#WINEMAKER-INTRODUCTION The process generates a Makefile that is supposed to complie a ressource file e.g. winemine.rc with the wrc compiler, but winemaker adds a '-L' option to the wrc compilwr that is does not recognize. I am using wine-20021219 on RedHat 8.0. It seems like a bug in winemaker. I have changed this line in the Makefile ## WRCFLAGS = -r -L WRCFLAGS = -r and it compiles. Problem 2 ========= When i try to run winemine I get this error (/user/usr/local/wine/programs/winemine-hcs) #./winemine-hcs winemine-hcs.so Warning: could not find wine config [Drive x] entry for current working directory /user/usr/local/wine/programs/winemine-hcs; starting in windows directory. /usr/local/bin/wine: cannot find 'winemine-hcs.exe' This is a list of the source directory (/user/usr/local/wine/programs/winemine-hcs) #ls -o | cut -c1-12,25- totalt 2076 drwxr-xr-x 4096 jan 1 20:59 autom4te-2.53.cache -rw-rw-r-- 13613 jan 1 20:59 config.log -rwxrwxr-x 20661 jan 1 20:59 config.status -rwxrwxr-x 158121 jan 1 20:59 configure -rw-rw-r-- 17915 jan 1 20:59 configure.ac -rw-r--r-- 3687 jan 1 20:59 dialog.c -rw-r--r-- 1161 jan 1 20:59 dialog.h -rw-rw-r-- 345180 jan 1 21:00 dialog.o -rw-r--r-- 30208 jan 1 20:59 main.c -rw-r--r-- 4852 jan 1 20:59 main.h -rw-rw-r-- 378552 jan 1 21:00 main.o -rw-rw-r-- 7630 jan 1 21:00 Makefile -rw-rw-r-- 2749 jan 1 20:59 Makefile.in -rw-rw-r-- 4925 jan 1 20:59 Make.rules -rw-rw-r-- 4716 jan 1 20:59 Make.rules.in -rw-r--r-- 1440 jan 1 20:59 resource.h -rw-r--r-- 25941 jan 1 20:59 rsrc.rc -rw-rw-r-- 25941 jan 1 20:59 rsrc.rc.bak -rw-rw-r-- 8864 jan 1 21:00 rsrc.res -rw-rw-r-- 969 jan 1 21:00 wineapploader -rw-rw-r-- 968 jan 1 20:59 wineapploader.in -rwxr-xr-x 969 jan 1 21:00 winemine-hcs -rwxrwxr-x 793446 jan 1 21:00 winemine-hcs.so -rw-rw-r-- 44160 jan 1 21:00 winemine-hcs.spec.c -rw-rw-r-- 92648 jan 1 21:00 winemine-hcs.spec.o -rw-rw-r-- 173 jan 1 20:59 winemine.exe.dbg.c -rw-rw-r-- 2040 jan 1 21:00 winemine.exe.dbg.o -rw-rw-r-- 43665 jan 1 15:39 winemine.exe.spec.c Any suggestions ? Regards -- Hans Christian Studt : http://hc.studt.dk mailto:hc(a)studt.dk .dk og W3C standarder : http://w3c.studt.dk

3 3

Alexandre?
by Jeff Smith Jan. 2, 2003

Jan. 2, 2003

I've seen no activity on wine-cvs for a week (Dec 23). What's up? Holiday vacation? Either way, Happy (if belated) Holidays to everyone who celebrates a holiday. :-) -- Jeff S _________________________________________________________________ MSN 8 helps eliminate e-mail viruses. Get 3 months FREE*. http://join.msn.com/?page=features/virus&xAPID=42&PS=47575&PI=7324&DI=7474&… http://www.hotmail.msn.com/cgi-bin/getmsg&HL=1216hotmailtaglines_virusprote…

4 3

Re: wineboot - initial version
by Dimitrie O. Paun Jan. 2, 2003

Jan. 2, 2003

On January 1, 2003 12:48 pm, Shachar Shemesh wrote: > * _stricmp is not defined, and is called directly instead of as > stricmp. * As a result of the above, there is a compilation warning when > compiling. There's no point in importing msvcrt just for this function. Just use lstrcmpiA (exported by kernel32 and defined in winbase.h) as suggested by Francois. As for the patch, please include even new files in the patch (as I explained in the message "Re: Tests for URL functions in shlwapi") by diffing against /dev/null. -- Dimi.

2 1