- Wine-Devel - list.winehq.org

SetWindowHookEx
by steve.lustbader＠philips.com Dec. 1, 2002

Dec. 1, 2002

My app uses SetWindowHookEx to install a WH_KEYBOARD_LL hook. Currently, the wine implementation tells me "fixme:hook:set_windows_hook system hook WH_KEYBOARD_LL won't work right" when I try to use it. I'd like to implement this so I can get my app to run, but I'm not sure where to start, since I don't know why it "won't work right." Any hints/suggestions? -Steve

3 5

Compilation with -DSTRICT
by Thomas Wickline Dec. 1, 2002

Dec. 1, 2002

Hello, I just want to say Thank you to all the people who put work into the Compilation with -DSTRICT Tom

1 0

Reopened a bug
by Dustin Navea Nov. 30, 2002

Nov. 30, 2002

I have reopened bug #15 due to the fact that the bug still exists to a certain extent and in a different form. When sending an IM in AIM with any recent version of wine (including a couple of days before the latest cvs snapshot), I can resize the window and when the buttons go to reposition themselves, they move much slower than the border of the window, and you can see them updating their position. Would there be any debug traces I could post to the bug to help resolve this? -Dustin

1 0

RE: strcat+strcat+strcat == baaad
by Medland, Bill Nov. 30, 2002

Nov. 30, 2002

> -----Original Message----- > From: wine-patches-admin(a)winehq.com > [mailto:wine-patches-admin(a)winehq.com]On Behalf Of Francois Gouget > Sent: Friday, November 29, 2002 10:11 PM > To: wine-patches(a)winehq.com > Subject: strcat+strcat+strcat == baaad > > > > I don't like pieces of code that go: > > strcpy(foo, bar1); > strcat(foo, bar2); > strcat(foo, bar3); > strcat(foo, bar4); > strcat(foo, bar5); > strcat(foo, bar6); > > It's really inefficient: the cost increases quadratically > with the size > of the resulting string. It's more efficient to do: > > sprintf(foo, "%s%s%s%s%s%s", bar1,bar2,bar3,bar4,bar5,bar6); > > Here the cost is proportional to the size of the resulting string. And surely when the opportunity arises it would be better to use snprintf (i.e. when you know the size of the buffer). (I doubt that the code has already checked the size of the strings being pasted together) > > For for various reasons I came accross a couple of instances of > strcat+strcat badness and replaced them with a sprintf. So here's the > patch. > > Changelog: > > * memory/environ.c, > tools/makedep.c > > Use sprintf rather than calling strcat over and over > > > Index: memory/environ.c > =================================================================== > RCS file: /home/wine/wine/memory/environ.c,v > retrieving revision 1.38 > diff -u -r1.38 environ.c > --- memory/environ.c 9 Oct 2002 18:35:02 -0000 1.38 > +++ memory/environ.c 30 Nov 2002 05:20:12 -0000 > @@ -641,12 +641,7 @@ > > /* Set the new string */ > > - if (value) > - { > - strcpy( p, name ); > - strcat( p, "=" ); > - strcat( p, value ); > - } > + if (value) sprintf( p, "%s=%s", name, value ); > current_envdb.env = new_env; > ret = TRUE; > > Index: tools/makedep.c > =================================================================== > RCS file: /home/wine/wine/tools/makedep.c,v > retrieving revision 1.13 > diff -u -r1.13 makedep.c > --- tools/makedep.c 17 Aug 2002 18:28:43 -0000 1.13 > +++ tools/makedep.c 30 Nov 2002 06:10:17 -0000 > @@ -192,9 +192,7 @@ > if (SrcDir) > { > pFile->filename = xmalloc( strlen(SrcDir) + > strlen(pFile->name) + 2 ); > - strcpy( pFile->filename, SrcDir ); > - strcat( pFile->filename, "/" ); > - strcat( pFile->filename, pFile->name ); > + sprintf( pFile->filename, "%s/%s", SrcDir, pFile->name ); > } > else pFile->filename = xstrdup( pFile->name ); > > @@ -218,9 +216,7 @@ > for (path = firstPath; path; path = path->next) > { > char *filename = xmalloc(strlen(path->name) + > strlen(pFile->name) + 2); > - strcpy( filename, path->name ); > - strcat( filename, "/" ); > - strcat( filename, pFile->name ); > + sprintf( filename, "%s/%s", path->name, pFile->name ); > if ((file = fopen( filename, "r" ))) > { > pFile->filename = filename; > > > -- > Francois Gouget fgouget(a)free.fr http://fgouget.free.fr/ > Linux: It is now safe to turn on your computer. > > >

1 0

Re: somebody help me identify this bug please
by ezra daniel Nov. 30, 2002

Nov. 30, 2002

that I have tried and needed yes, only valves with "acute accent" like you call it, excuse my english.. :) And I dont understand what you mean by dead key... but anyway... in every linux app I can type that right, only the new wine version breaks that, but I know it was fixed on 20021031 cause it worked great. To make an example of what I can't type : canción = in the wine version appears as cancion without the ó In my language this is very important or they will think I dont know how to write my language, hehehe Thanks :) -daniel http://www.debian-gnu.com >From: "Jeff Smith" <whydoubt(a)hotmail.com> >To: ezra_daniel(a)hotmail.com, wine-devel(a)winehq.com >Subject: Re: somebody help me identify this bug please >Date: Fri, 29 Nov 2002 13:31:46 -0600 > >Is it only characters with the acute accent? Is it that your are >attempting this using 'dead key' entry on a Spanish keyboard? > >If this is the case, the problem may be in a recent correction to >the Spanish keyboard layout. > >I will work on this some more when I get a chance, but hopefully >someone else will find something sooner. > > -- Jeff S > > >>From: "ezra daniel" <ezra_daniel(a)hotmail.com> >> >>Hello, >> >>At work I use Lotus Notes under Wine. >> >>I downloaded compiled and installed the new wine version 20021125 and I am >>no longer able to type accecented valves, like á é í ó ú. >> >>Ñ can be typed though correctly. >> >>With the other version 20021031 I could type accented valves.In fact I >>went back to using the older version and worked again so it is obvious it >>is a problem in the new wine version. >> >>Though I am a newbie and know nothing of developing, but I would like to >>submit the bug to the proper person so it fixes it back again but I dont >>know which section of wine or person deals with this character typing >>problem. >> >>Can anyone point me in the right direction? Thanks in advance. >> >>-daniel >>http://www.debian-gnu.com > _________________________________________________________________ MSN Fotos: la forma más fácil de compartir e imprimir fotos. http://photos.msn.es/support/worldwide.aspx

1 0

Re: Yet another D3D patch....
by Christian Costa Nov. 30, 2002

Nov. 30, 2002

Lionel Ulmer wrote: >Hi all, > >This patch should not be dependant of any others... But to prevent line >number errors, better to commit it after the 5 -> 9 series (yeah, the >attachements are numbered to ease tracking :-) ). > >Changelog: > - start of support for device locking / unlocking via glReadPixels / > glDrawPixels interface (slow but should be enough for a start) > - implement one vertex case for the D3D3/7 DrawPrimitive functions > - fix a missing \n in a TRACE call > > Lionel > This patch breaks the TWIST demo that was working fine. I think the changes in d3ddevice_create are responsible of that.

2 2

DPMI_CallRMProc trouble
by György 'Nog' Jeney Nov. 30, 2002

Nov. 30, 2002

I realy need help with this. Whenever I call a DOSDEV_ function then that function eventually calls DOSDEV_DoReq. This function calls DPMI_CallRMProc. Now that function call DOSMEM_GetBlock( 64, (UINT16 *)&(context->SegSs) ) to try and allocate a stack. This fails for some reason but I dont understand why because it succeds if called from int21/48. Anyone know whats going on? nog.

1 0

Re: Janitorial Projects
by Rolf Kalbermatter Nov. 30, 2002

Nov. 30, 2002

"Dimitrie O. Paun" <dpaun(a)rogers.com> wrote: >I have updated the Janitorial section: > http://www.dssd.ca/wine/Wine-Fun.html#janitorial > >with the list of cross calls from 32->16, and W->A. > >There are currently 13 cross calls from 32->16 bit code, >and 194 cross calls from Unicode to ASCII. I was just looking at shell32.dll and wondered if it should implement A->U as it almost completely consistently implements U->A. So I guess this should all be changed then. Problem is that some of those functions call other functions where only the ANSI version is implemented yet, so it is a lot more work than just moving the implementation from the ANSI to the Unicode version. But what the heck do the errors about AW functions calling Unicode mean? Isn't that the actual idea about the AW functions? Rolf Kalbermatter

2 1

MIDI Mapper fix
by Jeff Smith Nov. 30, 2002

Nov. 30, 2002

I'm so happy, I just had to share it with everyone :-D Changelog: Fix for MIDI Mapper. Notes: Finally found it! This was the last thing keeping sound from working in Auralia. With just this simple patch, it now works. Auralia still has a few problems, but they are minor in comparison. It *is* kind of important for sound to work in an ear training program ;-) BTW, Thanks to Eric P. for his help getting me off to a running start with his fixes to the OSS MIDI driver a couple of weeks back. (patch is attached - Hotmail has not been kind to my inlined patches the past few days) _________________________________________________________________ Help STOP SPAM with the new MSN 8 and get 2 months FREE* http://join.msn.com/?page=features/junkmail

1 0

The conformance tests need you!
by Francois Gouget Nov. 30, 2002

Nov. 30, 2002

Hi, I have been running the Wine conformance tests on Windows 95 and NT4. The results are pretty bad. 24 tests out of 32 have failures in one or more of these two platforms. That's 75% of 'Windows conformance tests' that don't work on Windows! Out of the 32 tests, only 4, that's 12.5%, execute successfully on all tested platforms (and one of them has 4 todos in Wine). You can see things more graphically at the following URL: http://fgouget.free.fr/wine/tests-en.shtml Come on people, we can do better. Send fixes to wine-patches, and send me emails to so that I update this table. -- Francois Gouget fgouget(a)free.fr http://fgouget.free.fr/ War doesn't determine who's right. War determines who's left.

1 0