- Wine-Devel - list.winehq.org

Listview K6
by Dimitrie O. Paun Oct. 4, 2002

Oct. 4, 2002

This one fixes a nasty little bug in OWNERDATA listviews. Xnews should now refresh properly. Selection is still borken, but that's the subject of a different patch. Bug reports are always welcomed. ;) ChangeLog Fix condition so we actually store the state in virtual listviews. Assorted code cleanups. --- dlls/comctl32/listview.c.K5 Fri Oct 4 02:39:12 2002 +++ dlls/comctl32/listview.c Fri Oct 4 11:38:11 2002 @@ -1236,7 +1236,7 @@ LONG lStyle = infoPtr->dwStyle; UINT uView = lStyle & LVS_TYPEMASK; POINT Origin, Position, TopLeft; - RECT Icon, Boundary, Label; + RECT Icon, Boundary, Label, FullText; INT nIndent = 0; if (!LISTVIEW_GetOrigin(infoPtr, &Origin)) return FALSE; @@ -1380,7 +1380,6 @@ if (infoPtr->himlNormal != NULL) { INT nLabelWidth; - RECT FullText; Label.left = TopLeft.x + Origin.x; Label.top = TopLeft.y + Origin.y + ICON_TOP_PADDING_HITABLE + @@ -1404,10 +1403,6 @@ InflateRect(&FullText, 2, 0); if (lprcLabel) *lprcLabel = Label; if (lprcText) *lprcText = FullText; - TRACE("hwnd=%x, item=%d, label=(%d,%d)-(%d,%d), fulltext=(%d,%d)-(%d,%d)\n", - infoPtr->hwndSelf, nItem, - Label.left, Label.top, Label.right, Label.bottom, - FullText.left, FullText.top, FullText.right, FullText.bottom); } else return FALSE; } @@ -1433,9 +1428,6 @@ Label.right = nLeftPos + infoPtr->nItemWidth; if (lprcLabel) *lprcLabel = Label; if (lprcText) *lprcText = Label; - TRACE("hwnd=%x, item=%d, label=(%d,%d)-(%d,%d)\n", - infoPtr->hwndSelf, nItem, - Label.left, Label.top, Label.right, Label.bottom); } else /* LVS_LIST or LVS_REPORT */ { @@ -1461,7 +1453,8 @@ if (lprcText) *lprcText = Label; } - TRACE("hwnd=%x, item=%d, label=%s\n", infoPtr->hwndSelf, nItem, debugrect(&Label)); + TRACE("hwnd=%x, item=%d, label=%s, fulltext=%s\n", + infoPtr->hwndSelf, nItem, debugrect(&Label), debugrect(lprcText)); /***********************************************************/ /* compute boundary box for the item (ala LVM_GETITEMRECT) */ @@ -2296,6 +2289,8 @@ { LVITEMW lvItem; + TRACE("nItem=%d\n", nItem); + LISTVIEW_RemoveAllSelections(infoPtr); lvItem.state = LVIS_FOCUSED | LVIS_SELECTED; @@ -2485,14 +2480,16 @@ NMLISTVIEW nmlv; INT oldState; - /* a virtual livst view stores only state for the main item */ + /* a virtual listview stores only the state for the main item */ if (lpLVItem->iSubItem || !(lpLVItem->mask & LVIF_STATE)) return FALSE; oldState = LISTVIEW_GetItemState(infoPtr, lpLVItem->iItem, LVIS_FOCUSED | LVIS_SELECTED); + TRACE("oldState=%x, newState=%x, uCallbackMask=%x\n", + oldState, lpLVItem->state, infoPtr->uCallbackMask); /* we're done if we don't need to change anything we handle */ - if ( (oldState ^ lpLVItem->state) & lpLVItem->stateMask & - ~infoPtr->uCallbackMask & (LVIS_FOCUSED | LVIS_SELECTED)) return FALSE; + if ( !((oldState ^ lpLVItem->state) & lpLVItem->stateMask & + ~infoPtr->uCallbackMask & (LVIS_FOCUSED | LVIS_SELECTED))) return TRUE; /* * As per MSDN LVN_ITEMCHANGING notifications are _NOT_ sent for @@ -2517,7 +2514,7 @@ add_selection_range(infoPtr, lpLVItem->iItem, lpLVItem->iItem, TRUE); } else - remove_selection_range(infoPtr, lpLVItem->iItem, lpLVItem->iItem, TRUE); + remove_selection_range(infoPtr, lpLVItem->iItem, lpLVItem->iItem, TRUE); } /* notify the parent now that things have changed */ @@ -3267,7 +3264,7 @@ } /* Get scroll info once before loop */ - LISTVIEW_GetOrigin(infoPtr, &ptOrig); + if (!LISTVIEW_GetOrigin(infoPtr, &ptOrig)) return; /* we now narrow the columns as well */ nLastCol = nColumnCount - 1; @@ -3315,7 +3312,8 @@ item.mask = LVIF_PARAM | LVIF_STATE; item.stateMask = LVIS_SELECTED | LVIS_FOCUSED; if (!LISTVIEW_GetItemW(infoPtr, &item, TRUE)) continue; - + + ZeroMemory(&dis, sizeof(dis)); dis.hwndItem = infoPtr->hwndSelf; dis.hDC = hdc; dis.CtlType = ODT_LISTVIEW; @@ -3323,7 +3321,6 @@ dis.itemID = nItem; dis.itemAction = ODA_DRAWENTIRE; dis.itemData = item.lParam; - dis.itemState = 0; if (item.state & LVIS_SELECTED) dis.itemState |= ODS_SELECTED; if (item.state & LVIS_FOCUSED) dis.itemState |= ODS_FOCUS; dis.rcItem.left = lpCols[0].rc.left; @@ -3333,7 +3330,7 @@ OffsetRect(&dis.rcItem, ptOrig.x, 0); TRACE("item=%s, rcItem=%s\n", debuglvitem_t(&item, TRUE), debugrect(&dis.rcItem)); - if (SendMessageW(GetParent(infoPtr->hwndSelf), WM_DRAWITEM, uID, (LPARAM)&dis)) + if (SendMessageW(GetParent(infoPtr->hwndSelf), WM_DRAWITEM, dis.CtlID, (LPARAM)&dis)) continue; } @@ -3481,7 +3478,7 @@ if(GETITEMCOUNT(infoPtr) == 0) return; - LISTVIEW_GetOrigin(infoPtr, &ptOrigin); + if (!LISTVIEW_GetOrigin(infoPtr, &ptOrigin)) return; GetClipBox(hdc, &rcClip); @@ -4746,7 +4743,7 @@ } /* we store only a little state, so if we're not asked, we're done */ - if (!(lpLVItem->mask & LVIF_STATE) || lpLVItem->iSubItem) return FALSE; + if (!(lpLVItem->mask & LVIF_STATE) || lpLVItem->iSubItem) return TRUE; /* if focus is handled by us, report it */ if ( !(infoPtr->uCallbackMask & LVIS_FOCUSED) ) @@ -6790,28 +6787,26 @@ */ static LRESULT LISTVIEW_SetItemState(LISTVIEW_INFO *infoPtr, INT nItem, LPLVITEMW lpLVItem) { - BOOL bResult = TRUE; - LVITEMW lvItem; - - TRACE("(nItem=%d, state=%x, stateMask=%x)\n", nItem, lpLVItem->state, - lpLVItem->stateMask); + BOOL bResult = TRUE; + LVITEMW lvItem; - lvItem.iItem = nItem; - lvItem.iSubItem = 0; - lvItem.mask = LVIF_STATE; - lvItem.state = lpLVItem->state; - lvItem.stateMask = lpLVItem->stateMask; - - if (nItem == -1) - { - /* apply to all items */ - for (lvItem.iItem = 0; lvItem.iItem < GETITEMCOUNT(infoPtr); lvItem.iItem++) - if (!LISTVIEW_SetItemT(infoPtr, &lvItem, TRUE)) bResult = FALSE; - } - else - bResult = LISTVIEW_SetItemT(infoPtr, &lvItem, TRUE); + lvItem.iItem = nItem; + lvItem.iSubItem = 0; + lvItem.mask = LVIF_STATE; + lvItem.state = lpLVItem->state; + lvItem.stateMask = lpLVItem->stateMask; + TRACE("lvItem=%s\n", debuglvitem_t(&lvItem, TRUE)); + + if (nItem == -1) + { + /* apply to all items */ + for (lvItem.iItem = 0; lvItem.iItem < GETITEMCOUNT(infoPtr); lvItem.iItem++) + if (!LISTVIEW_SetItemT(infoPtr, &lvItem, TRUE)) bResult = FALSE; + } + else + bResult = LISTVIEW_SetItemT(infoPtr, &lvItem, TRUE); - return bResult; + return bResult; } /***

1 0

Window flags problem
by Fabian Cenedese Oct. 4, 2002

Oct. 4, 2002

Hi I have a problem with my VC6 MFC MDI app. Every child window that is docked inside isn't painted anymore and doesn't receive any messages. Together with a friend (THX ic) I found out that the wrapper window that does the docking doesn't have the visible flag set. Even if I create the window with the flag set it gets deleted somewhere in CreateWindowEx or ShowWindow. In Windows the flag can even get set even if it wasn't set before but I just couldn't find out why. I scrutinized the MoveWindow call. It sends the messages WM_WINDOWPOSCHANGING, WM_NCCALCSIZE, WM_WINDOWPOSCHANGED, WM_MOVE and WM_SIZE (in this order) to the window. After these there is an additional WM_SHOWWINDOW. In every handler the visible flag isn't changed yet. After leaving the MoveWindow call the flag can be set or deleted. So this must happen between WM_SHOWWINDOW and the end of MoveWindow. But I couldn't find out what reason Windows uses to change it so I can't say where in wine the error is. I'd be very thankful if somebody with knowledge about windows and their style flags could shed some light upon this. Here is a small sample app (only exe, source is quite complicated, but I can deliver that too if anybody is interested). There is a toolbar docked below the menu but in wine there is just a dead area. http://www.indel.ch/ftp/TestIMD.zip BTW winedbg doesn't show the class information for walk wnd. The same problem has MS-Spy++ but besides that it runs quite well in wine :) Thanks for any hint/help/patch... bye Fabi

1 0

Regression Test - kernel atom test
by Steven Edwards Oct. 4, 2002

Oct. 4, 2002

Here is another one on my win2k sp3 box. All tests compiled with cygwin atom.c:81: Test failed: succeeded adding ff74 atom.c:84: Test failed: succeeded adding ff74 atom.c:81: Test failed: succeeded adding ff75 atom.c:84: Test failed: succeeded adding ff75 atom.c:81: Test failed: succeeded adding ff76 atom.c:84: Test failed: succeeded adding ff76 atom.c:81: Test failed: succeeded adding ff77 atom.c:84: Test failed: succeeded adding ff77 atom.c:81: Test failed: succeeded adding ff78 atom.c:84: Test failed: succeeded adding ff78 atom.c:81: Test failed: succeeded adding ff79 atom.c:84: Test failed: succeeded adding ff79 atom.c:81: Test failed: succeeded adding ff7a atom.c:84: Test failed: succeeded adding ff7a atom.c:81: Test failed: succeeded adding ff7b atom.c:84: Test failed: succeeded adding ff7b atom.c:81: Test failed: succeeded adding ff7c atom.c:84: Test failed: succeeded adding ff7c atom.c:81: Test failed: succeeded adding ff7d atom.c:84: Test failed: succeeded adding ff7d atom.c:81: Test failed: succeeded adding ff7e atom.c:84: Test failed: succeeded adding ff7e atom.c:81: Test failed: succeeded adding ff7f atom.c:84: Test failed: succeeded adding ff7f atom.c:81: Test failed: succeeded adding ff80 atom.c:84: Test failed: succeeded adding ff80 atom.c:81: Test failed: succeeded adding ff81 atom.c:84: Test failed: succeeded adding ff81 atom.c:81: Test failed: succeeded adding ff82 atom.c:84: Test failed: succeeded adding ff82 atom.c:81: Test failed: succeeded adding ff83 atom.c:84: Test failed: succeeded adding ff83 atom.c:81: Test failed: succeeded adding ff84 atom.c:84: Test failed: succeeded adding ff84 atom.c:81: Test failed: succeeded adding ff85 atom.c:84: Test failed: succeeded adding ff85 atom.c:81: Test failed: succeeded adding ff86 atom.c:84: Test failed: succeeded adding ff86 atom.c:81: Test failed: succeeded adding ff87 atom.c:84: Test failed: succeeded adding ff87 atom.c:81: Test failed: succeeded adding ff88 atom.c:84: Test failed: succeeded adding ff88 atom.c:81: Test failed: succeeded adding ff89 atom.c:84: Test failed: succeeded adding ff89 atom.c:81: Test failed: succeeded adding ff8a atom.c:84: Test failed: succeeded adding ff8a atom.c:81: Test failed: succeeded adding ff8b atom.c:84: Test failed: succeeded adding ff8b atom.c:81: Test failed: succeeded adding ff8c atom.c:84: Test failed: succeeded adding ff8c atom.c:81: Test failed: succeeded adding ff8d atom.c:84: Test failed: succeeded adding ff8d atom.c:81: Test failed: succeeded adding ff8e atom.c:84: Test failed: succeeded adding ff8e atom.c:81: Test failed: succeeded adding ff8f atom.c:84: Test failed: succeeded adding ff8f atom.c:81: Test failed: succeeded adding ff90 atom.c:84: Test failed: succeeded adding ff90 atom.c:81: Test failed: succeeded adding ff91 atom.c:84: Test failed: succeeded adding ff91 atom.c:81: Test failed: succeeded adding ff92 atom.c:84: Test failed: succeeded adding ff92 atom.c:81: Test failed: succeeded adding ff93 atom.c:84: Test failed: succeeded adding ff93 atom.c:81: Test failed: succeeded adding ff94 atom.c:84: Test failed: succeeded adding ff94 atom.c:81: Test failed: succeeded adding ff95 atom.c:84: Test failed: succeeded adding ff95 atom.c:81: Test failed: succeeded adding ff96 atom.c:84: Test failed: succeeded adding ff96 atom.c:81: Test failed: succeeded adding ff97 atom.c:84: Test failed: succeeded adding ff97 atom.c:81: Test failed: succeeded adding ff98 atom.c:84: Test failed: succeeded adding ff98 atom.c:81: Test failed: succeeded adding ff99 atom.c:84: Test failed: succeeded adding ff99 atom.c:81: Test failed: succeeded adding ff9a atom.c:84: Test failed: succeeded adding ff9a atom.c:81: Test failed: succeeded adding ff9b atom.c:84: Test failed: succeeded adding ff9b atom.c:81: Test failed: succeeded adding ff9c atom.c:84: Test failed: succeeded adding ff9c atom.c:81: Test failed: succeeded adding ff9d atom.c:84: Test failed: succeeded adding ff9d atom.c:81: Test failed: succeeded adding ff9e atom.c:84: Test failed: succeeded adding ff9e atom.c:81: Test failed: succeeded adding ff9f atom.c:84: Test failed: succeeded adding ff9f atom.c:81: Test failed: succeeded adding ffa0 atom.c:84: Test failed: succeeded adding ffa0 atom.c:81: Test failed: succeeded adding ffa1 atom.c:84: Test failed: succeeded adding ffa1 atom.c:81: Test failed: succeeded adding ffa2 atom.c:84: Test failed: succeeded adding ffa2 atom.c:81: Test failed: succeeded adding ffa3 atom.c:84: Test failed: succeeded adding ffa3 atom.c:81: Test failed: succeeded adding ffa4 atom.c:84: Test failed: succeeded adding ffa4 atom.c:81: Test failed: succeeded adding ffa5 atom.c:84: Test failed: succeeded adding ffa5 atom.c:81: Test failed: succeeded adding ffa6 atom.c:84: Test failed: succeeded adding ffa6 atom.c:81: Test failed: succeeded adding ffa7 atom.c:84: Test failed: succeeded adding ffa7 atom.c:81: Test failed: succeeded adding ffa8 atom.c:84: Test failed: succeeded adding ffa8 atom.c:81: Test failed: succeeded adding ffa9 atom.c:84: Test failed: succeeded adding ffa9 atom.c:81: Test failed: succeeded adding ffaa atom.c:84: Test failed: succeeded adding ffaa atom.c:81: Test failed: succeeded adding ffab atom.c:84: Test failed: succeeded adding ffab atom.c:81: Test failed: succeeded adding ffac atom.c:84: Test failed: succeeded adding ffac atom.c:81: Test failed: succeeded adding ffad atom.c:84: Test failed: succeeded adding ffad atom.c:81: Test failed: succeeded adding ffae atom.c:84: Test failed: succeeded adding ffae atom.c:81: Test failed: succeeded adding ffaf atom.c:84: Test failed: succeeded adding ffaf atom.c:81: Test failed: succeeded adding ffb0 atom.c:84: Test failed: succeeded adding ffb0 atom.c:81: Test failed: succeeded adding ffb1 atom.c:84: Test failed: succeeded adding ffb1 atom.c:81: Test failed: succeeded adding ffb2 atom.c:84: Test failed: succeeded adding ffb2 atom.c:81: Test failed: succeeded adding ffb3 atom.c:84: Test failed: succeeded adding ffb3 atom.c:81: Test failed: succeeded adding ffb4 atom.c:84: Test failed: succeeded adding ffb4 atom.c:81: Test failed: succeeded adding ffb5 atom.c:84: Test failed: succeeded adding ffb5 atom.c:81: Test failed: succeeded adding ffb6 atom.c:84: Test failed: succeeded adding ffb6 atom.c:81: Test failed: succeeded adding ffb7 atom.c:84: Test failed: succeeded adding ffb7 atom.c:81: Test failed: succeeded adding ffb8 atom.c:84: Test failed: succeeded adding ffb8 atom.c:81: Test failed: succeeded adding ffb9 atom.c:84: Test failed: succeeded adding ffb9 atom.c:81: Test failed: succeeded adding ffba atom.c:84: Test failed: succeeded adding ffba atom.c:81: Test failed: succeeded adding ffbb atom.c:84: Test failed: succeeded adding ffbb atom.c:81: Test failed: succeeded adding ffbc atom.c:84: Test failed: succeeded adding ffbc atom.c:81: Test failed: succeeded adding ffbd atom.c:84: Test failed: succeeded adding ffbd atom.c:81: Test failed: succeeded adding ffbe atom.c:84: Test failed: succeeded adding ffbe atom.c:81: Test failed: succeeded adding ffbf atom.c:84: Test failed: succeeded adding ffbf atom.c:81: Test failed: succeeded adding ffc0 atom.c:84: Test failed: succeeded adding ffc0 atom.c:81: Test failed: succeeded adding ffc1 atom.c:84: Test failed: succeeded adding ffc1 atom.c:81: Test failed: succeeded adding ffc2 atom.c:84: Test failed: succeeded adding ffc2 atom.c:81: Test failed: succeeded adding ffc3 atom.c:84: Test failed: succeeded adding ffc3 atom.c:81: Test failed: succeeded adding ffc4 atom.c:84: Test failed: succeeded adding ffc4 atom.c:81: Test failed: succeeded adding ffc5 atom.c:84: Test failed: succeeded adding ffc5 atom.c:81: Test failed: succeeded adding ffc6 atom.c:84: Test failed: succeeded adding ffc6 atom.c:81: Test failed: succeeded adding ffc7 atom.c:84: Test failed: succeeded adding ffc7 atom.c:81: Test failed: succeeded adding ffc8 atom.c:84: Test failed: succeeded adding ffc8 atom.c:81: Test failed: succeeded adding ffc9 atom.c:84: Test failed: succeeded adding ffc9 atom.c:81: Test failed: succeeded adding ffca atom.c:84: Test failed: succeeded adding ffca atom.c:81: Test failed: succeeded adding ffcb atom.c:84: Test failed: succeeded adding ffcb atom.c:81: Test failed: succeeded adding ffcc atom.c:84: Test failed: succeeded adding ffcc atom.c:81: Test failed: succeeded adding ffcd atom.c:84: Test failed: succeeded adding ffcd atom.c:81: Test failed: succeeded adding ffce atom.c:84: Test failed: succeeded adding ffce atom.c:81: Test failed: succeeded adding ffcf atom.c:84: Test failed: succeeded adding ffcf atom.c:81: Test failed: succeeded adding ffd0 atom.c:84: Test failed: succeeded adding ffd0 atom.c:81: Test failed: succeeded adding ffd1 atom.c:84: Test failed: succeeded adding ffd1 atom.c:81: Test failed: succeeded adding ffd2 atom.c:84: Test failed: succeeded adding ffd2 atom.c:81: Test failed: succeeded adding ffd3 atom.c:84: Test failed: succeeded adding ffd3 atom.c:81: Test failed: succeeded adding ffd4 atom.c:84: Test failed: succeeded adding ffd4 atom.c:81: Test failed: succeeded adding ffd5 atom.c:84: Test failed: succeeded adding ffd5 atom.c:81: Test failed: succeeded adding ffd6 atom.c:84: Test failed: succeeded adding ffd6 atom.c:81: Test failed: succeeded adding ffd7 atom.c:84: Test failed: succeeded adding ffd7 atom.c:81: Test failed: succeeded adding ffd8 atom.c:84: Test failed: succeeded adding ffd8 atom.c:81: Test failed: succeeded adding ffd9 atom.c:84: Test failed: succeeded adding ffd9 atom.c:81: Test failed: succeeded adding ffda atom.c:84: Test failed: succeeded adding ffda atom.c:81: Test failed: succeeded adding ffdb atom.c:84: Test failed: succeeded adding ffdb atom.c:81: Test failed: succeeded adding ffdc atom.c:84: Test failed: succeeded adding ffdc atom.c:81: Test failed: succeeded adding ffdd atom.c:84: Test failed: succeeded adding ffdd atom.c:81: Test failed: succeeded adding ffde atom.c:84: Test failed: succeeded adding ffde atom.c:81: Test failed: succeeded adding ffdf atom.c:84: Test failed: succeeded adding ffdf atom.c:81: Test failed: succeeded adding ffe0 atom.c:84: Test failed: succeeded adding ffe0 atom.c:81: Test failed: succeeded adding ffe1 atom.c:84: Test failed: succeeded adding ffe1 atom.c:81: Test failed: succeeded adding ffe2 atom.c:84: Test failed: succeeded adding ffe2 atom.c:81: Test failed: succeeded adding ffe3 atom.c:84: Test failed: succeeded adding ffe3 atom.c:81: Test failed: succeeded adding ffe4 atom.c:84: Test failed: succeeded adding ffe4 atom.c:81: Test failed: succeeded adding ffe5 atom.c:84: Test failed: succeeded adding ffe5 atom.c:81: Test failed: succeeded adding ffe6 atom.c:84: Test failed: succeeded adding ffe6 atom.c:81: Test failed: succeeded adding ffe7 atom.c:84: Test failed: succeeded adding ffe7 atom.c:81: Test failed: succeeded adding ffe8 atom.c:84: Test failed: succeeded adding ffe8 atom.c:81: Test failed: succeeded adding ffe9 atom.c:84: Test failed: succeeded adding ffe9 atom.c:81: Test failed: succeeded adding ffea atom.c:84: Test failed: succeeded adding ffea atom.c:81: Test failed: succeeded adding ffeb atom.c:84: Test failed: succeeded adding ffeb atom.c:81: Test failed: succeeded adding ffec atom.c:84: Test failed: succeeded adding ffec atom.c:81: Test failed: succeeded adding ffed atom.c:84: Test failed: succeeded adding ffed atom.c:81: Test failed: succeeded adding ffee atom.c:84: Test failed: succeeded adding ffee atom.c:81: Test failed: succeeded adding ffef atom.c:84: Test failed: succeeded adding ffef atom.c:81: Test failed: succeeded adding fff0 atom.c:84: Test failed: succeeded adding fff0 atom.c:81: Test failed: succeeded adding fff1 atom.c:84: Test failed: succeeded adding fff1 atom.c:81: Test failed: succeeded adding fff2 atom.c:84: Test failed: succeeded adding fff2 atom.c:81: Test failed: succeeded adding fff3 atom.c:84: Test failed: succeeded adding fff3 atom.c:81: Test failed: succeeded adding fff4 atom.c:84: Test failed: succeeded adding fff4 atom.c:81: Test failed: succeeded adding fff5 atom.c:84: Test failed: succeeded adding fff5 atom.c:81: Test failed: succeeded adding fff6 atom.c:84: Test failed: succeeded adding fff6 atom.c:81: Test failed: succeeded adding fff7 atom.c:84: Test failed: succeeded adding fff7 atom.c:81: Test failed: succeeded adding fff8 atom.c:84: Test failed: succeeded adding fff8 atom.c:81: Test failed: succeeded adding fff9 atom.c:84: Test failed: succeeded adding fff9 atom.c:81: Test failed: succeeded adding fffa atom.c:84: Test failed: succeeded adding fffa atom.c:81: Test failed: succeeded adding fffb atom.c:84: Test failed: succeeded adding fffb atom.c:81: Test failed: succeeded adding fffc atom.c:84: Test failed: succeeded adding fffc atom.c:81: Test failed: succeeded adding fffd atom.c:84: Test failed: succeeded adding fffd atom.c:81: Test failed: succeeded adding fffe atom.c:84: Test failed: succeeded adding fffe atom.c:81: Test failed: succeeded adding ffff atom.c:84: Test failed: succeeded adding ffff atom.c:110: Test failed: bad buffer contents atom.c:112: Test failed: GlobalGetAtomNameW succeeded on short buffer atom.c:116: Test failed: succeded atom.c:118: Test failed: succeded atom.c:120: Test failed: succeded atom.c:122: Test failed: succeded atom.c:140: Test failed: bad length 0 atom.c:143: Test failed: bad buffer contents aaaaaaaaaaha?xA

4 13

AVI resources in shell32.dll
by Stefan Leichter Oct. 3, 2002

Oct. 3, 2002

Hello, i have an installer that fails because of a missing AVI resource (the magnifier in front of the computer) in the buildin shell32.dll. To get the installer running i tried to build the resource. i used Paintshop Pro 6 to create the single pictures of the AVI and built the AVI with the animation builder of Paintshop Pro. The created AVI work (at least in the Media Player), but my new AVI is 53k big instead of the 7k of the native shell32.dll. Reducing the color deep of the single picturs does not have any effect to the size of the AVI. What do i need to change to get the resource as small as the native on? Are other tools needed to build the resource? Using compression ? Is there a tool to analyse the native resource in deep ? Any ideas? Thanks Stefan

3 4

Re: Need help interpreting debug log for Wine hard loop
by Miguel Feitosa Oct. 3, 2002

Oct. 3, 2002

On Thu, 2002-10-03 at 18:35, Sean Millichamp wrote: > On Thu, 2002-10-03 at 17:03, Miguel Feitosa wrote: > > I forgot to ask. > > What are the DLLs that your app links? > > It seems that your code is failing before mine. > > Mine actually got to start drawing a window...and yours hasnt. > > I was able to track done my erros to Borlands BWCC or something > > like that .DLL > > Well... I'm not sure how to see what DLL the app links but I suspect it > does need BWCC. I looked and it was installed in C:\Windows\System on > my fake_windows area. I use +file and +dll [I think] I've never done +loaddll Do a simple grep in the wine src and you can see the channels that exist. > > When I do a --debugmsg +loaddll I don't see any mention of bwcc.dll or > any non-builtin DLL. Is there a way I can force-load bwcc? Is there > some reason Wine wouldn't be loading it automatically? No, wine loades DLLs very well. I have never had any problems with that. > > Here are the DLLs that it's installer installed in Windows\System: > bwcc.dll dewcc.dll dewsc.dll dewtc.dll winsys.dll The only one I know is bwcc.dll > > I presume it needs all of them at some point but I see none of them in > use with loaddll before the loop. Do I need to configure this special > in .wine/config? I thought that it was supposed to know to auto-load > them but.... No need to put them in config, they will be loaded, your app is failing before bwcc get's loaded... > > I'm sorry if these are simple questions. I really appreciate you taking > the time to try to help me. If I don't get this working I will have to > install Windows where the application is needed (currently it's all > Linux) and I want to avoid that if possible. No problem, I had to sort through all this too a couple months ago. At the time I was trying to do this, I seach alot and didnt find a whole lot about wine + Borland C... I finally gave it up... I believe that expert wine programmers with the relay can pinpoint the issue that is bugging your app...8-) > > Thanks, > Sean > > See ya! Miguel

1 0

miscemu/wine gets into the way in map_image
by Uwe Bonnes Oct. 3, 2002

Oct. 3, 2002

Hallo, the full installer for XILINX Webpack 5.1 is a 160 MByte executable. It doesn't start with wine: > ~/tmp/wine/compile/wine/wine WebPACK_51_fcfull_i.exe err:virtual:map_image Standard load address for a Win32 program (0x00400000) not available - security-patched kernel ? Clearly my kernel isn't "security-patched". Printing out /proc/maps/self in this situation shows: 08048000-0805c000 r-xp 00000000 03:08 195157 /home/bon/tmp/wine/compile/wine-realclean/wine/miscemu/wine 0805c000-0805d000 rw-p 00013000 03:08 195157 /home/bon/tmp/wine/compile/wine-realclean/wine/miscemu/wine An strace on wine shows the mmap call in map_image: 23236 mmap2(0x400000, 161087488, PROT_READ|PROT_WRITE|PROT_EXEC, MAP_PRIVATE|MAP_ANONYMOUS, -1, 0) = 0x404c2000 Adding 0x400000 and 161087488 gives someting in the 0x09d0000 range. This overlaps with the wine executable itself and mmap2 can't satisfiy the request in place. Any ideas what to do about that? Thanks -- Uwe Bonnes bon(a)elektron.ikp.physik.tu-darmstadt.de Institut fuer Kernphysik Schlossgartenstrasse 9 64289 Darmstadt --------- Tel. 06151 162516 -------- Fax. 06151 164321 ----------

3 5

What do you guys make of this?
by Greg Turner Oct. 3, 2002

Oct. 3, 2002

I'm trying to run StarTeam Client, which used to work as recently as earlier this month. Nowadays, I get infinite recursion in the exception handlers, caused by various NULL pointer deferences within dlls/msvcrt/cppexcept.c. Any ideas? Looks like stack corruption to me... Here's some +seh output: trace:seh:EXC_RtlRaiseException code=e06d7363 flags=1 addr=0x401060f4 trace:seh:EXC_RtlRaiseException info[0]=19930520 trace:seh:EXC_RtlRaiseException info[1]=406f17f0 trace:seh:EXC_RtlRaiseException info[2]=41108f80 trace:seh:EXC_CallHandler calling handler at 0x411075e6 code=e06d7363 flags=1 trace:seh:EXC_CallHandler handler returned 1 trace:seh:EXC_CallHandler calling handler at 0x411074b4 code=e06d7363 flags=1 trace:seh:cxx_frame_handler handling C++ exception rec 0x406f1750 frame 0x406f186c trylevel 0 descr 0x41108c20 exception type: flags 0 destr (nil) handler (nil) type info 0x41108f68 0: flags 1 type 0x4110d400 ((nil) .PAVCStCommandExceptionDetected@@) offset 0 vbase -1,0 size 4 copy ctor (nil) 1: flags 1 type 0x4110d3e0 ((nil) .PAVCException@@) offset 0 vbase -1,0 size 4 copy ctor (nil) 2: flags 1 type 0x4110d440 ((nil) .PAVCObject@@) offset 0 vbase -1,0 size 4 copy ctor (nil) 3: flags 1 type 0x4110d430 ((nil) .PAX) offset 0 vbase -1,0 size 4 copy ctor (nil) function descr: magic 19930520 unwind table: 0x41108c40 4 0: prev -1 func (nil) 1: prev -1 func (nil) 2: prev 1 func (nil) 3: prev 1 func (nil) try table: 0x41108c60 2 0: start 2 end 2 catchlevel 3 catch 0x41108c88 1 0: flags 0 offset -28 handler 0x410fbb63 type 0x4110d3e0 ((nil) .PAVCException@@) 1: start 0 end 0 catchlevel 3 catch 0x41108c98 2 0: flags 0 offset -24 handler 0x410fbb36 type 0x4110d400 ((nil) .PAVCStCommandExceptionDetected@@) 1: flags 0 offset 0 handler 0x410fbb52 type (nil) trace:seh:call_catch_block matched type 0x41108f48 in tryblock 1 catchblock 0 trace:seh:EXC_RtlUnwind code=e06d7363 flags=3 trace:seh:EXC_CallHandler calling handler at 0x4010c310 code=e06d7363 flags=3 trace:seh:EXC_CallHandler handler returned 1 trace:seh:EXC_CallHandler calling handler at 0x411075e6 code=e06d7363 flags=3 trace:seh:EXC_CallHandler handler returned 1 trace:seh:call_catch_block calling catch block 0x41108c98 for type 0x41108f48 addr 0x410fbb36 ebp 0x406f1878 trace:seh:EXC_RtlRaiseException code=e06d7363 flags=1 addr=0x401060f4 trace:seh:EXC_RtlRaiseException info[0]=19930520 trace:seh:EXC_RtlRaiseException info[1]=406f0e6c trace:seh:EXC_RtlRaiseException info[2]=41108df8 trace:seh:EXC_CallHandler calling handler at 0x411074e6 code=e06d7363 flags=1 trace:seh:EXC_CallHandler handler returned 1 trace:seh:EXC_CallHandler calling handler at 0x411074b4 code=e06d7363 flags=1 trace:seh:cxx_frame_handler handling C++ exception rec 0x406f0dd4 frame 0x406f186c trylevel 1 descr 0x41108c20 exception type: flags 0 destr (nil) handler (nil) type info 0x41108de0 0: flags 1 type 0x4110d478 ((nil) .PAVCStBaseServerException@@) offset 0 vbase -1,0 size 4 copy ctor (nil) 1: flags 1 type 0x4110d458 ((nil) .PAVCStException@@) offset 0 vbase -1,0 size 4 copy ctor (nil) 2: flags 1 type 0x4110d3e0 ((nil) .PAVCException@@) offset 0 vbase -1,0 size 4 copy ctor (nil) 3: flags 1 type 0x4110d440 ((nil) .PAVCObject@@) offset 0 vbase -1,0 size 4 copy ctor (nil) 4: flags 1 type 0x4110d430 ((nil) .PAX) offset 0 vbase -1,0 size 4 copy ctor (nil) function descr: magic 19930520 unwind table: 0x41108c40 4 0: prev -1 func (nil) 1: prev -1 func (nil) 2: prev 1 func (nil) 3: prev 1 func (nil) try table: 0x41108c60 2 0: start 2 end 2 catchlevel 3 catch 0x41108c88 1 0: flags 0 offset -28 handler 0x410fbb63 type 0x4110d3e0 ((nil) .PAVCException@@) 1: start 0 end 0 catchlevel 3 catch 0x41108c98 2 0: flags 0 offset -24 handler 0x410fbb36 type 0x4110d400 ((nil) .PAVCStCommandExceptionDetected@@) 1: flags 0 offset 0 handler 0x410fbb52 type (nil) trace:seh:EXC_CallHandler handler returned 1 trace:seh:EXC_CallHandler calling handler at 0x410ceadd code=e06d7363 flags=1 trace:seh:cxx_frame_handler handling C++ exception rec 0x406f0dd4 frame 0x406f19ac trylevel 1 descr 0x410d43f8 exception type: flags 0 destr (nil) handler (nil) type info 0x41108de0 0: flags 1 type 0x4110d478 ((nil) .PAVCStBaseServerException@@) offset 0 vbase -1,0 size 4 copy ctor (nil) 1: flags 1 type 0x4110d458 ((nil) .PAVCStException@@) offset 0 vbase -1,0 size 4 copy ctor (nil) 2: flags 1 type 0x4110d3e0 ((nil) .PAVCException@@) offset 0 vbase -1,0 size 4 copy ctor (nil) 3: flags 1 type 0x4110d440 ((nil) .PAVCObject@@) offset 0 vbase -1,0 size 4 copy ctor (nil) 4: flags 1 type 0x4110d430 ((nil) .PAX) offset 0 vbase -1,0 size 4 copy ctor (nil) function descr: magic 19930520 unwind table: 0x410d4418 7 0: prev -1 func (nil) 1: prev 0 func (nil) 2: prev 1 func 0x410ceabd 3: prev 2 func 0x410ceac6 4: prev 3 func 0x410ceacf 5: prev 0 func (nil) 6: prev -1 func (nil) try table: 0x410d4450 2 0: start 1 end 4 catchlevel 5 catch 0x410d4478 2 0: flags 0 offset -80 handler 0x410abe43 type 0x410de070 ((nil) .PAVCException@@) 1: flags 0 offset 0 handler 0x410abe6d type (nil) 1: start 0 end 5 catchlevel 6 catch 0x410d4498 2 0: flags 0 offset -84 handler 0x410abe9c type 0x410de070 ((nil) .PAVCException@@) 1: flags 0 offset 0 handler 0x410abeb9 type (nil) trace:seh:call_catch_block matched type 0x41108d80 in tryblock 0 catchblock 0 trace:seh:EXC_RtlUnwind code=e06d7363 flags=3 trace:seh:EXC_CallHandler calling handler at 0x4010c310 code=e06d7363 flags=3 trace:seh:EXC_CallHandler handler returned 1 trace:seh:EXC_CallHandler calling handler at 0x411074e6 code=e06d7363 flags=3 trace:seh:EXC_CallHandler handler returned 1 trace:seh:EXC_CallHandler calling handler at 0x411074b4 code=e06d7363 flags=3 trace:seh:EXC_CallHandler handler returned 1 trace:seh:call_catch_block calling catch block 0x410d4478 for type 0x41108d80 addr 0x410abe43 ebp 0x406f19b8 trace:seh:EXC_RtlRaiseException code=e06d7363 flags=1 addr=0x401060f4 trace:seh:EXC_RtlRaiseException info[0]=19930520 trace:seh:EXC_RtlRaiseException info[1]=00000000 trace:seh:EXC_RtlRaiseException info[2]=00000000 trace:seh:EXC_CallHandler calling handler at 0x410ceadd code=e06d7363 flags=1 trace:seh:EXC_RtlRaiseException code=c0000005 flags=0 addr=0x40f3e9a3 trace:seh:EXC_RtlRaiseException info[0]=00000000 trace:seh:EXC_RtlRaiseException info[1]=00000008 trace:seh:EXC_CallHandler calling handler at 0x4010c310 code=c0000005 flags=0 trace:seh:EXC_CallHandler handler returned 2 trace:seh:EXC_CallHandler calling handler at 0x410ceadd code=c0000005 flags=10 trace:seh:cxx_frame_handler handling C++ exception rec 0x405e09d8 frame 0x406f19ac trylevel 5 descr 0x410d43f8 exception type: trace:seh:EXC_RtlRaiseException code=c0000005 flags=0 addr=0x40f3e1f5 trace:seh:EXC_RtlRaiseException info[0]=00000000 trace:seh:EXC_RtlRaiseException info[1]=0000000c trace:seh:EXC_CallHandler calling handler at 0x4010c310 code=c0000005 flags=0 trace:seh:EXC_CallHandler handler returned 2 trace:seh:EXC_CallHandler calling handler at 0x4010c310 code=c0000005 flags=10 trace:seh:EXC_CallHandler handler returned 2 trace:seh:EXC_CallHandler calling handler at 0x410ceadd code=c0000005 flags=10 trace:seh:cxx_frame_handler handling C++ exception rec 0x405dfe98 frame 0x406f19ac trylevel 5 descr 0x410d43f8 exception type: trace:seh:EXC_RtlRaiseException code=c0000005 flags=0 addr=0x40f3e1f5 trace:seh:EXC_RtlRaiseException info[0]=00000000 trace:seh:EXC_RtlRaiseException info[1]=0000000c trace:seh:EXC_CallHandler calling handler at 0x4010c310 code=c0000005 flags=0 trace:seh:EXC_CallHandler handler returned 2 trace:seh:EXC_CallHandler calling handler at 0x4010c310 code=c0000005 flags=10 trace:seh:EXC_CallHandler handler returned 2 trace:seh:EXC_CallHandler calling handler at 0x4010c310 code=c0000005 flags=10 trace:seh:EXC_CallHandler handler returned 2 trace:seh:EXC_CallHandler calling handler at 0x410ceadd code=c0000005 flags=10 . . . and so on, forever. The experience in a debugger is that the exception type becomes NULL and is passed around like that until it gets deferenced. Then all hell breaks loose. I don't understand where __wine_call_from_32_regs lives in the source, and lose track of what's going on in there, thwarting my debugging efforts. -- gmt "If ye love wealth better than liberty, the tranquility of servitude better than the animating contest of freedom, go home from us in peace. We ask not your counsels or your arms. Crouch down and lick the hands, which feed you. May your chains set lightly upon you, and may posterity forget that ye were our countrymen." -Samuel Adams

2 3

spec files and handles
by steve.lustbader＠philips.com Oct. 3, 2002

Oct. 3, 2002

With functions that take HANDLEs as arguments, what should that argument be listed as in the spec file? I thought HANDLEs were void *'s, so ptr would seem right. I found a function (DebugBreakProcess in kernel32.spec) that takes a HANDLE and has that listed as long in the spec. So which should it be - ptr or long? -Steve

2 1

Re: RPC merge (PL0)
by Ove Kaaven Oct. 3, 2002

Oct. 3, 2002

On Wed, 2 Oct 2002, Greg Turner wrote: > OK, here's a first chunk of Jürgen Schmied's RPC patches. > > This is roughly equivalent to the stuff I posted recently, just > not my code anymore (which is a good thing 'cause my code > had some bugs). Some very minor changes may exist between this > and the original patch but it's intended to be basically > the same stuff. > > LICENSE: > "OK to put it into Wine" Is it OK for you if it gets into ReWind too? Then just say X11, otherwise say LGPL. > just a thought: > are statics guaranteed to be zero'ed out, as this code > seems to assume? Yes, uninitialized static and global variables are allocated in the .bss section, which is always explicitly zeroed on load. You could make it an initialized variable if you don't feel comfortable with it, though (something like static UUID uuid_nil = {0};), which will allocate it in the .data section instead, so the initial value will be embedded in the compiled binaries.

1 0

Re: Patch - Makefile.in shell32
by Alexandre Julliard Oct. 2, 2002

Oct. 2, 2002

Steven Edwards <Steven_Ed4153(a)yahoo.com> writes: > Changelog: Dont include win16 shell support when building without > win16. (Untested under *NIX) It doesn't link with --disable-win16: iconcache.o: In function `ExtractAssociatedIconA': /home/julliard/wine/wine/dlls/shell32/iconcache.c:465: undefined reference to `ExtractAssociatedIcon16' shell32_main.o: In function `ExtractIconA': /home/julliard/wine/wine/dlls/shell32/shell32_main.c:526: undefined reference to `InternalExtractIcon16' -- Alexandre Julliard julliard(a)winehq.com

1 0