- Wine-Devel - list.winehq.org

Re: Small 'let's prevent a crash' fix
by Lionel Ulmer July 2, 2002

July 2, 2002

> This does not fix the real problem (ie why does this DC not have a font even > if the application called a 'SelectObject' on it), but well, it cannot harm > to be more verbose and to prevent crashes if possible :-) OK, found the 'error' : the problem comes from the fact that I am using client-side fonts (aka XRender) : so the 'font' part of the physDev structure is always '0'. And that also means that we cannot use as is the glXUseXFont function. So basically, I need to implement it myself using 'GetGlyphOutline' (should not be that hard to do :-) ). Now my question : is 'GetGlyphOutline' always working even when not using client-side fonts ? If yes, I will completely remove the call to glXUseXFonts (I know, in that case, fonts displayed by OpenGL will be different by the one displayed by X, but well, ...) and always use the manual 'GetGlyphOutline' function. And I will try at the same time to remove all GLX calls from wgl.c and put them in special X11DRV escapes to have a real X11 free wgl.c file (ie for example, creating an OpenGL context would be a special escape for the X11DRV as it's basically something that is in GLX). Lionel -- Lionel Ulmer - http://www.bbrox.org/

2 1

Re: Removed extra , from enum declarations
by Andreas Mohr July 2, 2002

July 2, 2002

On Tue, Jul 02, 2002 at 03:39:04PM -0400, Gregg Mattinson wrote: > Resubmitting because I forgot to attach the file. Sorry. I'm also sorry about > the large number of posts today. You feel sorry about WHAT !? Heck, I guess you might have a minimalistic reason to feel sorry once you manage to crash the mailing list server due to sending way too many patches, but until that happens... ;-) Have a nice day ! -- "My attitude is, everybody should try competing with Microsoft once in their life. Once." - Marc Andreessen, former Netscape lead employee, in a "browser wars" interview

1 0

Re: Added support for APPMODE=<type>[:<mainFunc>]
by Joerg Mayer July 2, 2002

July 2, 2002

On Tue, Jul 02, 2002 at 04:06:56PM -0400, Gregg Mattinson wrote: > - .spec files can't be compiled with -g when using Forte C. This causes static > variables to have a "random" prefix attached to their name, and prevents the > assembly code from linking to them correctly. > - Forte C has linker issues, so cui executables with main() conflicted with > main() in $WINELOADER. Renaming main() to main2() solved the issue, so I added > support to winebuild to allow the main function name to be optionally specified > in the makefile. > - Forte C does not support .previous It was replaced with a .section statement > for the appropriate section > - '.section .text' is incorrect. It should be '.section ".text"' You omitted: - Replace constants by numeric values (aka magic numbers). > - fprintf( outfile, " rec.code = 0x%08x;\n", EXCEPTION_WINE_STUB ); > + fprintf( outfile, " rec.code = 0x%08x;\n", 0x80000100 ); - Inserted compiler specific compilation (as opposed to feature specific compilation) > +#ifndef __SUNPRO_C > fprintf( outfile, "\n#include \"pshpack1.h\"\n" ); > +#endif - Removed some unneeded includes. Ciao Jörg -- Joerg Mayer <jmayer(a)loplof.de> I found out that "pro" means "instead of" (as in proconsul). Now I know what proactive means.

1 0

Re: Void functions can't return a value
by Joerg Mayer July 2, 2002

July 2, 2002

On Tue, Jul 02, 2002 at 03:34:44PM -0400, Gregg Mattinson wrote: > - void functions can't return a value, even if it is the return value from > another void function. Just looking at the patch a bit. This looks wrong to me. If you want to make the changes, you should convert return xxx() into { xxx(); return } > void WINAPI PathStripPathAW(LPVOID lpszPath) > { > if (SHELL_OsIsUnicode()) > - return PathStripPathW(lpszPath); > - return PathStripPathA(lpszPath); > + PathStripPathW(lpszPath); > + PathStripPathA(lpszPath); <----- should not be executed if condition is met > } This pattern is repeated several times. Ciao Jörg -- Joerg Mayer <jmayer(a)loplof.de> I found out that "pro" means "instead of" (as in proconsul). Now I know what proactive means.

1 0

Re: heads up: wine 20020605 broken on FreeBSD, workaround included
by Gerald Pfeifer July 2, 2002

July 2, 2002

[ I'm now also Cc:ing this to the Wine developers, thus the full-quote. In fact, all non-GLIBC platforms seem to be affected by this bug! ] Based on your pointer, I believe I found the problem. In aclocal.m4 we have: AC_DEFUN([WINE_CHECK_ERRNO], [AC_CACHE_CHECK([for reentrant libc: $1],[wine_cv_libc_r_$1], [AC_TRY_RUN([int myerrno = 0; char buf[256]; int *$1(){return &myerrno;} main(){connect(0,buf,255); exit(!myerrno);}], wine_cv_libc_r_$1=yes, wine_cv_libc_r_$1=no, wine_cv_libc_r_$1=yes)]) AS_IF([test "$wine_cv_libc_r_$1" = "yes"],[$2],[$3])]) which, in configure, becomes: int myerrno = 0; char buf256; int *__error(){return &myerrno;} main(){connect(0,buf,255); exit(!myerrno);} That is, instead of an array of 256 characters, we have one character, and the invocation of connect() is definitely incorrect. Could someone more familiar with autoconf please have a look at this? Gerald On Mon, 1 Jul 2002, Scott Bolte wrote: > Over the weekend I tried to get wine 20020605 to run on a > new installation of FreeBSD 4.6. It took a while, I haven't > tried wine since 1997 after all, but I determined that my > problems were due to configure's reentrant libc test failing > when building the port. > > The wine_cv_libc_reentrant test in configure.ac first checks > for Linux (__errno_location) and then tests for FreeBSD > (__error). I don't have more time to figure out why, but > nesting the FreeBSD test that way results in a false > negative. The configuration will continue, as will the > build, but the resulting non-reentrant code goes into an > endless loop when trying to spawn threads. > > A crude workaround, for FreeBSD users at least, is to > replace the Linux test with the FreeBSD one. This needs to > be done before configure is run. I did it by hand, but I > expect the following code would do the trick. > > % cd /usr/ports/emulators/wine > % make patch > % perl -i -pe 's/__errno_location/__error/' work/wine-20020605/configure.ac > % make > % make install > > Below is the autoconf test script that demonstrates the > problem. It needs to be run in > /usr/ports/emulators/wine/work/wine-20020605/configure.ac > > Scott > > P.S. I'm not on the freebsd-emulators mailing list, but I > see from freebsd-questions that at least one other > person got wine to compile on 4.6. I can't explain > why it worked for him and not for me. However, I > installed a brand new copy of 4.6 from the standard > ISO images just to run wine. > > ---- testconf.ac > dnl Process this file with autoconf to produce a configure script. > dnl Original author: Michael Patra > dnl See ChangeLog file for detailed change history. > > m4_define(WINE_VERSION,regexp(m4_include(VERSION),[version $[-.0-9A-Za-z]+$],[\1])) > > AC_PREREQ(2.53) > AC_INIT([Wine],WINE_VERSION) > AC_CONFIG_SRCDIR(server/atom.c) > AC_CONFIG_AUX_DIR(tools) > > dnl **** Check for some programs **** > > AC_PROG_CC > > dnl **** Check for reentrant libc **** > > wine_cv_libc_reentrant=no > > dnl ##### > dnl ##### There is a problem if the FreeBSD test is nested > dnl ##### after the Linux test. In that instance, it fails. > dnl ##### If, on the other hand, it is tested first, it works. > dnl ##### > dnl ##### Swap the order of two following test case to see > dnl ##### how they differ. (Ignore the second case since it > dnl ##### will use cached data.) > dnl ##### > > dnl FreeBSD style errno location > WINE_CHECK_ERRNO([__error], [wine_cv_libc_reentrant=__error]) > > dnl Linux style errno location > WINE_CHECK_ERRNO([__errno_location], [wine_cv_libc_reentrant=__errno_location], > dnl FreeBSD style errno location > WINE_CHECK_ERRNO([__error], [wine_cv_libc_reentrant=__error] > )) > -- Gerald "Jerry" pfeifer(a)dbai.tuwien.ac.at http://www.dbai.tuwien.ac.at/~pfeifer/

3 4

Bug in RegEnumValueA ?
by Massimo July 2, 2002

July 2, 2002

Again investigating AutoCAD r14 app under wine, I found a bug that make app hang when some registry values are present. At first I've made a script that cleans up registry before launching AutoCAD,but this was only a way-around to the problem. Looking at relay output, I found a loop in calling RegEnumValueA : // @@@@ START OF LOOP BLOCK HERE......... :Call advapi32.dll.RegEnumValueA (000000cc,00000001,40486844,404868ec,00000000,404868f4,41e62020, 404868fc) ret=008a3850 :Call ntdll.dll.NtEnumerateValueKey (000000cc,00000001,00000001,40486544,00000100,40486540) ret=406afb24 :Ret ntdll.dll.NtEnumerateValueKey() retval=00000000 ret=406afb24 :Call ntdll.dll.RtlUnicodeToMultiByteSize(4048653c,40486558 L"REGPATH\\\\HKEY_LOCAL_MACHINE\\Software\\Autodesk\\AutoCAD\\R1 4.0\\ACAD-2452448:80143967\\AutodeskApps\\LsObj",0000000e) ret=406afc03 :Ret ntdll.dll.RtlUnicodeToMultiByteSize() retval=00000000 ret=406afc03 :Call ntdll.dll.RtlUnicodeToMultiByteN (40486844,00000007,00000000,40486558,0000000e) ret=406afc24 :Ret ntdll.dll.RtlUnicodeToMultiByteN() retval=00000000 ret=406afc24 :Call ntdll.dll.RtlUnicodeToMultiByteSize(40486538,40486566 L"\\\\HKEY_LOCAL_MACHINE\\Software\\Autodesk\\AutoCAD\\R14.0\\AC AD-2452448:80143967\\AutodeskApps\\LsObj",000000bc) ret=406afc77 :Ret ntdll.dll.RtlUnicodeToMultiByteSize() retval=00000000 ret=406afc77 :Call ntdll.dll.RtlNtStatusToDosError(80000005) <--ERROR HERE ! ret=406afd5d :Ret ntdll.dll.RtlNtStatusToDosError() retval=000000ea ret=406afd5d :Ret advapi32.dll.RegEnumValueA() retval=000000ea ret=008a3850 <-- MORE DATA AVAILABLE RETURN (AUTOCAD KEEPS TRYING TO GET DATA) // @@@@ END OF LOOP BLOCK HERE Here RegEnumValueA returns an error of invalid buffer; Looking into code it seems to me that the NtEnumerateValueKey() used to find the largest name and value sizes of keys to be enumerated returns a wrong size; next use for reading the key gives an arror of buffer overflow, being it allocated with wrong (too small) size. AutoCAD keeps trying to get the keys/values, in and endless loop. Looking more with some debug print statements, it appears that Autocad allocates 4 bytes of buffer for the value, but RegEnumValueA needs much more, 94 in this case, giving an Out-Of-Buffer error back. It seems to me that the 94 bytes are for the name of the key, not for the value.... Regards Max

3 2

alsa disable configure?
by Chris Thielen July 2, 2002

July 2, 2002

Are there any patches in waiting to disable the use of ALSA in the configure script ... or is this not needed?

1 0

IsDialogMessageA/W question
by Sander van Leeuwen July 1, 2002

July 1, 2002

Hi, Is there a specific reason why unprocessed messages in IsDialogMessage don't get dispatched? Experiments in Windows 2000 show this is not (always) correct. It seems all messages passed on to IsDialogMessage are dispatched and it always returns 1. IsDialogMessage doesn't call DispatchMessage, but the function called internally by DispatchMessage. Changing the behaviour to match Windows 2000 fixes at least one problem I noticed in an MFC application (button getting stuck when using the spacebar). There's not much information in MSDN about this function, so I can't say if IsDialogMessage always behaves like this. Sander

3 2

Re: Using win dll with wine
by psuchomel＠volny.cz July 1, 2002

July 1, 2002

I can not simply transfer this code from Windows (under them it is compilable and working) to Wine, because this code is bridge beetwen my Java app and this dll. Because it depends on Windows natives of Sun JVM, it can not be directly run under Linux. My problem: How to brand (?) part of Wine, to be able use this dll f.e. with Qt Canvas or X11 rendering?. The example shows only some of the simpliest parts of this one, primary it is used as native rendering engine (and this engine exist only as dll for Windows, I do not expect there will be version for Linux in suitable time for me). Petr

1 0

Usind win dll with wine
by psuchomel＠volny.cz July 1, 2002

July 1, 2002

Hi wine gurus I have some dll, I want to run under Linux. I try to study Wine docs, but, if I say the truth, I did not make me clever so much. Please, could you help me port this part of win code (extracted from my java <--> cpp bridge) under Linux? Petr //define dll handler HINSTANCE hInst = NULL; //define entry in dll typedef char* (_pascal * GLL_version)(); //here is some call //load library if( hInst == NULL ) hInst = LoadLibrary("mylib"); if( hInst == NULL ) return; //get proc address FARPROC proc = GetProcAddress(hInst, "GLL_VERSION"); //and call it if (proc != NULL) printf("%s", (char*)(GLL_version)proc()); //free handler FreeLibrary(hInst); hInst = NULL;

2 1