- Wine-Devel - list.winehq.org

Re: Patches for FreeBSD 5.x compilation
by Alexandre Julliard Nov. 20, 2001

Nov. 20, 2001

Steve Kargl <sgk(a)troutmask.apl.washington.edu> writes: > What I questioned was the criticism that FreeBSD was guilty > of namespace pollution. Alexandre isn't the only wine > developer who made this statement (check usenet). The header > files in question are implementation dependent and can > contain any variable name or #define or typedef. The fact is > that both wine and FreeBSD have struct thread in implementation > header files. AFAICT, neither is incorrect. The Wine headers that define struct thread are only used inside Wine; the FreeBSD headers are used by applications, no matter how much you argue they are internal headers. So the situation is very different. > But, to have > a wine developer emphatically state that FreeBSD needs to > fix its system header files is somewhat surprising. Why is > it surprising to me? Because this reminds me a company here > in Seattle. I couldn't care less whether FreeBSD fixes its headers or not; we will need to work around the problem in Wine in any case. I was simply expressing the opinion that changing this would make FreeBSD better. I'm certainly not demanding that the FreeBSD guys fix it, if they feel exporting struct thread is a good idea it's their choice. -- Alexandre Julliard julliard(a)winehq.com

1 0

Re: LibaudioIO Patch for Solaris
by eric pouech Nov. 20, 2001

Nov. 20, 2001

Robert Lunnon wrote: > > Attached find files for libaudioio patch for audio on solaris 7 > > winmm.diff - Only the makefile patch is significant wavemap, just contains > some extra debugging traces > > libaudioio.tar, libaudioio goes under winmm > > base.diff, Patches to configure.in and Makefile.in to better support Solaris > and Libaudioio > > config.h.in added HAVE_SOLARIS and HAVE_LIBAUDIOIO and added a way for force > a 32 bit mmap. a few comments : - why do you add the libaudioio lib to winmm ? it should only be linked against the libaudioio (or whatever) driver... winmm should be independant of any driver... - in the libaudioio subdir: + you shouldn't use C++ comment. wine is a C project + it would a good idea to remove any reference to OSS in libaudioio... + I don't think that libaudioio supports midi... so, the preferred way to handle this would be to create a driver which doesn't export the midMessage and modMessage, and to get rid of midi.c and midipatch.c (same for mixMessage/mixer.c and auxMessage/aux.c) (it seems midi.c and mixer.c are protected by non existent HAVE_LIBAUDIO_MIDI and HAVE_LIBAUDIOIO_MIXER which are defined nowhere) + so the driver should only be made of the wave.c part and oss.c (which should be renamed to IMO) + anyway, I think that the libaudioio subdir should be named against the name of the DLL, which is audioio (eventually, since it's a wine only DLL, and to prevent DLL name collisions, I'd call it wineaudioio(.drv) - I don't see any reasons to define HAVE_SOLARIS... this is a wrong practice for system dependancies anyway A+ -- --------------- Eric Pouech (http://perso.wanadoo.fr/eric.pouech/) "The future will be better tomorrow", Vice President Dan Quayle

1 0

Re: Patches for FreeBSD 5.x compilation
by Alexandre Julliard Nov. 20, 2001

Nov. 20, 2001

Steve Kargl <sgk(a)troutmask.apl.washington.edu> writes: > Can you please explain how this is namespace pollution on the > part of the OS? AFAIK, <sys/user.h> is not specified by any > Standard (ISO C89, C90, or C99). <sys/user.h> can include > any (unprotected) variable name. Yes of course it can, but the fact that this isn't explicitly forbidden by some standard doesn't mean it's good practice or that it doesn't pollute the namespace. sys/user.h is also legally allowed to do "#define if else"; that doesn't make it a good idea. > If an application includes > <sys/user.h>, then the application should be prepared to > deal with conflicts. Great, then you need to fix all applications every time someone feels like exporting a new symbol from user.h. Of course user.h is a pretty obscure header so it's no big deal, but it would be easier to avoid exporting stuff under such common names as "struct thread". -- Alexandre Julliard julliard(a)winehq.com

4 4

interesting comment about WINE from MS
by Igor Nov. 20, 2001

Nov. 20, 2001

As far as WINE and Mono are concerned, I'm just not sure whether these organizations will end up being able to produce satisfactory products. The real problem is this: it is not good enough for WINE to run some Windows apps. If the general public is going to consume it, it must run all Windows apps. Windows 2000/XP has a significant level of POSIX compliancy, but many developers just don?t write their apps with these standards in mind. You'll find pieces of code everywhere in third party apps which run statements like if (WINVER==4.0 && GrokTheBIOSForSomeACPIGoo()), which have not been tested to see whether they will run on non-Windows/x86 platforms. In fact, Microsoft has had to put in significant time and effort to insure that older Win32 applications originally written to run in Win95 will run in NT." original article is here http://www.osnews.com/story.php?news_id=314

1 0

Implementation of TB_REPLACEBITMAP
by Marco Bizzarri Nov. 20, 2001

Nov. 20, 2001

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi all. I'm trying to provide an implementation of TB_REPLACEBITMAP Included is the patch I've done to record the bitmaps which are provided to the toolbar and to replace them when the message arrives. Even though the number of buttons displayed is correct, the output is otherwise garbled. I would appreciate any suggestion on this topic. The platform is a RH Linux 6.2. wine is from CVS (20/11/2001) - -- Marco Bizzarri - Responsabile Tecnico - Icube S.r.l. Sede: Via Ridolfi 15 - 56124 Pisa (PI), Italia E-mail: m.bizzarri(a)icube.it WWW: www.icube.it Tel: (+39) 050 97 02 07 Fax: (+39) 050 31 36 588 -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.0.6 (GNU/Linux) Comment: For info see http://quantumlab.net/pine_privacy_guard/ iD8DBQE7+oUXXhfyAQQVoaIRAudsAJ9QEbPYChk0YpTonozvkjUge4HtjACgl8cg A87v4vPHKOeeCgj6LpW18dw= =J2rq -----END PGP SIGNATURE-----

1 0

audio.c fault reproduction
by Simon Britnell Nov. 20, 2001

Nov. 20, 2001

I downloaded and ran the QuickTime installer and the Pajama Sam demo last PM. I have reproduced the problem with Pajama Sam (it seems that ends of samples are either not playing or being overwritten), but I can't get QuickTimePlayer.exe to do anything at all. I'll investigate the Pajama Sam problems over the remainder of the week. __________________________________________________ Do You Yahoo!? Yahoo! GeoCities - quick and easy web site hosting, just $8.95/month. http://geocities.yahoo.com/ps/info1

2 1

RE: MIDL and COM
by Patrik Stridvall Nov. 20, 2001

Nov. 20, 2001

> On 16 Nov 2001, Alexandre Julliard wrote: > > > Ove Kaaven <ovehk(a)ping.uio.no> writes: > > > > > But can the machine-generated sources that MIDL outputs > be put into the > > > official Wine source? > > > > I'd prefer not. If we want to use .idl files we'll have to come up > > with our own compiler, and then we can put the .idl source > in the tree > > and compile it at build time. > > Hmm. Even when using flex and bison, it sounds like a fair amount of > work... wonder who would volunteer? There already are a multitude of open souce (GPL and otherwise) CORBA .idl compilers. Of course Wine have probably slightly different requirements but I should guess that we could save 90% of the work compared to writing it from scratch. Alexandre: Is a GPL:ed (or possible different licenced) .idl compiler acceptable? > > > And how about source IDL files? Can we put into Wine IDL > extracted from > > > real Windoze .tlb files with a tool like oleview.exe, or > IDL parsed from > > > MIDL-generated Windows SDK .h files, like objidl.h, with a script? > > > > No, anything generated from a Windows file is copyrighted by > > Microsoft, so we cannot distribute it. We need to rewrite > these files > > from scratch, just like we do for the normal headers. > > Now where are all the usual non-lawyers on this list who > would argue that > API definitions, like prototypes in header files (which of > course IDL, as > a formalized API spec format, is all about), cannot be copyrighted? > Oh well... I'm here. :-) Well, I wouldn't really go quite that far. The API definitions in themselves can't be copyrighted, true. But a specific way of expressing them is, so compiling any Microsoft file will generate create a derived work copyrighted by Microsoft as the main rule. However it is not quite that easy, since only the specific expression is protected, the compilation result is only a derived work if it still contains any protected expression. In light of this you could argue that since, I presume, MIDL removes whitespace and commments which is IIRC the only really expression, since the rest the API defintions are just facts, that the MIDL compiled files just contains facts not any part of the protected expression. However that is a little thin line to walk, since there is quite of lack of real cases in the area, so I would recommend that we do as Alexandre suggest. Beside having the real .idl files in the Wine tree might be useful for other things as well.

1 0

Re: MIDL and COM
by Alexandre Julliard Nov. 20, 2001

Nov. 20, 2001

Ove Kaaven <ovehk(a)ping.uio.no> writes: > Problem 1: MIDL-generated code. > midl.exe is Microsoft's IDL compiler, it reads .idl files which describe > RPC and COM interface, from which it generates .c files, .h files, and > typelibs. (It is possible to find copies of midl.exe floating on the net, > as some people have put together "COM kits" for Borland C++ that contains > midl.exe and some standard .idl files and put them on the web) > > But can the machine-generated sources that MIDL outputs be put into the > official Wine source? I'd prefer not. If we want to use .idl files we'll have to come up with our own compiler, and then we can put the .idl source in the tree and compile it at build time. > And how about source IDL files? Can we put into Wine IDL extracted from > real Windoze .tlb files with a tool like oleview.exe, or IDL parsed from > MIDL-generated Windows SDK .h files, like objidl.h, with a script? No, anything generated from a Windows file is copyrighted by Microsoft, so we cannot distribute it. We need to rewrite these files from scratch, just like we do for the normal headers. > Problem 2: RPCSS > rpcss.exe is the place that keeps track of which process owns which RPC > endpoints, exported COM objects, and object activation tables. > The IRunningObjectTable interface, for example, is managed by rpcss.exe, > and keeps track of certain kinds of COM objects on the computer, so that > other processes can connect to running COM objects. We probably don't want > Wine to have to run a separate process for this? If not, can we put this > kind of COM stuff into the wineserver? I'd prefer having a separate process, at least in the first stage. -- Alexandre Julliard julliard(a)winehq.com

2 1

audio.c regression on Nov. 10th
by Ori Pessach Nov. 20, 2001

Nov. 20, 2001

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi, Despite my previous report on this, something did break in audio.c between November 9th and November 10th. I checked out a version from 11/09/2001, and it works. I updated just audio.c with -D 11/10/2001, and Humongous Entertainment games don't recognize the sound card anymore. There have been substantial changes to audio.c during those 24 hours - enough to confuse diff, as a matter of fact. I'll look into it, but I wanted to report this first. The reason I thought earlier that the problem went away was that I had a sticky date on audio.c that I wasn't aware of. Ori Pessach -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.0.6 (GNU/Linux) Comment: http://www.oripessach.com iD8DBQE7+VXUzA/uWWyw6uQRAmkHAJ94A+IW82jXdhhLl6ODWaUs7I+SwACg16oT FIIymJ5xAP6eNc+5GlbQ3SU= =zHkd -----END PGP SIGNATURE----- _________________________________________________________ Do You Yahoo!? Get your free @yahoo.com address at http://mail.yahoo.com

2 1

Re: Patches for FreeBSD 5.x compilation
by Alexandre Julliard Nov. 19, 2001

Nov. 19, 2001

Francois Gouget <fgouget(a)free.fr> writes: > I guess that one day Alexandre is going to argue that Linux should > stop polluting the namespace with 'struct user'... Well, struct user is the only reason for including sys/user.h, so I guess it can be considered acceptable; but anything else defined in there (like struct user_regs_struct on Linux) is namespace pollution too IMO. And if there comes a day when the server is managing users, the corresponding struct will definitely be named struct user, not struct wine_unique_prefix_0918274_user or whatever (and note that we don't really need user.h even on Linux, we could just as well hardcode the offset). -- Alexandre Julliard julliard(a)winehq.com

2 1