- Wine-Devel - list.winehq.org

min/max and types
by eric pouech Sept. 15, 2001

Sept. 15, 2001

just for fun, I tried compiling Wine with Linux latest min/max macros definitions Index: include/windef.h =================================================================== RCS file: /usr/share/cvs/cvsroot/wine/wine/include/windef.h,v retrieving revision 1.58 diff -u -r1.58 windef.h --- include/windef.h 2001/07/30 18:57:18 1.58 +++ include/windef.h 2001/09/14 18:06:53 @@ -133,6 +133,27 @@ #define min(a,b) (((a) < (b)) ? (a) : (b)) #endif #endif /* NOMINMAX */ +#if defined(__WINE__) && defined(__GNUC__) +#undef max +#undef min +#define min(x,y) \ + ({ const typeof(x) _x = x; \ + const typeof(y) _y = y; \ + \ + (void) (&_x == &_y); \ + \ + _x < _y ? _x : _y; \ + }) + +#define max(x,y) \ + ({ const typeof(x) _x = x; \ + const typeof(y) _y = y; \ + \ + (void) (&_x == &_y); \ + \ + _x > _y ? _x : _y; \ + }) +#endif #ifndef _MAX_PATH /* FIXME: These are supposed to be in stdlib.h only */ here's the output (the list of types mismatches in min/max calls...) to whomever feels like fixing them (if needed) registry.c:386: warning: comparison of distinct pointer types lacks a cast registry.c:1246: warning: comparison of distinct pointer types lacks a cast trace.c:69: warning: comparison of distinct pointer types lacks a cast trace.c:147: warning: comparison of distinct pointer types lacks a cast reg.c:177: warning: comparison of distinct pointer types lacks a cast reg.c:195: warning: comparison of distinct pointer types lacks a cast reg.c:209: warning: comparison of distinct pointer types lacks a cast reg.c:224: warning: comparison of distinct pointer types lacks a cast reg.c:232: warning: comparison of distinct pointer types lacks a cast reg.c:306: warning: comparison of distinct pointer types lacks a cast reg.c:318: warning: comparison of distinct pointer types lacks a cast reg.c:328: warning: comparison of distinct pointer types lacks a cast reg.c:379: warning: comparison of distinct pointer types lacks a cast reg.c:416: warning: comparison of distinct pointer types lacks a cast reg.c:496: warning: comparison of distinct pointer types lacks a cast dos_fs.c:2201: warning: comparison of distinct pointer types lacks a cast dos_fs.c:2202: warning: comparison of distinct pointer types lacks a cast drive.c:926: warning: comparison of distinct pointer types lacks a cast file.c:1884: warning: comparison of distinct pointer types lacks a cast profile.c:120: warning: comparison of distinct pointer types lacks a cast module.c:1644: warning: comparison of distinct pointer types lacks a cast module.c:1645: warning: comparison of distinct pointer types lacks a cast heap.c:645: warning: comparison of distinct pointer types lacks a cast local.c:401: warning: comparison of distinct pointer types lacks a cast local.c:891: warning: comparison of distinct pointer types lacks a cast registry.c:507: warning: comparison of distinct pointer types lacks a cast version.c:477: warning: comparison of distinct pointer types lacks a cast int21.c:857: warning: comparison of distinct pointer types lacks a cast int21.c:861: warning: comparison of distinct pointer types lacks a cast ole2nls.c:435: warning: comparison of distinct pointer types lacks a cast process.c:1251: warning: comparison of distinct pointer types lacks a cast process.c:1276: warning: comparison of distinct pointer types lacks a cast process.c:1312: warning: comparison of distinct pointer types lacks a cast process.c:1345: warning: comparison of distinct pointer types lacks a cast console.c:170: warning: comparison of distinct pointer types lacks a cast console.c:429: warning: comparison of distinct pointer types lacks a cast console.c:982: warning: comparison of distinct pointer types lacks a cast console.c:984: warning: comparison of distinct pointer types lacks a cast console.c:1294: warning: comparison of distinct pointer types lacks a cast console.c:1345: warning: comparison of distinct pointer types lacks a cast registry.c:785: warning: comparison of distinct pointer types lacks a cast registry.c:1001: warning: comparison of distinct pointer types lacks a cast registry.c:1082: warning: comparison of distinct pointer types lacks a cast enhmetafile.c:203: warning: comparison of distinct pointer types lacks a cast enhmetafile.c:229: warning: comparison of distinct pointer types lacks a cast enhmetafile.c:230: warning: comparison of distinct pointer types lacks a cast enhmetafile.c:1702: warning: comparison of distinct pointer types lacks a cast dde/misc.c:1963: warning: comparison of distinct pointer types lacks a cast message.c:962: warning: comparison of distinct pointer types lacks a cast resource.c:320: warning: comparison of distinct pointer types lacks a cast resource.c:370: warning: comparison of distinct pointer types lacks a cast text.c:318: warning: comparison of distinct pointer types lacks a cast menu.c:847: warning: comparison of distinct pointer types lacks a cast menu.c:849: warning: comparison of distinct pointer types lacks a cast menu.c:917: warning: comparison of distinct pointer types lacks a cast menu.c:918: warning: comparison of distinct pointer types lacks a cast menu.c:931: warning: comparison of distinct pointer types lacks a cast cursoricon.c:519: warning: comparison of distinct pointer types lacks a cast timer.c:155: warning: comparison of distinct pointer types lacks a cast winpos.c:1811: warning: comparison of distinct pointer types lacks a cast winpos.c:1812: warning: comparison of distinct pointer types lacks a cast winproc.c:1755: warning: comparison of distinct pointer types lacks a cast winproc.c:1768: warning: comparison of distinct pointer types lacks a cast winproc.c:1901: warning: comparison of distinct pointer types lacks a cast winpos.c:1733: warning: comparison of distinct pointer types lacks a cast winpos.c:1734: warning: comparison of distinct pointer types lacks a cast winpos.c:1738: warning: comparison of distinct pointer types lacks a cast winpos.c:1739: warning: comparison of distinct pointer types lacks a cast winpos.c:1743: warning: comparison of distinct pointer types lacks a cast winpos.c:1744: warning: comparison of distinct pointer types lacks a cast winpos.c:1748: warning: comparison of distinct pointer types lacks a cast winpos.c:1749: warning: comparison of distinct pointer types lacks a cast winpos.c:1815: warning: comparison of distinct pointer types lacks a cast winpos.c:1816: warning: comparison of distinct pointer types lacks a cast winpos.c:1817: warning: comparison of distinct pointer types lacks a cast winpos.c:1818: warning: comparison of distinct pointer types lacks a cast xfont.c:3336: warning: comparison of distinct pointer types lacks a cast xfont.c:3339: warning: comparison of distinct pointer types lacks a cast lolvldrv.c:106: warning: comparison of distinct pointer types lacks a cast mmsystem.c:986: warning: comparison of distinct pointer types lacks a cast comboex.c:395: warning: comparison of distinct pointer types lacks a cast listview.c:723: warning: comparison of distinct pointer types lacks a cast listview.c:780: warning: comparison of distinct pointer types lacks a cast listview.c:3123: warning: comparison of distinct pointer types lacks a cast listview.c:7940: warning: comparison of distinct pointer types lacks a cast propsheet.c:145: warning: comparison of distinct pointer types lacks a cast propsheet.c:1998: warning: comparison of distinct pointer types lacks a cast rebar.c:1476: warning: comparison of distinct pointer types lacks a cast rebar.c:1490: warning: comparison of distinct pointer types lacks a cast tab.c:1080: warning: comparison of distinct pointer types lacks a cast toolbar.c:1086: warning: comparison of distinct pointer types lacks a cast treeview.c:1500: warning: comparison of distinct pointer types lacks a cast treeview.c:1594: warning: comparison of distinct pointer types lacks a cast treeview.c:2514: warning: comparison of distinct pointer types lacks a cast treeview.c:2516: warning: comparison of distinct pointer types lacks a cast treeview.c:4218: warning: comparison of distinct pointer types lacks a cast treeview.c:4351: warning: comparison of distinct pointer types lacks a cast treeview.c:4356: warning: comparison of distinct pointer types lacks a cast midi.c:117: warning: comparison of distinct pointer types lacks a cast audio.c:774: warning: comparison of distinct pointer types lacks a cast audio.c:1759: warning: comparison of distinct pointer types lacks a cast midi.c:618: warning: comparison of distinct pointer types lacks a cast midi.c:968: warning: comparison of distinct pointer types lacks a cast internet.c:489: warning: comparison of distinct pointer types lacks a cast -- --------------- Eric Pouech (http://perso.wanadoo.fr/eric.pouech/) "The future will be better tomorrow", Vice President Dan Quayle

2 2

Winsock API
by Robert Lunnon Sept. 15, 2001

Sept. 15, 2001

I have Converted WSAIOCTL to use SIOCGETIFCONF ioctl calls rather than parse /proc which is to linux-centric but I was asked by Francois Gouget to look at trying to make WsControl unix independent by implementing it using other windows APIs rather than by using unix calls directly. Unfortunately this API is a bit of a mess because WsControl can return the MAC Adress but WSAIoctl doesn't appear to implement that functionality. To get The MAC Address we then need to make an appropriate UNIX IOCTL call for which we need the interface name, which isn't available from WSAIoctl either. There are other ways in windows to getthe MAC address via an SNMP call but I'm not sure how that is implemented (Possibly with a call back to WSControl) I don't see then how WSControl can be implemented without the present hacks and duplicated code between WSAIoclt and WSControl helper functions. My proposal then would be... 1.) Separate out all the unix centric helper functions for WSControl and WSAIoctl into a common ancestor source file with no windows dependencies. This should remove the ugly socket hack in WSControl, both libraries still end up with private copies of the common helper functions but since they are all derived from the same common source file it will at least be encapsulated and easier to maintain. 2.) The doco for WSIoctl indicate the encoding for the Ioctl op-code allows for a "Standard" unix IOCTL to be passed to WSIoctl ostensibly for FIONREAD,FIONBIO et al, with predictable results. If I were to implement SIOCGETIFCONF in WsIoctl then this would allow a pass-through so I could get what I need from the host OS without disturbing current windows programs. Because windows doesn't define SIOCGETIFCONF whatever we choose for the value of the op-code might end up being used by Microsoft later, breaking Wine. (Possible but not very likely) Opinions ?

1 0

Information Request For Porting WINE
by Lucien LaCroix Sept. 15, 2001

Sept. 15, 2001

I would like to find out if the development of WINE supports it being ported to Windows 16-Bit OS. Currently, I am developing a Windows Clone and would very much ike to work on Porting WINE to Win16. However, I am not 100% sure if the way WINE operates wether it would work. WINE will work if it is a complete re-written library system that merely interfaces with the host system. WINE won't work if it serves as a translater from host system system calls to the guest application. Any information on this plus a good compiler that is usefull for someone who knows a bit, but not everything, hopefully one with a good GUI. Thank-You. David Scherer, lacroixlucien(a)hotmail.com _________________________________________________________________ Get your FREE download of MSN Explorer at http://explorer.msn.com/intl.asp

2 1

Re: Bug: loss of mousepointer
by Alexandre Julliard Sept. 14, 2001

Sept. 14, 2001

Marcus Meissner <marcus(a)jet.franken.de> writes: > After last nights CVS commits, the Mousepointer appears not to be visible > in some applications in both managed and unmanaged mode. > > Reproducable for me with sol.exe and winmine.exe (16bit) for instance. This should fix it I think: Index: windows/nonclient.c =================================================================== RCS file: /opt/cvs-commit/wine/windows/nonclient.c,v retrieving revision 1.84 diff -u -r1.84 nonclient.c --- windows/nonclient.c 2001/08/24 00:26:59 1.84 +++ windows/nonclient.c 2001/09/14 17:20:00 @@ -1729,7 +1729,8 @@ */ LONG NC_HandleSetCursor( HWND hwnd, WPARAM wParam, LPARAM lParam ) { - if (hwnd != (HWND)wParam) return 0; /* Don't set the cursor for child windows */ + if (hwnd != WIN_GetFullHandle( (HWND)wParam )) + return 0; /* Don't set the cursor for child windows */ switch(LOWORD(lParam)) { -- Alexandre Julliard julliard(a)winehq.com

1 0

IE 5.01
by Nick Hudson Sept. 14, 2001

Sept. 14, 2001

Greetings, Well i know ill get flamed for this but has anyone got IE 5.01 installed on wine? Everytime I try it gives me an error that "Some programs hasnt finished and that I need to let it finish and restart my computer" Then it closes. So any ideo on getting any version of IE installed? Thanks Nick Hudson

2 1

GDI_CheckNotLock strikes again
by Dmitry Timoshkov Sept. 14, 2001

Sept. 14, 2001

Hello. Decided to try sample program which uses GetGlyphOutline. Backtrace: =>0 0x400d2ae1 (_CheckNotSysLevel+0x51(lock=0x407bb6a4) [syslevel.c:153] in libntdll.so) (ebp=405b6734) 1 0x407a2667 (GDI_CheckNotLock+0x1b [gdiobj.c:446] in libgdi32.so) (ebp=405b6744) 2 0x40798a1c (DeleteDC+0x48(hdc=0x8bc) [dc.c:784] in libgdi32.so) (ebp=405b6764) 3 0x407983b9 (RestoreDC+0x13d(hdc=0x8a0, level=0x1) [dc.c:541] in libgdi32.so) (ebp=405b6790) 4 0x4078ba4b (PATH_StrokePath+0x28b(dc=0x403a1640, pPath=0x403a16a0) [path.c:1511] in libgdi32.so) (ebp=405b67b4) 5 0x4078baf0 (StrokeAndFillPath+0x64(hdc=0x8a0) [path.c:1547] in libgdi32.so) (ebp=405b67d4) 6 0x004016c6 (DrawPath+0xb6(hDC=0x8a0) [C:\DevStudio\Projects\Glyph\Glyph.c:434] in C:\Glyph.exe) (ebp=405b683c) 7 0x00401c77 (DrawTTOutline+0x527(hDC=0x8a0, lpHeader=0x403a1c10, size=0xffffffff) [C:\DevStudio\Projects\Glyph\Glyph.c:618] in C:\Glyph.exe) (ebp=405b68c8) 8 0x00402023 (OutputGlyph+0x243(hDC=0x8a0, letter=0x21, x=0x0, y=0x0, ascent=0x78) [C:\DevStudio\Projects\Glyph\Glyph.c:724] in C:\Glyph.exe) (ebp=405b6970) 9 0x0040225f (PaintIt+0x14f(hWnd=0x10021, hDC=0x8a0) [C:\DevStudio\Projects\Glyph\Glyph.c:806] in C:\Glyph.exe) (ebp=405b6a48) 10 0x00402701 (MainWndProc+0x351(hWnd=0x10021, message=0xf, wParam=0x0, lParam=0x0) [C:\DevStudio\Projects\Glyph\Glyph.c:958] in C:\Glyph.exe) (ebp=405b6b30) 11 0x406e8507 (WINPROC_wrapper+0x17 in libuser32.so) (ebp=405b6b54) 12 0x406e85a0 (WINPROC_CallWndProc+0x8c(proc=0x401028, hwnd=0x10021, msg=0xf, wParam=0x0, lParam=0x0) [winproc.c:172] in libuser32.so) (ebp=405b6b84) 13 0x406edcfd (WINPROC_CallProc32WTo32A+0x8d(func=0x401028, hwnd=0x10021, msg=0xf, wParam=0x0, lParam=0x0) [winproc.c:2434] in libuser32.so) (ebp=405b6bac) 14 0x406ee237 (CallWindowProcW+0x93(func=0x40f80871, hwnd=0x10021, msg=0xf, wParam=0x0, lParam=0x0) [winproc.c:2685] in libuser32.so) (ebp=405b6bd4) 15 0x4068a6c9 (call_window_proc+0xb5(hwnd=0x10021, msg=0xf, wparam=0x0, lparam=0x0, unicode=0x1) [message.c:1108] in libuser32.so) (ebp=405b6c24) 16 0x4068b23c (SendMessageTimeoutW+0xc4(hwnd=0x10021, msg=0xf, wparam=0x0, lparam=0x0, flags=0x0, timeout=0xffffffff, res_ptr=0x405b6ca8) [message.c:1508] in libuser32.so) (ebp=405b6c78) 17 0x4068b4b0 (SendMessageW+0x38(hwnd=0x10021, msg=0xf, wparam=0x0, lparam=0x0) [message.c:1577] in libuser32.so) (ebp=405b6cac) 18 0x406d6a03 (RDW_Paint+0xbf(wndPtr=0x4039f0cc, hrgn=0x0, flags=0x180, ex=0x0) [painting.c:780] in libuser32.so) (ebp=405b6ce0) 19 0x406d6f40 (RedrawWindow+0x398(hwnd=0x10021, rectUpdate=0x0, hrgnUpdate=0x0, flags=0x180) [painting.c:974] in libuser32.so) (ebp=405b6d4c) 20 0x406d703d (UpdateWindow+0x21(hwnd=0x10021) [painting.c:1006] in libuser32.so) (ebp=405b6d68) 21 0x0040297e (InitInstance+0x6e(hInstance=0x400000, nCmdShow=0xa) [C:\DevStudio\Projects\Glyph\Glyph.c:1051] in C:\Glyph.exe) (ebp=405b6dc4) 22 0x004029e0 (WinMain+0x30(hInstance=0x400000, hPrevInstance=0x0, lpCmdLine=0x40360c45, nCmdShow=0xa) [C:\DevStudio\Projects\Glyph\Glyph.c:1087] in C:\Glyph.exe) (ebp=405b6e3c) 23 0x00402f53 (WinMainCRTStartup+0x113 [crt0.c:198] in C:\Glyph.exe) (ebp=405b6ecc) 24 0x400cec3d (start_process+0x195 [process.c:390] in libntdll.so) (ebp=405b6f30) 25 0x400d252c (SYSDEPS_DoCallOnStack+0x20(func=0x400ceaa8, arg=0x0) [sysdeps.c:183] in libntdll.so) (ebp=405b6ff0) 26 0x400d25d3 (SYSDEPS_CallOnStack+0x2f in libntdll.so) (ebp=bffffa3c) 27 0x400d2680 (SYSDEPS_SwitchToThreadStack+0x94(func=0x400ceaa8) [sysdeps.c:238] in libntdll.so) (ebp=bffffa78) 28 0x400cefce (PROCESS_InitWine+0x1ca(argc=0x2, argv=0xbffffaf4, win16_exe_name=0x804c620, win16_exe_file=0x804c724) [process.c:522] in libntdll.so) (ebp=bffffa90) 29 0x0804b1e6 (Letext [main.c] in wine) (ebp=bffffaa8) 30 0x402769cb (__libc_start_main+0xff(main=0x804b1cc, argc=0x2, argv=0xbffffaf4, init=0x80486d4, fini=0x804b224, rtld_fini=0x4000aea0, stack_end=0xbffffaec) [libc-start.c:92] in libc.so.6) (ebp=bffffac8) 31 0x08049021 (_start+0x21 in wine) (ebp=00000000) -- Dmitry.

2 3

Bug: loss of mousepointer
by Marcus Meissner Sept. 14, 2001

Sept. 14, 2001

Hi, After last nights CVS commits, the Mousepointer appears not to be visible in some applications in both managed and unmanaged mode. Reproducable for me with sol.exe and winmine.exe (16bit) for instance. Ciao, Marcus

1 0

Re: unmanaged windows
by Alexandre Julliard Sept. 14, 2001

Sept. 14, 2001

Bobby Bingham <uhmmmm(a)ameritech.net> writes: > I think there was a discussion a while back about possibly rewriting the > "unmanaged" mode (or adding a new mode, I don't recall which) to make it more > like XMMS, but I can't find it now. This would really help on my system, as > with KDE 2.2, wine windows are always on top and on every desktop and XMMS > fits in a little better. I was wondering what the result if any, of that > discussion was. I was planning to implement that as part of the new window management stuff. But this is on hold at the moment while I'm finishing the shared window handles. -- Alexandre Julliard julliard(a)winehq.com

1 0

Re: Problem with specmaker
by Guy L. Albertelli Sept. 13, 2001

Sept. 13, 2001

-----Original Message----- From: Patrik Stridvall <ps(a)leissner.se> To: 'eric pouech' <eric.pouech(a)wanadoo.fr>; Guy L. Albertelli <galberte(a)neo.lrun.com> Cc: Wine Devel <wine-devel(a)winehq.com> Date: Thursday, September 06, 2001 5:59 PM Subject: RE: Problem with specmaker > >Hmm. Thinking, modifying etc. > >What about this? > >Index: wine/tools/specmaker/function_grep.pl >=================================================================== >RCS file: /home/wine/wine/tools/specmaker/function_grep.pl,v >retrieving revision 1.1 >diff -u -u -r1.1 function_grep.pl >--- wine/tools/specmaker/function_grep.pl 2001/01/04 19:45:50 1.1 >+++ wine/tools/specmaker/function_grep.pl 2001/09/06 21:50:26 <snip> No the above patch merely resulted in an infinite loop. After much consultation with "Perl in a Nutshell", I came up with the following patch. The header file in question is "shlobj.h". The patch has two sections. First gets rid of the \n imbeded with the lookahead for preprocessor statements. The second gets rid of the ICOM_DEFINE statement (poorly I know) because it has no ";". This seems to make things work and generate correct headers. Thanks, Guy

1 0

dlls/advapi32/crypt.c
by Morten Welinder Sept. 13, 2001

Sept. 13, 2001

Someone added code to CryptGenRandom so that it generates very bad random data (with <10 bits randomness in them). Don't do that. It's a known security risk. Read from /dev/urandom instead. If that does not succeed, just abort(). Linux and newer Solaris have /dev/urandom. I would guess the BSDs have it too. Morten

2 1