- Wine-Devel - list.winehq.org

Window painting problem
by Glenn Schrader July 3, 2001

July 3, 2001

I've been tracking down a window painting problem and I think that I know whats happening but I'd like to get some opinions on the 'right' way to fix it. The symptom is that (in some cases) any change to a window will cause the entire window to be repainted. For instance, using the mouse to select a single character causes the whole window to update rather than just the small region which needs to be highlighted. This doesn't happen on most applications. In fact, the only one where i've seen this effect is RoAClient (a really good MUD client). Even so, its really annoying and makes the window flash so much that the app is effectively useless. The problem appears to be in BeginPaint. There is a test which checks to see if the window has the CS_PARENTDC flag set. If so then then the update region is discarded and the window is painted. This has the side effect of making the whole window repaint every time anything in the window changes. According to the windows docs that i've looked at, the CS_PARENTDC should just make the window paint using its parent's device context. There isn't any mention of also removing the invalid region clipping so i'm pretty sure that what BeginPaint is doing isn't right. In my hacking around, I disabled the branch of the test which removes the clipping region and things appear to work a lot better. The screen updating is definitely smoother. What I'm not sure of is whether this is good enough or whether the CS_PARENTDC case really should be slightly different. Normally the clipping region is offset relative to the window thats being drawn but with CS_PARENTDC should the offset be done relative to the parent window instead? Are there any other subtle things that CS_PARENTDC affects? Any insight would be appreciated... Thanks much, G. Schrader

2 1

Re: Window painting problem
by r.maurizzi＠gvs.it July 3, 2001

July 3, 2001

Glenn Schrader <gschrad(a)ll.mit.edu> wrote: > The symptom is that (in some cases) any change to a > window will cause the entire window to be repainted. > (...) > This doesn't happen on most applications. > In fact, the only one where i've seen this effect is > RoAClient (a really good MUD client). Even so, its > really annoying and makes the window flash so much > that the app is effectively useless. Just for info, Lotus Notes v 4.6x has the same problem. Ciao, Roberto.

1 0

Re: Win16 problems
by Gerard Patel July 3, 2001

July 3, 2001

At 02:58 AM 03/07/2001 +0200, you wrote: >Is it just me, or does no Win16 GUI apps work in the current Wine CVS? If >Wine is compiled with --enable-opengl, then we get BadMatch errors in >X_CreateWindow (some kind of visual mismatch), If I disable the OpenGL >visual, then the windows are created and seem to exist, but they're never >drawn. > >Win32 apps work fine, of course. For me Win16 apps have not more problems than Win32 ones. Word viewer 16 bits has one regression with current Cvs vs say one month ago, a focus problem that is occuring only in managed mode. Other than that, it is starting and loading files, either on my old computer with Xfree 3.3 and on my newer one with Xfree 4 (compiled with --enable-opengl) I still run most of my test apps on the old computer, but none of them crashes and the new redrawing problems are less than what you say. IMO Wine behaviour depends more now on the specific X server and window manager. I use Kde on both computers, btw (1.1.1 and 2.1 respectively) Gerard

1 0

Re: dead lock
by Alexandre Julliard July 3, 2001

July 3, 2001

eric pouech <eric.pouech(a)wanadoo.fr> writes: > let's assume fixing it is now on Alexandre's TODO list ;-) Yes, I'll fix it, thanks for the report. You'll have to wait a bit though, as I will be away most of the week. -- Alexandre Julliard julliard(a)winehq.com

1 0

Re: PATCH: setsockopt differences for winsock/winsock2
by Alexandre Julliard July 3, 2001

July 3, 2001

Marcus Meissner <marcus(a)jet.franken.de> writes: > That was the time that I spotted that the #defines for the IP_* > stuff _differs_ between winsock and winsock2. So I had to split up > the IPPROTO_IP handling. I tried to keep code duplication to a minimum. > > I am not sure whether the forwarders are good style. They are not IMHO. I'd suggest writing a ws1-to-ws2 conversion function instead, and use it (by duplicating its code) both for the 16-bit functions in ws2_32 and for the version 1 functions in wsock32. A little code duplication is better than adding entry points. An even better alternative that would avoid the duplication could be to have the 16-bit functions implemented in wsock32 instead of ws2_32, but this is probably a lot more work. -- Alexandre Julliard julliard(a)winehq.com

1 0

tray icon creation problem
by Adriaan Moors July 3, 2001

July 3, 2001

hi, earlier, i reported a problem with create_icon_window. It doesn't crash anymore with today's cvs (it says an error occurred when initing the tray icon). The application (winmx) continues to load, but it keeps moving downwards. This only occurs when using enlightenment, with window maker it stays still :-) Maybe it's a bug in enlightenment? regards adriaan moors -- Have you ever noticed that the people who are always trying to tell you, "There's a time for work and a time for play," never find the time for play?

1 0

Request for feature
by David Ronis July 2, 2001

July 2, 2001

I posted this to comp.emulators.ms-windows.wine, but got no reply. I'd been having problems with a windows application that want's to pass off a URL to a browser (netscape). OK I figured out part of my problem. [In short, I have an windows application that spawn netscape with some command-line url]. As was suggested in this thread, I had to install a windows version of netscape (I only had the linux native version installed). The installation set up the registry and things work (well sort of, netscape complains about not being able to write to the tmp directory e: [which is /tmp]). The problem now is that I seem to be on the slippery slope; i.e., most of the plugins/helper applications are absent, so in order to see various file types I have to download more windows versions of things already on my system. None of this would be necessary if there was some way to get wine to first try a native program; e.g., before trying netscape.exe or whatever was in the registry, try netscape using a standard unix system call; only if this failed would wine look for a windows version. Alternately the order could be reversed (I'd be more than willing to remove the windows versions of netscape). The best solution, would be some sort of override capability be added to the config file, for example, similar to the way native vs windows .dll's are chosen. I'm willing to play around with this, but have no experience with the internals of wine. Can somebody point me to the right point of the source code? It'd probably be trivial (and less likely to mess up wine) to first try to fork off a linux command (e.g., by mapping the end of command to something lowercase and less the .exe or .com suffix) and if that failed resort to the windows command. David P.S., I don't subscribe to this list, so please CC me.

1 0

dead lock
by eric pouech July 2, 2001

July 2, 2001

an app of mine, using two threads, dead locks as follows: thread 1 0 0x40057b1b (RtlpWaitForCriticalSection+0x147(crit=0x40652d48, crit=0x40652d48) [critsection.c:185] in libntdll.so) (ebp=40a96a74) 1 0x40057bf6 (RtlEnterCriticalSection+0x3e(crit=0x40652d48) [critsection.c:241] in libntdll.so) (ebp=40a96a88) 2 0x400ca883 (_EnterSysLevel+0xf7(lock=0x40652d48) [syslevel.c:80] in libntdll.so) (ebp=40a96ab4) 3 0x40639a5f (GDI_AllocObject+0x2f(size=0x34, magic=0x4f4b, handle=0x40a96afc, handle=0x40a96afc) [gdiobj.c:427] in libgdi32.so) (ebp=40a96ad8) 4 0x4062c668 (CreateBitmap+0x78(width=0x20, height=0x20, planes=0x1, bpp=0x18, bits=0x4039fe1c) [bitmap.c:124] in libgdi32.so) (ebp=40a96b00) 5 0x40770f66 (GetIconInfo+0xca(hIcon=0x24e, iconinfo=0x40a96b50) [cursoricon.c:1816] in libuser32.so) (ebp=40a96b30) 6 0x40805a4a (set_icon_hints+0xe6(display=0x8082898, wndPtr=0x4037fe00, hints=0x8083da0, display=0x8082898, win=0x4037fe00, display=0x8082898, win=0x4037fe00) [window.c:263] in libx11drv.so) (ebp=40a96b8c) 7 0x40805ccb (set_wm_hints+0xf3(display=0x8082898, win=0x4037fe00) [window.c:370] in libx11drv.so) (ebp=40a96bbc) 8 0x4080691e (create_whole_window+0x1aa(display=0x8082898, win=0x4037fe00, win=0x4037fe00) [window.c:699] in libx11drv.so) (ebp=40a96c50) 9 0x40806ead (X11DRV_CreateWindow+0xb5(hwnd=0x4ac, cs=0x40a96e2c, unicode=0x0) [window.c:856] in libx11drv.so) (ebp=40a96c90) 10 0x40797831 (WIN_CreateWindowEx+0x6c9(cs=0x40a96e2c, classAtom=0xc014, type=0x2) [win.c:865] in libuser32.so) (ebp=40a96d08) 11 0x40797cca (CreateWindowExA+0x15a(exStyle=0x0, className=0x404c86ce, windowName=0x4049ef3c, style=0xcf0000, x=0x366, y=0x14, width=0x19a, height=0x16f, parent=0x0, menu=0x0, instance=0x4049d000, data=0x0) [win.c:1030] in libuser32.so) (ebp=40a96e5c) 12 0x4049be85 (SInitInstance+0x169(hInstance=0x4049d000, nCmdShow=0x1) [sinit.c:247] in a.so) (ebp=40a96ecc) 13 0x4049911b (ServerThread+0x4b(p=0x405e6e14) [a.c:19] in a.so) (ebp=40a96f1c) 14 0x400cb1ac (THREAD_Start+0x98 [thread.c:273] in libntdll.so) (ebp=40a96f38) 15 0x400ca44e (SYSDEPS_StartThread+0x36(teb=0x40aa7000) [sysdeps.c:73] in libntdll.so) (ebp=40a96ff4) 16 0x4030531a (NTDLL.DLL.memcpy+0x494aa in libc.so.6) (ebp=00000000) thread 2 0 0x40057b1b (RtlpWaitForCriticalSection+0x147(crit=0x40841d10, crit=0x40841d10) [critsection.c:185] in libntdll.so) (ebp=405e6ac0) 1 0x40057bf6 (RtlEnterCriticalSection+0x3e(crit=0x40841d10) [critsection.c:241] in libntdll.so) (ebp=405e6ad4) 2 0x4080b668 (lock_tsx11+0x1c [x11drv_main.c:109] in libx11drv.so) (ebp=405e6ae4) 3 0x4080f595 (X11DRV_StretchBlt+0x39(dcDst=0x4039f710, xDst=0x0, yDst=0x0, widthDst=0xa0, heightDst=0x80, dcSrc=0x4039f4e8, xSrc=0x0, ySrc=0x0, widthSrc=0x190, heightSrc=0x140, rop=0xcc0020) [bitblt.c:1555] in libx11drv.so) (ebp=405e6b10) 4 0x4061bbf2 (StretchBlt+0x102(hdcDst=0xf4, xDst=0x0, yDst=0x0, widthDst=0xa0, heightDst=0x80, hdcSrc=0xf0, xSrc=0x0, ySrc=0x0, widthSrc=0x190, heightSrc=0x140, rop=0xcc0020) [bitblt.c:120] in libgdi32.so) (ebp=405e6b54) 5 0x40499b84 (CInitializeCoolBitmaps+0x36c [cinit.c:229] in a.so) (ebp=405e6bd4) 6 0x4049a265 (CMainWndProc+0x205(hWnd=0x13c, msg=0x590, wParam=0x0, lParam=0x0) [client.c:131] in a.so) (ebp=405e6d24) 7 0x4079e197 (WINPROC_wrapper+0x17 in libuser32.so) (ebp=405e6d48) 8 0x4079e216 (WINPROC_CallWndProc+0x76(proc=0x4049a060, hwnd=0x13c, msg=0x590, wParam=0x0, lParam=0x0) [winproc.c:171] in libuser32.so) (ebp=405e6d74) 9 0x407a3da8 (CallWindowProcA+0x88(func=0x4096054c, hwnd=0x13c, msg=0x590, wParam=0x0, lParam=0x0) [winproc.c:2589] in libuser32.so) (ebp=405e6d9c) 10 0x40785fcc (DispatchMessageA+0xd8(msg=0x405e6e24) [message.c:2359] in libuser32.so) (ebp=405e6de0) 11 0x404991ff (WinMain+0x9b(hInstance=0x4049d000, hPrevInstance=0x0, lpCmdLine=0x40360747, nCmdShow=0x1) [a.c:78] in a.so) (ebp=405e6e40) 12 0x4049e082 (__wine_exe_main+0x82 [a.spec.c:5838] in <Debugged process>) (ebp=405e6ecc) 13 0x400c6d52 (start_process+0x1a6 [process.c:391] in libntdll.so) (ebp=405e6f30) 14 0x400ca559 (SYSDEPS_DoCallOnStack+0x25(func=0x400c6bac, arg=0x0) [sysdeps.c:173] in libntdll.so) (ebp=405e6ff0) 15 0x400ca603 (SYSDEPS_CallOnStack+0x2f in libntdll.so) (ebp=bffff660) 16 0x400ca6ad (SYSDEPS_SwitchToThreadStack+0x95(func=0x400c6bac) [sysdeps.c:236] in libntdll.so) (ebp=bffff69c) 17 0x400c70de (PROCESS_InitWine+0x1ce(argc=0x1, argv=0xbffff734, win16_exe_name=0x804c620, win16_exe_file=0x804c724) [process.c:519] in libntdll.so) (ebp=bffff6b4) 18 0x0804b1ee (Letext [main.c] in wine) (ebp=bffff6cc) 19 0x4027bcbe (NTDLL.DLL.sqrt+0x3262e in libc.so.6) (ebp=bffff708) 20 0x08049021 (_start+0x21 in wine) (ebp=00000000) it (simply) deadlocks because the new window management code (written by Alexandre), (rev 1.5 of dlls/x11drv/window.c, change log entry Create an X window for every window, including children. Fixed non-client rectangle calculations in managed mode. Added support for icon window in managed mode. ) does call GDI functions (here GetIconInfo) while the x11drv critical section is held, which shouldn't be the case let's assume fixing it is now on Alexandre's TODO list ;-) A+ -- --------------- Eric Pouech (http://perso.wanadoo.fr/eric.pouech/) "The future will be better tomorrow", Vice President Dan Quayle

1 0

Re: convert 16bit comm stuff to use handles
by Ove Kaaven July 2, 2001

July 2, 2001

On Sat, 30 Jun 2001, Mike McCormack wrote: > this is the first step in cleaning up the 16bit comm code. > This patch is untested, so have a look, and give it a go! > - ptr->s_read = SERVICE_AddObject( FILE_DupUnixHandle( ptr->fd, > - GENERIC_READ | SYNCHRONIZE ), > + ptr->s_read = SERVICE_AddObject( ptr->handle, > comm_notification, > (ULONG_PTR)ptr ); Not good... you *must* duplicate the handle (probably with DuplicateHandle) before passing it to SERVICE_AddObject. The SERVICE_Delete will close the handle passed to AddObject, which is bound to cause problems if it's not a duplicate.

2 1

GDI Memory Leak + err:x11drv:X11DRV_SetDeviceClipping Rgn is 0. Please report this.
by adoniz＠hushmail.com July 2, 2001

July 2, 2001

I got these errors while trying to do something a little uncommon: I have been running Halflife from my windows partiton just fine. But I wanted to remove the huge files and replace them with symlinks to a cdrom, but since I can't do symlinks on fat32 (is there a wine hack for this?? i think it would be a great idea!!), I figured I copy the basic files of HL to my linux partition, and symlink the huge pak files. So, I have /mnt/halflife and under there I have some symlinks. I went ahead and added these to my ~/.wine/config [Drive H] "Path" = "/mnt" "Type" = "hd" "Filesystem" = "vfat" Now, as root try running halflife with: cd /mnt/halflife ; wine hl.exe or wine h:\\halflie\hl.exe (or with all the command line options for opengl, software, etc) I get these errors and a SegFault from wine: /mnt/halflife# wine h:\\halflife\\hl.exe -- -console -toconsole -soft -w 640 -win err:local:LOCAL_GetBlock not enough space in GDI heap 0237 for 108 bytes err:region:CombineRgn Invalid rgn=0000 err:x11drv:X11DRV_SetDeviceClipping Rgn is 0. Please report this. err:region:CombineRgn Invalid rgn=0000 err:region:CombineRgn Invalid rgn=0000 err:region:CombineRgn Invalid rgn=0000 err:region:CombineRgn Invalid rgn=0000 Segmentation fault whatever:/mnt/halflife# err:ntdll:RtlpWaitForCriticalSection Critical section 0x4065da54 wait timed out, retrying (60 sec) fs=0257 Running notepad.exe from /mnt/ works just fine. So something else is happening here... Email me if you need more info thanks Free, encrypted, secure Web-based email at www.hushmail.com

2 1