- Wine-Devel - list.winehq.org

InstallShield
by Daniel Walker April 15, 2001

April 15, 2001

I've been working on getting the Free Borland installer working. It uses installshield so I think this pertains to all installshield installers .. I've found a problem in propsheet.c , PROPSHEET_CollectPageInfo() . It appears that the property pages that come out of the installer have the PSP_USETITLE flag set. So wine attempts to get the title from the pszTitle field. The problem occurs because the pszTitle field is null. Wine try's to use it as a resource ID then fails. From reading over some MS docs I think windows, in this situation, reverts the PSP_USETITLE flag then uses the title in the template. So far I can get the installer to work, but it doesn't have a title or caption I haven't figured out why. I tryed changind it to "if (dwFlags & PSP_USETITLE && LOWORD(lppsp->pszTitle) != 0)" but it didn't have any effect. I also tryed reverting the PSP_USETITLE flag with no effect. Anyone have any ideas why there isn't a title? The patch below should fix the borland installer and , I assume, other install shield installers. Let me know if this patch doesn't work.. Daniel Walker --- ./dlls/comctl32/propsheet.c Mon Feb 12 10:08:31 2001 +++ ../../wine-20010305/dlls/comctl32/propsheet2.c Sat Apr 14 17:22:59 2001 @@ -296,12 +296,10 @@ if (dwFlags & PSP_USETITLE) { - if ( !HIWORD( lppsp->pszTitle ) ) - { char szTitle[256]; - - if ( !LoadStringA( lppsp->hInstance, (UINT) lppsp->pszTitle, szTitle, 256 ) ) - return FALSE; + + if ( !HIWORD( lppsp->pszTitle ) && LoadStringA( lppsp->hInstance, (UINT) lppsp->pszTitle, szTitle, 256 ) ) + { psInfo->proppage[index].pszText = HEAP_strdupAtoW( GetProcessHeap(), 0, szTitle );

1 0

Re: debugger startup
by Alexandre Julliard April 13, 2001

April 13, 2001

eric pouech <eric.pouech(a)wanadoo.fr> writes: > apart, from always using argv[0] (and transposing it to a windows > filename when needed), is there another fix ? You can set WINEPRELOAD to make sure we load the right file; so the exec would be something like: WINEPRELOAD=winedbg.so exec wine $* -- Alexandre Julliard julliard(a)winehq.com

2 1

Re: debugger startup
by Alexandre Julliard April 13, 2001

April 13, 2001

eric pouech <eric.pouech(a)wanadoo.fr> writes: > well, this has a major holes: > - since the process creation in Wine knows the created process is not > a PE image, it doesn't set the info on the server side for the newly > created process ; after the exec in the shell script, the info cannot > be retrieved from the parent, hence an error What makes you think that? Of course the info is set for non-PE binaries too, otherwise you could never debug a Winelib app. > perhaps, the best fix would be to merge the init_process/new_process > server calls I don't see how you could possibly do that. new_process is done by the parent, and init_process by the child; they serve very different purposes. -- Alexandre Julliard julliard(a)winehq.com

2 1

Re: Strange behaviour with GETVDMPOINTER32W
by Alexandre Julliard April 12, 2001

April 12, 2001

Uwe Bonnes <bon(a)elektron.ikp.physik.tu-darmstadt.de> writes: > Hopefully I get the cutting and pasting right now... > > ... > Call KERNEL.88: LSTRCPY(0x045f781a,0x02ef7044 "%CMDLINE%") ret=02e7:0687 ds=02f7 > Ret KERNEL.88: LSTRCPY() retval=0x045f781a ret=02e7:0687 ds=02f7 > ... > Call KERNEL.516: GETVDMPOINTER32W(0x045f781a,0x0001) ret=02e7:ae4a ds=02f7 > Ret KERNEL.516: GETVDMPOINTER32W() retval=0x404951ba ret=02e7:ae4a ds=02f7 > ... > Call kernel32.lstrcmpA(404951ba "\021\021\021\021\021\021\021\021\021\021\021\021\021\021\0..."...,407e6cbc "%FINDWINDOWCL%") ret=10001464 tid=081df290 Well, either GetVDMPointer returns the wrong pointer, or someone has written to the buffer in the meantime. You need to show us the full trace if you want us to be able to help. -- Alexandre Julliard julliard(a)winehq.com

1 0

Re: Strange behaviour with GETVDMPOINTER32W
by Alexandre Julliard April 12, 2001

April 12, 2001

Uwe Bonnes <bon(a)elektron.ikp.physik.tu-darmstadt.de> writes: > I don't understand this sequence: > > Some strings gets copied to segemented memory > Call KERNEL.88: LSTRCPY(0x046f0018,0x00ef0080 "") ret=02ef:069a ds=02ff > Ret KERNEL.88: LSTRCPY() retval=0x0467781a ret=02ef:0687 ds=02ff lstrcpy is supposed to return its first argument (0x046f0018 in this case). Something is very wrong here... -- Alexandre Julliard julliard(a)winehq.com

2 2

Re: edit control patch
by lawson_whitney＠juno.com April 12, 2001

April 12, 2001

On Wed, 11 Apr 2001, Dan Engel wrote: > This is my first attempt at submitting a patch--please someone let me know if there are "customs" I need to follow. > Not meaning to beat on you, but - if somebody else patches the same file while you are working on it, it makes garbage of your diff. For a project as big and open as Wine, it is only common sense and common courtesy that we use diff -u. As well as + and - to show what changed, that has also context lines so patch can have some idea if it is FI adding lines where they belong. Besides, Alexandre prefers it. (From <wine>/README, which I think we should all read now and again :-) " If you add something, or fix a bug, please send a patch ('diff -u' format preferred) to julliard(a)winehq.com or to the wine-patches(a)winehq.com mailing list for inclusion in the next release. -- Alexandre Julliard julliard(a)winehq.com " Lawson This message is brought to you by Wine-20010326, junopine-2.0.2, Juno 2.0.11, and pine-4.10 ---cut here ________________________________________________________________ GET INTERNET ACCESS FROM JUNO! Juno offers FREE or PREMIUM Internet access for less! Join Juno today! For your FREE software, visit: http://dl.www.juno.com/get/tagj.

1 0

Re: edit control patch
by James Hatheway April 12, 2001

April 12, 2001

Just one little comment, you should make your diffs using the -u (unified diff) option. (ie. cvs -d $CVSROOT -u controls/edit.c > newdiff.diff) That way your patch has "+"s and "-"s instead of ">"s. It makes it easier to read what is changing in the patch... (For example, you patch will look something like this instead:) + INT BkMode; + BkMode = GetBkMode(dc); + SetBkMode( dc, OPAQUE); + SetBkMode( dc, BkMode); -James -- James Hatheway Work: james(a)macadamian.com ~ http://www.macadamian.com Home: jhatheway(a)home.com ~ http://members.home.net/jhatheway "Man könnte froh sein, wenn die Luft so rein wäre wie das Bier" "One could be happy if the air were as pure as the beer" ----- Original Message ----- From: "Dan Engel" <dengel(a)sourceharvest.com> To: <wine-patches(a)winehq.com> Sent: Wednesday, April 11, 2001 10:24 PM Subject: edit control patch > This is my first attempt at submitting a patch--please someone let me know if there are "customs" I need to follow. > > Problem: Edit boxes are, in some cases, displaying selected text as white-on-white, so that it disappeared. > > Analysis: When text is drawn using the x11drv function X11DRV_ExtTextOut, the function does not paint a background rectangle if the background mode for the device context is transparent. In the case of edit controls, there is no attempt to change the background mode to opaque for selected text. > > Solution: In the case of painting reverse text in the edit control (function EDIT_PaintText) set the backgound mode to opaque, and then restore it before exiting the function. > > The patch is attached (wine.diff). > >

1 0

Strange behaviour with GETVDMPOINTER32W
by Uwe Bonnes April 11, 2001

April 11, 2001

Hallo, I don't understand this sequence: Some strings gets copied to segemented memory Call KERNEL.88: LSTRCPY(0x046f0018,0x00ef0080 "") ret=02ef:069a ds=02ff Ret KERNEL.88: LSTRCPY() retval=0x0467781a ret=02ef:0687 ds=02ff ... This segmented memory gets mapped to linear memory Call KERNEL.516: GETVDMPOINTER32W(0x0467781a,0x0001) ret=02ef:ae4a ds=02ff Ret KERNEL.516: GETVDMPOINTER32W() retval=0x4043bda2 ret=02ef:ae4a ds=02ff ... Accessing the linear memory returns garbage Call kernel32.lstrcmpA(4043bda2 "\021\021\021\021\021\021... ... ret=10001464 tid=08404b48 I don't see any other accesses to 0x046f:0x0018 or 0x0467781a in between. This happens withthe Encarta 99 setup. Bye Uwe Bonnes bon(a)elektron.ikp.physik.tu-darmstadt.de Free Software: If you contribute nothing, expect nothing --

1 0

Re: debugger startup
by Alexandre Julliard April 11, 2001

April 11, 2001

eric pouech <eric.pouech(a)wanadoo.fr> writes: > either we decide that shell scripts shouldn't be used (easy > solution) or we could do something like : > - if the CreateProcess fails, then wait for a certain amount of > time. If after that time the current process isn't currently > debugged, then report the error. Otherwise assume what did happen is > what has been described above CreateProcess already waits a couple of seconds for the new process to show up, so it's probably enough to simply check for the debugger once CreateProcess returns. An easier fix may be to have the script exec the debugger instead of launching it as a child process; this way the debugger parent pid will be the original Wine process, and everything should work fine. -- Alexandre Julliard julliard(a)winehq.com

2 1

Re: VxD information
by Alexandre Julliard April 11, 2001

April 11, 2001

Maurice van der Pot <griffon26(a)kfk4ever.com> writes: > I'd like to get started on VxD support, but I'm unable to find any useful > documentation on how it's implemented in Wine. I've been looking through > the sources (e.g. vxd.c, wprocs.spec) but I can't find the connection > between a call to int 2F and a call to the functions in vxd.c. The connection is through int 2f ax=0x1684 (in msdos/int2f.c), which does a GetProcAddress on wprocs and returns the vxd entry point to the application. The app then calls the corresponding vxd directly with a normal function call. -- Alexandre Julliard julliard(a)winehq.com

1 0