Re: shell32[1/2]: implements shell link's GetCurFile (with tests, fixes bug #21297)

[Nikolay Sivov]

On 2/10/2010 23:28, Austin English wrote:
> 2010/2/10 Mikołaj Zalewski<mikolaj(a)zalewski.pl>:
> > Some installers require this.
>
> +    expect_eq_x(S_FALSE, IPersistFile_IsDirty(pf));
> +    expect_eq_x(S_FALSE, IPersistFile_GetCurFile(pf,&string));
> +    expect_eq_p(NULL, string);
> +    expect_eq_x(S_OK, IShellLinkA_GetHotkey(link,&hotkey));
> +    expect_eq_x(0, hotkey);
> +    expect_eq_x(S_FALSE, IPersistFile_IsDirty(pf));
> +    // Setting the same value will not set IsDirty...
> +    expect_eq_x(S_OK, IShellLinkA_SetHotkey(link, 0));
> +    todo_wine expect_eq_x(S_FALSE, IPersistFile_IsDirty(pf));
> +    // ... but a different one will.
>
> You've got C++ comments in there...
>
> +        /* TODO: obejct should be reset on failure (see tests). */
>           TRACE("-- returning hr %08x\n", r);
> And a typo here.