Re: [PATCH vkd3d v3 03/12] vkd3d-shader/hlsl: Add aoffimmi modifiers on Sample sm4 instructions.

[Zebediah Figura (she/her)]

On 12/20/21 08:19, Francisco Casas wrote:
> December 17, 2021 6:33 PM, "Zebediah Figura (she/her)" <zfigura(a)codeweavers.com> wrote:
> > > + {
> > > + hlsl_error(ctx, &texel_offset->loc, VKD3D_SHADER_ERROR_HLSL_INVALID_TYPE,
> > > + "Offset must resolve to integer literal in the range -8 to 7\n");
> >
> > INVALID_TYPE isn't really appropriate here; we probably need a new enumeration value.
>
> Okay,
>
> VKD3D_SHADER_ERROR_HLSL_INVALID_TEXEL_OFFSET        = 5018,
>
> sounds right?

Yes, that sounds good.