Le 23/07/2026 à 19:14, Elizabeth Figura a écrit :
On Thursday, 23 July 2026 12:02:19 CDT Barath Rk wrote:
then the latter shouldn't call MessageBeep().
yeah, Beep doesn't call MessageBeep. the beep I am attempting to
implement will be done by a change in conhost where if '\a'(int 7) is
encountered we call MessageBeep(MB_OK), that's about it
Huh? Beep() calls IOCTL_CONDRV_BEEP, and Eric is proposing that IOCTL_CONDRV_BEEP should call MessageBeep().


in fact, I did propose MessageBeep to avoid calling Beep from conhost (as our current MessageBeep implementation doesn't fallbck to Beep) and to make the patch simpler

but I don't have strong objection for playing a predefined sound instead directly from conhost

-Eric