May 18, 2022
9:30 p.m.
On Wed May 18 20:22:09 2022 +0000, Chip Davis wrote: > > * If we're moving things around, I believe we also want to move > DECOMPRESS to the "base flags" group. > No we don't. AIUI that's for when the implementation doesn't support > uploading the compressed data directly, which can and does vary by > resource type--most infamously, OpenGL doesn't support compressed volume textures. > * Patches 10 and 11 in particular are an awful lot of churn, and the naming isn't clearly an improvement. Would it help if I broke patch 10 up into a patch per flag? (Acting on your second suggestion allowed me to eliminate patch 11.) > Maybe instead of "base_flags" we could say "attributes"? You know what? That's a good idea. Doing this also makes it easier to make sure I caught all the places where the flags are used. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/79#note_1002