Re: [PATCH 1/4] d3d9/tests: Add a windowed GetFrontBufferData test.

[Stefan Dösinger]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Am 2015-07-08 um 09:26 schrieb Henri Verbeet:
> I theory, once the shadowfb is moved from ddraw to wined3d we'd
> never read from the real drawable anymore.
I don't think we want to use the shadowfb unconditionally. It would
mean an extra copy (shadow backbuffer -> shadow frontbuffer -> GL_BACK
- -> swap as opposed to shadow backbuffer -> GL_BACK -> swap). I don't
think a reliable GetFrontBufferData is worth the extra copy,
especially since GetFrontbufferData isn't reliable on Windows either
(But ChildWindowFromPoint is).

We need the shadowfb for ddraw (esp. overlays, but also other corner
cases) and swapeffect_flip, although in that case we ideally swap the
FBOs and avoid the shadow backbuffer -> shadow frontbuffer blit and
just do shadow frontbuffer -> GL_BACK -> swap. In theory we also want
the shadow frontbuffer for a correct software cursor, but there are
other problems with that.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAEBAgAGBQJVnOSyAAoJEN0/YqbEcdMwM7QP/3WPmfIGTxyKaduPvbTa6+YE
TC16ZC09iAX8Mgh5EfPLH9OwYohgVf5iVVrsR+wrmMHvo6HIXfxWL+F+bqckNmU7
a8Q21xxIyQ6NzhnUGUicLsv6SU7Z5XaNQl/BeqVLnj+XuYdPEXV8/yVePkFB23V0
YlT2lbEHIj53LcBY406587Pmt4+JpiU5NgEGQAV913OGAAImO4yeiTU/PlYesAGl
zb0FGmjGoHTwnY6CnjmluL1IQk0tSDUgm5dN9Pfp+HfdvLjiIAlPGiemRRuPRSUG
h/yRsk1dzt4X7ijgFfQ08pc2/pxNGscV5CjQgIc3q30bf5Wv4B67EZ9pEl1Y/mAr
YUBCkiEEvss+Qz15FIjWpRcbM8ZuWOIT0Sl8YY/N7WCZfdzA2wTitbbE47qAlKvI
aGRCi5nF0dKVSWKQ4Sm2HqsbeUckpDc3k6gBIjxnQDGvrocvIYsaK5KxdDkp+Has
EBvNMBMW0izEVfuLJMCzUg/PtxdXMQuWzCERXixvhu8z1WhJPHr+8XpQx8UOcbs1
FNp5X4WdIU4q5olyijkT5XJXoZ3z2Mqoz4Opx1W6nbBRITjFGYV4yJXizz2+tiWb
b7nlPew9IUK8R9fGlz5TCUcAhEG4YIlur6lvBlfyA9BLOqZijoEi4QY395KofZ86
XhHUlutdZ/gWQ1OynG9N
=XeTQ
-----END PGP SIGNATURE-----