Re: msi: Split msi_set_sourcedir_props into a separate function.

[James Hawkins]

On 11/19/06, Mike McCormack <mike(a)codeweavers.com> wrote:
> ---
>   dlls/msi/action.c |   37 +++++++++++++++++++++++--------------
>   1 files changed, 23 insertions(+), 14 deletions(-)

+UINT msi_set_sourcedir_props(MSIPACKAGE *package)
+{

Shouldn't this be static?

-- 
James Hawkins

msi: Split msi_set_sourcedir_props into a separate function.

[Mike McCormack]

James Hawkins wrote:
> On 11/19/06, Mike McCormack <mike(a)codeweavers.com> wrote:
> > ---
> >   dlls/msi/action.c |   37 +++++++++++++++++++++++--------------
> >   1 files changed, 23 insertions(+), 14 deletions(-)
>
> +UINT msi_set_sourcedir_props(MSIPACKAGE *package)
> +{
>
> Shouldn't this be static?

Possibly, but I think it either needs to be moved around, or used in 
more than one place, which is why it's not static for the moment...

Mike