Re: [1/6] wsdapi: Add wsdapi_internal.h for shared internal function and macro definitions. [try 3]

[Owen Rudge]

Hi Alexandre,

Is there anything else that needs improving for these patches to be 
accepted?

Thanks,

-- 

Owen Rudge
http://www.owenrudge.net/

[1/6] wsdapi: Add wsdapi_internal.h for shared internal function and macro definitions. [try 3]

[Alexandre Julliard]

Owen Rudge <owen(a)owenrudge.net> writes:
> Hi Alexandre,
>
> Is there anything else that needs improving for these patches to be
> accepted?

I'm afraid that's just too much code at once. Part of it is the coding
style, where you use 30 lines for a function that should take 5, but
even taking that into account it's still too big to review carefully.
And from what little I've looked at, I'm afraid it's going to need a
very careful review.

-- 
Alexandre Julliard
julliard(a)winehq.org