Re: [PATCH 1/6] mshtml: Moved getting frame by name to separated function

[Alexandre Julliard]

Jacek Caban <jacek(a)codeweavers.com> writes:
> ---
>  dlls/mshtml/htmlwindow.c |  127
> ++++++++++++++++++++++++++--------------------
>  1 files changed, 72 insertions(+), 55 deletions(-)

gcc -m32 -c -I. -I. -I../../include -I../../include  -D__WINESRC__ -DCOM_NO_WINDOWS_H -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wempty-body -Wignored-qualifiers -Wstrict-prototypes -Wtype-limits -Wunused-but-set-parameter -Wwrite-strings -gdwarf-2 -gstrict-dwarf -fno-omit-frame-pointer -Wpointer-arith -Wlogical-op -Werror -I/usr/include/freetype2    -g -O2  -o htmlwindow.o htmlwindow.c
htmlwindow.c: In function ‘HTMLWindow2_item’:
htmlwindow.c:416:13: error: variable ‘hres’ set but not used [-Werror=unused-but-set-variable]
cc1: all warnings being treated as errors
make: *** [htmlwindow.o] Error 1

-- 
Alexandre Julliard
julliard(a)winehq.org

[PATCH 1/6] mshtml: Moved getting frame by name to separated function

[Jacek Caban]

On 09/03/12 16:13, Alexandre Julliard wrote:
> Jacek Caban <jacek(a)codeweavers.com> writes:
> > ---
> >  dlls/mshtml/htmlwindow.c |  127
> > ++++++++++++++++++++++++++--------------------
> >  1 files changed, 72 insertions(+), 55 deletions(-)
> > gcc -m32 -c -I. -I. -I../../include -I../../include  -D__WINESRC__ -DCOM_NO_WINDOWS_H -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wempty-body -Wignored-qualifiers -Wstrict-prototypes -Wtype-limits -Wunused-but-set-parameter -Wwrite-strings -gdwarf-2 -gstrict-dwarf -fno-omit-frame-pointer -Wpointer-arith -Wlogical-op -Werror -I/usr/include/freetype2    -g -O2  -o htmlwindow.o htmlwindow.c
> > htmlwindow.c: In function ‘HTMLWindow2_item’:
> > htmlwindow.c:416:13: error: variable ‘hres’ set but not used [-Werror=unused-but-set-variable]
> > cc1: all warnings being treated as errors
> > make: *** [htmlwindow.o] Error 1

My GCC didn't warn about it. I've resent a fixed version.

Thanks,
Jacek

[PATCH 1/6] mshtml: Moved getting frame by name to separated function

[Alexandre Julliard]

Jacek Caban <jacek(a)codeweavers.com> writes:
> On 09/03/12 16:13, Alexandre Julliard wrote:
> > Jacek Caban <jacek(a)codeweavers.com> writes:
> > > ---
> > >  dlls/mshtml/htmlwindow.c |  127
> > > ++++++++++++++++++++++++++--------------------
> > >  1 files changed, 72 insertions(+), 55 deletions(-)
> > > gcc -m32 -c -I. -I. -I../../include -I../../include -D__WINESRC__
> > > -DCOM_NO_WINDOWS_H -D_REENTRANT -fPIC -Wall -pipe
> > > -fno-strict-aliasing -Wdeclaration-after-statement -Wempty-body
> > > -Wignored-qualifiers -Wstrict-prototypes -Wtype-limits
> > > -Wunused-but-set-parameter -Wwrite-strings -gdwarf-2 -gstrict-dwarf
> > > -fno-omit-frame-pointer -Wpointer-arith -Wlogical-op -Werror
> > > -I/usr/include/freetype2 -g -O2 -o htmlwindow.o htmlwindow.c
> > > htmlwindow.c: In function ‘HTMLWindow2_item’:
> > > htmlwindow.c:416:13: error: variable ‘hres’ set but not used [-Werror=unused-but-set-variable]
> > > cc1: all warnings being treated as errors
> > > make: *** [htmlwindow.o] Error 1
>
> My GCC didn't warn about it. I've resent a fixed version.

You are still not using hres.

-- 
Alexandre Julliard
julliard(a)winehq.org