Patch 16182 causes a regression in IrfanView and Textpad

[Ron Jensen]

http://www.winehq.org/hypermail/wine-cvs/2005/02/0364.html causes
regressions in IrfanView ( http://www.irfanview.com/ ) and Textpad
( http://www.textpad.com/ )

IrfanView no longer runs.  It errors out with a dialog box that says 

LOADER ERROR
The procedure entry point DragAcceptFiles could not be located in the
dynamic link library SHELL32.dll

Textpad has fatal exceptions:

WineDbg starting on pid 0xd
Unhandled exception: 0xc06d007f in 32-bit code (0x404d1ffc).
In 32 bit mode.
Register dump:
CS:0073 SS:007b DS:007b ES:007b FS:003b GS:0033
EIP:404d1ffc ESP:4069fb30 EBP:4069fb88 EFLAGS:00200216(   - 00      -
IAP1)
EAX:4069fb30 EBX:4058c404 ECX:00000000 EDX:4069fb44
ESI:4069fbf8 EDI:4a850000
Stack dump:
0x4069fb30:  c06d007f 00000000 00000000 404d1f90
0x4069fb40:  00000001 4069fbac 401fb904 401c072e
0x4069fb50:  401fd5c0 4069fb7c 4a850000 4069fb6c
0x4069fb60:  401c0866 c000007a 4058c404 4069fb90
0x4069fb70:  404ed277 c000007a 00000000 0010000f
0x4069fb80:  00000000 005878e0 4069fbf0 004ca8ba
Backtrace:
=>1 0x404d1ffc RaiseException+0x6c(code=0xc06d007f, flags=0x0,
nbargs=0x1, args=0x4069fbf8)
[/home/wineguy/src/wine/dlls/kernel/except.c:87] in kernel32
(0x4069fb88)
  2 0x004ca8ba in textpad (+0xca8ba) (0x4069fbf0)
  3 0x004ca1e9 in textpad (+0xca1e9) (0x4069fdf4)
  4 0x0050f688 in textpad (+0x10f688) (0x4069ff2c)
  5 0x404f8aa6 start_process+0xc6(arg=0x0)
[/home/rjensen/src/wine/dlls/kernel/process.c:1046] in kernel32
(0x4069fff4)
  6 0x4002dd61 wine_mmap_is_in_reserved_area+0x71(addr=0x0, size=0x0)
[/home/wineguy/src/wine/libs/wine/mmap.c:471] in libwine.so.1
(0x00000000)
0x404d1ffc RaiseException+0x6c
[/home/wineguy/src/wine/dlls/kernel/except.c:87] in kernel32: leal
0xfffffff8(%ebp),%esp
87     RtlRaiseException( &record );
Wine-dbg>WineDbg terminated on pid 0xd

[Mike Hearn]

This is the second report of regressions caused by that patch. Hans, what
motivated it originally? I'm not sure what harm there is in exporting
entry points by name.

thanks -mike

On Sun, 20 Feb 2005 10:26:48 -0700, Ron Jensen wrote:
> http://www.winehq.org/hypermail/wine-cvs/2005/02/0364.html causes
> regressions in IrfanView ( http://www.irfanview.com/ ) and Textpad
> ( http://www.textpad.com/ )
>
> IrfanView no longer runs.  It errors out with a dialog box that says
>
> LOADER ERROR
> The procedure entry point DragAcceptFiles could not be located in the
> dynamic link library SHELL32.dll
>
> Textpad has fatal exceptions:
>
> WineDbg starting on pid 0xd
> Unhandled exception: 0xc06d007f in 32-bit code (0x404d1ffc).
> In 32 bit mode.
> Register dump:
> CS:0073 SS:007b DS:007b ES:007b FS:003b GS:0033
> EIP:404d1ffc ESP:4069fb30 EBP:4069fb88 EFLAGS:00200216(   - 00      -
> IAP1)
> EAX:4069fb30 EBX:4058c404 ECX:00000000 EDX:4069fb44
> ESI:4069fbf8 EDI:4a850000
> Stack dump:
> 0x4069fb30:  c06d007f 00000000 00000000 404d1f90
> 0x4069fb40:  00000001 4069fbac 401fb904 401c072e
> 0x4069fb50:  401fd5c0 4069fb7c 4a850000 4069fb6c
> 0x4069fb60:  401c0866 c000007a 4058c404 4069fb90
> 0x4069fb70:  404ed277 c000007a 00000000 0010000f
> 0x4069fb80:  00000000 005878e0 4069fbf0 004ca8ba
> Backtrace:
> =>1 0x404d1ffc RaiseException+0x6c(code=0xc06d007f, flags=0x0,
> nbargs=0x1, args=0x4069fbf8)
> [/home/wineguy/src/wine/dlls/kernel/except.c:87] in kernel32
> (0x4069fb88)
>   2 0x004ca8ba in textpad (+0xca8ba) (0x4069fbf0)
>   3 0x004ca1e9 in textpad (+0xca1e9) (0x4069fdf4)
>   4 0x0050f688 in textpad (+0x10f688) (0x4069ff2c)
>   5 0x404f8aa6 start_process+0xc6(arg=0x0)
> [/home/rjensen/src/wine/dlls/kernel/process.c:1046] in kernel32
> (0x4069fff4)
>   6 0x4002dd61 wine_mmap_is_in_reserved_area+0x71(addr=0x0, size=0x0)
> [/home/wineguy/src/wine/libs/wine/mmap.c:471] in libwine.so.1
> (0x00000000)
> 0x404d1ffc RaiseException+0x6c
> [/home/wineguy/src/wine/dlls/kernel/except.c:87] in kernel32: leal
> 0xfffffff8(%ebp),%esp
> 87     RtlRaiseException( &record );
> Wine-dbg>WineDbg terminated on pid 0xd

[Hans Leidekker]

On Sunday 20 February 2005 19:18, you wrote:
> This is the second report of regressions caused by that patch. Hans, what
> motivated it originally? I'm not sure what harm there is in exporting
> entry points by name.

I already sent a patch (as did Lauri Tulmin) that reverses
the incorrect changes I did for the Drag* functions.

In general we should not export by name when some (usually
older) native version of the DLL doesn't, because a binary
linked against our import lib will fail to link against such
a DLL at runtime.

 -Hans

[Stefan Dösinger]

Am Sonntag, 20. Februar 2005 19:18 schrieb Mike Hearn:
> This is the second report of regressions caused by that patch. Hans, what
> motivated it originally? I'm not sure what harm there is in exporting
> entry points by name.
> Opera and UltraISO show the same message box.

Stefan