[PATCH] kernel32: add stub for GetApplicationRestartSettings

[Louis Lenders]

Found this trying to start newest firefox 61.0.2. This prevents crashing
it.

(note: also removed a superfluous extra emply line few lines above this
change) 

Signed-off-by: Louis Lenders <xerox.xerox2000x(a)gmail.com>
---
 dlls/kernel32/kernel32.spec |  2 +-
 dlls/kernel32/process.c     | 11 ++++++++++-
 include/winbase.h           |  1 +
 3 files changed, 12 insertions(+), 2 deletions(-)

diff --git a/dlls/kernel32/kernel32.spec b/dlls/kernel32/kernel32.spec
index c53276c70a..f1d75b8e1c 100644
--- a/dlls/kernel32/kernel32.spec
+++ b/dlls/kernel32/kernel32.spec
@@ -543,7 +543,7 @@
 @ stdcall GetActiveProcessorCount(long)
 @ stdcall GetActiveProcessorGroupCount()
 # @ stub GetApplicationRecoveryCallback
-# @ stub GetApplicationRestartSettings
+@ stdcall GetApplicationRestartSettings(long ptr ptr ptr)
 @ stdcall GetAtomNameA(long ptr long)
 @ stdcall GetAtomNameW(long ptr long)
 @ stdcall GetBinaryType(str ptr) GetBinaryTypeA
diff --git a/dlls/kernel32/process.c b/dlls/kernel32/process.c
index d615f06c4a..b2e3aeee98 100644
--- a/dlls/kernel32/process.c
+++ b/dlls/kernel32/process.c
@@ -3953,7 +3953,6 @@ BOOL WINAPI CmdBatNotification( BOOL bBatchRunning )
     return FALSE;
 }
 
-
 /***********************************************************************
  *           RegisterApplicationRestart       (KERNEL32.@)
  */
@@ -4023,6 +4022,16 @@ HRESULT WINAPI RegisterApplicationRecoveryCallback(APPLICATION_RECOVERY_CALLBACK
     return E_FAIL;
 }
 
+/***********************************************************************
+ *           GetApplicationRestartSettings       (KERNEL32.@)
+ */
+HRESULT WINAPI GetApplicationRestartSettings(HANDLE process, WCHAR *cmdline, DWORD *size, DWORD *flags)
+{
+    FIXME("%p, %p, %p, %p)\n", process, cmdline, size, flags);
+    SetLastError(ERROR_CALL_NOT_IMPLEMENTED);
+    return E_FAIL;
+}
+
 /**********************************************************************
  *           GetNumaHighestNodeNumber     (KERNEL32.@)
  */
diff --git a/include/winbase.h b/include/winbase.h
index aa57dae818..8b26308b95 100644
--- a/include/winbase.h
+++ b/include/winbase.h
@@ -2038,6 +2038,7 @@ WINBASEAPI BOOL        WINAPI FreeResource(HGLOBAL);
 WINADVAPI  PVOID       WINAPI FreeSid(PSID);
 WINADVAPI  BOOL        WINAPI GetAce(PACL,DWORD,LPVOID*);
 WINADVAPI  BOOL        WINAPI GetAclInformation(PACL,LPVOID,DWORD,ACL_INFORMATION_CLASS);
+WINBASEAPI HRESULT     WINAPI GetApplicationRestartSettings(HANDLE,WCHAR*,DWORD*,DWORD*);
 WINBASEAPI UINT        WINAPI GetAtomNameA(ATOM,LPSTR,INT);
 WINBASEAPI UINT        WINAPI GetAtomNameW(ATOM,LPWSTR,INT);
 #define                       GetAtomName WINELIB_NAME_AW(GetAtomName)
-- 
2.17.1

[Jacek Caban]

Hi Louis,

On 08/27/2018 05:50 PM, Louis Lenders wrote:
> +/***********************************************************************
> + *           GetApplicationRestartSettings       (KERNEL32.@)
> + */
> +HRESULT WINAPI GetApplicationRestartSettings(HANDLE process, WCHAR *cmdline, DWORD *size, DWORD *flags)
> +{
> +    FIXME("%p, %p, %p, %p)\n", process, cmdline, size, flags);
> +    SetLastError(ERROR_CALL_NOT_IMPLEMENTED);
> +    return E_FAIL;

Functions returning HRESULT don't use SetLastError().


Thanks,

Jacek

[Louis Lenders]

Hi Jacek,

At first I had it just returning  E_NOTIMPL but then I saw that the stubs
above this one like HRESULT ApplicationRecoveryInProgress and HRESULT
RegisterApplicationRecoveryCallback used this syntax with setting last
error as well so I thought there was a reason for that (some application
depends on that???)

Anyway, , i `ll send an updated version then.

Thanks, Louis





Op ma 27 aug. 2018 om 17:57 schreef Jacek Caban <jacek(a)codeweavers.com>:
> Hi Louis,
>
> On 08/27/2018 05:50 PM, Louis Lenders wrote:
> > +/***********************************************************************
> > + *           GetApplicationRestartSettings       (KERNEL32.@)
> > + */
> > +HRESULT WINAPI GetApplicationRestartSettings(HANDLE process, WCHAR
> > *cmdline, DWORD *size, DWORD *flags)
> > +{
> > +    FIXME("%p, %p, %p, %p)\n", process, cmdline, size, flags);
> > +    SetLastError(ERROR_CALL_NOT_IMPLEMENTED);
> > +    return E_FAIL;
>
> Functions returning HRESULT don't use SetLastError().
>
> Thanks,
>
> Jacek