Re: [PATCH] kernel32/tests: Skip ResolveDelayLoadedAPI tests on Win10+

[Nikolay Sivov]

On 13.03.2016 19:42, André Hentschel wrote:
> Signed-off-by: André Hentschel <nerv(a)dawncrow.de>
> ---
>  dlls/kernel32/tests/loader.c | 6 ++++++
>  1 file changed, 6 insertions(+)
>
> diff --git a/dlls/kernel32/tests/loader.c b/dlls/kernel32/tests/loader.c
> index c35cf25..30cc2e4 100644
> --- a/dlls/kernel32/tests/loader.c
> +++ b/dlls/kernel32/tests/loader.c
> @@ -2728,6 +2728,11 @@ static void test_ResolveDelayLoadedAPI(void)
>
> cb_count = 0;
>              ret = pResolveDelayLoadedAPI(hlib, delaydir, failuredllhook, NULL, &itda[i], 0);
> +            if (!ret && td[i].succeeds)
> +            {
> +                win_skip("Skipping broken ResolveDelayLoadedAPI implementation\n");
> +                goto cleanup;
> +            }
>              if (td[i].succeeds)
>              {
>                  ok(ret != NULL, "Test %u: ResolveDelayLoadedAPI failed\n", i);
> @@ -2745,6 +2750,7 @@ static void test_ResolveDelayLoadedAPI(void)
>          delaydir++;
>      }
>
> +cleanup:
>      FreeLibrary(hlib);
>      trace("deleting %s\n", dll_name);
>      DeleteFileA(dll_name);

So what's exactly wrong with it on Win10? Silencing failures does not
seem useful if actual issue was not investigated.