re: ntdll: Fixed some heap allocation stalls
Which game were you testing?
i dunno about the game, but i saw similar stalls in our software a huge batch process that consumed about 1 GB on Windows would both run slower and eat up about 2 GB on Wine before crashing i made a similar change to Steaphan's that not only improved performance, it brought the memory usage down to roughly what it was on Windows - and didn't crash i was planning on submitting it at some point if i could think of a good test to validate it. the only difference was that i added more lists, but i'd say adding more free lists definitely makes it faster daniel
On 03. 11. 2012 01:20, Dan Kegel wrote:
Which game were you testing?
League of Legends has similar issues with memory allocation. This patch does something similar: http://uz.sns.it/~ranma42/iLoL/spectator-fix-v2/0001-ntdll-Improve-performac... I have it in my tree since February and no problems so far.
On 11/03/2012 02:09 AM, Matej Špindler wrote:
On 03. 11. 2012 01:20, Dan Kegel wrote:
Which game were you testing?
League of Legends has similar issues with memory allocation.
This patch does something similar: http://uz.sns.it/~ranma42/iLoL/spectator-fix-v2/0001-ntdll-Improve-performac...
I have it in my tree since February and no problems so far.
Yes, that patch looks like it is targeted at speeding larger allocations (where mine speeds smaller ones). These are similar fixes for opposite ends of the spectrum. And, the two should be simple to merge. Though, I don't believe the 0x08 on that one actually does anything (since these values include the arena overhead, and the smallest allocation I've seen is 8). However, I haven't looked at many examples, and I believe if an allocation request of 4 is possible, then that *would* hit that "0x08" bin. -- Steaphan Greene<steaphan(a)gmail.com>
participants (4)
-
Dan Kegel -
Daniel Lehman -
Matej Špindler -
Steaphan Greene