Re: [PATCH] tools/wine.inf.in: Added UTF8 bom header. (resend)
Qian Hong <fracting(a)gmail.com> wrote:
Added comment as Dan suggested. Thanks Dmitry, Dan and Nikolay for comments and advice. Also I'm appreciated for any other ideas to resolve Bug 32136.
So, how is this supposed to work under Windows? -- Dmitry.
Hi Dmitry, On Wed, Nov 7, 2012 at 11:25 AM, Dmitry Timoshkov <dmitry(a)baikal.ru> wrote:
So, how is this supposed to work under Windows?
I wrote a test case, to my surprise, Windows doesn't support UTF8 .inf file, no matter with or without BOM. However, Windows support Little-endian UTF-16 Unicode .inf file. The test case compiled with mingw-w64 and run on https://testbot.winehq.org/JobDetails.pl?Key=22822 However, in git log I see such a commit: commit 31ade1eb67e6b55f1b0c09ef7a806cd53652b1e2 Author: Alexandre Julliard <julliard(a)winehq.org> Date: Wed Mar 21 13:52:43 2007 +0100 setupapi: Add support for .inf files in utf-8 format. Did I miss anything or was there a reason to add utf8 support for inf files in Wine? Thanks a lot! -- Regards, Qian Hong - Sent from Ubuntu http://www.ubuntu.com/
Qian Hong <fracting(a)gmail.com> writes:
However, in git log I see such a commit: commit 31ade1eb67e6b55f1b0c09ef7a806cd53652b1e2 Author: Alexandre Julliard <julliard(a)winehq.org> Date: Wed Mar 21 13:52:43 2007 +0100
setupapi: Add support for .inf files in utf-8 format.
Did I miss anything or was there a reason to add utf8 support for inf files in Wine?
It's here to support Unicode data in wine.inf, as you noted. However, I don't think it makes sense to add the BOM unless we actually have Unicode keys in there. -- Alexandre Julliard julliard(a)winehq.org
Hello, On Thu, Nov 8, 2012 at 3:25 AM, Alexandre Julliard <julliard(a)winehq.org> wrote:
It's here to support Unicode data in wine.inf, as you noted. However, I don't think it makes sense to add the BOM unless we actually have Unicode keys in there.
Thanks for explain! Let me make a summary of Bug 32136: Since Wine1.4 we added the 'font replacement' feature to Wine, and leave the 'font replacement' setting to distribution folks, for example, Ubuntu's Wine packager has a patch like 0001-tools-wine.inf.in-Added-font-name-replacement.txt To solve Bug 32136, we need not only English font name replacement for CJK fonts, but also localized font name replacement for CJK fonts, so Ubuntu need to update their patch like 0001-tools-wine.inf.in-Added-localized-font-name-replacemen.txt. The second patch is a bit strange and ugly, because it change the encoding of a upstream file, that will make people confused. What's worse, once Wine update the encoding of wine.inf.in from ANSI to UTF8_with_bom in the future, the second patch will confilict to the new wine.inf.in. My idea is split the second patch into two parts, the first part is 0001-tools-wine.inf.in-Added-UTF8-bom-header.txt, the second part is adding english and localized font name replacement settings without changing the encoding of wine.inf.in. Did I explain clearly enough? Does that make sense? Thank you! -- Regards, Qian Hong - Sent from Ubuntu http://www.ubuntu.com/
On Thu, Nov 8, 2012 at 4:04 PM, Qian Hong <fracting(a)gmail.com> wrote:
My idea is split the second patch into two parts, the first part is 0001-tools-wine.inf.in-Added-UTF8-bom-header.txt, the second part is adding english and localized font name replacement settings without changing the encoding of wine.inf.in.
I mean, after splitting into two parts, commit the first part to upstream Wine, and leave the second part to the distribution folks, just like what we do for 0001-tools-wine.inf.in-Added-font-name-replacement.txt right now. -- Regards, Qian Hong - Sent from Ubuntu http://www.ubuntu.com/
Qian Hong <fracting(a)gmail.com> wrote:
I mean, after splitting into two parts, commit the first part to upstream Wine, and leave the second part to the distribution folks, just like what we do for 0001-tools-wine.inf.in-Added-font-name-replacement.txt right now.
What's wrong with having a .reg file with unicode file names and feed it to reg.exe? Then there is no any need for custom wine.inf patches. -- Dmitry.
Hello, On Thu, Nov 8, 2012 at 5:53 PM, Dmitry Timoshkov <dmitry(a)baikal.ru> wrote:
What's wrong with having a .reg file with unicode file names and feed it to reg.exe? Then there is no any need for custom wine.inf patches.
Then we have to feed it to reg.exe every time when a new wineprefix created, or did I miss something? I can't see how it could replace the custom wine.inf patch in Ubuntu/Fedora's packages, could you be more details? Thanks! -- Regards, Qian Hong - Sent from Ubuntu http://www.ubuntu.com/
Qian Hong <fracting(a)gmail.com> writes:
Since Wine1.4 we added the 'font replacement' feature to Wine, and leave the 'font replacement' setting to distribution folks, for example, Ubuntu's Wine packager has a patch like 0001-tools-wine.inf.in-Added-font-name-replacement.txt
A better approach would be to do this somehow through fontconfig. -- Alexandre Julliard julliard(a)winehq.org
participants (3)
-
Alexandre Julliard -
Dmitry Timoshkov -
Qian Hong