Re: user32/edit: Check for Null before strlen(try2)

[Nikolay Sivov]

André Hentschel wrote:
> related to Bug 4742
> try2: fixed indentation
> ---
>  dlls/user32/edit.c |    6 ++++--
>  1 files changed, 4 insertions(+), 2 deletions(-)

-		    countA = strlen(textA) + 1;
+            if(textA)
+                countA = strlen(textA) + 1;
 		}
---


Previous lines use 2 tabs and 4 spaces after.
Also a test is needed, looks like bug contains already something to 
start with.

user32/edit: Check for Null before strlen(try2)

[André Hentschel]

Nikolay Sivov schrieb:
> André Hentschel wrote:
> > related to Bug 4742
> > try2: fixed indentation
> > ---
> >  dlls/user32/edit.c |    6 ++++--
> >  1 files changed, 4 insertions(+), 2 deletions(-)
>
> -            countA = strlen(textA) + 1;
> +            if(textA)
> +                countA = strlen(textA) + 1;
>         }
> ---
>
> Previous lines use 2 tabs and 4 spaces after.
> Also a test is needed, looks like bug contains already something to 
> start with.

I dont think we need a test, if textA is NULL then strlen crashes. Thats all.
Should i change the indentation of the code around?

user32/edit: Check for Null before strlen(try2)

[Nikolay Sivov]

André Hentschel wrote:
> Nikolay Sivov schrieb:
> > André Hentschel wrote:
> > > related to Bug 4742
> > > try2: fixed indentation
> > > ---
> > >  dlls/user32/edit.c |    6 ++++--
> > >  1 files changed, 4 insertions(+), 2 deletions(-)
> >
> > -            countA = strlen(textA) + 1;
> > +            if(textA)
> > +                countA = strlen(textA) + 1;
> >         }
> > ---
> >
> > Previous lines use 2 tabs and 4 spaces after.
> > Also a test is needed, looks like bug contains already something to 
> > start with.
>
> I dont think we need a test, if textA is NULL then strlen crashes. 
> Thats all.
> Sure, and test will prevent regression if someday anybody decide to 
> remove this check,
> thinking it's unnecessary.
> Should i change the indentation of the code around?
> Just add your line same way.

P.S. I'm not very familiar with patch subject. Treat this as general 
suggestions.

user32/edit: Check for Null before strlen(try2)

[André Hentschel]

Nikolay Sivov schrieb:
> > Should i change the indentation of the code around?
> > Just add your line same way.

I did in try1:

Paul Vriens schrieb:
> André Hentschel wrote:
> > related to Bug 4742
> > ---
> >  dlls/user32/edit.c |    6 ++++--
> >  1 files changed, 4 insertions(+), 2 deletions(-)
> >
> > ------------------------------------------------------------------------
>
> Hi André,
>
> Your mixing tabs and spaces.

> P.S. I'm not very familiar with patch subject. Treat this as general 
> suggestions.

I can't see the problem. Sorry if it is bad english.

user32/edit: Check for Null before strlen(try2)

[Paul Vriens]

André Hentschel wrote:
> Nikolay Sivov schrieb:
> > > Should i change the indentation of the code around?
> > > Just add your line same way.
>
> I did in try1:

In try1 you added 1 line with tabs and 3 with spaces.

-- 
Cheers,

Paul.