[PATCH] msxml3: Remove redundant not-NULL check (coccinellery)

Feb. 21, 2019

Signed-off-by: Michael Stefaniuc <mstefani(a)winehq.org>
---
return E_OUTOFMEMORY if This is NULL


 dlls/msxml3/selection.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/dlls/msxml3/selection.c b/dlls/msxml3/selection.c
index b7c560a9a5..31be4d8f10 100644
--- a/dlls/msxml3/selection.c
+++ b/dlls/msxml3/selection.c
@@ -831,7 +831,7 @@ HRESULT create_selection(xmlNodePtr node, xmlChar* query, IXMLDOMNodeList **out)
     TRACE("found %d matches\n", xmlXPathNodeSetGetLength(This->result->nodesetval));
 
 cleanup:
-    if (This && FAILED(hr))
+    if (FAILED(hr))
         IXMLDOMSelection_Release( &This->IXMLDOMSelection_iface );
     xmlXPathFreeContext(ctxt);
     return hr;
-- 
2.20.1

    

Michael Stefaniuc

Nikolay Sivov

tags

participants (2)