Re: dsound: Allow a special cbSize case in CreateSoundBuffer
April 20, 2009
10:07 p.m.
Hey Jesse, Jesse Allen schreef:
OK now do you have comments? I have test cases.
On Sun, Apr 19, 2009 at 6:30 PM, Jesse Allen <the3dfxdude(a)gmail.com> wrote:
In CreateSoundBuffer, some apps pass sizeof(WAVEFORMATEXTENSIBLE) for the cbSize and we have to allow it, but only when the SubFormat is KSDATAFORMAT_SUBTYPE_PCM.
Includes test cases which were verified on WinXP. Fixes bug #11716
If you want me to review a patch add me to cc please.
The variable size_ok is unneeded here, you can rewrite that so that it will fall through if test fails. Apart from that it looks ok to me. Cheers, Maarten.
6185
Age (days ago)
6185
Last active (days ago)
0 comments
1 participants
participants (1)
-
Maarten Lankhorst