Re: [PATCH] include: Add undocumented theming hook structs to winuser.h.

[Dmitry Timoshkov]

[please keep wine-devel in the cc: list]

Mark Harmstone <hellas(a)burntcomma.com> wrote:
> > > Adds the undocumented structs to winuser.h which are needed for uxtheme to hook
> > > into user32. As researched by ReactOS: see https://www.reactos.org/wiki/Techwiki:RegisterUserApiHook
> >
> > Referencing reactos as a source of the information makes it unlikely
> > to improve the chances of including the patch in Wine.
>
> What? Why? They've already done the research...

To make long story short - ReactOS' understanding of allowed research
practices doesn't match the accepted Wine standards.
> > Moreover, as
> > was already discussed many times, theme interface is completely
> > undocumented and different between Windows versions, therefore it's
> > very unlikely that there is an application that depends on the
> > details of this interface, thus making it unnecessary to duplicate
> > it in Wine.
>
> Well, I'm about to submit patches to allow uxtheme to hook into user32,
> so it can theme the non-client areas like scrollbars. Clearly some
> sort of shared interface is needed for this, would you not agree?

Just making this interface Wine specific would work better IMHO. Using
that approach you could add the needed pieces one by one.

-- 
Dmitry.