Error in the server thread id fix
Is anyone else looking into a problem that appears to have been introduced by the server change on Feb 1st changing thread and process ids to small integers? As a result ACCPAC for Windows' main desktop process shuts down after about a minute, but leaves various other processes running. I'll have a look at it but I don't know how successful I'll be. -- Bill Medland ACCPAC International, Inc. medbi01(a)accpac.com Corporate: www.accpac.com Hosted Services: www.accpaconline.com
"Bill" == Bill Medland <billmedland(a)mercuryspeed.com> writes:
Bill> Is anyone else looking into a problem that appears to have been Bill> introduced by the server change on Feb 1st changing thread and Bill> process ids to small integers? Bill> As a result ACCPAC for Windows' main desktop process shuts down Bill> after about a minute, but leaves various other processes running. Bill> I'll have a look at it but I don't know how successful I'll be. Webpack doesn't work as before since the last CVS update. It uses a lot of processes and perhaps threads. Maybe this problem is correlated. Bye -- Uwe Bonnes bon(a)elektron.ikp.physik.tu-darmstadt.de Institut fuer Kernphysik Schlossgartenstrasse 9 64289 Darmstadt --------- Tel. 06151 162516 -------- Fax. 06151 164321 ----------
On February 13, 2003 11:42 am, Uwe Bonnes wrote:
"Bill" == Bill Medland <billmedland(a)mercuryspeed.com> writes:
Bill> Is anyone else looking into a problem that appears to have been Bill> introduced by the server change on Feb 1st changing thread and Bill> process ids to small integers?
Bill> As a result ACCPAC for Windows' main desktop process shuts down Bill> after about a minute, but leaves various other processes running.
Bill> I'll have a look at it but I don't know how successful I'll be.
Webpack doesn't work as before since the last CVS update. It uses a lot of processes and perhaps threads. Maybe this problem is correlated.
Bye
Could be. Since the last CVS update? Do you mean the last snapshot on 20030115? If not then it probably isn't; this problem was introduced two weeks ago. (Shows how much attention I am paying) It looks like something goes wrong in the next_process handler. I'll let you know. -- Bill Medland ACCPAC International, Inc. medbi01(a)accpac.com Corporate: www.accpac.com Hosted Services: www.accpaconline.com
Ah ha, so that's the problem is it? I'm seeing a similar issue with IE6 after loading the adobe svg viewer plugin. For no apparent reason, Wine bombs after about 1-2 minutes. It doesn't crash or anything, it just stops, and the logs don't show anything out of the ordinary. The windows stay on the screen, but the processes appear hung. How did you determine it was changing the ids? Just a regression search? On Thu, 2003-02-13 at 18:52, Bill Medland wrote:
Is anyone else looking into a problem that appears to have been introduced by the server change on Feb 1st changing thread and process ids to small integers?
As a result ACCPAC for Windows' main desktop process shuts down after about a minute, but leaves various other processes running.
I'll have a look at it but I don't know how successful I'll be.
On February 13, 2003 11:56 am, Mike Hearn wrote:
Ah ha, so that's the problem is it? I'm seeing a similar issue with IE6 after loading the adobe svg viewer plugin. For no apparent reason, Wine bombs after about 1-2 minutes. It doesn't crash or anything, it just stops, and the logs don't show anything out of the ordinary. The windows stay on the screen, but the processes appear hung.
How did you determine it was changing the ids? Just a regression search?
Yep. It just takes processor time really, so that is the easiest way. Looks like it is the next_process handler.
On Thu, 2003-02-13 at 18:52, Bill Medland wrote:
Is anyone else looking into a problem that appears to have been introduced by the server change on Feb 1st changing thread and process ids to small integers?
As a result ACCPAC for Windows' main desktop process shuts down after about a minute, but leaves various other processes running.
I'll have a look at it but I don't know how successful I'll be.
-- Bill Medland ACCPAC International, Inc. medbi01(a)accpac.com Corporate: www.accpac.com Hosted Services: www.accpaconline.com
Bill Medland wrote:
Is anyone else looking into a problem that appears to have been introduced by the server change on Feb 1st changing thread and process ids to small integers?
does this help ? A+ -- Eric Pouech Index: server/snapshot.c =================================================================== RCS file: /home/cvs/cvsroot/wine/wine/server/snapshot.c,v retrieving revision 1.18 diff -u -r1.18 snapshot.c --- server/snapshot.c 30 Jan 2003 00:26:44 -0000 1.18 +++ server/snapshot.c 13 Feb 2003 20:27:41 -0000 @@ -124,7 +124,7 @@ ptr = &snapshot->processes[snapshot->process_pos++]; reply->count = ptr->count; reply->pid = get_process_id( ptr->process ); - reply->ppid = get_process_id( ptr->process->parent ); + reply->ppid = ptr->process->parent ? get_process_id( ptr->process->parent ) : 0; reply->heap = 0; /* FIXME */ reply->module = 0; /* FIXME */ reply->threads = ptr->threads;
On February 13, 2003 12:29 pm, Eric Pouech wrote:
Bill Medland wrote:
Is anyone else looking into a problem that appears to have been introduced by the server change on Feb 1st changing thread and process ids to small integers?
does this help ? A+
Yep. (So should the fix be there or should get_process_id be able to handle a null pointer?) -- Bill Medland ACCPAC International, Inc. medbi01(a)accpac.com Corporate: www.accpac.com Hosted Services: www.accpaconline.com
Bill Medland wrote:
On February 13, 2003 12:29 pm, Eric Pouech wrote:
Bill Medland wrote:
Is anyone else looking into a problem that appears to have been introduced by the server change on Feb 1st changing thread and process ids to small integers?
does this help ? A+
Yep.
(So should the fix be there or should get_process_id be able to handle a null pointer?)
since the function is inline, it doesn't matter much I'd better leave it that way, so it makes it clear that we don't always keep track of the parent for a given process A+ -- Eric Pouech
participants (4)
-
Bill Medland -
Eric Pouech -
Mike Hearn -
Uwe Bonnes