[patch] DNS_SD bridge, v2

[C.W. Betts]

The following is an updated patch that actually builds and links.
The patch does patch configure and config.h.in, both of which were generated with an older version of autoconf and autoheader.

[Marcus Meissner]

On Mon, Mar 15, 2010 at 04:36:32AM -0600, C.W. Betts wrote:
> The following is an updated patch that actually builds and links.
> The patch does patch configure and config.h.in, both of which were generated with an older version of autoconf and autoheader.

You can and should leave out both configure and config.h.in from the diff, it is
regenerated by Alexandre.


- You use "openal" in a configure.ac warning messages instead of dns_sd.

- how is non-presence of libdns_sd handled? It seems it will just fail
  to build then.

  It should load the called functions dynamically.

Ciao, Marcus

[C.W. Betts]

Excuse my ignorance, but what would happen if it didn't find the library dynamically?
On Mar 16, 2010, at 4:03 AM, Marcus Meissner wrote:
> On Mon, Mar 15, 2010 at 04:36:32AM -0600, C.W. Betts wrote:
> > The following is an updated patch that actually builds and links.
> > The patch does patch configure and config.h.in, both of which were generated with an older version of autoconf and autoheader.
>
> You can and should leave out both configure and config.h.in from the diff, it is
> regenerated by Alexandre.
>
> - You use "openal" in a configure.ac warning messages instead of dns_sd.
>
> - how is non-presence of libdns_sd handled? It seems it will just fail
>  to build then.
>
> It should load the called functions dynamically.
>
> Ciao, Marcus

[Marcus Meissner]

On Tue, Mar 16, 2010 at 04:41:02PM -0600, C.W. Betts wrote:
> Excuse my ignorance, but what would happen if it didn't find the library dynamically?

You would check this condition (like NULL handle or NULL function pointer)
in every wrapped function and return an error condition in that case.

Or if there is a central startup function for the whole library, just in that
one function (if this leads to the others not called).

ciao, Marcus

[patch] DNS_SD bridge, v3

[C.W. Betts]

Here is version 3 of my DNS_sd patch for Wine. Comments and feedback welcome